Hi Ian, On 11/20/2014 04:08 PM, Ian Campbell wrote: > On Tue, 2014-11-18 at 20:03 +0000, Julien Grall wrote: >> By default, the script get_maintainer.pl will remove duplicates email as soon >> as it appends the list of maintainers of a new file, and therefore override >> the role of the developper. >> >> On complex patch (see [1]), this will result to ommitting randomly some >> maintainers. >> >> This could be fixed > > Are you proposing an alternative/better fix here? or describing what > this patch does?
Describing what the patch does. >> by not removing the duplicate email in the list. Once the >> list is created, when it's necessary, the script will drop the "REST" people >> and remove duplicata. >> >> Example: >> >> Patch: https://patches.linaro.org/41083/ >> >> Before: >> >> Daniel De Graaf <dgde...@tycho.nsa.gov> >> Ian Jackson <ian.jack...@eu.citrix.com> >> Stefano Stabellini <stefano.stabell...@eu.citrix.com> >> Ian Campbell <ian.campb...@citrix.com> >> Wei Liu <wei.l...@citrix.com> >> George Dunlap <george.dun...@eu.citrix.com> >> xen-devel@lists.xen.org >> >> After: >> >> Daniel De Graaf <dgde...@tycho.nsa.gov> >> Ian Jackson <ian.jack...@eu.citrix.com> >> Stefano Stabellini <stefano.stabell...@eu.citrix.com> >> Ian Campbell <ian.campb...@citrix.com> >> Wei Liu <wei.l...@citrix.com> >> Stefano Stabellini <stefano.stabell...@citrix.com> >> Tim Deegan <t...@xen.org> >> Keir Fraser <k...@xen.org> >> Jan Beulich <jbeul...@suse.com> >> George Dunlap <george.dun...@eu.citrix.com> >> xen-devel@lists.xen.org >> >> [1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html >> >> Signed-off-by: Julien Grall <julien.gr...@linaro.org> >> CC: Don Slutz <dsl...@verizon.com> >> >> --- >> I would like to see this patch in Xen 4.5 and backported to Xen 4.4 >> (first >> time the script has been introduced). >> >> Developpers using this script won't ommitted to cc some maintainers, and >> it >> will avoid maintainers complaining about miss CC. >> >> The only drawbacks I can see is there is too much people CCed (the >> patch d67738db was intended to avoid CCing Keir too often). > > My tree doesn't have in it d67738db but from the example you give above > it seems like this patch will regress that? As someone who already gets > too much mail and is listed in THE REST these days I am very much in > favour of not mailing THE REST when other maintainers have been found. It's still the case with this patch. Before if a maintainer was both in x86 section and "THE REST". It may end up to completely drop the maintainer in the CC list. By drawbacks I meant, if there is another bug in the script then we may end up to cc too many people. Honestly I don't believe it's the case. >> Also, if the maintainers is referenced twice in the file MAINTAINERS with >> different email, the script won't notice it's duplicated and list 2 >> times. >> Though, for this one it could be fixed by modifying the MAINTAINERS >> file. >> Is it worth for Xen 4.5? For know, it seems to only happen with Stefano. > Regards. -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
