Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-06 Thread Motonori Shindo
Guy, et al. Thanks for your advise. I upgraded the subversion to the latest one via MacPorts. $ svn --version svn, version 1.6.16 (r1073529) and it now works fine! I've just filed my patch to Bugzilla. Regards, --- Motonori Shindo 2011/4/6 Guy Harris : > > On Apr 5, 2011, at 11:42 PM, Motono

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-06 Thread Motonori Shindo
Guy, I must have installed the subversion using MacPorts a way back and haven't upgraded it since then. This is most likely a problem caused by the old subversion. I will bring up the subversion to the latest one and see how it works. Thanks again! Regards, --- Motonori Shindo 2011/4/6 Guy Harr

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Guy Harris
On Apr 5, 2011, at 11:42 PM, Motonori Shindo wrote: > Unn, that's weird. I simply did "svn diff" against the up-to-date SVN > repository on MacOS X 10.6.7 with svn version 1.6.5 (r38866). SVN 1.6.5 is older than the version of SVN that comes with 10.6.7: $ sw_vers ProductName:Mac OS X Produ

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Motonori Shindo
Guy, Jaap, and Andres, Unn, that's weird. I simply did "svn diff" against the up-to-date SVN repository on MacOS X 10.6.7 with svn version 1.6.5 (r38866). I will look into it further. Thank you all for your help. Regards, --- Motonori Shindo 2011/4/6 Guy Harris : > > On Apr 5, 2011, at 11:04 P

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Guy Harris
On Apr 5, 2011, at 11:04 PM, Motonori Shindo wrote: > Anders, > > Ooops, my brain seems to stay in the days of 5 years ago, when we used > to post patches on the dev mailing list. I will open the case in > bugzilla. I don't know why the patch doesn't apply. I will check it. Part of the problem

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Motonori Shindo
Anders, Ooops, my brain seems to stay in the days of 5 years ago, when we used to post patches on the dev mailing list. I will open the case in bugzilla. I don't know why the patch doesn't apply. I will check it. Sorry for the inconvenience. --- Motonori Shindo 2011/4/6 Anders Broman : > Motono

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Anders Broman
Motonori Shindo skrev 2011-04-06 06:55: Hi, Current NetFlow V9/IPFIX dissector treats IN_BYTES (IE=1) and IN_PERMANENT_BYTES (IE=85) exactly in the same way. The same applies to IN_PKTS (IE=2) and IN_PERMANENT_PKTS (IE=86). However, IN_BYTES/IN_PKTS and IN_PERMANENT_BYTES/IN_PERMANENT_PKTS have

Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Jaap Keuter
Hi, This would normally have to go through Bugzilla, so to better track and comment on patches. This patch for instance lacks line numbers. --- epan/dissectors/packet-netflow.c(revision 36487) +++ epan/dissectors/packet-netflow.c(working copy) @@ -%ld,%ld +%ld,%ld @@ static int h

[Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX

2011-04-05 Thread Motonori Shindo
Hi, Current NetFlow V9/IPFIX dissector treats IN_BYTES (IE=1) and IN_PERMANENT_BYTES (IE=85) exactly in the same way. The same applies to IN_PKTS (IE=2) and IN_PERMANENT_PKTS (IE=86). However, IN_BYTES/IN_PKTS and IN_PERMANENT_BYTES/IN_PERMANENT_PKTS have different semantics so they should be dist