Re: [vpp-dev] minor doc change

2020-11-27 Thread Paul Vinciguerra
Hi Hermant. The document is in the sources here: docs/gettingstarted/developers/infrastructure.md The best way to get the docs updated is to submit a change. Paul On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io wrote: > At this link: > > > > > https://my-vpp-docs.readthedocs.io/en/late

[vpp-dev] minor doc change

2020-11-27 Thread hemant via lists.fd.io
At this link: https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infra structure.html unformat_init_string() used two args but the latest VPP code uses three args. We should change the doc. Thanks, Hemant smime.p7s Description: S/MIME cryptographic signature

Re: [vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread hemant via lists.fd.io
Thanks, Dave. I will change the code at least for action-name, table-name. If you see the help for my CLI, you will see a and . I would love to entry the key and value as a vector for CLI. Let me look into it. Hemant From: vpp-dev@lists.fd.io On Behalf Of Dave Barach Sent: Frida

Re: [vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread Dave Barach
This will make you sad. Don’t write code line this: if (unformat (line_input, "%s %s %x %hhu %hhu %hu %hu %s %hhu %hu %hu %u %x %x %hu %hhu %hhu", ...)) If you want to parse a bunch of different fields, do it this way, aka the way it’s done elsewhere in the code base:

Re: [vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread hemant via lists.fd.io
Also, I did update my VPP repo last week to get latest VPP code from gerrit. Hemant From: vpp-dev@lists.fd.io On Behalf Of hemant via lists.fd.io Sent: Friday, November 27, 2020 7:24 PM To: slu...@cisco.com; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] unformat fails processing > 3 variable

Re: [vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread hemant via lists.fd.io
Sorry, I fat-fingered one format tag during moving the snippet of code to github. Even with 18 format tags and 18 args, I still fail. I used a delimiter of “=>” between table entry key and the entry value. vpp# upf add-entry pkt_filter4_0 permit4 0xac100102 0xac100202 17 0 61 2152 => 130 0

RES: RES: RES: [vpp-dev] NAT memory usage problem for VPP 20.09 compared to 20.05 due to larger translation_buckets value

2020-11-27 Thread Marcos - Mgiga
Hi Klement Those values ( max sessions and max users) are avaible in deterministic mode? Best regards -Mensagem original- De: vpp-dev@lists.fd.io Em nome de Klement Sekera via lists.fd.io Enviada em: quinta-feira, 26 de novembro de 2020 18:16 Para: Marcos - Mgiga Cc: Elias Rudberg ; v

Re: [vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread steven luong via lists.fd.io
You have 17 format tags, but you pass 18 arguments to the unformat function. Is that intentional? Steven From: on behalf of "hemant via lists.fd.io" Reply-To: "hem...@mnkcg.com" Date: Friday, November 27, 2020 at 3:52 PM To: "vpp-dev@lists.fd.io" Subject: [vpp-dev] unformat fails processing

[vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread hemant via lists.fd.io
I am writing VPP CLI for the first time. Please see this new CLI I developed for my VPP plugin at the link below. https://github.com/hesingh/misc/blob/master/vpp-issues/cli.c If I use more than three variables with unformat on line

Re: [vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Paul Vinciguerra
> > > My question is specifically about the carve out in your reply. > > "assuming that all mandatory requirements are installed in the system:" > > Yes, it is not cmake project job to install dependencies. > That is the direction I was looking for. [snip...] > > At the moment vppapigen is script

Re: [vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Damjan Marion via lists.fd.io
> On 27.11.2020., at 18:08, Paul Vinciguerra wrote: > > Thanks Damjan. > > My question is specifically about the carve out in your reply. > "assuming that all mandatory requirements are installed in the system:" Yes, it is not cmake project job to install dependencies. For that reason, to ma

Re: [vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Paul Vinciguerra
Thanks Damjan. My question is specifically about the carve out in your reply. "assuming that all mandatory requirements are installed in the system:" Today we have all these system package dependencies in the Makefile to add ply. These are all dependencies for vppapigen. I have previously added

Re: [vpp-dev] [VCL] Memory access error for different size of mutex with different glibc versions in VPP and VCL app

2020-11-27 Thread Florin Coras
Hi Hanlin, Good point! I actually have that on my todo list to see how/if it affects performance. The other way around we should be somewhat safer after the switch to the new socket api (instead of the binary api with socket transport). That is, vpp detects if an app goes down almost instantly

Re: [vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Damjan Marion via lists.fd.io
> On 27.11.2020., at 15:52, Paul Vinciguerra wrote: > > Can someone memorialize the policy around changes to make and cmake? > I have a change that replaces an existing symlink in the repo with a called > command. Since it is a symlink now, and therefore, by definition, already > setup befo

[vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Paul Vinciguerra
Can someone memorialize the policy around changes to make and cmake? I have a change that replaces an existing symlink in the repo with a called command. Since it is a symlink now, and therefore, by definition, already setup before cmake, can I address it in the Makefile, just like we set up syste

Re: [vpp-dev] Custom VxLAN port

2020-11-27 Thread Ole Troan
Hi Artem, > I don't fully understand, > If I want to support configurable UDP port per tunnel, I need to extend > "vxlan_tunnel_t" or "vxlan_gpe_tunnel_t" or "vxlan_gbp_tunnel_t" or all of > them. So this is what I meant in point 2. Why 2.5? :) > Or can I only use the "vxlan_gbp_tunnel_t" for th