> On 27.11.2020., at 18:08, Paul Vinciguerra <pvi...@vinciconsulting.com> wrote: > > Thanks Damjan. > > My question is specifically about the carve out in your reply. > "assuming that all mandatory requirements are installed in the system:"
Yes, it is not cmake project job to install dependencies. For that reason, to make life easier for people, we have top-level Makefile which installs dependencies on some distros. On other distros, it is still possible to compile VPP but before that you need to ensure manually that alll dependencies are set. > Today we have all these system package dependencies in the Makefile to add > ply. These are all dependencies for vppapigen. I have previously added > comments in the makefile why the package is there in the first place. Yeah, assume that you want to build vpp in the build-root or yocto. There you will need to add dependency on ply in recipe file as top-level makefile will not be used.. > > Why the changeset at all? > For the community, It is straightforward to have vppapigen manage its own > dependencies and we can clean up the makefile. For me, I want to reuse > vppapigen from python, and launching it over and over again via subprocess is > suboptimal. Furthermore, it is fragile in that it expects files to be named > in a certain template and placed in specific locations. > > As a script only usable by the build system, vppapigen works. But there are > uses for vppapigen outside of make. My changeset works. It's just not > integrated with VPP. > > I expect that I can get it to pass the CI by adding a variant of a single > 'pip install vppapigen' and updating the symlink to the new install location. > It just seems wrong to me to use a symlink to meet a dependency. If I'm > already making changes in the code, I don't mind updating it. At the moment vppapigen is script directly called by cmake, if your change wil prevent cmake to call that script directly from the place where it is today, we will need to significantly refactor cmake project files and i will rather not go there…. — Damjan
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18174): https://lists.fd.io/g/vpp-dev/message/18174 Mute This Topic: https://lists.fd.io/mt/78548158/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
