> On 27.11.2020., at 15:52, Paul Vinciguerra <pvi...@vinciconsulting.com> wrote: > > Can someone memorialize the policy around changes to make and cmake? > I have a change that replaces an existing symlink in the repo with a called > command. Since it is a symlink now, and therefore, by definition, already > setup before cmake, can I address it in the Makefile, just like we set up > system packages, or does it somehow need to be a formal dependency in cmake? > > The change is: https://gerrit.fd.io/r/c/vpp/+/30080 > <https://gerrit.fd.io/r/c/vpp/+/30080> Not sure wha problem you are trying to solve with this patch and what is the benefit it brings, but general rule is that cmake project needs to be self-suffiicient to build running vpp tree.
In other words following sequence needs to work assuming that all mandatory requirements are installed in the system: $ mkdir /some/random/path $ cd /some/random/path $ cmake -G Ninja /path/to/vpp/src $ ninja — Damjan
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18171): https://lists.fd.io/g/vpp-dev/message/18171 Mute This Topic: https://lists.fd.io/mt/78548158/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
