Thanks Damjan. My question is specifically about the carve out in your reply. "assuming that all mandatory requirements are installed in the system:"
Today we have all these system package dependencies in the Makefile to add ply. These are all dependencies for vppapigen. I have previously added comments in the makefile why the package is there in the first place. Why the changeset at all? For the community, It is straightforward to have vppapigen manage its own dependencies and we can clean up the makefile. For me, I want to reuse vppapigen from python, and launching it over and over again via subprocess is suboptimal. Furthermore, it is fragile in that it expects files to be named in a certain template and placed in specific locations. As a script only usable by the build system, vppapigen works. But there are uses for vppapigen outside of make. My changeset works. It's just not integrated with VPP. I expect that I can get it to pass the CI by adding a variant of a single 'pip install vppapigen' and updating the symlink to the new install location. It just seems wrong to me to use a symlink to meet a dependency. If I'm already making changes in the code, I don't mind updating it. On Fri, Nov 27, 2020 at 10:04 AM Damjan Marion <dmar...@me.com> wrote: > > > On 27.11.2020., at 15:52, Paul Vinciguerra <pvi...@vinciconsulting.com> > wrote: > > Can someone memorialize the policy around changes to make and cmake? > I have a change that replaces an existing symlink in the repo with a > called command. Since it is a symlink now, and therefore, by definition, > already setup before cmake, can I address it in the Makefile, just like we > set up system packages, or does it somehow need to be a formal dependency > in cmake? > > The change is: https://gerrit.fd.io/r/c/vpp/+/30080 > > > Not sure wha problem you are trying to solve with this patch and what is > the benefit it brings, > but general rule is that cmake project needs to be self-suffiicient to > build running vpp tree. > > In other words following sequence needs to work assuming that all > mandatory requirements are installed in the system: > > $ mkdir /some/random/path > $ cd /some/random/path > $ cmake -G Ninja /path/to/vpp/src > $ ninja > > — > Damjan > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18173): https://lists.fd.io/g/vpp-dev/message/18173 Mute This Topic: https://lists.fd.io/mt/78548158/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
