On 19/06/13 20:30, Albert ARIBAUD wrote:
> Hi Minkyu,
>
> On Mon, 17 Jun 2013 11:10:58 +0900, Minkyu Kang
> wrote:
>
>> Dear Albert,
>>
>> The following changes since commit d0a51373131c4ba565a2391d5ed78b87c406ce98:
>>
>> at91sam9260ek: move boar
lczek
>> > Cc: Heiko Schocher; U-Boot Mailing List; Dirk Eibach; Stefan Roese;
>> > Holger Brunck; Mike Frysinger; Stephen Warren; Minkyu Kang
>> > Subject: Re: [PATCH v3 0/9] Bring in new I2C framework
>> >
>>
movable = <1>;
> + };
> +
> + mmc@1223 {
> + status = "disabled";
> + };
> +
> tmu@1006 {
> samsung,min-temp= <25>;
> samsung,max-temp= <125>;
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
+#else
>> fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd();
>> +#endif
>>
>> offset = exynos_fimd_get_base_offset();
>>
>> --
>> 1.8.0
>>
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de <mailto:U-Boot@lists.denx.de>
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>>
>
applied to u-boot-samsung.
thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
uart"),
>
ditto.
> };
>
> const char *fdtdec_get_compatible(enum fdt_compat_id id)
> --
> 1.7.4.4
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
device;
> + else if (config.port_id == 2)
> + return &s5p_serial2_device;
> + else if (config.port_id == 3)
> + return &s5p_serial3_device;
> + else
> + debug("Unknown config.port_id: %d", config.port_id);
>
switch case?
> +
> + return NULL;
> +#else
> + config.enabled = 1;
> #if defined(CONFIG_SERIAL0)
> return &s5p_serial0_device;
> #elif defined(CONFIG_SERIAL1)
> @@ -220,6 +297,7 @@ __weak struct serial_device
> *default_serial_console(void)
> #else
> #error "CONFIG_SERIAL? missing."
> #endif
> +#endif
> }
>
> void s5p_serial_initialize(void)
> --
> 1.7.4.4
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Piotr Wilczek,
On 21 May 2013 21:54, Piotr Wilczek wrote:
> This patch add new functions to pmic max77686 to set voltage and mode.
>
> Signed-off-by: Piotr Wilczek
> Signed-off-by: Kyungmin Park
> CC: Minkyu Kang
> CC: Rajeshwari Shinde
>
> Acked-by: Rajeshwari
by: Simon Glass
>
applied to u-boot-samsung
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
pmic.h | 2 ++
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
id);
> +
> +/*
> + * Power off the system; it should never return.
> + */
> +void power_shutdown(void);
> +
> +/*
> + * Perform a software reset.
> + */
please check comment rule.
One line comment should be.. /* */
> +void power_reset(void);
> #endif
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
amsung,exynos5-dp"),
> COMPAT(SAMSUNG_EXYNOS5_DWMMC, "samsung,exynos5250-dwmmc"),
> + COMPAT(SAMSUNG_EXYNOS_SERIAL, "samsung,exynos4210-uart"),
Is it exynos4210 specific?
If not, how about exynos-uart?
> COM
serial@12C3";
> + console = "/serial@12C3";
> };
>
> sromc@1225 {
> diff --git a/board/samsung/dts/exynos5250-snow.dts
> b/board/samsung/dts/exynos5250-snow.dts
> index d167df9..fd
t; board/samsung/dts/exynos5250-snow.dts |2 +
> drivers/serial/serial_s5p.c | 78
> +
> include/configs/exynos5250-dt.h |2 +-
> include/fdtdec.h |1 +
> lib/fdtdec.c
t;dat);
> + s5p_gpio_set_value(bank, gpio, en);
> }
>
> void s5p_gpio_direction_input(struct s5p_gpio_bank *bank, int gpio)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
ut(unsigned gpio, int value)
> {
> - writel(GPIO_FULLPORT(gpio), GPIO_OUTPUT << GPIO_BIT(gpio));
> + writel(GPIO_OUTPUT << GPIO_BIT(gpio), GPIO_FULLPORT(gpio));
> return gpio_set_value(gpio, value);
> }
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
;
> Signed-off-by: Arkadiusz Wlodarczyk
> Signed-off-by: Kyungmin Park
> Tested-by: Arkadiusz Wlodarczyk
> Cc: Minkyu Kang
> ---
> board/samsung/goni/goni.c |7 +++
> include/configs/s5p_goni.h | 20 +++-
> 2 files changed, 26 insertions(+), 1 deleti
};
>
> -enum boot_mode {
> - BOOT_MODE_MMC = 4,
> - BOOT_MODE_SERIAL = 20,
> - BOOT_MODE_EMMC = 8, /* EMMC4.4 */
> - /* Boot based on Operating Mode pin settings */
> - BOOT_MODE_OM = 32,
> - BOOT_MODE_USB, /* Boot using USB download */
>
ch.
exynos5250 should be
FOUT = MDIV * FIN / (PDIV * 2^SDIV)
but my manual (I'm not sure that is latest version) shows
FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1))
Akshay,
please check this.
Rajeshwari,
Thank you for raise this issue,
I'll check it and resend the patch.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
in V2:
> - Rebased on latest u-boot-samsung tree.
> - Incorporated review comments from Minkyu Kang.
> arch/arm/cpu/armv7/exynos/Makefile | 17 +-
> .../arm/cpu/armv7/exynos}/clock_init.h |0
> arch/arm/cpu/armv7/exynos/clock_init_exynos4.c |
nfigs/arndale.h
>
This patch seems to conflict with Rajeshwari's patch.
http://patchwork.ozlabs.org/patch/256058/
So, this patch will be pending until merge.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 01/07/13 17:41, Rajeshwari Birje wrote:
> Hi Minkyu Kang,
>
> As per the user manual I have for EXYNOS5 it is
> FOUT = MDIV * FIN / (PDIV * 2^SDIV)
What is your version of manual?
If possible, could you please send it to me?
>
> Regards,
> Rajeshwari Shinde.
>
>
;
> Signed-off-by: Arkadiusz Wlodarczyk
> Signed-off-by: Kyungmin Park
> Tested-by: Arkadiusz Wlodarczyk
> Cc: Minkyu Kang
>
> ---
> Changes for v2:
> - Remove blank line
> ---
> board/samsung/goni/goni.c |7 +++
> include/configs/s5p_goni.h | 20 +
test u-boot-samsung tree.
> - Incorporated review comments from Minkyu Kang.
> Changes in V3:
> - Optimised the mem_ctrl_init function for exynos4.
> - Removed magic numbers.
> arch/arm/cpu/armv7/exynos/Makefile | 17 +-
> .../arm/cpu
id compilation error.
> Please do let me know if you are fine with these changes.
>>
I suggest following.
EXYNOS4_DMC_BASE0x-
EXYNOS4_DMC_PHY_BASEDEVICE_NOT_AVAILABLE
EXYNOS4X12_DMC_BASE 0x-
EXYNOS4X12_DMC_PHY_BASE DEVICE_NOT_AVAILABLE
EXYNOS5_DMC_PHY_BASE0x-
EXYNOS5_DMC_BASE
On 04/07/13 14:27, Rajeshwari Birje wrote:
> Hi Minkyu Kang,
>
> On Thu, Jul 4, 2013 at 7:31 AM, Minkyu Kang wrote:
>>>>> diff --git a/arch/arm/include/asm/arch-exynos/cpu.h
>>>>> b/arch/arm/include/asm/arch-exynos/cpu.h
>>>>> index 36b98c8
DKV310 using pinmux.
>
> Changes in V2:
> - Rebased on latest u-boot-samsung tree.
> - Incorporated review comments from Simon glass and
> Minkyu Kang.
> Changes in V3:
> - Optimised the mem_ctrl_init function for exynos4.
> - Re
eded bigger buffer to
> transfer for example uImage.
>
> Signed-off-by: Lukasz Majewski
> Cc: Minkyu Kang
> ---
> include/configs/trats.h |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/trats.h b/include/configs/trats.h
ttery/bat_trats.c | 13 +
> drivers/power/power_core.c|3 ++-
> 2 files changed, 11 insertions(+), 5 deletions(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
ode 100644 board/samsung/smdkv310/lowlevel_init.S
delete mode 100644 board/samsung/smdkv310/mem_setup.S
delete mode 100644 board/samsung/smdkv310/mmc_boot.c
--
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
There are differnce with clock calcuation by cpu variations.
This patch will fix it according to user manual.
Signed-off-by: Minkyu Kang
Signed-off-by: Rajeshwari Shinde
---
arch/arm/cpu/armv7/exynos/clock.c | 37 +
1 file changed, 33 insertions(+), 4
port for both
FDT and non-FDT for I2C, and initialise the I2C channels.
Signed-off-by: Amar
Acked-by: Simon Glass
Signed-off-by: Minkyu Kang
diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
index 46d2506..3fc1c5b 100644
--- a/drivers/i2c/s3c24x0_i2c.c
+++ b
GONI board code.
>
> Signed-off-by: Arkadiusz Wlodarczyk
> Signed-off-by: Kyungmin Park
> Tested-by: Arkadiusz Wlodarczyk
> Cc: Minkyu Kang
> ---
>
Please add change log here.
And this patch seem version 3 (or 2?), but you did not mention it.
> board/samsung/goni/goni.c |
On 08/07/13 15:19, Lukasz Majewski wrote:
> On Sun, 07 Jul 2013 14:48:18 +0900, Minkyu Kang wrote:
>
> Dear Minkyu,
>
>> Dear Lukasz,
>>
>>
>> On 4 July 2013 19:52, Lukasz Majewski wrote:
>>
>>> From: Arkadiusz Wlodarczyk
>>>
>
min Park
> Tested-by: Arkadiusz Wlodarczyk
> Cc: Minkyu Kang
> ---
> board/samsung/goni/goni.c | 68
>
> include/configs/s5p_goni.h |5
> 2 files changed, 73 insertions(+)
>
please run checkpatch before submitting.
CHECK
On Monday, July 8, 2013, Minkyu Kang wrote:
> On 04/07/13 19:52, Lukasz Majewski wrote:
> > From: Arkadiusz Wlodarczyk >
> >
> > This commit enables support for USB mass storage composite function.
> > It defines platform code and enables it at config file.
&g
There are differnce with clock calcuation by cpu variations.
This patch will fix it according to user manual.
Signed-off-by: Minkyu Kang
Signed-off-by: Rajeshwari Shinde
---
Changes for v2:
- remove hard-coded constants.
arch/arm/cpu/armv7/exynos/clock.c | 43
Dear Amar,
On 07/07/13 14:43, Minkyu Kang wrote:
> Dear Amar,
>
>
> On 6 July 2013 04:12, Albert ARIBAUD <mailto:albert.u.b...@aribaud.net>> wrote:
>
> Hi Minkyu,
>
> This breaks build of VCMA9:
>
> s3c24x0_i2c.c: In function 'board_
um = i2c_busses++;
> exynos_pinmux_config(bus->id, 0);
> }
> -#else
> - for (i = 0; i < CONFIG_MAX_I2C_NUM; i++) {
> - exynos_pinmux_config((PERIPH_ID_I2C0 + i),
> - PINMUX_FLAG_NONE);
> - }
> -#endif
> }
>
> -#ifdef CONFIG_OF_CONTROL
> static struct s3c24x0_i2c_bus *get_bus(unsigned int bus_idx)
> {
> if (bus_idx < i2c_busses)
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 09/07/13 23:05, amar_g wrote:
> This patch resolves the below mentiond compilation error of i2c driver
typo.. maybe mentiond will be mentioned?
> for non-FDT case
>
> Compilation error:
> s3c24x0_i2c.c: In function 'board_i2c_init':
> s3c24x0_i2c.c:544:18: error: 'CONFIG_MAX_I2C_NUM' undecla
On 09/07/13 16:56, Rajeshwari Birje wrote:
> Looks fine to me.
>
> Acked-by: Rajeshwari Shinde
>
> On Tue, Jul 9, 2013 at 1:07 PM, Minkyu Kang wrote:
>> There are differnce with clock calcuation by cpu variations.
>> This patch will fix it according to user manual.
ot;Compilation error" message for 5 lines.
> b) Changed the spelling of 'mentiond' to 'mentioned'.
>
> board/samsung/smdk5250/smdk5250.c | 10 ++
> drivers/i2c/s3c24x0_i2c.c |9 +
> 2 files changed, 11 insertions(
EXYNOS: Resolve the i2c compilation error
Axel Lin (2):
gpio: s3c2440_gpio: Fix wrong writel arguments
gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code
Bernie Thompson (1):
exynos: Adjust the starting MIF voltage to 1.05v
Minkyu Kang (1):
arm: exynos: fix
board).
>
>
> Signed-off-by: Lukasz Majewski
> Cc: Minkyu Kang
> ---
> arch/arm/cpu/armv7/exynos/clock.c |9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>
Acked-by: Minkyu Kang
Thanks for patch.
Minkyu Kang.
--
from. prom.
www.promsoft.net
was
> used only in this particular place.
>
> Test HW: Trats Exynos4210 rev 0.
>
> Signed-off-by: Lukasz Majewski
> Signed-off-by: Kyungmin Park
> Cc: Minkyu Kang
> ---
> board/samsung/trats/trats.c | 10 +-----
> 1 file changed, 1 inser
;From tomorrow I'm going to go the winter vacation.
>
>> Regards,
>> Rajeshwari.
>
> Amicalement,
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
> + SROMC_BC_TCOH(config.timing[FDT_SROM_TCOH]) |
> + SROMC_BC_TAH(config.timing[FDT_SROM_TAH]) |
> + SROMC_BC_TACP(config.timing[FDT_SROM_TACP]) |
> + SROMC_BC_PMC(config.timing[FDT_SROM_PMC]);
> +
> + /* Select and configure the SROMC bank */
> + exynos_pinmux_config(PERIPH_ID_SROMC, config.bank);
> + s5p_config_sromc(config.bank, smc_bw_conf, smc_bc_conf);
> + return smc911x_initialize(0, base_addr);
> +#endif
> + return 0;
> +}
> +
> +#ifdef CONFIG_GENERIC_MMC
> +int board_mmc_init(bd_t *bis)
> +{
> + int ret;
> +
> + /* dwmmc initializattion for available channels */
> + ret = exynos_dwmmc_init(gd->fdt_blob);
> + if (ret)
> + debug("dwmmc init failed\n");
> +
> + return ret;
> +}
> +#endif
> +#endif
> +
> +#ifdef CONFIG_BOARD_LATE_INIT
> +int board_late_init(void)
> +{
> + stdio_print_current_devices();
> +
> + if (local.cros_ec_err) {
> + /* Force console on */
> + gd->flags &= ~GD_FLG_SILENT;
> +
> + printf("cros-ec communications failure %d\n",
> +local.cros_ec_err);
> + puts("\nPlease reset with Power+Refresh\n\n");
> + panic("Cannot init cros-ec device");
> + return -1;
> + }
> + return 0;
> +}
> +#endif
> +
> +int arch_early_init_r(void)
> +{
> +#ifdef CONFIG_CROS_EC
> + if (board_init_cros_ec_devices(gd->fdt_blob)) {
> + printf("%s: Failed to init EC\n", __func__);
> + return 0;
> + }
> +#endif
> +
> + return 0;
> +}
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
samsung/common/board.c
> create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
> create mode 100644 board/samsung/smdk5420/Makefile
> create mode 100644 board/samsung/smdk5420/smdk5420.c
> create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
> create mode 100644 include/co
On 18/12/13 23:43, Piotr Wilczek wrote:
> This fix is necessary after increased by one the number
> of adapters in s3c24x0 driver.
>
> Tested on Trats and Trats2.
>
> Signed-off-by: Piotr Wilczek
> Signed-off-by: Kyungmin Park
> Cc: Minkyu Kang
> Cc: Lukasz Majew
gt; "loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
> "${fdtfile}\0" \
> - "mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
> + "mmcdev=" __stringify(CONFIG_MMC_DEFAULT_DEV) "\0" \
> "mmcbootpart=2\0" \
> "mmcrootpart=5\0" \
> "opts=always_resume=1\0" \
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
G_LCD
> +#ifdef CONFIG_LCD
> +#define CONFIG_EXYNOS_FB
> +#define CONFIG_EXYNOS_DP
> +#define LCD_BPP LCD_COLOR16
please use space.
> +#endif
> +
> #endif /* __CONFIG_5420_H */
>
Thanks,
Minkyu Kang.
___
nos5_setup.h
> @@ -780,7 +780,7 @@
> #define CLK_SRC_TOP2_VAL 0x11101000
> #define CLK_SRC_TOP3_VAL 0x
> #define CLK_SRC_TOP4_VAL 0x0111
> -#define CLK_SRC_TOP5_VAL 0x1100
> +#define CLK_SRC_TOP5_VAL 0x1101
> #define CLK_SRC_TOP6_VAL
fo);
> #endif
> diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
> index 689919d..508962c 100644
> --- a/include/configs/exynos5250-dt.h
> +++ b/include/configs/exynos5250-dt.h
> @@ -50,8 +50,6 @@
> #ifdef CONFIG_LCD
> #define CONFIG_EXYNOS_FB
> #define CONFIG_EXYNOS_DP
> -#define LCD_XRES 2560
> -#define LCD_YRES 1600
> #define LCD_BPP LCD_COLOR16
> #endif
> #endif /* __CONFIG_5250_H */
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
/* __ASSEMBLY__ */
> +
> +/* LCD console */
> +#define LCD_BPP LCD_COLOR16
> +#define CONFIG_SYS_WHITE_ON_BLACK
> +
> /* LCD */
> #define CONFIG_EXYNOS_FB
> #define CONFIG_LCD
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
>
> obj-y+= trats.o
> +
> +$(obj)trats.o: CFLAGS += $(PLATFORM_NO_UNALIGNED)
> \ No newline at end of file
>
What is the example of unexpected unaligned access on trats?
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
file include/configs/trats2.h
Hunk #1 FAILED at 293.
1 out of 1 hunk FAILED -- saving rejects to file include/configs/trats2.h.rej
please check it.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
ush.o: CFLAGS += $(PLATFORM_NO_UNALIGNED)
> $(obj)fdt_support.o: CFLAGS += $(PLATFORM_NO_UNALIGNED)
> +$(obj)lcd.o: CFLAGS += $(PLATFORM_NO_UNALIGNED)
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 19/12/13 03:31, Przemyslaw Marczak wrote:
> Config: CONFIG_MISC_INIT_R enables implementation of misc_init_r()
> in common file::
> - board/samsung/common/misc.c
I can't understand this commit message.
What means?
>
> Signed-off-by: Przemyslaw Marczak
>
> ---
> Changes v2:
> - change CONFIG
ozlabs.org/patch/232842/
and
http://patchwork.ozlabs.org/patch/232849/
I didn't notice that patch was delegated to me, because this patch is for power.
I'm sorry for long pending.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
"Changes Requested".
please check.
it's 3/3 v5
http://patchwork.ozlabs.org/patch/233418/
and it's 4/4 v3
http://patchwork.ozlabs.org/patch/218903/
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 03/01/14 08:37, Leela Krishna Amudala wrote:
> Hi Minkyu Kang,
>
> On Thu, Dec 5, 2013 at 2:50 PM, Minkyu Kang wrote:
>> Dear Leela Krishna Amudala,
>>
>> On 12/11/13 19:04, Leela Krishna Amudala wrote:
>>> The current pmic i2c code assumes the current
/smdk5420_spl.c
create mode 100644 include/configs/exynos5-dt.h
create mode 100644 include/configs/smdk5420.h
--
Happy New Year!
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
USB VBUS GPIOs to be device tree configured
>>
>> Recent changes for common board file migration for exynos platform
>> added it again. So removing it now.
>>
>> Signed-off-by: Vivek Gautam
>> Cc: Julius Werner
>> Cc: Minkyu Kang
>>
l as
>> XHCI ports on exynos5250 boards.
>>
>> Signed-off-by: Vivek Gautam
>> Cc: Julius Werner
>> Cc: Minkyu Kang
>> Cc: Marek Vasut
>
> Reiewed-by: Marek Vasut
>
> Minkyu, can you please pick this?
OK.
>
> Best regards,
> Marek Va
Cc: Anatolij Gustschin
On 04/01/14 01:43, Przemyslaw Marczak wrote:
> Changes:
> - le16_to_cpu() to get_unaligned_le16()
> - le32_to_cpu() to get_unaligned_le32()
> when access fields in struct bmp header.
>
> This changes avoids data abort exception caused by unaligned data access.
>
> Signed-o
4x12_gpio_get(2, x3, 3)
> +#endif /* __COMMON_H_ */
> +#endif /* __ASSEMBLY__ */
> +
> +/* LCD console */
> +#define LCD_BPP LCD_COLOR16
> +#define CONFIG_SYS_WHITE_ON_BLACK
> +
> /* LCD */
> #define CONFIG_EXYNOS_FB
> #define CONFIG_LCD
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
sal.h
> b/include/configs/s5pc210_universal.h
> index d9e4c56..02a1c99 100644
> --- a/include/configs/s5pc210_universal.h
> +++ b/include/configs/s5pc210_universal.h
> @@ -229,8 +229,8 @@
> /*
> * I2C Settings
> */
> -#define CONFIG_SOFT_I2C_GPIO_SCL exynos4_gpio_part1_get
; + }
> +
> + return 0;
> +}
> +
> +static void check_boot_mode(void)
> +{
> + int pwr_key;
> +
> + pwr_key = power_key_pressed(KEY_PWR_STATUS_REG);
> + if (!pwr_key)
> + return;
> +
> + /* Clear PWR button Rising edge interrupt status flag */
> + power_key_pressed(KEY_PWR_INTERRUPT_REG);
> +
> + if (key_pressed(KEY_VOLUMEUP))
> + boot_menu();
> + else if (key_pressed(KEY_VOLUMEDOWN))
> + mode_leave_menu(BOOT_MODE_THOR);
> +}
> +
> +static void keys_init(void)
> +{
> + /* Set direction to input */
> + gpio_direction_input(KEY_VOL_UP_GPIO);
> + gpio_direction_input(KEY_VOL_DOWN_GPIO);
> +}
> +#endif /* CONFIG_LCD_MENU */
>
> #ifdef CONFIG_CMD_BMP
> static void draw_logo(void)
> @@ -50,9 +385,14 @@ static void draw_logo(void)
> /* Common for Samsung boards */
> int misc_init_r(void)
> {
> +#ifdef CONFIG_LCD_MENU
> + keys_init();
> + check_boot_mode();
> +#endif
> #ifdef CONFIG_CMD_BMP
> if (panel_info.logo_on)
> draw_logo();
> #endif
> +
> return 0;
> }
> diff --git a/board/samsung/common/misc.h b/board/samsung/common/misc.h
> new file mode 100644
> index 000..f583552
> --- /dev/null
> +++ b/board/samsung/common/misc.h
> @@ -0,0 +1,18 @@
> +#ifndef __SAMSUNG_COMMON_MISC_H__
> +#define __SAMSUNG_COMMON_MISC_H__
> +
> +#ifdef CONFIG_LCD_MENU
> +enum {
> + BOOT_MODE_INFO,
> + BOOT_MODE_THOR,
> + BOOT_MODE_UMS,
> + BOOT_MODE_DFU,
> + BOOT_MODE_EXIT,
> +};
> +
> +#ifdef CONFIG_REVISION_TAG
> +u32 get_board_rev(void);
> +#endif
> +#endif /* CONFIG_LCD_MENU */
> +
> +#endif /* __SAMSUNG_COMMON_MISC_H__ */
> \ No newline at end of file
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
#define CONFIG_POWER_MAX77686
>>>>>
>>>>> -/* SPI */
>>>>> -#define CONFIG_ENV_IS_IN_SPI_FLASH
>>>>> -#define CONFIG_SPI_FLASH
>>>>> -
>>>>> -#ifdef CONFIG_SPI_FLASH
>>>>>
iver at drivers/usb/phy/phy-samsung-usb2.c, which also
>>>> sets up
>>>
>>> all
>>>
>>>> ports unconditionally.
>>>
>>> OK, I won't fight this. I would be much more inclined to being able to
>>> conditionally se
> ret = exynos_xhci_core_init(ctx);
> if (ret) {
> puts("XHCI: failed to initialize controller\n");
> @@ -321,7 +353,10 @@ int xhci_hcd_init(int index, struct xhci_hccr **hccr,
> struct xhci_hcor **hcor)
>
> void xhci_hcd_stop(int index)
> {
> - struct exynos_xhci *ctx = &exynos;
> + struct exynos_xhci *ctx = ®_bases[index];
>
> exynos_xhci_core_exit(ctx);
> +
> + /* Power-off usb_drd phy */
> + set_usbdrd_phy_ctrl(POWER_USB_DRD_PHY_CTRL_DISABLE, index);
> }
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index d1c2e5c..24175e6 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -30,10 +30,6 @@
> #include
> #include "xhci.h"
>
> -#ifndef CONFIG_USB_MAX_CONTROLLER_COUNT
> -#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
> -#endif
> -
> static struct descriptor {
> struct usb_hub_descriptor hub;
> struct usb_device_descriptor device;
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index ceb1573..612bf79 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -21,6 +21,10 @@
> #include
> #include
>
> +#ifndef CONFIG_USB_MAX_CONTROLLER_COUNT
> +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
> +#endif
> +
> #define upper_32_bits(n) (u32)((n) >> 32)
> #define lower_32_bits(n) (u32)(n)
>
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
fined at exynos5-dt.h
> +#define CONFIG_POWER_S2MPS11
> +
> #endif /* __CONFIG_5420_H */
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
to pmic.h, all of pmic operations are allowed u32.
> +};
> +
> +/**
> + * Common function used to intialize an i2c based PMIC.
> + *
> + * This function finds the PMIC in the device tree based on its compatibility
> + * ID. If found, the struct pmic is allocated, initialized and registered.
> + *
> + * Then the table of initialization settings is scanned and the PMIC
> registers
> + * are set as dictated by the table contents,
> + *
> + * @param pmic_compat compatibility ID f the PMIC to be initialized.
> + * @param pmic_ops a pointer to the table containing PMIC initialization
> + * settings. The last entry contains reg_op
> + * of PMIC_REG_BAIL.
> + * @return zero on success, nonzero on failure
> + */
> +int pmic_common_init(enum fdt_compat_id pmic_compat,
> + const struct pmic_init_ops *pmic_ops);
>
> #define pmic_i2c_addr (p->hw.i2c.addr)
> #define pmic_i2c_tx_num (p->hw.i2c.tx_num)
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Przemsyslaw Marczak,
On 07/01/14 21:54, Przemyslaw Marczak wrote:
> Hello,
>
> On 01/06/2014 12:37 PM, Minkyu Kang wrote:
>> On 04/01/14 02:21, Przemyslaw Marczak wrote:
>>> Signed-off-by: Przemyslaw Marczak
>>>
>>> ---
>>> changes v2:
if (mmc) {
> + if (!mmc->capacity)
> + mmc_init(mmc);
> +
> + lcd_printf("\teMMC size: %llu MB\n", mmc->capacity / SZ_1M);
> + }
#endif
> +
> + if (vid)
> + lcd_printf("\tDisplay resolution: %u x % u\n",
> +vid->vl_col, vid->vl_row);
> +
> + lcd_printf("\tDisplay BPP: %u\n", 1 << vid->vl_bpix);
> +}
> +
> +static int boot_menu(void)
> +{
> + int key = 0;
> + int timeout = 10;
> +
> + display_mode_info();
> +
> + while (timeout--) {
> + lcd_printf("\rNormal boot will start in: %d seconds.", timeout);
> + udelay(100);
mdelay(1000)?
> +
> + key = key_pressed(KEY_POWER);
> + if (key)
> + break;
> + }
> +
> + lcd_clear();
> +
> + /* If PWR pressed - show download menu */
> + if (key) {
> + printf("Power pressed - go to download menu\n");
> + download_menu();
> + printf("Download mode exit.\n");
> + }
> +
> + return 0;
> +}
> +
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 10/01/14 18:37, Przemyslaw Marczak wrote:
> Hello Minkyu,
>
> On 01/10/2014 02:37 AM, Minkyu Kang wrote:
>> On 09/01/14 20:23, Przemyslaw Marczak wrote:
>>> This simple LCD menu allows run one of download mode on device
>>> without writing on console or fo
gister using mask not just one bit value
>>> - add checking return value to functions fg read/write
>>> - add model lock and model check count
>>> - add debug msg
>>>
>>> Signed-off-by: Przemyslaw Marczak
>>> Cc: Lukasz Majewski
>>> C
On 09/01/14 23:31, Mateusz Zalega wrote:
> In some cases MMC was still uninitialized while media capacity check,
> leading to broken ums command.
>
> Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca
> Signed-off-by: Mateusz Zalega
> Cc: Lukasz Majewski
> Cc: Minkyu Kang
delete mode 100644 board/friendlyarm/mini2440/mini2440.c
> delete mode 100644 board/friendlyarm/mini2440/mini2440.h
> delete mode 100644 doc/README.mini2440
>
Acked-by: Minkyu Kang
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.de
s need for some common function which allows set proper
logo by board config".
At previous version of board files, you already have common function
(init_panel_info - even though this function is not for the logo but I think,
it's enough).
@@ -484,10 +484,6 @@ void init_panel_info(vidinfo_t *vid)
vid->resolution = HD_RESOLUTION;
vid->rgb_mode = MODE_RGB_P;
-#ifdef CONFIG_TIZEN
- get_tizen_logo_info(vid);
-#endif
-
/* for LD9040. */
vid->pclk_name = 1; /* MPLL */
vid->sclk_div = 1;
If you remove this change at each boards, then you don't have add ifdef
CONFIG_TIZEN at draw_logo function.
It can be split common stuffs and board specific stuffs efficiently.
How you think?
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Don't know why but, file permission was changed
Signed-off-by: Minkyu Kang
---
0 files changed
mode change 100755 => 100644 drivers/mmc/dw_mmc.c
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
old mode 100755
new mode 100644
--
1.7.9.5
--
Thanks,
Min
> 1 file changed, 1 insertion(+)
>
Acked-by: Minkyu Kang
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
can be quite confident that it is already available in L1 and L2 can
> be disabled.
>
> Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b
> Signed-off-by: Lukasz Majewski
> ---
> include/configs/trats.h |1 +
> include/configs/trats2.h | 1 +
> 2 files change
figs/trats2.h |5 -
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
Acked-by: Minkyu Kang
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
>
It seems there are three patches.
http://patchwork.ozlabs.org/patch/310477/
http://patchwork.ozlabs.org/patch/310478/
http://patchwork.ozlabs.org/patch/310479/
for reducing PR steps, it's better to apply those patches to u-boot-arm or
u-boot directly.
How you think?
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
ung boards */
>> +int misc_init_r(void)
>> +{
>> +return 0;
>> +}
>>
> #endif
>
> In this way we can add other functions in the future even without
> CONFIG_MISC_INIT_R.
partly agree.
But, I doubt what is the role of misc.c file.
because of the meaning of miscellaneous is ambiguous,
this file have possibility to be messy.
So, please let me know what is your plan to this file.
>
> Is it better solution?
>
> Thank you,
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 16/01/14 13:05, Leela Krishna Amudala wrote:
> Hi Minkyu Kang,
>
> Thanks for reviewing the patch, Please check my comments inline.
>
> On 1/7/14, Minkyu Kang wrote:
>> On 06/01/14 20:49, Leela Krishna Amudala wrote:
>>> Most of i2c PMIC drivers follow th
On 15/01/14 14:27, Inha Song wrote:
> Use setbits/clrbits macro instead of readl/writel function
>
> Signed-off-by: Inha Song
> Signed-off-by: Minkyu Kang
> Tested-by: Przemyslaw Marczak
> ---
> Changes for v2:
> - Coding Style cleanup
> - add signed-off-by
>
s well as "and 0x9, or 0x6" which is inconsistent.
> Unless this is the "bits vs numbers" thing, where comments may
> help. (Ignore this latter concern if there already are those
> comments, which just are not in the patch's context. I haven't
> checked the source but only looked at your patch.)
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 16/01/14 17:20, Inha Song wrote:
>
> Hi,
>
> On Thu, 16 Jan 2014 16:50:37 +0900
> Minkyu Kang wrote:
>
>> On 15/01/14 14:27, Inha Song wrote:
>>> Use setbits/clrbits macro instead of readl/writel function
>>>
>>> Signed-off-by: Inha
On 15/01/14 17:18, Przemyslaw Marczak wrote:
> Hello Piotr,
>
> On 01/15/2014 09:08 AM, Piotr Wilczek wrote:
>> Dear Przemyslaw,
>>
>>> -Original Message-
>>> From: Przemyslaw Marczak [mailto:p.marc...@samsung.com]
>>> Sent: Wednesday, Jan
On 17/01/14 17:36, Przemyslaw Marczak wrote:
> On 01/17/2014 07:26 AM, Minkyu Kang wrote:
>> On 15/01/14 17:18, Przemyslaw Marczak wrote:
>>>>>>>
>>>>>>> In this way we can add other functions in the future even without
>>>>> CONFIG
Jaehoon,
How you think?
On 29/01/14 04:31, Tom Rini wrote:
> On Tue, Jan 28, 2014 at 12:25:02PM -0500, Tom Rini wrote:
>> Hey guys,
>>
>> I've posted a patch to support the eMMC boot partitions found on the TI
>> DRA7xx EVM the other day, and I've been looking at what exactly happens
>> with the '
id based in interrupt
>> number.
>>>
>>> Signed-off-by: Piotr Wilczek
>>> Signed-off-by: Kyungmin Park
>>> CC: Minkyu Kang
>>> ---
>>> arch/arm/cpu/armv7/exynos/pinmux.c | 21 +
>>> 1 file changed, 21
The value of PERIPH_ID_COUNT was wrong, and unnecessary.
Signed-off-by: Minkyu Kang
---
arch/arm/cpu/armv7/exynos/clock.c |2 +-
arch/arm/include/asm/arch-exynos/periph.h |1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv7/exynos/clock.c
b
Signed-off-by: Minkyu Kang
---
arch/arm/include/asm/arch-exynos/periph.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-exynos/periph.h
b/arch/arm/include/asm/arch-exynos/periph.h
index 30c7f18..6d77d80 100644
--- a/arch/arm/include/asm/arch
Because of the list of peripherals is not sequential,
such a routine does not check for valid correctly.
Error check will be done when call the exynos_pinmux_config function.
Signed-off-by: Minkyu Kang
---
arch/arm/cpu/armv7/exynos/pinmux.c |7 +--
1 file changed, 1 insertion(+), 6
utam
> Cc: Julius Werner
> Cc: Minkyu Kang
> Cc: Marek Vasut
> ---
> board/samsung/dts/exynos5250-smdk5250.dts |2 +-
> board/samsung/dts/exynos5250-snow.dts |4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
appli
mmon board file migration for exynos platform
> added it again. So removing it now.
>
> Signed-off-by: Vivek Gautam
> Cc: Julius Werner
> Cc: Minkyu Kang
> Cc: Marek Vasut
> ---
> board/samsung/smdk5250/smdk5250.c | 19 ---
> 1 file changed, 19 deletions
644 lib/tizen/tizen_hd_logo.h
> delete mode 100644 lib/tizen/tizen_hd_logo_data.h
> create mode 100644 lib/tizen/tizen_logo_16bpp.h
> create mode 100644 lib/tizen/tizen_logo_16bpp_gzip.h
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
h|3 ++-
> 3 files changed, 13 insertions(+), 2 deletions(-)
> create mode 100644 board/samsung/common/dfu_sample_env.txt
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
101 - 200 of 1563 matches
Mail list logo
