On 13/01/14 18:27, Przemyslaw Marczak wrote: > Hello Minkyu, > > On 12/30/2013 11:31 AM, Przemyslaw Marczak wrote: >> Hello, >> >> On 12/30/2013 11:24 AM, Przemyslaw Marczak wrote: >>> Issues: >>> - reading i2c data by passing u16 pointer causes errors in read data. >>> - max17042 status register fields have not only Power On Reset meaning >>> so using proper mask is required. >>> >>> Changes: >>> - read i2c data to type u32 instead of u16 - avoids buffer overflow >>> - compare FG status register using mask not just one bit value >>> - add checking return value to functions fg read/write >>> - add model lock and model check count >>> - add debug msg >>> >>> Signed-off-by: Przemyslaw Marczak <p.marc...@samsung.com> >>> Cc: Lukasz Majewski <l.majew...@samsung.com> >>> Cc: Minkyu Kang <mk7.k...@samsung.com> >>> >>> --- >>> Changes v2: >>> - add checking return value to functions fg read/write >>> - add model lock and model check count >>> - add status msg >>> - change logical AND to bitwise AND when checking status register >>> >> >> To test this patch, it is required to apply trats i2c fix by Piotr Wilczek: >> "[PATCH] board:trats1:trats2: fix adapter number" >> which can be found at u-boot list. >> In other way FG will be not initialized. >> >> Regards, > > Could you review this patch, please? > Is it possible to apply this before the release? > It is useful fix. > > Thank you,
This patch was delegated to Tom. Thanks, Minkyu Kang. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
