Re: [U-Boot] [PATCH] omap3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
Paulraj, Sandeep wrote: > >> -Original Message- >> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] >> On Behalf Of Mike Rapoport >> Sent: Wednesday, November 11, 2009 3:03 AM >> To: u-boot@lists.denx.de >> Cc: Mike Rapoport

Re: [U-Boot] [PATCH] omap3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
Peter Tyser wrote: > On Wed, 2009-11-11 at 15:41 +0200, Mike Rapoport wrote: >> Paulraj, Sandeep wrote: >>>> -Original Message- >>>> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] >>>> On Behalf Of Mike Rapoport &g

Re: [U-Boot] [PATCH] omap3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
Tom wrote: > Peter Tyser wrote: >> >> >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -3168,6 +3168,9 @@ omap3_zoom1_config :unconfig >>> omap3_zoom2_config : unconfig >>> @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd >>> omap3 >>> >>> +omap3_c

[U-Boot] [PATCH v2] OMAP3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
Add CM-T35 board support -- v2 changes: - rename board config file from omap3_cm-t35.h to cm-t35.h - remove SZ_xx references - add MAKEALL/MAINTEINERS entries -- Signed-off-by: Mike Rapoport --- MAINTAINERS |4 + MAKEALL |1 + Makefile

Re: [U-Boot] [PATCH 5/5] smc911x: allow mac address to be kept after smc911x_halt

2009-11-11 Thread Mike Rapoport
Mike Frysinger wrote: > On Wednesday 11 November 2009 03:03:04 Mike Rapoport wrote: >> The smc911x_halt gets called after completion of network opration >> and resets the chip. When there is no SROM attached to the SMSC, MAC >> address gets reset as well. Add CONFIG_SMC91

Re: [U-Boot] [PATCH 3/5] smc911x: silence MAC mismatch warning

2009-11-11 Thread Mike Rapoport
Mike Frysinger wrote: > On Wednesday 11 November 2009 03:03:02 Mike Rapoport wrote: >> If there is no SROM attached to the SMSC chip it's MAC address is >> initialized to ff:ff:ff:ff:ff:ff and it causes the following >> warning: >> >> Warnin

Re: [U-Boot] [PATCH v2] OMAP3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
On Wed, Nov 11, 2009 at 8:37 PM, Dirk Behme wrote: > Mike Rapoport wrote: >> Add CM-T35 board support >> >> -- >> v2 changes: >> - rename board config file from omap3_cm-t35.h to cm-t35.h >> - remove SZ_xx references >> - add MAKEALL/MAINTEINERS entrie

Re: [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs

2009-11-11 Thread Mike Rapoport
On Wed, Nov 11, 2009 at 5:18 PM, Mike Frysinger wrote: > On Wednesday 11 November 2009 03:03:01 Mike Rapoport wrote: >> --- a/drivers/net/smc911x.h >> +++ b/drivers/net/smc911x.h >> @@ -480,8 +480,8 @@ static void smc911x_reset(struct eth_device *dev) >>              

Re: [U-Boot] [PATCH v2] OMAP3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
On Wed, Nov 11, 2009 at 10:03 PM, Ben Warren wrote: > Mike Rapoport wrote: >> Add CM-T35 board support >> >> -- >> v2 changes: >> - rename board config file from omap3_cm-t35.h to cm-t35.h >> - remove SZ_xx references >> - add MAKEALL/MAINTEINERS ent

Re: [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs

2009-11-11 Thread Mike Rapoport
On Thu, Nov 12, 2009 at 12:11 AM, Mike Frysinger wrote: > On Wednesday 11 November 2009 16:56:57 Mike Rapoport wrote: >> On Wed, Nov 11, 2009 at 5:18 PM, Mike Frysinger wrote: >> > On Wednesday 11 November 2009 03:03:01 Mike Rapoport wrote: >> >> --- a/drivers/net

Re: [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs

2009-11-12 Thread Mike Rapoport
Hi Mike, On Thu, Nov 12, 2009 at 12:50 AM, Mike Frysinger wrote: > > here's my [compile] tested change as the board i have with this part isnt > readily accessible atm ... > -mike I've tested your changes, MAC register dumps works Ok. I needed to make some changes to make it work, see the commen

Re: [U-Boot] [PATCH v2] OMAP3: add CM-T35 board

2009-11-12 Thread Mike Rapoport
Dear Wolfgang, Wolfgang Denk wrote: > Dear Mike Rapoport, > > In message <1257955131-16729-1-git-send-email-m...@compulab.co.il> you wrote: >> Add CM-T35 board support >> >> -- >> v2 changes: >> - rename board config file from omap3_cm-t35.h to c

[U-Boot] [PATCH] smc911x: make smc911x_initialize return correct value (Was: Re: [PATCH 1/5] smc911x: return -1 when initialization fails)

2009-11-12 Thread Mike Rapoport
Mike Frysinger wrote: > On Wednesday 11 November 2009 03:03:00 Mike Rapoport wrote: >> --- a/drivers/net/smc911x.c >> +++ b/drivers/net/smc911x.c >> @@ -243,7 +243,7 @@ >> dev = malloc(sizeof(*dev)); >> if (!dev) { >>

Re: [U-Boot] [PATCH] smc911x: fix typo in smc911x_handle_mac_address name

2009-11-14 Thread Mike Rapoport
Ben, Any chance this one can be merged as well? Mike Rapoport wrote: > Signed-off-by: Mike Rapoport > --- > drivers/net/smc911x.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c > index c5

[U-Boot] [PATCHi v3] OMAP3: add CM-T35 board

2009-11-14 Thread Mike Rapoport
Add CM-T35 board support Signed-off-by: Mike Rapoport -- v2 changes: - rename board config file from omap3_cm-t35.h to cm-t35.h - remove SZ_xx references - add MAKEALL/MAINTEINERS entries v3 changes: - fix whitespace and indentation - remove eth_init from board_eth_init - add CM-T35 entry to

Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Mike Rapoport
Any comments on this? Mike Rapoport wrote: > There are several presets for GPMC registers defined in > include/asm-arm/arch-omap3/mem.h. Allow selection between SMNAND and > M_NAND presets based on OMAP34XX_GPMC_NAND_ defines > > Signed-off-by: Mike Rapoport > --- > c

[U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Mike Rapoport
Add CM-T35 board support Signed-off-by: Mike Rapoport -- v2 changes: - rename board config file from omap3_cm-t35.h to cm-t35.h - remove SZ_xx references - add MAKEALL/MAINTEINERS entries v3 changes: - fix whitespace and indentation - remove eth_init from board_eth_init - add CM-T35 entry to

Re: [U-Boot] [PATCHi v3] OMAP3: add CM-T35 board

2009-11-15 Thread Mike Rapoport
Paulraj, Sandeep wrote: > >> Add CM-T35 board support >> >> Signed-off-by: Mike Rapoport >> >> -- >> v2 changes: >> - rename board config file from omap3_cm-t35.h to cm-t35.h >> - remove SZ_xx references >> - add MAKEALL/MAINTEINERS entr

Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Mike Rapoport
On Sun, Nov 15, 2009 at 6:36 PM, Tom wrote: > Mike Rapoport wrote: >> Any comments on this? >> > > This is a good idea but.. > > These defines are used in the TI codebase but > it doesn't look like the samsung nand is used here. > > As a test I removed th

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Mike Rapoport
Dear Wolfgang, Wolfgang Denk wrote: > Dear Mike Rapoport, > > In message <1258296430-19678-1-git-send-email-m...@compulab.co.il> you wrote: >> Add CM-T35 board support > ... >> MAINTAINERS |4 + >> MAKEALL |1 +

[U-Boot] [PATCHi v5] OMAP3: add CM-T35 board

2009-11-16 Thread Mike Rapoport
CM-T35 is a system-on-module board from CompuLab, Ltd. The CM-T35 datasheet can be found at http://www.compulab.co.il/t35/html/t35-cm-datasheet.htm Signed-off-by: Mike Rapoport -- v2 changes: - rename board config file from omap3_cm-t35.h to cm-t35.h - remove SZ_xx references - add MAKEALL

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-16 Thread Mike Rapoport
Tom, Tom wrote: > Paulraj, Sandeep wrote: >>> Add CM-T35 board support >>> > > Please add more description of the board. > >>> Signed-off-by: Mike Rapoport >>> >>> -- >>> v2 changes: >>> - rename board config file from

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-16 Thread Mike Rapoport
Tom wrote: > Mike Rapoport wrote: >> Tom, >> >> Tom wrote: >>> Paulraj, Sandeep wrote: >>>>> Add CM-T35 board support >>>>> >>> Please add more description of the board. >>> >>>>> Signed-off-by: Mike Rap

[U-Boot] [PATCH v6] OMAP3: add CM-T35 board

2009-11-17 Thread Mike Rapoport
CM-T35 is a system-on-module board from CompuLab, Ltd. The CM-T35 datasheet can be found at http://www.compulab.co.il/t35/html/t35-cm-datasheet.htm Signed-off-by: Mike Rapoport -- v2 changes: - rename board config file from omap3_cm-t35.h to cm-t35.h - remove SZ_xx references - add MAKEALL

Re: [U-Boot] [PATCH] OMAP3 Remove unneeded boot_flash_* declarations

2009-11-18 Thread Mike Rapoport
variables The boot_flash_* variables can be completely replaced by static definitions and therefore are not needed. Signed-off-by: Mike Rapoport --- cpu/arm_cortexa8/omap3/mem.c| 27 --- include/configs/devkit8000.h| 10 +- include/configs/omap3_beagle.h |

[U-Boot] omap3 and get_board_rev

2009-11-19 Thread Mike Rapoport
Hi all, In current omap3 implementation get_board_rev function is defined in cpu/arm_cortexa8/omap3/sys_info.c. The function returns some magic constant and that's it. I wonder what would be the best way to fix it: either make the get_board_rev in cpu/arm_cortexa8/omap3/sys_info.c "weak", or copy

Re: [U-Boot] [PATCH v6] OMAP3: add CM-T35 board

2009-11-22 Thread Mike Rapoport
Mike Rapoport wrote: > CM-T35 is a system-on-module board from CompuLab, Ltd. The CM-T35 > datasheet can be found at > http://www.compulab.co.il/t35/html/t35-cm-datasheet.htm > > Signed-off-by: Mike Rapoport > Any updates on this?

[U-Boot] [PATCH] examples/api/Makefile: add lib_arm/eabi_compat

2009-11-25 Thread Mike Rapoport
Some EABI conformant tool chains cause external references to utility functions like raise(); import such functions from lib_arm/eabi_compat.c Signed-off-by: Mike Rapoport --- examples/api/Makefile | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/examples/api

Re: [U-Boot] [PATCH v6] OMAP3: add CM-T35 board

2009-11-26 Thread Mike Rapoport
Mike Rapoport wrote: > > Mike Rapoport wrote: >> CM-T35 is a system-on-module board from CompuLab, Ltd. The CM-T35 >> datasheet can be found at >> http://www.compulab.co.il/t35/html/t35-cm-datasheet.htm >> >> Signed-off-by: Mike

[U-Boot] [PATCH] omap3: fix bi_dram initialization when CONFIG_NR_DRAM_BANKS is 1

2009-11-11 Thread Mike Rapoport
When CONFIG_NR_DRAM_BANKS is 1 gd->bd->bi_dram[1] assignment exceeds bi_dram array bounds. Perform it only if CONFIG_NR_DRAM_BANKS is greater than 1. Signed-off-by: Mike Rapoport --- cpu/arm_cortexa8/omap3/board.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[U-Boot] [PATCH] smc911x: fix typo in smc911x_handle_mac_address name

2009-11-11 Thread Mike Rapoport
Signed-off-by: Mike Rapoport --- drivers/net/smc911x.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index c50758e..acc2306 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -37,7 +37,7 @@ void

[U-Boot] [PATCH 4/5] smc911x: update SMC911X related configuration description

2009-11-11 Thread Mike Rapoport
Since commit 736fead8fdbf8a8407048bebc373cd551d01ec98 "Convert SMC911X Ethernet driver to CONFIG_NET_MULTI API" SMC911X configration options are called CONFIG_SMC911X rather than CONFIG_DRIVER_SMC911X. Update README to reflect that change. Signed-off-by: Mike Rapoport --- REA

[U-Boot] [PATCH 0/5] smc911x driver fixes and additions

2009-11-11 Thread Mike Rapoport
This patch serie miscelaneous fixes and additions for SMC911X driver. Mike Rapoport (5): smc911x: return -1 when initialization fails smc911x: use dev->name in printfs smc911x: silence MAC mismatch warning smc911x: update SMC911X related configuration description smc911x: allow

[U-Boot] [PATCH 3/5] smc911x: silence MAC mismatch warning

2009-11-11 Thread Mike Rapoport
3 Set dev->enetaddr only if MAC address is valid, and thus avoid the above case. Signed-off-by: Mike Rapoport --- drivers/net/smc911x.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 9ff1288..f5d984d

[U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs

2009-11-11 Thread Mike Rapoport
Signed-off-by: Mike Rapoport --- drivers/net/smc911x.c | 17 - drivers/net/smc911x.h | 10 +- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 57ad806..9ff1288 100644 --- a/drivers/net/smc911x.c +++ b

[U-Boot] [PATCH 1/5] smc911x: return -1 when initialization fails

2009-11-11 Thread Mike Rapoport
Signed-off-by: Mike Rapoport --- drivers/net/smc911x.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index acc2306..57ad806 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -243,7 +243,7 @@ int

[U-Boot] [PATCH 5/5] smc911x: allow mac address to be kept after smc911x_halt

2009-11-11 Thread Mike Rapoport
-off-by: Mike Rapoport --- README|5 + drivers/net/smc911x.c |4 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/README b/README index 84d7f16..a5956b2 100644 --- a/README +++ b/README @@ -857,6 +857,11 @@ The following options need to be configured

[U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-11 Thread Mike Rapoport
There are several presets for GPMC registers defined in include/asm-arm/arch-omap3/mem.h. Allow selection between SMNAND and M_NAND presets based on OMAP34XX_GPMC_NAND_ defines Signed-off-by: Mike Rapoport --- cpu/arm_cortexa8/omap3/mem.c | 25 - 1 files changed, 16

[U-Boot] [PATCH] omap3: add CM-T35 board

2009-11-11 Thread Mike Rapoport
Add CM-T35 board support Signed-off-by: Mike Rapoport --- Makefile |3 + board/cm-t35/Makefile | 47 ++ board/cm-t35/cm-t35.c | 196 ++ board/cm-t35/cm-t35.h | 173 +++ board/cm-t35

[U-Boot] [PATCH v2] OMAP3: add CM-T35 board

2010-12-07 Thread Mike Rapoport
This patch adds support for CM-T35 board Signed-off-by: Mike Rapoport --- v2 changes: * address Nishanth's comments MAINTAINERS |4 + MAKEALL |1 + board/cm_t35/Makefile| 47 ++ board/cm_t35/cm_t35.c|

[U-Boot] [PATCH v3] OMAP3: add CM-T35 board

2010-12-16 Thread Mike Rapoport
This patch adds support for CM-T35 board Signed-off-by: Mike Rapoport --- v3 changes: * address Wolfgang's comments v2 changes: * address Nishanth's comments MAINTAINERS |4 + board/cm_t35/Makefile| 47 ++ board/cm_t35/cm_t35.c

Re: [U-Boot] [PATCH v3 1/4] arm: Tegra2: Add basic NVIDIA Tegra2 SoC support

2011-01-24 Thread Mike Rapoport
On 01/19/11 23:19, Tom Warren wrote: > Signed-off-by: Tom Warren > --- > Changes for V2: > - Coding style cleanup > - Move serial driver changes to separate patch > - Use board/nvidia/ instead of /board/tegra > - Remove TRUE/FALSE defines > - Use standard NS

Re: [U-Boot] [PATCH v3 3/4] arm: Tegra2: Add support for NVIDIA Harmony board

2011-01-24 Thread Mike Rapoport
On 01/19/11 23:19, Tom Warren wrote: > Signed-off-by: Tom Warren > --- > Changes for V2: > - Use board/nvidia/ instead of /board/tegra > - Change nv-common.h config file to tegra2-common.h > > MAINTAINERS |4 + > board/nvidia/harmony/Makefile | 50

Re: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

2011-01-25 Thread Mike Rapoport
On 01/22/11 01:06, Tom Warren wrote: > Signed-off-by: Tom Warren > --- [ snip ] > +/* > + * Routine: pin_mux_uart > + * Description: setup the pin muxes/tristate values for a UART > + */ > +static void pin_mux_uart(void) > +{ > + pinmux_tri_ctlr *const pmt = (pinmux_tri_ctlr *)NV_PA_APB_MISC

Re: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

2011-01-25 Thread Mike Rapoport
On 01/25/11 18:50, Tom Warren wrote: > Mike, > > On Tue, Jan 25, 2011 at 1:11 AM, Mike Rapoport wrote: >> On 01/22/11 01:06, Tom Warren wrote: >>> Signed-off-by: Tom Warren >>> --- >> >> [ snip ] >> >>> +/* >>> + * Routine:

Re: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

2011-01-26 Thread Mike Rapoport
On 01/26/11 00:24, Peter Tyser wrote: >> As I've already pointed out (1) this covers only one possibility of UART >> pin >> muxing options. I agree that it makes sense when this is a part of the >> board-specific code. However, forcing specific pins configuration in the >> gen

Re: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

2011-01-26 Thread Mike Rapoport
Tom, On 01/26/11 19:05, Tom Warren wrote: > Mike, > > On Wed, Jan 26, 2011 at 1:13 AM, Mike Rapoport wrote: >> My point was that pin muxing belongs to the board code rather than to the >> driver. Driver should just assume that pins are configured elsewhere and it >&g

Re: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

2011-01-26 Thread Mike Rapoport
On 01/26/11 17:58, Peter Tyser wrote: > On Wed, 2011-01-26 at 10:13 +0200, Mike Rapoport wrote: >> On 01/26/11 00:24, Peter Tyser wrote: > >> Moreover, I'd prefer to see pinmux_board_init or something similar that >> configures all the pins at once rather than c

Re: [U-Boot] [Patch V6 0/4] Add basic NVIDIA Tegra2 SoC support

2011-02-01 Thread Mike Rapoport
On 02/02/11 02:09, Tom Warren wrote: > I haven't seen any new feedback on this version (V6) of the patchset > since it was posted. > > Wolfgang, Mike, Peter, et al - are you happy with the current patch? I'm Ok with the current patch. > If so, when can I expect it to be pushed? > > Thanks, > >

Re: [U-Boot] [Patch V6 0/4] Add basic NVIDIA Tegra2 SoC support

2011-02-02 Thread Mike Rapoport
On 02/02/11 19:06, Tom Warren wrote: > Mike, > > On Wed, Feb 2, 2011 at 12:57 AM, Mike Rapoport wrote: >> On 02/02/11 02:09, Tom Warren wrote: >>> I haven't seen any new feedback on this version (V6) of the patchset >>> since it was posted. >>> &

[U-Boot] [PATCH] OMAP3: add CM-T35 board

2010-11-23 Thread Mike Rapoport
This patch adds support for CM-T35 board Signed-off-by: Mike Rapoport --- MAINTAINERS |4 + MAKEALL |1 + board/cm_t35/Makefile| 47 ++ board/cm_t35/cm_t35.c| 222 board/cm_t35/cm_t35.h| 184

Re: [U-Boot] [PATCH] OMAP3: add CM-T35 board

2010-11-27 Thread Mike Rapoport
Hi Nishanth, Sorry for the delay, some deadly virus has caught me and I was not really functional last week. On 11/24/10 04:58, Nishanth Menon wrote: > Mike Rapoport wrote, on 11/23/2010 01:29 AM: > minor comments follow: > [...] > > diff --git a/board/cm_t35/cm_t35.h b/board/