Mike Frysinger wrote: > On Wednesday 11 November 2009 03:03:02 Mike Rapoport wrote: >> If there is no SROM attached to the SMSC chip it's MAC address is >> initialized to ff:ff:ff:ff:ff:ff and it causes the following >> warning: >> >> Warning: smc911x-0 MAC addresses don't match: >> Address in SROM is ff:ff:ff:ff:ff:ff >> Address in environment is 00:01:ba:dc:0d:03 >> >> Set dev->enetaddr only if MAC address is valid, and thus avoid the >> above case. > > someone already posted a patch for this issue: > NET: Fix MAC addr handling for smc911x > > i think the approach they took is better -- they check for explicit values > that indicate 'no srom is attached' rather than 'is the mac valid' as your > code could ignore attached srom's but bad addresses. in this latter case, i > think we want the warning.
agree > -mike -- Sincerely yours, Mike. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
