Hi Nishanth, Sorry for the delay, some deadly virus has caught me and I was not really functional last week.
On 11/24/10 04:58, Nishanth Menon wrote: > Mike Rapoport wrote, on 11/23/2010 01:29 AM: > minor comments follow: > [...] > > diff --git a/board/cm_t35/cm_t35.h b/board/cm_t35/cm_t35.h > > new file mode 100644 > > index 0000000..514017d > > --- /dev/null > > +++ b/board/cm_t35/cm_t35.h > [..] >> + /*DSS*/\ [ snip ] >> + MUX_VAL(CP(DSS_DATA19), (IDIS | PTD | DIS | M0)) /*DSS_DATA19*/\ >> + MUX_VAL(CP(DSS_DATA20), (IDIS | PTD | DIS | M0)) /*DSS_DATA20*/\ >> + MUX_VAL(CP(DSS_DATA21), (IDIS | PTD | DIS | M0)) /*DSS_DATA21*/\ >> + MUX_VAL(CP(DSS_DATA22), (IDIS | PTD | DIS | M0)) /*DSS_DATA22*/\ >> + MUX_VAL(CP(DSS_DATA23), (IDIS | PTD | DIS | M0)) /*DSS_DATA23*/\ > Are you using bootlogo in CM-t35 u-boot? Not at the moment, but we'd really like to add bootlogo support. AFAIK, some of CM-T35 users already have the bootlogo support and therefore I'd prefer to have the DSS pins configured. > >> + MUX_VAL(CP(SYS_CLKOUT1), (IEN | PTD | DIS | M0)) /*CLKOUT1*/\ >> + MUX_VAL(CP(SYS_CLKOUT2), (IDIS | PTD | DIS | M4)) /*green LED*/\ > might be better to state which GPIO than green led :) The GPIO controlling the led is not available for other functionality, so I'd prefer to keep the comment. >> + MUX_VAL(CP(JTAG_nTRST), (IEN | PTD | DIS | M0)) /*JTAG_nTRST*/\ >> + MUX_VAL(CP(JTAG_TCK), (IEN | PTD | DIS | M0)) /*JTAG_TCK*/\ >> + MUX_VAL(CP(JTAG_TMS), (IEN | PTD | DIS | M0)) /*JTAG_TMS*/\ >> + MUX_VAL(CP(JTAG_TDI), (IEN | PTD | DIS | M0)) /*JTAG_TDI*/\ > >> + MUX_VAL(CP(SDRC_CKE0), (IDIS | PTU | EN | M0)) /*sdrc_cke0*/\ >> + MUX_VAL(CP(SDRC_CKE1), (IDIS | PTD | DIS | M7)) /*sdrc_cke1*/\ > this tiny set probably should go along with sdrc to reflect proper > functional set I guess. Agree >> + >> +#endif >> diff --git a/board/cm_t35/config.mk b/board/cm_t35/config.mk >> new file mode 100644 >> index 0000000..e81e283 >> --- /dev/null >> +++ b/board/cm_t35/config.mk >> @@ -0,0 +1,30 @@ >> +# >> +# (C) Copyright 2009 >> +# CompuLab, Ltd.,<www.compulab.co.il> >> +# >> +# See file CREDITS for list of people who contributed to this >> +# project. >> +# >> +# This program is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU General Public License as >> +# published by the Free Software Foundation; either version 2 of >> +# the License, or (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write to the Free Software >> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, >> +# MA 02111-1307 USA >> +# >> +# Physical Address: >> +# 8000'0000 (bank0) >> +# >> +# Linux-Kernel is expected to be at 8000'8000, entry 8000'8000 >> +# (mem base + reserved) >> + >> +# For use with external or internal boots. >> +CONFIG_SYS_TEXT_BASE = 0x80008000 >> diff --git a/boards.cfg b/boards.cfg >> index 6c2a667..e79b2d7 100644 >> --- a/boards.cfg >> +++ b/boards.cfg >> @@ -392,6 +392,7 @@ igep0020 arm armv7 igep0020 isee >> omap3 >> igep0030 arm armv7 igep0030 isee omap3 >> am3517_evm arm armv7 am3517evm logicpd omap3 >> devkit8000 arm armv7 devkit8000 timll omap3 >> +cm_t35 arm armv7 cm_t35 - >> omap3 >> omap4_panda arm armv7 panda ti >> omap4 >> omap4_sdp4430 arm armv7 sdp4430 ti >> omap4 >> s5p_goni arm armv7 goni samsung s5pc1xx >> diff --git a/doc/README.omap3 b/doc/README.omap3 >> index 6227151..460950d 100644 >> --- a/doc/README.omap3 >> +++ b/doc/README.omap3 >> @@ -21,6 +21,8 @@ Currently the following boards are supported: >> >> * TI/Logic PD Zoom 2 [7] >> >> +* CompuLab Ltd. CM-T35 [8] >> + >> Toolchain >> ========= >> >> @@ -61,6 +63,11 @@ make >> make omap3_zoom2_config >> make >> >> +* CM-T35: >> + >> +make cm_t35_config >> +make >> + >> Custom commands >> =============== >> >> @@ -119,7 +126,7 @@ To read a bit : >> Acknowledgements >> ================ >> >> -OMAP3 U-Boot is based on U-Boot tar ball [8] for BeagleBoard and EVM done by >> +OMAP3 U-Boot is based on U-Boot tar ball [9] for BeagleBoard and EVM done by >> several TI employees. >> >> Links >> @@ -153,6 +160,11 @@ >> http://www.logicpd.com/products/devkit/ti/zoom_mobile_development_kit >> [7] TI/Logic PD Zoom 2 >> >> >> http://www.logicpd.com/sites/default/files/1012659A_Zoom_OMAP34x-II_MDP_Brief.pdf >> -[8] TI OMAP3 U-Boot: >> + >> +[8] CompuLab Ltd. CM-T35: >> + >> +http://www.compulab.co.il/t3530/html/t3530-cm-datasheet.htm >> + >> +[9] TI OMAP3 U-Boot: >> >> http://beagleboard.googlecode.com/files/u-boot_beagle_revb.tar.gz >> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h >> new file mode 100644 >> index 0000000..63a4938 >> --- /dev/null >> +++ b/include/configs/cm_t35.h >> @@ -0,0 +1,364 @@ >> +/* >> + * (C) Copyright 2006-2008 >> + * Texas Instruments. >> + * Richard Woodruff<r-woodru...@ti.com> >> + * Syed Mohammed Khasim<x0kha...@ti.com> >> + * > 2010 copyright? Yes, of course. >> + * Configuration settings for the TI OMAP3530 Beagle board. > > ^^^^ need fixes.. Will fix. >> + * >> + * See file CREDITS for list of people who contributed to this >> + * project. >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of >> + * the License, or (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, >> + * MA 02111-1307 USA >> + */ >> + >> +#ifndef __CONFIG_H >> +#define __CONFIG_H >> + >> +/* >> + * High Level Configuration Options > [...] -- Sincerely yours, Mike. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
