[GIT PULL] Please pull u-boot-dfu-next-20241003

2024-10-03 Thread Mattijs Korpershoek
ommandline Heinrich Schuchardt (1): cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies Mattijs Korpershoek (1): bootstd: android: Add U-Boot version to cmdline Rasmus Villemoes (1): dfu: define a callback function for the dfu_alt_info environment variable Vitaliy Vasylskyy (1):

Re: [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies

2024-10-03 Thread Mattijs Korpershoek
Hi, On Sat, 21 Sep 2024 11:20:50 +0200, Heinrich Schuchardt wrote: > CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET. > It is sufficient to depend on the prior. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu-next) [1/1] cmd: simplify CONFIG_CMD_

Re: [PATCH v5 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes

2024-10-24 Thread Mattijs Korpershoek
Hi, On Thu, 17 Oct 2024 17:12:05 +0300, Dmitry Rokosov wrote: > The patch series include changes: > - move ab_select_slot() documentation to @ notation > - redesign 'bcb' command to U_BOOT_LONGHELP approach > - move ab_select command to bcb subcommands > - introduce the ab_dump com

Re: [PATCH v2 0/3] image: android: misc fixes when using on Qualcomm platforms

2024-10-25 Thread Mattijs Korpershoek
Hi, On Thu, 17 Oct 2024 16:44:41 +0200, Neil Armstrong wrote: > When trying to use the Android boot image with header version 2 > on recent Qualcomm platforms, we get into some troubles. > > First the kernel in-place address can be > 32bit, then since > we use the Android mkbootimg, it uses the d

Re: [PATCH v5 6/6] common: android_ab: fix slot suffix for abc block

2024-11-06 Thread Mattijs Korpershoek
Hi Sam, On mar., nov. 05, 2024 at 18:58, Sam Protsenko wrote: > On Tue, Nov 5, 2024 at 9:06 AM Mattijs Korpershoek > wrote: >> >> Hi Sam, >> > > Hey Mattijs, > > [snip] > >> >> @@ -328,7 +328,8 @@ int ab_select_slot(struct blk_desc

Re: [PATCH v5 6/6] common: android_ab: fix slot suffix for abc block

2024-11-07 Thread Mattijs Korpershoek
Hi Sam, On mer., nov. 06, 2024 at 21:17, Sam Protsenko wrote: > On Wed, Nov 6, 2024 at 4:02 AM Mattijs Korpershoek > wrote: >> >> Hi Sam, >> >> On mar., nov. 05, 2024 at 18:58, Sam Protsenko >> wrote: >> >> > On Tue, Nov 5, 2024 at 9:06 AM

Re: [PATCH 3/6] configs: khadas-vim3{l}: fix userdata size

2024-11-08 Thread Mattijs Korpershoek
Hi Neil, On jeu., oct. 17, 2024 at 18:10, Guillaume La Roque wrote: > After increase boot and recovery partition userdata was not resize. > so on VIM3 16GB and VIM3L `fastboot oem format` or `gpt write mmc 2 > $partitions` fail because end of last partition is outside of eMMC > size. > > Remove

Re: (subset) [PATCH 0/6] Add support of Android Boot Image version 2 and non-AB image

2024-11-08 Thread Mattijs Korpershoek
On ven., nov. 08, 2024 at 11:11, Neil Armstrong wrote: > Hi, > > On Thu, 17 Oct 2024 18:10:24 +0200, Guillaume La Roque wrote: >> Actually bootmethod android only support android boot image version 4 >> and with AB image, some old platform wtill use android boot image >> version 2 with AB or wit

Re: [PATCH] bootstd: android: don't read whole partition sizes

2024-11-22 Thread Mattijs Korpershoek
> with these new functions: > - android_image_get_bootimg_size > - android_image_get_vendor_bootimg_size > Use these information and read only the necessary. > > By doing this with mt8365 EVK board, we read boot image in ~5 secs. > > Signed-off-by: Julien Masson Reviewed-by: Mattijs

Re: [PATCH v2 3/5] configs: khadas-vim3l_android{_ab}: move on bootmeth android

2024-11-19 Thread Mattijs Korpershoek
"mmcdev=2\0" \ > + "fastboot_raw_partition_bootloader=0x1 0xfff mmcpart 1\0" \ > + "fastboot_raw_partition_bootenv=0x0 0xfff mmcpart 2\0"\ > + "gpio_recovery=88\0"

Re: [PATCH v2 4/5] configs: khadas-vim3_android{_ab}: move on bootmeth android

2024-11-19 Thread Mattijs Korpershoek
"mmcdev=2\0" \ > + "fastboot_raw_partition_bootloader=0x1 0xfff mmcpart 1\0" \ > + "fastboot_raw_partition_bootenv=0x0 0xfff mmcpart 2\0"\ > + "gpio_recovery=88\0"

Re: [PATCH v2 2/5] bootstd: android: add non-A/B image support

2024-11-19 Thread Mattijs Korpershoek
Hi Guillaume, Thank you for the patch. On jeu., nov. 14, 2024 at 22:29, Guillaume La Roque wrote: > Update android bootmeth to support non-A/B image. > Enable AB support only when ANDROID_AB is enabled. > > Signed-off-by: Guillaume La Roque Reviewed-by: Mattijs Korpershoek &

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-19 Thread Mattijs Korpershoek
Hi Guillaume, On mar., nov. 19, 2024 at 15:16, Mattijs Korpershoek wrote: > Hi, > > On Tue, 19 Nov 2024 12:37:37 +0100, Guillaume La Roque wrote: >> Actually bootmethod android only support android boot image version 4 >> and with AB image, some old platform wtill u

Re: [PATCH] fastboot: properly handle unknown partition type

2024-11-19 Thread Mattijs Korpershoek
Hi, On Wed, 13 Nov 2024 06:05:59 +0100, Caleb Connolly wrote: > In getvar_partition_type() we attempt to find a filesystem driver for > the partition (of the list of driver enabled in U-Boot), on failure we > return the error to fastboot and completely bail out of the operation. > > However, this

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-19 Thread Mattijs Korpershoek
Hi, On Tue, 19 Nov 2024 12:37:37 +0100, Guillaume La Roque wrote: > Actually bootmethod android only support android boot image version 4 > and with AB image, some old platform wtill use android boot image > version 2 with AB or without AB slot. > > This patchset add support of both version 2 and

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-21 Thread Mattijs Korpershoek
ive some idea of what i can try or check . > > thanks for helping. I'll have a look > > Guillaume > Le 20/11/2024 à 13:56, Guillaume LA ROQUE a écrit : >> Hi, >> >> Le 19/11/2024 à 18:21, Mattijs Korpershoek a écrit : >>> Hi Guillaume, >>> &

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-25 Thread Mattijs Korpershoek
Hello, On mar., nov. 19, 2024 at 15:16, "Mattijs Korpershoek via groups.io" wrote: > Hi, > > On Tue, 19 Nov 2024 12:37:37 +0100, Guillaume La Roque wrote: >> Actually bootmethod android only support android boot image version 4 >> and with AB image, some old

Re: [PATCH] fastboot: properly handle unknown partition type

2024-11-14 Thread Mattijs Korpershoek
disabled in U-Boot), as failing to determine the current partition > type is not an error in this case. > > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_getvar.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --

Re: [PATCH v2] cmd: add a fetch utility

2024-11-14 Thread Mattijs Korpershoek
e output is meant to be useful, it should also be pleasing to > look at and perhaps entertaining. The ufetch command aims to bring this > to U-Boot, featuring a colorful ASCII art version of the U-Boot logo. > > [1]: https://en.wikipedia.org/wiki/Neofetch > > Signed-off-by: Caleb Con

Re: [PATCH] drivers: fastboot: Enable flashing support for UFS

2024-11-26 Thread Mattijs Korpershoek
Hi Varadarajan, Thank you for the patch. On mar., nov. 26, 2024 at 10:46, Varadarajan Narayanan wrote: > On Mon, Nov 25, 2024 at 06:59:40PM +0100, Caleb Connolly wrote: >> Hi Varadarajan, >> >> On 25/11/2024 12:03, Varadarajan Narayanan wrote: >> > MMC and UFS seem to execute very similar step

Re: [PATCH v4 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-26 Thread Mattijs Korpershoek
Hi, On Tue, 26 Nov 2024 09:06:08 +0100, Guillaume La Roque wrote: > Actually bootmethod android only support android boot image version 4 > and with AB image, some old platform wtill use android boot image > version 2 with AB or without AB slot. > > This patchset add support of both version 2 and

Re: [PATCH v2 1/1] usb: ci_udc: don't use "advance" feature when setting address

2024-11-26 Thread Mattijs Korpershoek
fix regression on old and > and be compatible with newer controllers. > > Inspired by: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef15e5490edc7edf808d3477ab32e0e320792f65 > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhe

Re: [PATCH v2 0/1] Fix peripheral USB mode detection

2024-11-26 Thread Mattijs Korpershoek
Hi, On Tue, 26 Nov 2024 09:29:55 +0200, Svyatoslav Ryhel wrote: > In the older USB controllers like for example in ChipIdea controller > used by the Tegra 2 the "USBADRA: Device Address Advance" bitflag > does not exist, so the new device address set during SET_ADDRESS > can't be deferred by hardw

Re: [PATCH] bootstd: android: don't read whole partition sizes

2024-11-26 Thread Mattijs Korpershoek
Hi, On Thu, 21 Nov 2024 11:59:55 +0100, Julien Masson wrote: > The current implementation is reading the whole partition for boot and > vendor_boot image which can be long following the size of the > partition or the time to read blocks (driver/SoC specific). > > For example with mediatek mt8365

Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

2024-11-26 Thread Mattijs Korpershoek
anks, >> Neil >> >> On 06/03/2024 19:59, Dmitrii Merkurev wrote: >> > Signed-off-by: Dmitrii Merkurev >> > Cc: Patrick Delaunay >> > Cc: Simon Glass >> > Cc: Mattijs Korpershoek >> > Cc: Ying-Chun Liu (PaulLiu) >> > --- >>

[GIT PULL] Please pull u-boot-dfu-20241126

2024-11-26 Thread Mattijs Korpershoek
Hi Tom, Please find some fixes for master: Fastboot: - handle unknown partition type as "raw" Usb gadget: - Fix ci_udc gadget driver for Tegra 2 devices by not using USBADRA CI job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/23572 Thanks, Mattijs The following changes s

[GIT PULL] Please pull u-boot-dfu-next-20241126

2024-11-26 Thread Mattijs Korpershoek
Hi Tom, Please find some new developments for next: Android: - bootstd: Implement bootimage v2 support - bootstd: Support non-A/B in bootmeth_android - Migrate VIM3 and VIM3L to use bootmeth_android - bootstd: Additional test for bootimage v2 - bootstd: Optimize load time when reading partitions

Re: [PATCH v1 1/6] fastboot: Fix warning when CONFIG_SYS_64BIT_LBA is enable

2024-12-03 Thread Mattijs Korpershoek
~~ > | | > | long long unsigned int > > Signed-off-by: Patrice Chotard Reviewed-by: Mattijs Korpershoek Please feel free to take this through your tree. Acked-by: Mattijs Korpershoek > -

Re: [PATCH v2] usb: gadget: f_mass_storage: Add schedule() in sleep_thread()

2024-12-03 Thread Mattijs Korpershoek
nd watchdog is triggered. > > Add schedule() call to avoid this issue. > > Signed-off-by: Patrice Chotard Reviewed-by: Mattijs Korpershoek > > --- > > Changes in v2: > - move schedule() right before dm_usb_gadget_handle_interrupts() > > drivers/usb/gad

Re: [PATCH] usb: dwc3-of-simple: Remove Amlogic and Rockchip compatible

2025-01-07 Thread Mattijs Korpershoek
tible, it is no longer in > use by any device tree in mainline linux or U-Boot. > > Signed-off-by: Jonas Karlman Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/host/dwc3-of-simple.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/host/dwc3-of

Re: [PATCH v3 1/8] usb: dwc2: Extract register definitions to common header file

2025-01-07 Thread Mattijs Korpershoek
initions into a common header file to reduce > redundancy and make the code more maintainable. > > Signed-off-by: Kongyang Liu > Reviewed-by: Marek Vasut > Tested-by: Peter Robinson > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > drivers/u

Re: [PATCH v3 2/8] usb: dwc2: Fix incorrect ULPI_UTMI_SEL bit setting

2025-01-07 Thread Mattijs Korpershoek
/chapter-26-usb-otg-2-0.pdf#page=30 > [2] > https://github.com/torvalds/linux/blob/v6.13-rc3/drivers/usb/dwc2/core.c#L1106 > > Reviewed-by: Marek Vasut > Tested-by: Peter Robinson > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/host/dwc2.

Re: [PATCH v3 3/8] USB: dwc2: Fix HBstLen setting for external DMA mode

2025-01-07 Thread Mattijs Korpershoek
Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > > --- > Additionally, the boards I have only use internal DMA mode, and it’s > unclear which chips employ external DMA. The testing was performed by > comparing against the datasheet, and the results are

Re: [PATCH v3 4/8] usb: dwc2: Clean up with bitfield macros

2025-01-07 Thread Mattijs Korpershoek
ithout altering functionality. > > Signed-off-by: Kongyang Liu > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/dwc2_udc_otg.c | 5 +- > drivers/usb/gadget/dwc2_udc_otg_regs.h | 250 > drivers/usb/gadget/dwc2_udc_otg_xfe

Re: [PATCH v3 5/8] usb: dwc2: Align macros with Linux kernel definitions

2025-01-07 Thread Mattijs Korpershoek
leanup the code. > > Signed-off-by: Kongyang Liu > Reviewed-by: Marek Vasut > Tested-by: Peter Robinson > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/dwc2_udc_otg.c | 62 +-- > drivers/usb/gadget/dwc2_udc_otg_regs.h

Re: [PATCH v3 0/8] usb: dwc2: Refactor and update USB DWC2 driver

2025-01-07 Thread Mattijs Korpershoek
Hi Junhui, On sam., janv. 04, 2025 at 11:37, Junhui Liu wrote: > This series improves the USB DWC2 driver by extracting register > definitions into a common file for better readability and updating the > reset method to reflect changes in version 4.20a, including the new > GRSTCTL_CSFTRST_DONE b

Re: [PATCH v3 6/8] usb: dwc2: Extract macro definitions to common header

2025-01-07 Thread Mattijs Korpershoek
Hi Junhui, Thank you for the patch. On sam., janv. 04, 2025 at 11:37, Junhui Liu wrote: > From: Kongyang Liu > > Some macros are shared between host and gadget code, causing duplicated > definitions. Move DWC2 macro definitions from host and gadget code into a > common header to reduce duplica

Re: [PATCH] usb: dwc3-generic: Fix build errors when USB_DWC3_GADGET is disabled

2025-01-07 Thread Mattijs Korpershoek
Hi Marek, On dim., janv. 05, 2025 at 20:29, Marek Vasut wrote: > On 6/18/24 9:15 AM, Mattijs Korpershoek wrote: >> Hi Jonas, > > Hello all, > >> On sam., mars 02, 2024 at 14:00, Jonas Karlman wrote: >> >> [...] >> >>>> >>

Re: [PATCH 2/2] usb: ehci-mx6: Use regulator_set_enable_if_allowed

2025-01-08 Thread Mattijs Korpershoek
t; Change to use the more relaxed regulator_set_enable_if_allowed to > continue if regulator already was enabled or disabled. > > Based on 335799b7252a ("usb: dwc2: Use regulator_set_enable_if_allowed") > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --

Re: [PATCH 1/2] usb: ehci-mx5: Use regulator_set_enable_if_allowed

2025-01-08 Thread Mattijs Korpershoek
t; Change to use the more relaxed regulator_set_enable_if_allowed to > continue if regulator already was enabled or disabled. > > Based on 335799b7252a ("usb: dwc2: Use regulator_set_enable_if_allowed") > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --

Re: [PATCH] Fix fastboot handling of partitions when no slots are supported

2025-01-30 Thread Mattijs Korpershoek
ciated. > > > Specifically: > > > > On 30/01/25 14:49, Mattijs Korpershoek wrote: >> Hi Federico, >> >> Thank you for the patch. >> >> On mar., janv. 28, 2025 at 12:18, Federico Fuga via B4 Relay >> wrote: >> >>> From:

Re: [PATCH v5 5/9] usb: dwc3-generic: Add STih407 support

2025-01-30 Thread Mattijs Korpershoek
asut Reviewed-by: Mattijs Korpershoek > > --- > > Changes in v5: > - reorder files entry for ARM STI in MAINTAINERS file > - add #define LOG_CATEGORY UCLASS_NOP > - use UCLASS_NOP instead of UCLASS_SIMPLE_BUS > > Changes in v4: > - Update Kconfig descrip

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2025-02-04 Thread Mattijs Korpershoek
On lun., févr. 03, 2025 at 15:38, Jon Humphreys wrote: > Ilias Apalodimas writes: [...] >> > > I went with option 1 above. I started working on option 2 however the > changes are quite invasive, touching all of the DFU interfaces, and I do not > have the understanding of the different DFU use

Re: [PATCH 2/2] board: remove capsule update support in set_dfu_alt_info()

2025-02-04 Thread Mattijs Korpershoek
ff-by: Jonathan Humphreys Nitpick: use standard Fixes syntax here please. It should be: """ Fixes: a9e6f01a941f ("efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled") Signed-off-by: Jonathan Humphreys """ With that addressed, plea

Re: [PATCH 1/2] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-04 Thread Mattijs Korpershoek
Hi Jon, Thank you for the patch. On lun., févr. 03, 2025 at 15:53, Jonathan Humphreys wrote: > The current implementation of EFI capsule update uses set_dfu_alt_info() to > set the dfu_alt_info environment variable with the settings it requires. > However, set_dfu_alt_info() is doing this for a

Re: [PATCH v4] usb: gadget: g_dnl: Fix NULLPTR dereference when serial# is unset

2025-02-06 Thread Mattijs Korpershoek
Hi, On Mon, 27 Jan 2025 21:09:45 -0600, Michael Ferolito wrote: > The current behaviour of this function will dereference a null pointer > if the serial# environment variable is unset. This was discovered on a > board where U-Boot did not have access to the first 256MB of ram, > resulting in a boa

Re: [PATCH] boot: android: handle boot images with missing DTB

2025-02-06 Thread Mattijs Korpershoek
Hi, On Thu, 23 Jan 2025 14:35:01 +, Sam Day wrote: > 607b07554e2 removed the check on the return status of the > android_image_get_dtb_img_addr call from android_image_get_dtb_by_index, > which results in null pointer accesses shortly after when trying to > check the header of a nonexistent DT

[GIT PULL] Please pull u-boot-dfu-20250211

2025-02-11 Thread Mattijs Korpershoek
Hi Tom, Please find the following fixes for master: Android: - Handle boot images with missing DTB Usb gadget: - Fix nullptr in g_dnl when serial# is unset - Add missing schedule() in f_mass_storage gadget - Add support for STih407 in dwc3-generic - Fix usb clocks on STih407 - Migrate STih407 to

Re: [PATCH v2] usb: gadget: f_mass_storage: Add schedule() in sleep_thread()

2025-02-10 Thread Mattijs Korpershoek
On lun., févr. 10, 2025 at 14:42, Marek Vasut wrote: > On 2/10/25 11:28 AM, Patrice CHOTARD wrote: >> Hi Marek > > Hi, > >> Any chance to get this patch merged in next U-Boot tag 2025.04-rc2 ? > Gadget stuff is on Mattijs desk, please ping me in a few days if he > doesn't pick it up, I'll do so

Re: [PATCH v2 2/6] test/py: Drop u_boot_ prefix on test files

2025-02-11 Thread Mattijs Korpershoek
/py/tests/test_android/test_avb.py| 2 +- > test/py/tests/test_dfu.py | 18 ++-- Reviewed-by: Mattijs Korpershoek # test_android / test_dfu > test/py/tests/test_efi_fit.py | 2 +- [...]

Re: [PATCH v2 3/6] test/py: Drop importing utils as util

2025-02-11 Thread Mattijs Korpershoek
test/py/tests/test_trace.py| 18 +++ > test/py/tests/test_vboot.py| 70 +----- > 18 files changed, 110 insertions(+), 104 deletions(-) Reviewed-by: Mattijs Korpershoek # test_android > [...]

Re: [PATCH v5 0/9] Restore USB and add UMS support for STiH407-B2260

2025-02-10 Thread Mattijs Korpershoek
Hi Patrice, Marek, On lun., févr. 10, 2025 at 14:42, Marek Vasut wrote: > On 2/10/25 11:28 AM, Patrice CHOTARD wrote: >> >> Hi Marek > > Hi, > >> Any chance to get this series merged in next U-Boot tag 2025.04-rc2 ? > Gadget stuff is on Mattijs desk, please ping me in a few days if he > doesn'

Re: [PATCH v2] usb: gadget: f_mass_storage: Add schedule() in sleep_thread()

2025-02-11 Thread Mattijs Korpershoek
Hi, On Mon, 02 Dec 2024 08:46:44 +0100, Patrice Chotard wrote: > In case "ums" command is used on platforms which don't implement > g_dnl_board_usb_cable_connected() and USB cable is not connected, > we stay inside sleep_thread() forever and watchdog is triggered. > > Add schedule() call to avoid

Re: [PATCH v5 0/9] Restore USB and add UMS support for STiH407-B2260

2025-02-11 Thread Mattijs Korpershoek
Hi, On Thu, 30 Jan 2025 17:35:38 +0100, Patrice Chotard wrote: > This series is : > _ restoring USB on STiH410-B2260 which hasn't been >tested since a while. > _ migrating STi DWC3 glue from proprietary driver to >dwc3-generic driver. > _ adding UMS support for STiH410-B2260. > > [...]

Re: [PATCH v4] usb: gadget: g_dnl: Fix NULLPTR dereference when serial# is unset

2025-01-29 Thread Mattijs Korpershoek
larifies things a bit, and thank you for contributing! Mattijs > > > On Tue, Jan 28, 2025 at 3:40 AM Mattijs Korpershoek > wrote: >> >> Hi Michael, >> >> Thank you for the patch. >> >> On lun., janv. 27, 2025 at 21:09, Michael Ferolito >&g

Re: [PATCH] Fix fastboot handling of partitions when no slots are supported

2025-01-30 Thread Mattijs Korpershoek
Hi Federico, Thank you for the patch. On mar., janv. 28, 2025 at 12:18, Federico Fuga via B4 Relay wrote: > From: Federico Fuga > > The fastboot module has a bug that prevents some command to work > properly on devices that haven't an Android-like partition scheme, that > is, just one spl and

Re: [PATCH 1/4] boot: android: fix extra command line support

2024-12-15 Thread Mattijs Korpershoek
("android: boot: support extra command line") > Signed-off-by: Nicolas Belin Reviewed-by: Mattijs Korpershoek > --- > boot/image-android.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/boot/image-android.c b/boot/image-android.c > ind

Re: [PATCH 2/4] boot: android: free newbootargs when done

2024-12-16 Thread Mattijs Korpershoek
Hi Nicolas, Thank you for the patch. On mer., déc. 11, 2024 at 14:53, Nicolas Belin wrote: > Free newbootargs when the concatenation is done and bootargs env > is set. > > Fixes: 86f4695b ("image: Fix Android boot image support") > Signed-off-by: Nicolas Bel

Re: [PATCH 3/4] boot: android: rework bootargs concatenation

2024-12-16 Thread Mattijs Korpershoek
Hi Nicolas, Thank you for the patch. On mer., déc. 11, 2024 at 14:53, Nicolas Belin wrote: > Rework the bootargs concatenation allocating more accurately > the length that is needed. > Do not forget an extra byte for the null termination byte as, > in some cases, the allocation was 1 byte short

Re: [PATCH 4/4] boot: android: reorder the length calculation order

2024-12-16 Thread Mattijs Korpershoek
Hi Nicolas, Thank you for the patch. On mer., déc. 11, 2024 at 14:53, Nicolas Belin wrote: > Keep the same order (bootargs then kcmdline then kcmdline_extra) > for both the length calculation and the string concatenation steps. > > Signed-off-by: Nicolas Belin Reviewed

Re: [PATCH v2 5/5] doc: board: document support for USB DFU boot on AM62Px SoC

2024-12-18 Thread Mattijs Korpershoek
ool. > > Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek > --- > This patch has been newly introduced in this series based on the > discussion at: > https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-3-s-vadapa...@ti.com/#3432702 > >

Re: [PATCH v2 1/5] board: ti: am62px: env: include environment for DFU Boot

2024-12-18 Thread Mattijs Korpershoek
f the file. > > Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek > --- > v1: > https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-3-s-vadapa...@ti.com/ > Changes since v1: > - Updated commit message indicating that a newline is also being a

Re: [PATCH v2 0/3] boot: android: rework the bootargs concatenation

2024-12-18 Thread Mattijs Korpershoek
Hi, On Tue, 17 Dec 2024 14:29:07 +0100, Nicolas Belin wrote: > Rework the bootargs concatenation logic to make the logic clearer > and address several issues such as: > - checking the value at the address kcmdline_extra instead of > checking the address value itself > - freeing the string that was

Re: [PATCH 2/4] board: ti: am62px: env: include environment for DFU Boot

2024-12-18 Thread Mattijs Korpershoek
On mer., déc. 18, 2024 at 15:44, Siddharth Vadapalli wrote: > On Wed, Dec 18, 2024 at 10:57:36AM +0100, Mattijs Korpershoek wrote: > > Hello Mattijs, > >> Hi Siddharth, >> >> Thank you for the patch. >> >> On mar., déc. 17, 2024 at 18:46, Siddharth Vad

Re: [PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support

2024-12-18 Thread Mattijs Korpershoek
3_defconfig" in order to enable support for USB DFU > flash and boot. Remove those configs from "am62px_evm_a53_defconfig" which > are present in the "am62x_a53_usbdfu.config" config fragment that is being > included. > > Signed-off-by: Siddharth Vadapalli

Re: [PATCH v2 0/5] Add support for USB DFU boot on AM62Px

2024-12-18 Thread Mattijs Korpershoek
ies since its equivalent has been > posted by Jonathan Humphreys at: > > https://patchwork.ozlabs.org/project/uboot/patch/20241217204835.3312765-1-j-humphr...@ti.com/ > - Based on the feedback from Mattijs Korpershoek on the second patch of > the v1 series, the patches in

Re: [PATCH 0/4] Add support for USB DFU boot on AM62Px

2024-12-18 Thread Mattijs Korpershoek
clude environment for DFU Boot > configs: am62x_r5_usbdfu: extend for AM62Px > arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot Boot tested this on AM62Px SK EVM using snagrecover: Boot logs are here: https://paste.debian.net/1340377/ Tested-by: Mattijs Korpershoek > >

Re: [PATCH v2 3/3] boot: android: rework bootargs concatenation

2024-12-18 Thread Mattijs Korpershoek
n was 1 byte short. > > Fixes: 86f4695b ("image: Fix Android boot image support") > Signed-off-by: Nicolas Belin Reviewed-by: Mattijs Korpershoek > --- > boot/image-android.c | 29 - > 1 file changed, 16 insertions(+), 13 deletions(-) >

Re: [PATCH 3/4] configs: am62x_r5_usbdfu: extend for AM62Px

2024-12-18 Thread Mattijs Korpershoek
is is needed, without this, the tispl size is too big and we can't build. Reviewed-by: Mattijs Korpershoek > --- > configs/am62x_r5_usbdfu.config | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configs/am62x_r5_usbdfu.config b/configs/am62x_r5_usbdfu.config > in

Re: [PATCH 4/4] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-18 Thread Mattijs Korpershoek
FU boot. > > Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/k3-am62p5-sk-u-boot.dtsi | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi > b/arch/arm/dts/k3-am62p5-sk-u

Re: [PATCH 2/4] board: ti: am62px: env: include environment for DFU Boot

2024-12-18 Thread Mattijs Korpershoek
Hi Siddharth, Thank you for the patch. On mar., déc. 17, 2024 at 18:46, Siddharth Vadapalli wrote: > Include the TI K3 DFU environment to support DFU Boot and DFU Flash. > Also add "usb" to the list of "boot_targets". > > Signed-off-by: Siddharth Vadapalli > --- > board/ti/am62px/am62px.env |

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2024-12-18 Thread Mattijs Korpershoek
Hi Jonathan, Thank you for the patch. On mar., déc. 17, 2024 at 14:48, Jonathan Humphreys wrote: > If CONFIG_SET_DFU_ALT_INFO is enabled, the dfu_alt_info environment > variable is dynamically set when initializing the DFU entities, which is > done as part of normal flow of a DFU operation. > >

Re: [PATCH v2 1/2] cmd: Add support for optee hello world ta command

2024-12-13 Thread Mattijs Korpershoek
Hi Venkatesh, Thank you for the patch. On ven., déc. 13, 2024 at 16:30, Venkatesh Yadav Abbarapu wrote: > Enable "optee hello" command which increments the value passed. > This provides easy test for establishing a session with OP-TEE > TA and verify. > > It includes following subcommands: > o

[GIT PULL] Please pull u-boot-dfu-20241219

2024-12-19 Thread Mattijs Korpershoek
Hi Tom, Please find some fixes for master: Android: - Fix kcmdline_extra support when parsing boot image - Fix memory leak when after bootargs concatenation - Fix length calculation when merging bootargs, cmdline and kcmdline CI Job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipeli

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-21 Thread Mattijs Korpershoek
On jeu., nov. 21, 2024 at 12:11, "Mattijs Korpershoek via groups.io" wrote: > Hi, > > On jeu., nov. 21, 2024 at 10:40, Mattijs Korpershoek > wrote: > >> Hi Guillaume, >> >> On mer., nov. 20, 2024 at 18:54, Guillaume LA ROQUE >> wrote: >

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-21 Thread Mattijs Korpershoek
Hi, On jeu., nov. 21, 2024 at 10:40, Mattijs Korpershoek wrote: > Hi Guillaume, > > On mer., nov. 20, 2024 at 18:54, Guillaume LA ROQUE > wrote: > >> Hi, >> >> unfortunately i don't find for now how i can fix issue in test. >> >>

[PATCH] test: boot: Bind bootmeth_{cros,android} only once per run

2024-11-21 Thread Mattijs Korpershoek
a "cros" or "android" driver and only bind it if it does not exist. Fixes: fbdac8155c89 ("test: Expand implementation of ut_list_has_dm_tests()") Signed-off-by: Mattijs Korpershoek --- Initially, this was found when merging some Android bootflow patches from [1]. How

Re: [PATCH v3 0/5] Add support of Android Boot Image version 2 and non-AB image

2024-11-21 Thread Mattijs Korpershoek
On jeu., nov. 21, 2024 at 15:38, Mattijs Korpershoek wrote: > On jeu., nov. 21, 2024 at 12:11, "Mattijs Korpershoek via groups.io" > wrote: > >> Hi, >> >> On jeu., nov. 21, 2024 at 10:40, Mattijs Korpershoek >> wrote: >> >>> Hi Gui

Re: [PATCH v1 1/1] usb: ci_udc: don't use "advance" feature when setting address

2024-11-21 Thread Mattijs Korpershoek
Hi, On jeu., nov. 21, 2024 at 13:15, Svyatoslav Ryhel wrote: [...] >> > If no other comments were proposed, may this patch be applied? >> >> Ah, sorry, i've been waiting for a v2 patch that includes a link to the >> related kernel commit as asked in [1]. >> >> Do you want me to fixup the commit

Re: [PATCH v1 1/1] usb: ci_udc: don't use "advance" feature when setting address

2024-11-21 Thread Mattijs Korpershoek
Hello, On mer., nov. 20, 2024 at 08:45, Svyatoslav Ryhel wrote: > нд, 27 жовт. 2024 р. о 18:42 Svyatoslav Ryhel пише: >> >> нд, 27 жовт. 2024 р. о 18:09 Marek Vasut пише: >> > >> > On 10/13/24 4:58 PM, Svyatoslav Ryhel wrote: >> > >> > Sorry for the late reply. >> > >> > > +++ b/drivers/usb/ga

[PATCH v2] test: boot: Set DM|SCAN_FDT flags for bootmeth_{cros,android}

2024-11-22 Thread Mattijs Korpershoek
gs to both tests to make sure that the bootmeths are unbound after the test finishes. Fixes: fbdac8155c89 ("test: Expand implementation of ut_list_has_dm_tests()") Signed-off-by: Mattijs Korpershoek --- Initially, this was found when merging some Android bootflow patches from [1]. Howev

Re: [PATCH] test: boot: Bind bootmeth_{cros, android} only once per run

2024-11-22 Thread Mattijs Korpershoek
Hi Simon, On ven., nov. 22, 2024 at 06:37, Simon Glass wrote: > Hi Mattijs, > > On Thu, 21 Nov 2024 at 08:03, Mattijs Korpershoek > wrote: >> >> We make fewer calls to dm_test_restore() since >> commit fbdac8155c89 ("test: Expand implementation of ut_list_has

[PATCH 1/2] bootstd: android: Add missing NULL in the avb partition list

2025-01-08 Thread Mattijs Korpershoek
e NULL instead. Add NULL as last element to requested_partitions to avoid this problem. Fixes: 125d9f3306ea ("bootstd: Add a bootmeth for Android") Signed-off-by: Mattijs Korpershoek --- boot/bootmeth_android.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 2/2] bootstd: android: Allow boot with AVB failures when unlocked

2025-01-08 Thread Mattijs Korpershoek
: Add a bootmeth for Android") Signed-off-by: Mattijs Korpershoek --- boot/bootmeth_android.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/boot/bootmeth_android.c b/boot/bootmeth_android.c index 2cd167f80280801618a317a65e93a1

[PATCH 0/2] bootstd: android: Allow booting with AVB failures when unlocked

2025-01-08 Thread Mattijs Korpershoek
urity/features/verifiedboot/boot-flow#unlocked-devices [3] https://software-dl.ti.com/processor-sdk-android/esd/AM62PX/10_01_00/docs/devices/AM62PX/android/Release_Specific_Release_Notes.html Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (2): bootstd: android: Add missing NULL i

Re: [PATCH 2/2] bootstd: android: Allow boot with AVB failures when unlocked

2025-01-08 Thread Mattijs Korpershoek
Hi, Please ignore this patch, I've send this a bit too fast and did not test all the cases. Sorry for the noise. Mattijs On mer., janv. 08, 2025 at 14:43, Mattijs Korpershoek wrote: > When the bootloader is UNLOCKED, it should be possible to boot Android > even if AVB reports v

[PATCH v2 0/2] bootstd: android: Allow booting with AVB failures when unlocked

2025-01-08 Thread Mattijs Korpershoek
urity/features/verifiedboot/boot-flow#unlocked-devices [3] https://software-dl.ti.com/processor-sdk-android/esd/AM62PX/10_01_00/docs/devices/AM62PX/android/Release_Specific_Release_Notes.html Signed-off-by: Mattijs Korpershoek --- Changes in v2: - Re-did patch 2/2 a bit: fixed booting withou

[PATCH v2 1/2] bootstd: android: Add missing NULL in the avb partition list

2025-01-08 Thread Mattijs Korpershoek
e NULL instead. Add NULL as last element to requested_partitions to avoid this problem. Fixes: 125d9f3306ea ("bootstd: Add a bootmeth for Android") Signed-off-by: Mattijs Korpershoek --- boot/bootmeth_android.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v2 2/2] bootstd: android: Allow boot with AVB failures when unlocked

2025-01-08 Thread Mattijs Korpershoek
: Add a bootmeth for Android") Signed-off-by: Mattijs Korpershoek --- boot/bootmeth_android.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/boot/bootmeth_android.c b/boot/bootmeth_android.c index 2cd167f80280801618a317a65e93a1

Re: [PATCH v2 0/2] bootstd: android: Allow booting with AVB failures when unlocked

2025-01-23 Thread Mattijs Korpershoek
Hi, On Wed, 08 Jan 2025 15:38:40 +0100, Mattijs Korpershoek wrote: > Android Verified Boot (AVB) [1] protects Android systems by providing a > root of trust in the vbmeta partition. > > On unlocked devices, system developers might want to disable the root > of trust to re

Re: [PATCH] boot: android: Check kcmdline's for NULL in android_image_get_kernel()

2025-01-23 Thread Mattijs Korpershoek
Hi, On Mon, 13 Jan 2025 10:11:45 +0100, Mattijs Korpershoek wrote: > kcmdline and kcmdline_extra strings can be NULL. In that case, we still > read the content from 0x0 and pass that to the kernel, which is > completely wrong. > > Fix android_image_get_kernel() to check

Re: [PATCH] MAINTAINERS: move myself to reviewers for avb/ab

2025-01-23 Thread Mattijs Korpershoek
Hi, On Thu, 09 Jan 2025 12:28:22 +0100, Igor Opaniuk wrote: > As Mattijs Korpershoek is in fact doing overall > maintenance of AVB/AB code, move myself to reviewers. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu) [1/1] MAINTAINERS: mo

[GIT PULL] Please pull u-boot-dfu-20250124

2025-01-24 Thread Mattijs Korpershoek
--disable-verity vbmeta vbmeta.img Aaron Kling (1): boot: android: Check kcmdline's for NULL in android_image_get_kernel() Igor Opaniuk (1): MAINTAINERS: move myself to reviewers for avb/ab Mattijs Korpershoek (2)

Re: [PATCH] boot: android: handle boot images with missing DTB

2025-01-28 Thread Mattijs Korpershoek
o > check the header of a nonexistent DTB. > > Fixes: 607b07554e2 ("android: boot: move to andr_image_data structure") > Signed-off-by: Sam Day Reviewed-by: Mattijs Korpershoek > --- > boot/image-android.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(

Re: [PATCH][V2] Fix fastboot handling of partitions when no slots are supported

2025-01-28 Thread Mattijs Korpershoek
Hi Federico, Thank you for the patch. This patch has incorrect recipients. This has only been send to the U-Boot. However, when running: $ ./scripts/get_maintainer.pl -f drivers/fastboot Mattijs Korpershoek (maintainer:FASTBOOT,commit_signer:7/10=70%) Tom Rini (maintainer:THE REST,authored

Re: [PATCH] Fix fastboot handling of partitions when no slots are, supported

2025-01-28 Thread Mattijs Korpershoek
([PATCH] Fix fastboot handling of partitions when no slots are, supported) Analyzing 0 code-review messages Will use the latest revision: v2 You can pick other revisions using the -vN flag Checking attestation on all messages, may take a moment... --- [PATCH] Fix fastboot handling of partitions

Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Mattijs Korpershoek
Hi Heiko, On mar., janv. 28, 2025 at 10:17, Heiko Schocher wrote: > Hello Mattijs, > > On 28.01.25 10:11, Mattijs Korpershoek wrote: >> Hi Michael, >> >> Thank you for the patch. >> >> On mar., janv. 28, 2025 at 02:49, Marek Vasut wrote: >> &

Re: [PATCH v4] usb: gadget: g_dnl: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Mattijs Korpershoek
c: Heiko Schocher > Cc: Kyungmin Park Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/g_dnl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c > index 631969b340..f2540eb6de 100

Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Mattijs Korpershoek
>> >> Signed-off-by: Michael Ferolito >> Cc: Marek Vasut >> Cc: Heiko Schocher >> Cc: Kyungmin Park > The subject tag is "usb: gadget: g_dnl:" instead of "USB:" , with that > fixed: > > Reviewed-by: Marek Vasut Agreed with Marek

Re: [PATCH] usb: dwc2: Refactor register operations with clrsetbits macros

2025-01-28 Thread Mattijs Korpershoek
adability. > > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > This patch is a supplement of patch series [1]. > > [1] > https://lore.kernel.org/u-boot/20250110-dwc2-dev-v4-0-987f4fd6f...@pigmoral.tech > --- > drivers/usb/gadget/dwc2_udc_otg.c

<    3   4   5   6   7   8   9   10   >