Hi Siddharth, Thank you for the series.
On mar., déc. 17, 2024 at 18:46, Siddharth Vadapalli <s-vadapa...@ti.com> wrote: > Hello, > > This series add support for USB DFU boot on TI's AM62Px SoC which has > two instances of USB Controllers, of which the USB0 instance of USB > which is a DWC3 USB Controller is used for USB DFU Boot: > ROM => tiboot3.bin => tispl.bin => u-boot.img > > The first patch of this series is based on the suggestion of > Jonathan Humphreys <j-humpr...@ti.com> > at: > https://patchwork.ozlabs.org/project/uboot/cover/20241124070828.617558-1-s-vadapa...@ti.com/#3419733 > which prevents overwriting the "dfu_alt_info" environment variable which > is set by "spl_dfu_cmd()" for USB DFU boot. > > The second patch adds USB DFU environment for AM62Px. > > The third patch extends "am62x_r5_usbdfu.config" config fragment for > being re-used by AM62Px SoC by dropping configs which aren't required > for USB DFU boot. This is necessary to reduce the size of R5 SPL > (tiboot3.bin) built for USB DFU boot. > > The fourth patch enables USB device-tree nodes for USB DFU functionality > on AM62Px. Since CONFIG_OF_UPSTREAM is not yet supported for AM62Px, the > changes are being made in arch/arm/dts/k3-am62p5-sk-u-boot.dtsi at the > moment, with the intent of making the same changes in the Linux > device-tree and eventually enabling CONFIG_OF_UPSTREAM to drop the > changes made in "k3-am62p5-sk-u-boot.dtsi". > > Series is based on commit > 3b3c7280b82 smbios: address build warning > of the next branch of U-Boot. > > The USB DFU config fragments for AM62x are to be re-used for enabling > USB DFU boot on AM62Px as follows: > R5 => am62px_evm_r5_defconfig + am62x_r5_usbdfu.config > A53 => am62px_evm_a53_defconfig + am62x_a53_usbdfu.config > > Series has been tested on AM62P5-SK. Logs validating USB DFU boot on > AM62P5-SK with this series: > https://gist.github.com/Siddharth-Vadapalli-at-TI/50198ee3348c2db73e0dbd3a14cb0f8b > > Series has also been validated on AM625-SK to ensure that the changes > made to "am62x_r5_usbdfu.config" config fragment being used by AM625-SK > for USB DFU boot do not cause a regression on AM625-SK w.r.t. USB DFU > boot. Logs validating USB DFU Boot on AM625-SK with this series: > https://gist.github.com/Siddharth-Vadapalli-at-TI/85a7579ed2c95330ac71ee3a832cadfb > > Regards, > Siddharth. > > Jonathan Humphreys (1): > dfu: do not overwrite "dfu_alt_info" > > Siddharth Vadapalli (3): > board: ti: am62px: env: include environment for DFU Boot > configs: am62x_r5_usbdfu: extend for AM62Px > arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot Boot tested this on AM62Px SK EVM using snagrecover: Boot logs are here: https://paste.debian.net/1340377/ Tested-by: Mattijs Korpershoek <mkorpersh...@baylibre.com> > > arch/arm/dts/k3-am62p5-sk-u-boot.dtsi | 10 ++++++++++ > board/ti/am62px/am62px.env | 5 +++-- > configs/am62x_r5_usbdfu.config | 3 +++ > drivers/dfu/dfu.c | 7 +++++-- > 4 files changed, 21 insertions(+), 4 deletions(-) > > -- > 2.43.0
