Re: [PATCH v5 20/23] doc: board: ti: Update documentation for binman flow

2023-07-07 Thread Jerome Forissier
On 7/7/23 14:34, Neha Malcom Francis wrote: > Earlier documentation specified builds for generating bootloader images > using an external TI repository k3-image-gen and core-secdev-k3. Modify > this to using the binman flow so that user understands how to build the > final boot images. > > Sign

Re: [PATCH v7 00/23] Migration to using binman for bootloader

2023-07-14 Thread Jerome Forissier
On 7/14/23 15:50, Neha Malcom Francis wrote: > This series aims to eliminate the use of additional custom repositories > such as k3-image-gen (K3 Image Generation) repo and core-secdev-k3 (K3 > Security Development Tools) that was plumbed into the U-Boot build flow > to generate boot images for

Re: [PATCH v1 4/5] rockchip: evb_rk3229: Update/fix README

2023-07-17 Thread Jerome Forissier
On 7/16/23 10:10, Alex Bee wrote: > This updates the evb_rk3229's README on howto create / use the FIT image > created by binman. > Also fix some wrong paths and update filenames which have changed in recent > upstream optee-os versions. > > Signed-off-by: Alex Bee > --- > board/rockchip/evb_

Re: [PATCH] mmc: dwmmc: only clear handled interrupts

2022-09-16 Thread Jerome Forissier
K_RXDR | > + DWMCI_INTMSK_DTO)); > while (size) { > ret = dwmci_fifo_ready(host, > DWMCI_FIFO_EMPTY, Tested-by: Jerome Forissier (Rock PI 4B) Boot logs: -

Re: [PATCH v4 10/16] arm: dts: Introduce j784s4 u-boot dts files

2023-10-02 Thread Jerome Forissier
Hello Apurva, On 10/1/23 18:55, Apurva Nandan wrote: > Introduce the base dts files needed for u-boot or to augment the linux > dtbs for use in the u-boot-spl and u-boot binaries. > > Signed-off-by: Hari Nagalla > [ add binman and ddr dtsi files ] > Signed-off-by: Neha Malcom Francis > Signed-o

Re: [PATCH v7 06/12] binman: Support new op-tee binary format

2022-12-21 Thread Jerome Forissier
Hi Simon, On 12/17/22 22:28, Simon Glass wrote: > OP-TEE has a format with a binary header that can be used instead of the > ELF file. With newer versions of OP-TEE this may be required on some > platforms. > > Add support for this in binman. First, add a method to obtain the ELF > sections from

Re: [PATCH v7 06/12] binman: Support new op-tee binary format

2022-12-22 Thread Jerome Forissier
On 12/22/22 00:38, Simon Glass wrote: > Hi Jerome, > > On Wed, 21 Dec 2022 at 07:39, Jerome Forissier > wrote: >> >> Hi Simon, >> >> On 12/17/22 22:28, Simon Glass wrote: >>> OP-TEE has a format with a binary header that can be used instead of th

Re: [PATCH v8 06/13] binman: Support new op-tee binary format

2022-12-22 Thread Jerome Forissier
On 12/22/22 00:07, Simon Glass wrote: > OP-TEE has a format with a binary header that can be used instead of the > ELF file. With newer versions of OP-TEE this may be required on some > platforms. > > Add support for this in binman. First, add a method to obtain the ELF > sections from an entry

Re: [PATCH v8 06/13] binman: Support new op-tee binary format

2022-12-22 Thread Jerome Forissier
On 12/22/22 21:23, Simon Glass wrote: > (dropping the two bounces from cc) > > On Thu, 22 Dec 2022 at 13:18, Simon Glass wrote: >> >> Hi Jerome, >> >> On Thu, 22 Dec 2022 at 08:36, Jerome Forissier >> wrote: >>> >>> >>> >&

Re: [PATCH v8 06/13] binman: Support new op-tee binary format

2023-01-07 Thread Jerome Forissier
On 1/7/23 19:55, Simon Glass wrote: > Hi Quentin, > > On Mon, 2 Jan 2023 at 10:54, Quentin Schulz > wrote: >> >> Hi Simon, >> >> On 12/22/22 00:07, Simon Glass wrote: >>> OP-TEE has a format with a binary header that can be used instead of the >>> ELF file. With newer versions of OP-TEE this m

Re: [PATCH v8 06/13] binman: Support new op-tee binary format

2023-01-07 Thread Jerome Forissier
On 1/7/23 19:55, Simon Glass wrote: > Hi Jerome, > > On Thu, 22 Dec 2022 at 15:20, Jerome Forissier > wrote: >> >> >> >> On 12/22/22 21:23, Simon Glass wrote: >>> (dropping the two bounces from cc) >>> >>> On Thu, 22 Dec 2022 at 1

Re: [PATCH v2 12/14] test/py: net: add _lwip variants of dhcp, ping and tftpboot tests

2024-05-30 Thread Jerome Forissier
On 5/28/24 11:53, Maxim Uvarov wrote: > пт, 24 мая 2024 г. в 19:22, Jerome Forissier : >> >> WHen NET_LWIP is enabled, the dhcp/ping/tftpboot commands are enabled >> via CMD_DHCP_LWIP, CMD_PING_LWIP and CMD_TFTPBOOT_LWIP, respectively; >> therefore the config ann

Re: [PATCH v2 01/14] net: introduce alternative implementation as net-lwip/

2024-06-05 Thread Jerome Forissier
On 5/27/24 17:34, Tom Rini wrote: > On Fri, May 24, 2024 at 06:19:55PM +0200, Jerome Forissier wrote: > >> Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by >> adding a new net-lwip/ directory and the NET_LWIP symbol. At this >> point, enabling NET_

Re: [PATCH v2 00/14] Introduce the lwIP network stack

2024-06-06 Thread Jerome Forissier
On 5/27/24 17:34, Tom Rini wrote: > On Fri, May 24, 2024 at 06:19:54PM +0200, Jerome Forissier wrote: > >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP >&g

Re: [PATCH v2 12/14] test/py: net: add _lwip variants of dhcp, ping and tftpboot tests

2024-06-06 Thread Jerome Forissier
On 5/30/24 16:22, Maxim Uvarov wrote: > чт, 30 мая 2024 г. в 17:11, Jerome Forissier : >> >> >> >> On 5/28/24 11:53, Maxim Uvarov wrote: >>> пт, 24 мая 2024 г. в 19:22, Jerome Forissier : >>>> >>>> WHen NET_LWIP is enabled, the dh

Re: [PATCH v2 08/14] net-lwip: add wget command

2024-06-06 Thread Jerome Forissier
On 5/28/24 15:39, Maxim Uvarov wrote: > пт, 24 мая 2024 г. в 19:22, Jerome Forissier : >> >> Add support for the wget command with NET_LWIP. >> >> About the small change in cmd/efidebug.c: when the wget command based >> on the lwIP stack is used the wget command

Re: [PATCH v2 06/14] net-lwip: add ping command

2024-06-06 Thread Jerome Forissier
On 6/6/24 11:10, Ilias Apalodimas wrote: >> +#include >> +#include >> + >> +#define PING_DELAY_MS 1000 >> +#define PING_TIMEOUT_MS 1 >> +/* Additional data size to include in the packet */ >> +#define PING_DATA_SIZE 32 >> +/* Ping identifier - must fit on a u16_t */ >> +#define PING_ID 0xA

Re: [PATCH v2 08/14] net-lwip: add wget command

2024-06-06 Thread Jerome Forissier
On 6/6/24 12:16, Maxim Uvarov wrote: > чт, 6 июн. 2024 г. в 12:56, Jerome Forissier : [...] >>>> diff --git a/net-lwip/wget.c b/net-lwip/wget.c >>>> new file mode 100644 >>>> index 000..25b75040806 >>>> --- /dev/null >>>

Re: [PATCH v2 07/14] net-lwip: add dns command

2024-06-06 Thread Jerome Forissier
On 6/6/24 08:29, Ilias Apalodimas wrote: > Hi Jerome, > > [...] > >> + >> +static ulong start; >> +static ip_addr_t host_ipaddr; >> +static bool done; >> + >> +static void do_dns_tmr(void *arg) >> +{ >> + dns_tmr(); >> +} >> + >> +static void dns_cb(const char *name, const ip_addr_t *ipadd

[PATCH v3 00/12] Introduce the lwIP network stack

2024-06-06 Thread Jerome Forissier
understand what is needed for v3. ** Miscellaneous improvements - "net: introduce alternative implementation as net-lwip/": * Make DFU_OVER_TFTP not DFU_TFTP incompatible with NET_LWIP. It seems quite natural to supplement "depends on NET" with "&& !NET_LWIP"

[PATCH v3 02/12] net-lwip: build lwIP

2024-06-06 Thread Jerome Forissier
previous RFC patch series. Signed-off-by: Jerome Forissier Co-developed-by: Maxim Uvarov Cc: Maxim Uvarov --- lib/Makefile| 2 + lib/lwip/Makefile | 57 + lib/lwip/u-boot/arch/cc.h | 43 +++ lib/lwip/u-boot/arch/sys_arch.h | 0 lib/lwip

[PATCH v3 04/12] net-lwip: add TFTP support and tftpboot command

2024-06-06 Thread Jerome Forissier
Implement do_tftpb(). Signed-off-by: Jerome Forissier --- cmd/Kconfig | 3 +- cmd/net-lwip.c | 8 ++ net-lwip/dhcp.c | 11 ++- net-lwip/tftp.c | 202 +++- 4 files changed, 219 insertions(+), 5 deletions(-) diff --git a/cmd/Kconfig b/cmd

[PATCH v3 05/12] net-lwip: add ping command

2024-06-06 Thread Jerome Forissier
Add support for the the ping command with NET_LWIP. The implementation is derived from lwIP's contrib/apps/ping/ping.c. Signed-off-by: Jerome Forissier --- boot/Kconfig | 2 +- cmd/Kconfig| 6 ++ cmd/net-lwip.c | 8 +++ include/net-lwip.h | 3 + net-lwip/Mak

[PATCH v3 06/12] net-lwip: add dns command

2024-06-06 Thread Jerome Forissier
Add CMD_DNS when NET_LWIP is enabled to provide the dns command using lwIP. Signed-off-by: Jerome Forissier --- cmd/Kconfig| 6 +++ cmd/net-lwip.c | 8 include/net-lwip.h | 1 + net-lwip/Makefile | 1 + net-lwip/dns.c | 107

[PATCH v3 07/12] net-lwip: add wget command

2024-06-06 Thread Jerome Forissier
exist. So, guard the call in efidebug.c with CONFIG_CMD_WGET. Based on code initially developed by Maxim U. Signed-off-by: Jerome Forissier Co-developed-by: Maxim Uvarov Cc: Maxim Uvarov --- cmd/Kconfig| 7 ++ cmd/Makefile | 5 +- cmd/efidebug.c | 8 +- cmd/net-com

[PATCH v3 08/12] test: dm: dsa, eth: disable tests when CONFIG_NET_LWIP=y

2024-06-06 Thread Jerome Forissier
CONFIG_NET_LWIP is enabled. Signed-off-by: Jerome Forissier --- test/dm/dsa.c | 2 ++ test/dm/eth.c | 4 2 files changed, 6 insertions(+) diff --git a/test/dm/dsa.c b/test/dm/dsa.c index c857106eaf4..147e2a4afe2 100644 --- a/test/dm/dsa.c +++ b/test/dm/dsa.c @@ -59,6 +59,7 @@ static int

[PATCH v3 09/12] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y

2024-06-06 Thread Jerome Forissier
Support "bdinfo -e" when lwIP is selected. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas Reviewed-by: Tom Rini --- cmd/bdinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 79106caeec2..690fb894bf6 100644

[PATCH v3 10/12] configs: add qemu_arm64_lwip_defconfig

2024-06-06 Thread Jerome Forissier
Add qemu_arm64_lwip_defconfig based on qemu_arm64_defconfig but with NET_LWIP instead of NET. Signed-off-by: Jerome Forissier --- configs/qemu_arm64_lwip_defconfig | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 configs/qemu_arm64_lwip_defconfig diff --git a/configs

[PATCH v3 11/12] MAINTAINERS: net-lwip: add myself as a maintainer

2024-06-06 Thread Jerome Forissier
: Jerome Forissier Reviewed-by: Ilias Apalodimas --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f8afd7d51e2..11105869304 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1310,6 +1310,17 @@ F: drivers/net/ F: include/net.h F

[PATCH v3 12/12] CI: add qemu_arm64_lwip to the test matrix

2024-06-06 Thread Jerome Forissier
Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight IP (lwIP) implementation of the dhcp, tftpboot and ping commands. Signed-off-by: Jerome Forissier --- .azure-pipelines.yml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/.azure-pipelines.yml b/.azure

Re: [PATCH v3 06/12] net-lwip: add dns command

2024-06-06 Thread Jerome Forissier
On 6/6/24 17:46, Ilias Apalodimas wrote: >> @@ -7,6 +7,7 @@ obj-$(CONFIG_$(SPL_)DM_ETH) += ../net/eth_common.o >> obj-$(CONFIG_$(SPL_)DM_ETH) += ../net/eth-uclass.o >> obj-$(CONFIG_$(SPL_)DM_ETH) += net-lwip.o >> obj-$(CONFIG_CMD_DHCP) += dhcp.o >> +obj-$(CONFIG_CMD_DNS) += dns.o >> obj-$(CO

Re: [PATCH v3 06/12] net-lwip: add dns command

2024-06-06 Thread Jerome Forissier
On 6/6/24 18:02, Ilias Apalodimas wrote: > [...] > + + if (!ipaddr) { + printf("DNS: host not found\n"); + host_ipaddr.addr = 0; + return; + } + + if (var) + env_set(var, ipstr

[PATCH v3 01/12] net: introduce alternative implementation as net-lwip/

2024-06-06 Thread Jerome Forissier
NET_LWIP because it depends on net_loop(), tftp_timeout_ms, tftp_timeout_count_max. Let's add a dependency of DFU_OVER_TFTP on !NET_LWIP for now. Signed-off-by: Jerome Forissier --- Kconfig| 40 ++ Makefile | 2 +- c

[PATCH v3 03/12] net-lwip: add DHCP support and dhcp commmand

2024-06-06 Thread Jerome Forissier
when NET_LWIP is enabled. Declarations from the latter will be transferred to the former as needed when new network commands are ported on top of lwIP. - CMD_TFTPBOOT is selected by BOOTMETH_EFI due to this code having an implicit dependency on do_tftpb(). Signed-off-by: Jerome Forissier

Re: [PATCH v3 05/12] net-lwip: add ping command

2024-06-07 Thread Jerome Forissier
On 6/6/24 19:45, Ilias Apalodimas wrote: > On Thu, 6 Jun 2024 at 20:02, Ilias Apalodimas > wrote: >> >> On Thu, 6 Jun 2024 at 19:53, Ilias Apalodimas >> wrote: >>> >>> [...] >>> +static int ping_raw_init(void *recv_arg) +{ + ping_pcb = raw_new(IP_PROTO_ICMP); +

Re: [PATCH v3 00/12] Introduce the lwIP network stack

2024-06-07 Thread Jerome Forissier
On 6/6/24 18:56, Tom Rini wrote: > On Thu, Jun 06, 2024 at 03:35:55PM +0200, Jerome Forissier wrote: > >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP >&g

Re: [PATCH v3 07/12] net-lwip: add wget command

2024-06-07 Thread Jerome Forissier
On 6/6/24 17:41, Ilias Apalodimas wrote: > Hi Jerome, > > Can we split this in 2 patches instead? > A preparatory one, with split the net-common etc and one that adds wget? Sure, done in v4. > Thanks > /Ilias > > On Thu, 6 Jun 2024 at 16:37, Jerome Forissier > w

[PATCH v4 00/14] Introduce the lwIP network stack

2024-06-17 Thread Jerome Forissier
ce alternative implementation as net-lwip/": * Make DFU_OVER_TFTP not DFU_TFTP incompatible with NET_LWIP. It seems quite natural to supplement "depends on NET" with "&& !NET_LWIP". * Make PROT_*_LWIP not visible by removing the Kconfig prompt. [1] https://lore.kernel.org/all

[PATCH v4 01/14] flash: prefix error codes with FL_

2024-06-17 Thread Jerome Forissier
Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes with third-party libraries. Case in point: including the lwIP library header file which defines err_enum_t as an enum with values being ERR_*. Signed-off-by: Jerome Forissier --- board/cobra5272/flash.c | 26

[PATCH v4 03/14] net: split include/net.h into net{, -common, -legacy, -lwip}.h

2024-06-17 Thread Jerome Forissier
Make net.h a wrapper which includes net-common.h and either net-legacy.h or net-lwip.h based on NET_LWIP. Signed-off-by: Jerome Forissier --- Makefile | 4 +- include/net-common.h | 408 +++ include/net-legacy.h | 649 + include/net

[PATCH v4 04/14] net-lwip: build lwIP

2024-06-17 Thread Jerome Forissier
previous RFC patch series. Signed-off-by: Jerome Forissier Co-developed-by: Maxim Uvarov Cc: Maxim Uvarov Acked-by: Ilias Apalodimas --- lib/Makefile| 2 + lib/lwip/Makefile | 55 + lib/lwip/u-boot/arch/cc.h | 43 +++ lib/lwip/u-boot

[PATCH v4 05/14] net-lwip: add DHCP support and dhcp commmand

2024-06-17 Thread Jerome Forissier
Add what it takes to enable NETDEVICES with NET_LWIP and enable DHCP as well as the dhcp command. CMD_TFTPBOOT is selected by BOOTMETH_EFI due to this code having an implicit dependency on do_tftpb(). Signed-off-by: Jerome Forissier --- Makefile| 6 + boot/Kconfig

[PATCH v4 06/14] net-lwip: add TFTP support and tftpboot command

2024-06-17 Thread Jerome Forissier
Implement do_tftpb(). Signed-off-by: Jerome Forissier --- cmd/Kconfig | 3 +- cmd/net-lwip.c | 8 ++ net-lwip/dhcp.c | 11 ++- net-lwip/tftp.c | 221 +++- 4 files changed, 237 insertions(+), 6 deletions(-) diff --git a/cmd/Kconfig b/cmd

[PATCH v4 07/14] net-lwip: add ping command

2024-06-17 Thread Jerome Forissier
Add support for the the ping command with NET_LWIP. The implementation is derived from lwIP's contrib/apps/ping/ping.c. Signed-off-by: Jerome Forissier --- boot/Kconfig | 2 +- cmd/Kconfig| 6 ++ cmd/net-lwip.c | 8 +++ include/net-lwip.h | 1 + net-lwip/Mak

[PATCH v4 08/14] net-lwip: add dns command

2024-06-17 Thread Jerome Forissier
Add CMD_DNS when NET_LWIP is enabled to provide the dns command using lwIP. Signed-off-by: Jerome Forissier --- cmd/Kconfig| 6 +++ cmd/net-lwip.c | 8 include/net-lwip.h | 1 + net-lwip/Makefile | 1 + net-lwip/dns.c | 117

[PATCH v4 09/14] net: split cmd/net.c into cmd/net.c and cmd/net-common.c

2024-06-17 Thread Jerome Forissier
Extract some code from cmd/net.c that will be useful in a subsequent commit to implement wget with NET_LWIP. Signed-off-by: Jerome Forissier --- cmd/Makefile | 5 ++- cmd/net-common.c | 109 cmd/net.c| 115

[PATCH v4 10/14] net-lwip: add wget command

2024-06-17 Thread Jerome Forissier
Add support for the wget command with NET_LWIP. Based on code initially developed by Maxim U. Signed-off-by: Jerome Forissier Co-developed-by: Maxim Uvarov Cc: Maxim Uvarov Signed-off-by: Jerome Forissier --- cmd/Kconfig| 7 ++ cmd/net-lwip.c | 8 ++ include/net-lwip.h | 18

[PATCH v4 11/14] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y

2024-06-17 Thread Jerome Forissier
Support "bdinfo -e" when lwIP is selected. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas Reviewed-by: Tom Rini --- cmd/bdinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 79106caeec2..690fb894bf6 100644

[PATCH v4 12/14] configs: add qemu_arm64_lwip_defconfig

2024-06-17 Thread Jerome Forissier
Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and selects NET_LWIP instead of NET. This config has all the supported net commands enabled. Signed-off-by: Jerome Forissier --- configs/qemu_arm64_lwip_defconfig | 4 1 file changed, 4 insertions(+) create mode 1

[PATCH v4 13/14] MAINTAINERS: net-lwip: add myself as a maintainer

2024-06-17 Thread Jerome Forissier
: Jerome Forissier Reviewed-by: Ilias Apalodimas --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f8afd7d51e2..11105869304 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1310,6 +1310,17 @@ F: drivers/net/ F: include/net.h F

[PATCH v4 14/14] CI: add qemu_arm64_lwip to the test matrix

2024-06-17 Thread Jerome Forissier
Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight IP (lwIP) implementation of the dhcp, tftpboot and ping commands. Signed-off-by: Jerome Forissier --- .azure-pipelines.yml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/.azure-pipelines.yml b/.azure

[PATCH v4 02/14] net: introduce alternative implementation as net-lwip/

2024-06-17 Thread Jerome Forissier
OX so that the NET_LWIP alternative is not visible in make menuconfig when sandbox_defconfig is used. Signed-off-by: Jerome Forissier --- Kconfig| 41 ++ Makefile | 2 +- common/Kconfig | 2 +- common/spl/Kc

Re: [PATCH v4 05/14] net-lwip: add DHCP support and dhcp commmand

2024-06-19 Thread Jerome Forissier
On 6/17/24 18:54, Heinrich Schuchardt wrote: > On 17.06.24 17:32, Jerome Forissier wrote: >> Add what it takes to enable NETDEVICES with NET_LWIP and enable DHCP as >> well as the dhcp command. CMD_TFTPBOOT is selected by BOOTMETH_EFI due >> to this code having an i

Re: [PATCH v4 02/14] net: introduce alternative implementation as net-lwip/

2024-06-19 Thread Jerome Forissier
On 6/18/24 19:59, Tom Rini wrote: > On Mon, Jun 17, 2024 at 05:32:54PM +0200, Jerome Forissier wrote: > >> Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by >> adding a new net-lwip/ directory and the NET_LWIP symbol. Network >> support is either N

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-19 Thread Jerome Forissier
On 6/19/24 09:24, Ilias Apalodimas wrote: > Hi Tom > > On Tue, 18 Jun 2024 at 23:21, Tom Rini wrote: >> >> On Mon, Jun 17, 2024 at 05:32:52PM +0200, Jerome Forissier wrote: >> >>> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add l

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-19 Thread Jerome Forissier
On 6/19/24 17:07, Tom Rini wrote: > On Wed, Jun 19, 2024 at 04:47:08PM +0200, Jerome Forissier wrote: >> >> >> On 6/19/24 09:24, Ilias Apalodimas wrote: >>> Hi Tom >>> >>> On Tue, 18 Jun 2024 at 23:21, Tom Rini wrote: >>>> >>&

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-20 Thread Jerome Forissier
On 6/19/24 19:19, Peter Robinson wrote: > On Wed, 19 Jun 2024 at 16:06, Jerome Forissier > wrote: >> >> >> >> On 6/19/24 09:24, Ilias Apalodimas wrote: >>> Hi Tom >>> >>> On Tue, 18 Jun 2024 at 23:21, Tom Rini wrote: >>>>

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Jerome Forissier
On 6/20/24 19:10, Tim Harvey wrote: > On Mon, Jun 17, 2024 at 8:33 AM Jerome Forissier > wrote: >> >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP >

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Jerome Forissier
Hi Simon, On 6/21/24 16:57, Simon Glass wrote: > Hi Jerome, > > On Mon, 17 Jun 2024 at 09:33, Jerome Forissier > wrote: >> >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to i

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Jerome Forissier
On 6/21/24 18:08, Tim Harvey wrote: > On Fri, Jun 21, 2024 at 5:59 AM Jerome Forissier > wrote: >> >> >> >> On 6/20/24 19:10, Tim Harvey wrote: >>> On Mon, Jun 17, 2024 at 8:33 AM Jerome Forissier >>> wrote: >>>> >>>>

Re: [PATCH v4 10/14] net-lwip: add wget command

2024-06-24 Thread Jerome Forissier
On 6/24/24 08:21, Jon Humphreys wrote: > Jerome Forissier writes: > >> Add support for the wget command with NET_LWIP. >> >> Based on code initially developed by Maxim U. >> >> Signed-off-by: Jerome Forissier >> Co-developed-by: Maxim Uvarov >

Re: [PATCH v4 10/14] net-lwip: add wget command

2024-06-24 Thread Jerome Forissier
On 6/24/24 08:25, Jon Humphreys wrote: > Subject: [PATCH] net-lwip: fixes off-by-one array access error with wget > > When wget parses the url and extracts the host, it is off by one on the > index to terminate the character array. > > Signed-off-by: Jonathan Humphreys > --- > net-lwip/wget.

Re: [PATCH v4 10/14] net-lwip: add wget command

2024-06-24 Thread Jerome Forissier
On 6/24/24 08:26, Jon Humphreys wrote: > Subject: [PATCH] net-lwip: Add message if not using http:// for wget > > U-Boot's wget only supports http://, so give the user a clue if they don't > use it. > > Signed-off-by: Jonathan Humphreys > --- > net-lwip/wget.c | 4 +++- > 1 file changed, 3 i

Re: [PATCH v4 10/14] net-lwip: add wget command

2024-06-25 Thread Jerome Forissier
On 6/25/24 05:20, Jon Humphreys wrote: > Jerome Forissier writes: > >> On 6/24/24 08:21, Jon Humphreys wrote: >>> Jerome Forissier writes: >>> >>>> Add support for the wget command with NET_LWIP. >>>> >>>> Based on code initial

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-25 Thread Jerome Forissier
On 6/25/24 00:28, Tim Harvey wrote: > On Sat, Jun 22, 2024 at 1:09 AM Maxim Uvarov wrote: >> >> пт, 21 июн. 2024 г. в 21:42, Fabio Estevam : >>> >>> Hi Tim and Jerome, >>> >>> On Fri, Jun 21, 2024 at 1:08 PM Tim Harvey wrote: >>> I tried your to-upstream/v5-wip branch (042bea36eb9731079

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-28 Thread Jerome Forissier
Hi Tim, On 6/26/24 18:00, Tim Harvey wrote: > On Tue, Jun 25, 2024 at 1:02 AM Jerome Forissier > wrote: >> >> On 6/25/24 00:28, Tim Harvey wrote: >>> On Sat, Jun 22, 2024 at 1:09 AM Maxim Uvarov wrote: >>>> >>>> пт, 21 июн. 2024 г. в 2

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-07-01 Thread Jerome Forissier
On 6/28/24 17:48, Tim Harvey wrote: > On Fri, Jun 28, 2024 at 2:50 AM Jerome Forissier > wrote: >> >> Hi Tim, >> >> On 6/26/24 18:00, Tim Harvey wrote: >>> On Tue, Jun 25, 2024 at 1:02 AM Jerome Forissier >>> wrote: >>>> >>>

Re: [PATCH v4 02/29] mbedtls: Add script to update MbedTLS subtree

2024-07-03 Thread Jerome Forissier
On 7/2/24 22:56, Tom Rini wrote: > On Tue, Jul 02, 2024 at 11:22:38AM -0700, Raymond Mao wrote: > >> lib/mbedtls/update-mbedtls-subtree.sh is a wrapper of git subtree >> commands. >> Usage from U-Boot top directory, run: >> >> $ ./lib/mbedtls/update-mbedtls-subtree.sh pull >> $ ./lib/mbedtls/u

Re: [PATCH] tools: Add script to update git subtree projects

2024-07-22 Thread Jerome Forissier
;Invalid subtree name: $subtree_name" print_usage exit 1 esac } set_params $1 > + > +merge_commit_msg=$(cat << EOF > +Subtree merge tag '$ref' of $subtree_name repo [1] into $path > + > +[1] $repo_url > +EOF > +) > + > +remote_add_and_fetch() { > +if [ -z "$(git remote get-url $remote_name 2>/dev/null)" ]; then > +echo "Warning: Script automatically adds new git remote via:" > +echo "git remote add $remote_name \\" > +echo "$repo_url" > +git remote add $remote_name $repo_url > +fi > +git fetch $remote_name master > +} > + > +if [ "$op" = "pull" ]; then > +remote_add_and_fetch > +git subtree pull --prefix $path $remote_name "$ref" --squash -m > "$merge_commit_msg" > +elif [ "$op" = "pick" ]; then > +remote_add_and_fetch > +git cherry-pick -x --strategy=subtree -Xsubtree=$path/ "$ref" > +else > +print_usage > +exit 1 > +fi Overall LGTM. FWIW: Acked-by: Jerome Forissier Thanks, -- Jerome

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-22 Thread Jerome Forissier
> 3 files changed, 90 insertions(+), 52 deletions(-) > delete mode 100755 dts/update-dts-subtree.sh > create mode 100755 tools/update-subtree.sh Acked-by: Jerome Forissier -- Jerome

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-25 Thread Jerome Forissier
On 7/25/24 07:45, Sumit Garg wrote: > On Wed, 24 Jul 2024 at 19:40, Raymond Mao wrote: >> >> Hi Sumit, >> >> On Wed, 24 Jul 2024 at 03:08, Sumit Garg wrote: >>> >>> Hi Raymond, >>> >>> Thanks for doing this. >>> >>> On Tue, 23 Jul 2024 at 01:01, Raymond Mao wrote: Recently we are in

[PATCH v5 00/20] Introduce the lwIP network stack

2024-07-25 Thread Jerome Forissier
"test: dm: dsa, eth: disable tests when CONFIG_NET_LWIP=y"). I need some more time for that and I think running CI on this v2 will help better understand what is needed for v3. ** Miscellaneous improvements - "net: introduce alternative implementation as net-lwip/": * Make DFU_OVER_TFTP

[PATCH v5 01/20] flash: prefix error codes with FL_

2024-07-25 Thread Jerome Forissier
Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes with third-party libraries. Case in point: including the lwIP library header file which defines err_enum_t as an enum with values being ERR_*. Signed-off-by: Jerome Forissier Reviewed-by: Tom Rini Reviewed-by: Ilias

[PATCH v5 04/20] net: fec_mxc_init(): do not ignore return status of fec_open()

2024-07-25 Thread Jerome Forissier
The fec_mxc_init() function currently always returns 0. This does not allow the callers to detect when for instance the PHY initialization failed due to the port being unconnected. Fix that by returning the status of fec_open(). Signed-off-by: Jerome Forissier --- drivers/net/fec_mxc.c | 3

[PATCH v5 06/20] net: eth-uclass: add function eth_start_udev()

2024-07-25 Thread Jerome Forissier
Add a function to start a given etwork device, and update eth_init() to use it. Signed-off-by: Jerome Forissier --- include/net-common.h | 1 + net/eth-uclass.c | 38 +- 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/include/net

[PATCH v5 07/20] net-lwip: build lwIP

2024-07-25 Thread Jerome Forissier
previous RFC patch series. Signed-off-by: Jerome Forissier Co-developed-by: Maxim Uvarov Cc: Maxim Uvarov Acked-by: Ilias Apalodimas --- lib/Makefile| 2 + lib/lwip/Makefile | 55 +++ lib/lwip/u-boot/arch/cc.h | 43 + lib/lwip/u-boot

[PATCH v5 05/20] net: split include/net.h into net{, -common, -legacy, -lwip}.h

2024-07-25 Thread Jerome Forissier
Make net.h a wrapper which includes net-common.h and either net-legacy.h or net-lwip.h based on NET_LWIP. Signed-off-by: Jerome Forissier --- Makefile | 4 +- include/net-common.h | 412 +++ include/net-legacy.h | 635 + include/net

[PATCH v5 09/20] net-lwip: add TFTP support and tftpboot command

2024-07-25 Thread Jerome Forissier
Implement do_tftpb(). This implementation of the tftp command supports an optional port number. For example: tftp 192.168.0.30:9069:file.bin Signed-off-by: Jerome Forissier --- cmd/Kconfig | 1 + cmd/net-lwip.c | 8 ++ net/lwip/dhcp.c | 11 +- net/lwip/tftp.c | 269

[PATCH v5 11/20] net-lwip: add dns command

2024-07-25 Thread Jerome Forissier
Add CMD_DNS when NET_LWIP is enabled to provide the dns command using lwIP. Signed-off-by: Jerome Forissier --- cmd/Kconfig| 11 ++-- cmd/net-lwip.c | 8 +++ include/net-lwip.h | 1 + net/lwip/Makefile | 1 + net/lwip/dns.c | 127

[PATCH v5 12/20] net: split cmd/net.c into cmd/net.c and cmd/net-common.c

2024-07-25 Thread Jerome Forissier
Extract some code from cmd/net.c that will be useful in a subsequent commit to implement wget with NET_LWIP. Signed-off-by: Jerome Forissier --- cmd/Makefile | 5 ++- cmd/net-common.c | 109 cmd/net.c| 115

[PATCH v5 13/20] net-lwip: add wget command

2024-07-25 Thread Jerome Forissier
Add support for the wget command with NET_LWIP. Based on code initially developed by Maxim U. Signed-off-by: Jerome Forissier Co-developed-by: Maxim Uvarov Cc: Maxim Uvarov Signed-off-by: Jerome Forissier --- cmd/Kconfig| 16 +-- cmd/net-lwip.c | 8 ++ include/net-lwip.h

[PATCH v5 14/20] net-lwip: lwIP wget supports user defined port in the uri, so allow it.

2024-07-25 Thread Jerome Forissier
From: Jonathan Humphreys Signed-off-by: Jonathan Humphreys Signed-off-by: Jerome Forissier --- net/lwip/wget.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/lwip/wget.c b/net/lwip/wget.c index 65a69fab6e8..bd1aab499d2 100644 --- a/net/lwip/wget.c +++ b/net/lwip/wget.c

[PATCH v5 15/20] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y

2024-07-25 Thread Jerome Forissier
Support "bdinfo -e" when lwIP is selected. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas Reviewed-by: Tom Rini --- cmd/bdinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 437ac4e8630..472e5c42b08 100644

[PATCH v5 10/20] net-lwip: add ping command

2024-07-25 Thread Jerome Forissier
Add support for the the ping command with NET_LWIP. The implementation is derived from lwIP's contrib/apps/ping/ping.c. Signed-off-by: Jerome Forissier --- cmd/Kconfig| 11 +-- cmd/net-lwip.c | 8 ++ include/net-lwip.h | 1 + net/lwip/Makefile | 1 + net/lwip/ping.c

[PATCH v5 16/20] configs: add qemu_arm64_lwip_defconfig

2024-07-25 Thread Jerome Forissier
Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and selects NET_LWIP instead of NET. This config has all the supported net commands enabled. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas --- configs/qemu_arm64_lwip_defconfig | 5 + 1 file chang

[PATCH v5 17/20] lwip: tftp: add support of blksize option to client

2024-07-25 Thread Jerome Forissier
new function: tftp_client_set_blksize() which may be used to change the block size from the default. It has to be called after tftp_client_init() and before tftp_get(). If the server does not support the option, the client will still accept to receive 512-byte blocks. Signed-off-by: Jerome

[PATCH v5 08/20] net-lwip: add DHCP support and dhcp commmand

2024-07-25 Thread Jerome Forissier
Add what it takes to enable NETDEVICES with NET_LWIP and enable DHCP as well as the dhcp command. CMD_TFTPBOOT is selected by BOOTMETH_EFI due to this code having an implicit dependency on do_tftpb(). Signed-off-by: Jerome Forissier --- boot/Kconfig| 3 +- cmd/Kconfig

[PATCH v5 18/20] net-lwip: add TFTP_BLOCKSIZE

2024-07-25 Thread Jerome Forissier
KiB/s before. That is still a low number, but I think we can't expect more without implementing the windowsize option. Signed-off-by: Jerome Forissier --- net/Kconfig | 20 ++-- net/lwip/tftp.c | 2 ++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git

[PATCH v5 19/20] CI: add qemu_arm64_lwip to the test matrix

2024-07-25 Thread Jerome Forissier
Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight IP (lwIP) implementation of the dhcp, tftpboot and ping commands. Signed-off-by: Jerome Forissier --- .azure-pipelines.yml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/.azure-pipelines.yml b/.azure

[PATCH v5 20/20] MAINTAINERS: net-lwip: add myself as a maintainer

2024-07-25 Thread Jerome Forissier
: Jerome Forissier Reviewed-by: Ilias Apalodimas --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6b32a6d9464..10323efffad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1336,6 +1336,17 @@ F: drivers/net/ F: include/net.h F

[PATCH v5 02/20] net: introduce alternative implementation as net-lwip/

2024-07-25 Thread Jerome Forissier
OX so that the NET_LWIP alternative is not visible in make menuconfig when sandbox_defconfig is used. Signed-off-by: Jerome Forissier --- Kconfig| 26 ++ common/Kconfig | 2 +- common/spl/Kconfig | 1 + drivers/dfu/Kconfig

[PATCH v5 03/20] configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y

2024-07-25 Thread Jerome Forissier
o make review easier. Signed-off-by: Jerome Forissier --- configs/LicheePi_Zero_defconfig | 2 +- configs/M5249EVB_defconfig | 2 +- configs/am335x_pdu001_defconfig | 2 +- configs/am62ax_evm_r5_defconfig | 2 +- configs/am6

Re: [PATCH v5 16/20] configs: add qemu_arm64_lwip_defconfig

2024-07-25 Thread Jerome Forissier
On 7/25/24 17:58, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: > >> Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and >> selects NET_LWIP instead of NET. This config has all the supported net >> commands

Re: [PATCH v5 06/20] net: eth-uclass: add function eth_start_udev()

2024-07-26 Thread Jerome Forissier
On 7/25/24 20:27, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:27PM +0200, Jerome Forissier wrote: > >> Add a function to start a given etwork device, and update eth_init() > > Typo, "network". Fixed in v6. >> to use it. >> >> Signed-off-by:

Re: [PATCH v5 01/20] flash: prefix error codes with FL_

2024-07-26 Thread Jerome Forissier
On 7/25/24 20:18, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:22PM +0200, Jerome Forissier wrote: > >> Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes >> with third-party libraries. Case in point: including the lwIP library >> header file

Re: [PATCH v5 16/20] configs: add qemu_arm64_lwip_defconfig

2024-07-26 Thread Jerome Forissier
On 7/25/24 18:25, Tom Rini wrote: > On Thu, Jul 25, 2024 at 06:10:48PM +0200, Jerome Forissier wrote: >> >> >> On 7/25/24 17:58, Tom Rini wrote: >>> On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: >>> >>>> Add qemu_arm64_lwip_

Re: [PATCH v5 02/20] net: introduce alternative implementation as net-lwip/

2024-07-26 Thread Jerome Forissier
On 7/25/24 18:17, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:23PM +0200, Jerome Forissier wrote: > >> Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by >> adding a new net/lwip/ directory and the NET_LWIP symbol. Network >> support is either N

Re: [PATCH v5 02/20] net: introduce alternative implementation as net-lwip/

2024-07-26 Thread Jerome Forissier
On 7/26/24 10:44, Michal Simek wrote: > čt 25. 7. 2024 v 15:28 odesílatel Jerome Forissier > napsal: >> >> Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by >> adding a new net/lwip/ directory and the NET_LWIP symbol. Network >> support is ei

Re: [PATCH v5 18/20] net-lwip: add TFTP_BLOCKSIZE

2024-07-29 Thread Jerome Forissier
Hi Ilias, On 7/29/24 14:29, Ilias Apalodimas wrote: > Hi Jerome, > > On Thu, 25 Jul 2024 at 15:59, Jerome Forissier > wrote: >> >> Add support for setting the TFTP block size. The default value (1468) >> is fine for Ethernet and allows a better throughput than the

Re: [PATCH v5 00/20] Introduce the lwIP network stack

2024-07-30 Thread Jerome Forissier
On 7/25/24 19:22, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:21PM +0200, Jerome Forissier wrote: > >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP >&g

  1   2   3   4   5   6   7   8   >