Re: [U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

2008-10-23 Thread Guennadi Liakhovetski
m_init > mem_ctrl_asm_init: > - /* Memory subsystem address 0x7e00f120 */ > - ldr r0, =ELFIN_MEM_SYS_CFG > - > - /* Xm0CSn2 = NFCON CS0, Xm0CSn3 = NFCON CS1 */ > - mov r1, #0xd > - str r1, [r0] > - > /* DMC1 base address 0x7e001000 */

Re: [U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

2008-10-23 Thread Guennadi Liakhovetski
d be set as 0x1002 Sorry, do not understand what "it." If you mean the MEM_SYS_CFG then I also don't understand this. As I quoted from the datasheet above, bit 1 set to 0 (0 << 1) is for _both_ - NAND or OneNAND. You suggest to set it to 1, which is SROMC CS2. And (1 << 12) i

Re: [U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

2008-10-23 Thread Guennadi Liakhovetski
4XX_MEM_SYS_CFG_NAND0x0008 > S3C64XX_MEM_SYS_CFG_ONENAND 0x1000 ? I asked above what the bus width has to do with OneNAND selection, you didn't reply. > S3C64XX_MEM_SYS_CFG_MOVINAND 0x Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

2008-10-23 Thread Guennadi Liakhovetski
ways 16-bit butwidth. there's no exception. Ok, thanks, but I wouldn't call the macro ONENAND, but rather 16BIT, but that's just IMHO. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office

Re: [U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

2008-10-23 Thread Guennadi Liakhovetski
On Thu, 23 Oct 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > > > + /* Xm0CSn[2] = OneNANDC CS0 or NFCON CS0, Xm0CSn[3] = SROMC CS3 > > > > */ > > > > >

Re: [U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

2008-10-23 Thread Guennadi Liakhovetski
On Thu, 23 Oct 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > > Hey, actually I do think that describing which hardware configurations > > > the software performs is a Good Thing

Re: [U-Boot] [PATCH 2/3] iMX31: Add support to copy NAND Flash code to RAM

2008-10-23 Thread Guennadi Liakhovetski
ne NFC_CONFIG2 (*((volatile u16 *)(NFC_REGS + > NFC_CONFIG2_OFF))) > + > +#define RAM_BUFFER_ADDRESS_RBA_3 0x3 > +#define NFC_BUFSIZE_1KB 0x0 > +#define NFC_BUFSIZE_2KB 0x1 > +#define NFC_CONFIGURATION_UNLOCKED 0x2 > +#define ECC_STATUS_RESULT_NO_ERR

Re: [U-Boot] [PATCH 2/3] iMX31: Add support to copy NAND Flash code to RAM

2008-10-23 Thread Guennadi Liakhovetski
On Thu, 23 Oct 2008, Alan Carvalho de Assis wrote: > Hi Guennadi, > > On Thu, Oct 23, 2008 at 4:10 PM, Guennadi Liakhovetski <[EMAIL PROTECTED]> > wrote: > > > > Last time Scott Wood suggested to use nand_spl you replied "I think using > > nand_spl is

Re: [U-Boot] [PATCH 2/3] iMX31: Add support to copy NAND Flash code to RAM

2008-10-23 Thread Guennadi Liakhovetski
e SPL-image name from nand_spl/u-boot-spl-16k.bin to something more flexible:-) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax

Re: [U-Boot] u-boot-2008.10 nand boot not working for SMDK6400

2008-12-05 Thread Guennadi Liakhovetski
ease on smdk6400, last version I tried was from approximately end of September, which is not much older than 2008.10. Which toolchain and which configuration have you used? You haven't modified the sources, have you? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering

[U-Boot] udelay(100000000) in drivers/net/3c589.c

2008-08-08 Thread Guennadi Liakhovetski
nnadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED]

Re: [U-Boot] [PATCH 5/7 v6] serial: add S3C64XX serial driver

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > > > + u32 reg; > > > > + u32 pclk_ratio = get_PCLK() / gd->baudrate; > > > > + int i; &g

Re: [U-Boot] [PATCH 5/7 v6] serial: add S3C64XX serial driver

2008-08-11 Thread Guennadi Liakhovetski
nt too - one uses "%", another one multiplication and subtraction, don't think it should be alarming that the resulting asm-code is different too. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Det

[U-Boot] [PATCH 0/7 v7] SMDK6400 support

2008-08-11 Thread Guennadi Liakhovetski
[PATCH 2/7] Add definition for the AM29LV800BB AMD NOR-flash", because it has been applied by Stefan to cfi-flash/next. [PATCH 1/7] is in nand/testing already too. While working on this new version I hit a compilation problem, which I will describe in a separate email. Thanks Guenna

[U-Boot] [PATCH 4/7 v7] USB: Add support for OHCI controller on S3C6400

2008-08-11 Thread Guennadi Liakhovetski
Notice: USB on S3C6400 currently works _only_ with switched off MMU. One could try to enable the MMU, but map addresses 1-to-1, and disable data cache, then it should work too and we could still profit from instruction cache. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --

[U-Boot] [PATCH 5/7 v7] serial: add S3C64XX serial driver

2008-08-11 Thread Guennadi Liakhovetski
Based on the original S3C64XX UART driver by Samsung for U-Boot 1.1.6. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- drivers/serial/Makefile |1 + drivers/serial/s3c64xx.c | 193 ++ 2 files changed, 194 insertions(+), 0 del

[U-Boot] [PATCH 6/7 v7] NAND: add NAND driver for S3C64XX

2008-08-11 Thread Guennadi Liakhovetski
Based on the original S3C64XX NAND driver by Samsung for U-Boot 1.1.6. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- drivers/mtd/nand/Makefile |1 + drivers/mtd/nand/s3c64xx.c | 319 2 files changed, 320 insertions(+), 0 del

[U-Boot] [PATCH 7/7 v7] ARM: Add support for S3C6400 based SMDK6400 board

2008-08-11 Thread Guennadi Liakhovetski
. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- MAINTAINERS|1 + MAKEALL|1 + Makefile | 17 ++ board/samsung/smdk6400/Makefile| 54 + board/samsung/sm

[U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
g. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ___

Re: [U-Boot] [PATCH 4/7 v7] USB: Add support for OHCI controller on S3C6400

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Guennadi Liakhovetski wrote: > Notice: USB on S3C6400 currently works _only_ with switched off MMU. One could > try to enable the MMU, but map addresses 1-to-1, and disable data cache, then > it should work too and we could still profit from instruction cache. >

Re: [U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > As I remarked in the opening email to the SMDK6400 patch-series, I've got > > a strange problem, I cannot understand. > >

Re: [U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Kenneth Johansson wrote: > > On Mon, 2008-08-11 at 18:23 +0200, Guennadi Liakhovetski wrote: > > > I cannot think of any such examples... I know access-types can be changed > > on the hardware, say, on a 16-bit bus a 32-bit access can be split into &g

Re: [U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:48 Mon 11 Aug , Guennadi Liakhovetski wrote: > > Hi > > > > As I remarked in the opening email to the SMDK6400 patch-series, I've got > > a strange problem, I cannot underst

Re: [U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Kenneth Johansson wrote: > On Mon, 2008-08-11 at 19:00 +0200, Guennadi Liakhovetski wrote: > > On Mon, 11 Aug 2008, Kenneth Johansson wrote: > > > > > On Mon, 2008-08-11 at 18:23 +0200, Guennadi Liakhovetski wrote: > > > > > > >

Re: [U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Scott Wood wrote: > On Mon, Aug 11, 2008 at 05:48:21PM +0200, Guennadi Liakhovetski wrote: > > The respective assembly code is quite simple: > > > > : > >0: e59f3004ldr r3, [pc, #4]; c > >4: e59

Re: [U-Boot] __attribute__((__packed__)) switching to byte-access on ARM

2008-08-11 Thread Guennadi Liakhovetski
On Mon, 11 Aug 2008, Guennadi Liakhovetski wrote: > but this doesn't change a thing, I checked it too. Even this > > } __attribute__((__packed__,aligned(4))); > > doesn't help. Sorry, this last statement is wrong, adding aligned(4) does help. Thanks Guennadi --- Gu

[U-Boot] [feature request] make TAGS target

2008-08-12 Thread Guennadi Liakhovetski
mind adding this target too:-) Yes, kernel has these targets. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49

Re: [U-Boot] [feature request] make TAGS target

2008-08-12 Thread Guennadi Liakhovetski
looks by default for a file called TAGS, not etags. Second, IMHO, it would be better to only tag files under respective include paths according to configuration, as in Linux. Currently include/ is tagged completely. Thirdly, I think, it should be possible to use either "find ... | xargs

[U-Boot] [PATCH] i.MX31: switch to CFG_HZ=1000

2008-08-12 Thread Guennadi Liakhovetski
: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- Based on the current arm/next + the "i.MX31: Add reset_timer() and modify get_timer_masked()" patch from Magnus Lilja. Tests on other i.MX31 boards requested! diff --git a/cpu/arm1136/mx31/interrupts.c b/cpu/arm1136/mx31/interrupts

[U-Boot] [PATCH] i.MX31: Specify maintainers for i.MX31-based boards

2008-08-13 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- This patch should be applied after SMDK6400 is merged, which will, probably, get in with the nand tree. Please comment any objections:-) diff --git a/MAINTAINERS b/MAINTAINERS index 0cab77a..343393c 100644 --- a/MAINTAINERS

Re: [U-Boot] [PATCH] i.MX31: Specify maintainers for i.MX31-based boards

2008-08-13 Thread Guennadi Liakhovetski
On Wed, 13 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > This patch should be applied after SMDK6400 is merged, which will, > > probably, get in with the nand tree. Please comment any objec

Re: [U-Boot] [PATCH 0/7 v7] SMDK6400 support

2008-08-21 Thread Guennadi Liakhovetski
Hi Harald, On Fri, 22 Aug 2008, Harald Welte wrote: > On Thu, Aug 14, 2008 at 10:07:37PM +0200, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > On 17:36 Mon 11 Aug , Guennadi Liakhovetski wrote: > > > Version 7: further comments addressed, style cleanup, s3c64xx NAND dri

Re: [U-Boot] [PATCH 0/7 v7] SMDK6400 support

2008-08-22 Thread Guennadi Liakhovetski
On Fri, 22 Aug 2008, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 08:41 Fri 22 Aug , Guennadi Liakhovetski wrote: > > Hi Harald, > > > > On Fri, 22 Aug 2008, Harald Welte wrote: > > > > > On Thu, Aug 14, 2008 at 10:07:37PM +0200, Jean-Christophe > &g

[U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

2008-08-27 Thread Guennadi Liakhovetski
injected bad block, crossing block border, read and write. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 E

[U-Boot] [PATCH 1/6] Convert fw_env.c to use a single environment image union

2008-08-27 Thread Guennadi Liakhovetski
Use a union to cover both with and without redundant environment cases. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c | 148 +--- 1 files changed, 82 insertions(+), 66 deletions(-) diff --git a/tools/env/fw

[U-Boot] [PATCH 2/6] Separate flash read and write operations

2008-08-27 Thread Guennadi Liakhovetski
The flash_io function was used for both read and write operations, whereby very little code was shared between the two modes. By breaking this function we simplify the code and save one level of identation. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c

[U-Boot] [PATCH 3/6] "return" is not a function

2008-08-27 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c | 88 ++-- 1 files changed, 44 insertions(+), 44 deletions(-) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 6f7fdb2..2c82970 100644 --- a/too

[U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-27 Thread Guennadi Liakhovetski
Use consistent naming for active and redundant environment variables, remove redundant erase struct initialisation by using separate structs for the active and redundant environments. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c

[U-Boot] [PATCH 5/6] Support environment anywhere within erase area

2008-08-27 Thread Guennadi Liakhovetski
This will become more important with NAND support, in which case the minimum erase region is a block, which consists of several pages and can be 256KiB large. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c

[U-Boot] [PATCH 6/6] Support environment in NAND

2008-08-27 Thread Guennadi Liakhovetski
Add support for environment in NAND with automatic recognition, including unaligned environment, bad-block skipping, redundant environment copy. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c | 344 +++- 1

[U-Boot] [PATCH] smdk6400: remove redundant bootargs definition

2008-08-28 Thread Guennadi Liakhovetski
Double bootargs setting leads to a duplicated environmant entry. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- This, of course, should be applied after the bulk of smdk6400 support is in the tree. diff --git a/include/configs/smdk6400.h b/include/configs/smdk6400.h index 6

[U-Boot] [PATCH] S3C64XX: remove broken HWFLOW support from the serial driver

2008-08-28 Thread Guennadi Liakhovetski
As noted by Harald Welte, HWFLOW support in the S3C64XX serial driver is broken and currently unused. Remove it. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- As well as the previous patch, please, apply after the s3c64xx / smdk6400 support is merged in. diff --git a/d

[U-Boot] [PATCH] i.MX31: document timer precision option

2008-08-28 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- diff -u /dev/null doc/README.imx31 --- /dev/null 2008-08-28 10:21:05.503011301 +0200 +++ doc/README.imx312008-08-28 12:15:21.0 +0200 @@ -0,0 +1,13 @@ +i.MX31 specific Configuration O

[U-Boot] [PATCH 6/6 v2] Support environment in NAND

2008-08-29 Thread Guennadi Liakhovetski
preserve backwards compatibility on NOR, including identical erase / write behaviour. Also fix some return codes. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- I am not resending patches 1-5, they remain unchanged. Changes since v1: instead of abusing the "erase sector size

Re: [U-Boot] [PATCH 1/6] Convert fw_env.c to use a single environment image union

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Use a union to cover both with and without redundant environment cases. > ... > > -typedef struct environment_s { > > - ulong crc;

Re: [U-Boot] [PATCH 2/6] Separate flash read and write operations

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Your > > > Subject: Re: [U-Boot] [PATCH 2/6] Separate flash read and write operations > > does not make a good commit comment - y

Re: [U-Boot] [PATCH 3/6] "return" is not a function

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> > > I don't see any need to change this code. Patch rejected. return

Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Use consistent naming for active and redundant environment variables, remove > > redundant erase struct initialisation by using separate str

Re: [U-Boot] [PATCH 3/6] "return" is not a function

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > > I don't see any need to change this code. Patch rejected. > > > > return (0) and similar produce warnings from checkpa

Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > It's not purely stylistic. For example, previously the code had fd and > > fdr, curdev and otherdev. It used one erase struct f

Re: [U-Boot] [PATCH 5/6] Support environment anywhere within erase area

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > This will become more important with NAND support, in which case the minimum > > erase region is a block, which consists of several pages

Re: [U-Boot] [PATCH 2/6] Separate flash read and write operations

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > So, no, this is not because I didn't like somebody else's coding style. > > This is because with NAND addition this function

Re: [U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > What follows is a patch series to support NAND environment under Linux, > > including bad blocks. In principle, this is just one logical chang

Re: [U-Boot] [PATCH 6/6] Support environment in NAND

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > --- a/tools/env/fw_env.c > > +++ b/tools/env/fw_env.c > > @@ -44,6 +44,12 @@ > > #defineCMD_GETENV "fw_pr

Re: [U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

2008-09-01 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > Ok, how about this: we leave the current fw_env.c as it is, I submit > > _exactly_ the state after applying my 6 patches as a new fi

Re: [U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

2008-09-01 Thread Guennadi Liakhovetski
On Mon, 1 Sep 2008, Guennadi Liakhovetski wrote: > > New issue: I just noted that the default environment built into the > > fw_ tool has not much to do with the default environment build into > > the U-Boot binary image; in theory both should be the same. Don;t > &g

Re: [U-Boot] [PATCH 7/7 v7] ARM: Add support for S3C6400 based SMDK6400 board

2008-09-01 Thread Guennadi Liakhovetski
On Mon, 1 Sep 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > SMDK6400 can only boot U-Boot from NAND-flash. This patch adds a nand_spl > > driver for it too. The board can also boot from the NOR fla

Re: [U-Boot] u-boot-arm pull request

2008-09-01 Thread Guennadi Liakhovetski
> are available in the git repository at: > > git://git.denx.de/u-boot-arm.git master > > Guennadi Liakhovetski (7): > ARM: Add arm1176 core with S3C6400 SoC > USB: Add support for OHCI controller on S3C6400 > serial: add S3C64XX serial driver > S3C64

Re: [U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

2008-09-01 Thread Guennadi Liakhovetski
t will look worse than the broken-down patch-series. Otherwise we could remove the current file and add a new one in two patches? This wouldn't be very good either - you'd have to change Makefiles etc. to keep the tree compilable. Thanks Guennadi --- Guennadi Liakhovetski, P

Re: [U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

2008-09-02 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > What follows is a patch series to support NAND environment under Linux, > > including bad blocks. In principle, this is just one logical chang

[U-Boot] [PATCH] fw_env: add NAND support

2008-09-02 Thread Guennadi Liakhovetski
Add support for environment in NAND with automatic NOR / NAND recognition, including unaligned environment, bad-block skipping, redundant environment copy. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- This is now a single patch. No union any more, instead a struc

Re: [U-Boot] [PATCH] fw_env: add NAND support

2008-09-02 Thread Guennadi Liakhovetski
-aligned by construction" mean? It means, by the way I constructed (calculated) lengths above this place, we land here only if offset is block-aligned. > > + erase.length = erasesize; > > + > > + /* This only runs once on NOR flash */ > > How comes that? Because on

Re: [U-Boot] [PATCH] fw_env: add NAND support

2008-09-02 Thread Guennadi Liakhovetski
, then yes, writing per one write would be essentially different. In short, I think, CRC provides sufficient protection of data integrity. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5,

Re: [U-Boot] [PATCH] fw_env: add NAND support

2008-09-03 Thread Guennadi Liakhovetski
ne to me. The orginal code however accepted such lines and only dropped lines with rc < 3. I do not understand how the original code managed to work with rc == 3. As I thought this was a bug, I changed the test to "rc < 4", i.e., now I require

Re: [U-Boot] [PATCH] fw_env: add NAND support

2008-09-03 Thread Guennadi Liakhovetski
ole buffer at once as I did up to now, or change it to follow your scheme above? In the latter case I am not sure if this will work with all kernel versions with all mtd drivers and all NOR flashes. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgan

Re: [U-Boot] [PATCH] fw_env: add NAND support

2008-09-03 Thread Guennadi Liakhovetski
emory Error: can't write fw_env to flash Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL

Re: [U-Boot] [PATCH] fw_env: add NAND support

2008-09-03 Thread Guennadi Liakhovetski
On Wed, 3 Sep 2008, Markus Klotzbücher wrote: > Dear Guennadi, > > On Tue, Sep 02, 2008 at 07:05:29PM +0200, Guennadi Liakhovetski wrote: > > > +static int flash_flag_obsolete (int dev, int fd, off_t offset) > > +{ > > + struct mtd_info_user mtdinfo; > >

[U-Boot] [PATCH v2] fw_env: add NAND support

2008-09-04 Thread Guennadi Liakhovetski
Add support for environment in NAND with automatic NOR / NAND recognition, including unaligned environment, bad-block skipping, redundant environment copy. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- Changes since v1: multiple style updates, added Copyright, restored fl

[U-Boot] [REGRESSION] commit b502611b51... "Change env_get_char from a..." breaks imx31_phycore

2008-09-05 Thread Guennadi Liakhovetski
current HEAD fixes the problem. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email:

Re: [U-Boot] [REGRESSION] commit b502611b51... "Change env_get_char from a..." breaks imx31_phycore

2008-09-05 Thread Guennadi Liakhovetski
On Fri, 5 Sep 2008, Joakim Tjernlund wrote: > > > -Original Message- > > From: Guennadi Liakhovetski [mailto:[EMAIL PROTECTED] > > Sent: den 5 september 2008 20:01 > > To: U-Boot@lists.denx.de > > Cc: Joakim Tjernlund > > Subject: [REGRESSION] co

Re: [U-Boot] [REGRESSION] commit b502611b51... "Change env_get_char from a..." breaks imx31_phycore

2008-09-06 Thread Guennadi Liakhovetski
r none at all out there. Hence the question: shell we set GD_FLG_RELOC centrally really for all boards or are there boards out there that really must not have this flag set? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165

Re: [U-Boot] [REGRESSION] commit b502611b51... "Change env_get_char from a..." breaks imx31_phycore

2008-09-06 Thread Guennadi Liakhovetski
On Sat, 6 Sep 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > Hence the question: shell we set GD_FLG_RELOC centrally really for all > > boards or are there boards out there that really must not

Re: [U-Boot] [PATCH] Suppressing Diagnostic Output for 'fw_setenv'

2008-09-07 Thread Guennadi Liakhovetski
ent in). In my last patch version (v2, submitted last Thursday, 4 Sep), I put all debugging output in "#ifdef DEBUG" blocks. So, if this patch is accepted in its current form, you will have to look at those ifdef's and see which of them you want to make dynamically selectable per

Re: [U-Boot] [REGRESSION] commit b502611b51... "Change env_get_char from a..." breaks imx31_phycore

2008-09-07 Thread Guennadi Liakhovetski
On Sat, 6 Sep 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > Was this patch correct then? > > > > http://lists.denx.de/pipermail/u-boot/2008-July/037375.html > > > >

Re: [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long".

2008-09-09 Thread Guennadi Liakhovetski
#include > #include > #include > +#include > > static ulong timer_load_val; > > @@ -148,7 +149,9 @@ void reset_timer(void) > > ulong get_timer_masked(void) > { > - return get_ticks() / (timer_load_val / (100 * CFG_HZ)); > + unsigned long long

Re: [U-Boot] [fw_printenv should open device as O_SYNC]

2008-09-10 Thread Guennadi Liakhovetski
rk like that? > I ve modified the fw_env.c file to open the mtd O_SYNC and it works > fine. > > If it is OK I can submit a patch for this. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office

Re: [U-Boot] erase and saveenv stop working after using fw_setenv

2008-09-16 Thread Guennadi Liakhovetski
ch can take value MTD_WRITEABLE, but I think it means something different - whether this mtd-device is writable in principle. So, it looks like the only way to find out whether the specific sector is locked is to try to write / erase it:-( Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX So

Re: [U-Boot] [PATCH] i.MX31: document timer precision option

2008-09-18 Thread Guennadi Liakhovetski
On Thu, 18 Sep 2008, Shinya Kuribayashi wrote: > Hi Guennadi, > > Guennadi Liakhovetski wrote: > > Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> > > --- > > > > diff -u /dev/null doc/README.imx31 > > --- /dev/null 2008-08-28 10:2

Re: [U-Boot] [PATCH 1/1] i.MX31: switch to CFG_HZ=1000

2008-09-20 Thread Guennadi Liakhovetski
Hi Jean-Christophe, On Tue, 16 Sep 2008, Jean-Christophe PLAGNIOL-VILLARD wrote: > From: Guennadi Liakhovetski <[EMAIL PROTECTED]> > > Switch to the standard CFG_HZ=1000 value, while at it, minor white-space > cleanup, remove CFG_CLKS_IN_HZ from config-headers. Tested on mx3

Re: [U-Boot] ARM & u-boot-next pull request

2008-09-21 Thread Guennadi Liakhovetski
sitory at: > > git://git.denx.de/u-boot-arm.git master > > Guennadi Liakhovetski (1): > i.MX31: switch to CFG_HZ=1000 > > Jean-Christophe PLAGNIOL-VILLARD (4): > Revert "ARM: set GD_FLG_RELOC for boards skipping relocation to RAM" > ARM: s

[U-Boot] [PATCH v2] i.MX31: switch to CFG_HZ=1000

2008-09-25 Thread Guennadi Liakhovetski
: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- On Jean-Christophe's request: rebased against current top-of-tree, no changes since the previous changes otherwise, still, I decided to count the version up to make it easier to distinguish them... diff --git a/cpu/arm1136/mx31/interru

Re: [U-Boot] [PATCH] mx31ads: update board configuration

2009-08-13 Thread Guennadi Liakhovetski
On Thu, 13 Aug 2009, Wolfgang Denk wrote: > Bring default environment more in line with other boards; > fix address range for "mtest" command. > > Signed-off-by: Wolfgang Denk > Cc: Guennadi Liakhovetski Having various board configurations look similar has, certain

Re: [U-Boot] [PATCH] SPI: Fix 32 bit transfers in mxc_spi.c

2009-12-02 Thread Guennadi Liakhovetski
quot; broke 32 bit transfers. This patch > > makes single 32 bit transfer work again. > > > > Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to > > the MC13783/ATLAS chip (using the 'date' command). > > > > Signed-off-by: Magnus Lilj

Re: [U-Boot] [PATCH] SPI: Fix 32 bit transfers in mxc_spi.c

2010-01-04 Thread Guennadi Liakhovetski
On Mon, 4 Jan 2010, Magnus Lilja wrote: > Hi > > Magnus Lilja skrev: > > 2009/12/3 Guennadi Liakhovetski : > >> On Wed, 2 Dec 2009, Wolfgang Denk wrote: > >> > >>> Dear Guennadi, > >>> > >>> In message <1257965907

Re: [U-Boot] [PATCH] board/linkstation/ide.c: Fix compile warning

2009-09-11 Thread Guennadi Liakhovetski
Hi Wolfgang On Fri, 11 Sep 2009, Wolfgang Denk wrote: > Fix warning: ide.c:60: warning: dereferencing type-punned pointer will > break strict-aliasing rules > > Signed-off-by: Wolfgang Denk > Cc: Guennadi Liakhovetski > --- > board/linkstation/ide.c |4 +++-

Re: [U-Boot] [PATCH][v2] FDT: remove obsolete OF_CPU and OF_SOC macros.

2009-09-11 Thread Guennadi Liakhovetski
On Wed, 9 Sep 2009, Marcel Ziswiler wrote: > Signed-off-by: Marcel Ziswiler Acked-by: Guennadi Liakhovetski > --- > Changes since v1: > - CC all respective board maintainers > > README|6 -- > include/configs/IDS8247.h |2

Re: [U-Boot] [PATCH] board/linkstation/ide.c: Fix compile warning

2009-09-11 Thread Guennadi Liakhovetski
On Fri, 11 Sep 2009, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message you wrote: > > Hi Wolfgang > > > > On Fri, 11 Sep 2009, Wolfgang Denk wrote: > > > > > Fix warning: ide.c:60: warning: dereferencing type-punned poin

Re: [U-Boot] [PATCH v2] board/linkstation/ide.c: Fix compile warning

2009-09-15 Thread Guennadi Liakhovetski
On Tue, 15 Sep 2009, Wolfgang Denk wrote: > Fix warning: ide.c:60: warning: dereferencing type-punned pointer will > break strict-aliasing rules > > Signed-off-by: Wolfgang Denk > Cc: Guennadi Liakhovetski > > --- > v2: Better implementation as suggested by

Re: [U-Boot] [PATCH v2] board/linkstation/ide.c: Fix compile warning

2009-09-16 Thread Guennadi Liakhovetski
On Tue, 15 Sep 2009, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message you wrote: > > > > > pci_read_config_dword (devbusfn, PCI_BASE_ADDRESS_0, > > > -

Re: [U-Boot] [PATCH v2] board/linkstation/ide.c: Fix compile warning

2009-09-22 Thread Guennadi Liakhovetski
On Tue, 22 Sep 2009, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message you wrote: > > > > I have the hardware, yes, and I even have something, that should be a Jtag > > cable for it... But I don't have near 100% certainty, that if I brick it I

[U-Boot] [PATCH] remove myself as a maintainer of several ARM boards

2010-04-06 Thread Guennadi Liakhovetski
Since I haven't been actively maintaining these boards for a long while, keeping myself as their maintainer makes no sense. Signed-off-by: Guennadi Liakhovetski --- I've submitted my last patch to U-Boot almost a year ago and haven't been following U-Boot development since

[U-Boot] [PATCH v2] remove myself as a maintainer of several ARM boards

2010-04-14 Thread Guennadi Liakhovetski
Since I haven't been actively maintaining these boards for a long while, keeping myself as their maintainer makes no sense. Signed-off-by: Guennadi Liakhovetski --- v1 -> v2 added to the orphaned list diff --git a/MAINTAINERS b/MAINTAINERS index bb03f17..6274599 100644 --- a/MAI

[U-Boot] [PATCH] ARM: Add the imx31_phycore_eet board to MAKEALL

2009-03-25 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski --- diff --git a/MAKEALL b/MAKEALL index cf05133..1456a30 100755 --- a/MAKEALL +++ b/MAKEALL @@ -535,15 +535,16 @@ LIST_ARM10=" \ # ## ARM11 Sy

Re: [U-Boot] Out-of-tree build for imx31_phycore_eet fails

2009-03-30 Thread Guennadi Liakhovetski
nfiguration for an existing board. Do we really want a new MAINTAINERS entry for it? I looked at a couple other boards with multiple configs, they all had only one entry in MAINTAINERS (at most:-)). Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfga

[U-Boot] [PATCH] ARM: fix out-of-tree build of imx31_phycore_eet, add to MAINTAINERS

2009-04-04 Thread Guennadi Liakhovetski
Fix out-of-tree build of the imx31_phycore_eet target, add it to the list of boards, maintained by me, in MAINTAINERS. Reported-by: Wolfgang Denk Signed-off-by: Guennadi Liakhovetski --- diff --git a/MAINTAINERS b/MAINTAINERS index 284f5c6..4b1b187 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[U-Boot] [PATCH] ARM: fix out-of-tree build of imx31_phycore_eet

2009-04-04 Thread Guennadi Liakhovetski
Fix out-of-tree build of the imx31_phycore_eet target. Reported-by: Wolfgang Denk Signed-off-by: Guennadi Liakhovetski --- diff --git a/Makefile b/Makefile index f9edd9d..86e6d62 100644 --- a/Makefile +++ b/Makefile @@ -3066,6 +3066,7 @@ imx31_litekit_config : unconfig

[U-Boot] [PATCH] ARM: add the imx31_phycore_eet target to MAINTAINERS

2009-04-04 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski --- diff --git a/MAINTAINERS b/MAINTAINERS index 284f5c6..03d59b9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -568,8 +568,9 @@ Prakash Kumar Guennadi Liakhovetski - mx31ads i.MX31 - SMDK6400S3C6400 + imx31_phycore_eet

Re: [U-Boot] [PATCH 05/22] board/linkstation/ide.c: Fix GCC 4.6 build warnings

2011-11-06 Thread Guennadi Liakhovetski
gt; ide.c:70:17: warning: array subscript is above array bounds > [-Warray-bounds] > > Signed-off-by: Wolfgang Denk > Cc: Guennadi Liakhovetski > --- > board/linkstation/ide.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/board/linkstatio

[U-Boot] [PATCH 1/2] env_nand: remove unused variable.

2009-05-18 Thread Guennadi Liakhovetski
Remove an unused "total" variable in multiple functions. Signed-off-by: Guennadi Liakhovetski --- common/env_nand.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/common/env_nand.c b/common/env_nand.c index 76569da..21bce25 100644 --- a/common/

[U-Boot] [PATCH 2/2] nand_spl: read environment early, when booting from NAND using nand_spl

2009-05-18 Thread Guennadi Liakhovetski
ically and remain at their default values. Fix this problem by reading out main and redundand (if used) copies of the environment in the nand_spl code. Signed-off-by: Guennadi Liakhovetski --- README |6 ++ common/env_nand.c

  1   2   >