On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Use consistent naming for active and redundant environment variables, remove > > redundant erase struct initialisation by using separate structs for the > > active and redundant environments. > > This is another sylistic change that is IMHO not justified by any > functional improvements or code fixes. > > If you are woking on other people's code you will have to accept that > these other people have other preferences for variable names and the > like. Reformatting the code and renaming variables just to make it > better match your own style is IMHO not justified. > > Your new code gets longer, you even have to split a couple of lines > because of that. That's not an improvement to me.
It's not purely stylistic. For example, previously the code had fd and fdr, curdev and otherdev. It used one erase struct for both main and redundant copies, thus they had to initialise it multiple times to one or another version. I separated it into two erase_current and erase_target thus removing the need for multiple initialisation. I think, having dev_target, erase_target, fd_target vs. dev_current, erase_current and fd_current is also a readability improvement. > I reject this patch. Please, reconsider. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
