Re: [PATCH v2] imx8m: clock_imx8mq: Add the ecspi clocks

2022-02-15 Thread Marek Vasut
On 2/15/22 01:51, Angus Ainslie wrote: Hi Marek, Hi, On 2022-02-14 16:25, Marek Vasut wrote: On 2/14/22 21:51, Angus Ainslie wrote: Enable the clocks for spi buses 1 through 3 Signed-off-by: Angus Ainslie --- Changes since v1: added MXC_CSPI_CLK to ECSPI1_CLK_ROOT mapping   arch/arm/in

RE: STM32MP: Can't lock PHK fuses through U-Boot cmd's "stm32key" or "fuse"

2022-02-15 Thread Johann Neuhauser
> -Original Message- > From: Patrick DELAUNAY [mailto:patrick.delau...@foss.st.com] > Sent: Monday, February 14, 2022 4:21 PM > > Hi, > > > On 2/14/22 12:14, Patrick DELAUNAY wrote: > > Hi Johann, > > Hello Patrick, > > On 2/11/22 15:02, Johann Neuhauser wrote: > >> Hello Patrick, Patri

[PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-15 Thread Masami Hiramatsu
Since now the capsule_on_disk will restart the u-boot sandbox right after the capsule update, if CONFIG_EFI_CAPSULE_ON_DISK_EARLY=y, the boot with a new capsule file will repeat reboot sequence. On the other hand, if CONFIG_EFI_CAPSULE_ON_DISK_EARLY=n, the 'env print -e' command will execute the ca

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-15 Thread Masami Hiramatsu
Hi Heinrich, I and Takahiro found that the capsule update test case and test framework didn't expect that a command can reboot the sandbox and the sandbox can reboot while booting, which happens when my "Reset system after CapsuleUpdate on disk" patch applied. This patch fixes those issues. Thank

Re: [PATCH] clk: update clk_clean_rate_cache to use private clk struct

2022-02-15 Thread Patrick DELAUNAY
Hi Sean On 2/1/22 16:14, Sean Anderson wrote: On 1/31/22 10:18 AM, Patrick Delaunay wrote: In clk_clean_rate_cache, clk->rate should update the private clock struct, in particular when CCF is activated, to save the cached rate value. When clk_get_parent_rate is called, the cached information i

Re: [PATCH u-boot-marvell 1/4] arm: a37xx: pci: Use standard register macros from pci.h

2022-02-15 Thread Stefan Roese
On 2/10/22 14:53, Pali Rohár wrote: PCI config space of the aardvark PCIe Root Port is available only in internal aardvark memory space starting at offset 0x0. PCI Express registers (PCI_EXP_*) start at offset 0xc0. And Advanced Error Reporting registers (PCI_ERR_*) start at offset 0x100. Replac

Re: [PATCH u-boot-marvell 2/4] arm: a37xx: pci: Cleanup macro names

2022-02-15 Thread Stefan Roese
On 2/10/22 14:53, Pali Rohár wrote: Remove "PCI_" prefix from all macros which are aardvark specific to not conflict with macros defined in global include file pci.h. Instead add "ADVK_" prefix for them so it is visible that they are aardvark specific. After "ADVK_" prefix append keyword which d

Re: [PATCH u-boot-marvell 3/4] arm: a37xx: pci: Use dev_read_addr()

2022-02-15 Thread Stefan Roese
On 2/10/22 14:53, Pali Rohár wrote: There is only one base address, so use dev_read_addr() instead of dev_read_addr_index(). Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pci/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH u-boot-marvell 4/4] arm: a37xx: pci: Ensure that root port is always on root zero bus

2022-02-15 Thread Stefan Roese
On 2/10/22 14:53, Pali Rohár wrote: Writing to the PCI_PRIMARY_BUS register of the root port should not change bus number on which is root port present. This PCI_PRIMARY_BUS register is used only for correct configuration of legacy PCI stuff, like forwarding of PCI special cycles between buses.

Re: [PATCH u-boot-marvell 1/9] rtc: ds1307: Add bindings for microchip,mcp7940x

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: Compatible string microchip,mcp7940x is used by Turris Mox DTS file in Linux kernel and U-Boot ds1307.c driver works fine with it. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/rtc/ds1307.c | 1 + 1 file changed, 1 in

Re: [PATCH u-boot-marvell 2/9] phy: marvell: a3700: Update compatible string to official DT bindings

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: In commit d368e1070514 ("phy: marvell: a3700: Convert to official DT bindings in COMPHY driver") was done update to official DT bindings but compatible string of official DT bindings was not updated. Fix it now. Fixes: d368e1070514 ("phy: marvell: a3700: Conv

Re: [PATCH u-boot-marvell 3/9] usb: ehci: ehci-marvell: Update compatible string to official DT bindings

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: Official DT bindings use compatible string marvell,armada-3700-ehci. Update drivers and DTS files. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-37xx.dtsi | 2 +- drivers/phy/marvell/comphy_a3700.c |

Re: [PATCH u-boot-marvell 4/9] watchdog: armada_37xx: Convert to official DT bindings

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: Official DT bindings have only one reg property: watchdog address space. Convert armada-37xx-wdt.c driver to offical DT bindings and access sel_reg register via MVEBU_REGISTER() macro, as its value (required by U-Boot driver) is not in DT yet. In later stage ca

Re: [PATCH u-boot-marvell 5/9] arm: mvebu: turris_mox: Remove hardcoded ethernet node names

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: Armada 3720 DTS files in upstream kernel use ethernet nodes named 'ethernet@3' and 'ethernet@4'. U-Boot have them named 'neta@3' and 'neta@4'. To have Turris Mox U-Boot board code independent of ethernet node names, find ethernet node via alias.

Re: [PATCH u-boot-marvell 6/9] arm: a37xx: Update sdhci pointers to official DT bindings

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: In Linux kernel version of armada-37xx.dtsi file sdhci1 pointer refers to sdhci@d node and sdhci0 pointer to sdhci@d8000 node. Strange. Do you know why this "reverted naming" is used in the Kernel? Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese

Re: [PATCH u-boot-marvell 7/9] arm: a37xx: espressobin: Move U-Boot specific partitions node to -u-boot.dtsi

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: U-Boot specific changes should be in armada-3720-espressobin-u-boot.dtsi DTS file. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- .../dts/armada-3720-espressobin-u-boot.dtsi | 23 +++ arch/arm/dts/armada-372

Re: [PATCH u-boot-marvell 8/9] arm: a37xx: espressobin: Explicitly enable eMMC node in -u-boot.dtsi

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: Official DT bindings for Espressobin have disabled eMMC node. As U-Boot requires to have this node enabled by default, do it in armada-3720-espressobin-u-boot.dtsi DTS file. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/

Re: [PATCH u-boot-marvell 9/9] arm: a37xx: Update DTS files to version from upstream Linux kernel

2022-02-15 Thread Stefan Roese
On 2/14/22 11:34, Pali Rohár wrote: This change updates all Armada 37xx DTS files to version which is used by Linux kernel v5.18. Signed-off-by: Pali Rohár Very nice. Thanks for working on this. Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-371x.dtsi | 3

Re: [PATCH u-boot-marvell 6/9] arm: a37xx: Update sdhci pointers to official DT bindings

2022-02-15 Thread Pali Rohár
On Tuesday 15 February 2022 10:28:26 Stefan Roese wrote: > On 2/14/22 11:34, Pali Rohár wrote: > > In Linux kernel version of armada-37xx.dtsi file sdhci1 pointer refers to > > sdhci@d node and sdhci0 pointer to sdhci@d8000 node. > > Strange. Do you know why this "reverted naming" is used in t

RE: [PATCH] crypto: aspeed: fix polling RSA status wrong issue

2022-02-15 Thread ChiaWei Wang
> From: Neal Liu > Sent: Tuesday, February 15, 2022 4:55 PM > > Check interrupt status to see if RSA engine is completed. After completion of > the task, write-clear the status to finish operation. > Add missing register base for completion. > > Signed-off-by: Neal Liu Please add a line with "

[PATCH u-boot-marvell 1/3] arm: a37xx: pci: Do not try to access other buses when link is down

2022-02-15 Thread Pali Rohár
If a PIO request is executed while link-down, the whole controller gets stuck in a non-functional state, and even after link comes up again, PIO requests won't work anymore, and a reset of the whole PCIe controller is needed. Therefore we need to prevent sending PIO requests while the link is down.

[PATCH u-boot-marvell 3/3] arm: a37xx: pci: Update comment about Command/Direct mode

2022-02-15 Thread Pali Rohár
Code is changing PCIe controller from Command mode to Direct mode. Signed-off-by: Pali Rohár --- drivers/pci/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c index c795ef10b884..4f7e61ecf166 100644 --- a/dr

[PATCH u-boot-marvell 2/3] arm: a37xx: pci: Register controller also when no PCIe card is connected

2022-02-15 Thread Pali Rohár
Allow access to config space of PCIe Root Port (which is always present on the root bus) even when PCIe link is down or no card is connected. Signed-off-by: Pali Rohár --- drivers/pci/pci-aardvark.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/pci/pci-

[PATCH u-boot-marvell] pci: mvebu: Ensure that root port is always on root zero bus

2022-02-15 Thread Pali Rohár
Writing to the PCI_PRIMARY_BUS register of the root port should not change bus number on which is root port present. Same change and exactly same fix as was done in commit for pci-aardvark.c. Fixes: a7b61ab58d5d ("pci: pci_mvebu: Properly configure and use PCI Bridge (PCIe Root Port)") Signed-of

Re: [PATCH] arm: am33xx: Fix early debug UART initialization

2022-02-15 Thread Felix Brack
Hello Tom, On 14.02.22 23:45, Tom Rini wrote: > On Mon, Feb 14, 2022 at 05:56:52PM +0100, Felix Brack wrote: >> The changes from commit 0dba45864b2a ("arm: Init the debug UART") >> prevent the early debug UART from being initialized correctly. >> By adding a new SoC specific early UART initializat

Re: [PATCH] tools: kwbimage: Fix dumping DATA registers for v0 images

2022-02-15 Thread Stefan Roese
On 2/13/22 01:04, Pali Rohár wrote: End of DATA register section is indicated by zero value in both raddr and rdata. So do not stop dumping registers with non-zero address and zero value. And also print end of DATA registers section. Fixes: 1a8e6b63e24f ("tools: kwbimage: Dump kwbimage config f

Re: [PATCH u-boot-mvebu 1/3] arm: mvebu: a37xx: Fix calling build_mem_map()

2022-02-15 Thread Stefan Roese
On 2/15/22 00:28, Pali Rohár wrote: Function build_mem_map() modifies global variable mem_map. This variable is used by the get_page_table_size() function which is called by function arm_reserve_mmu() (as aliased macro PGTABLE_SIZE). Function arm_reserve_mmu() is called earlier than enable_caches

Re: [PATCH] tools/zynqmp_pm_cfg_obj_convert.py: fix build with Vivado 2021.x

2022-02-15 Thread Michal Simek
On 2/12/22 13:51, Luca Ceresoli wrote: This tool fails with a pm_cfg_obj.c file generated by Vitis 2021.2. This is because that version of Vitis added the PM_CONFIG_OBJECT_TYPE_BASE that was not previously generated, thus the script does not implement it. Reported-by: Neal Frager [report: h

Re: [PATCH] rpi: always set fdt_addr to the correct value

2022-02-15 Thread Jaehoon Chung
On 22. 2. 14. 20:25, Marek Szyprowski wrote: > The fdt_addr env have meaning only for the current runtime and it depends > on the dtb size or firmware version. If one save the environment to disk > and the loads it on the latter boot, the fdt_addr might change, what > result in passing incorrect dt

Re: [PATCH 01/24] moveconfig: Show the config name rather than the defconfig

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > The _defconfig suffix is unnecessary when showing matching boards. Drop > it. > > Signed-off-by: Simon Glass > --- > > tools/moveconfig.py | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/tools/moveconfig.py b/to

Re: [PATCH 02/24] moveconfig: Allow regex matches when finding combinations

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > It is useful to be able to search for CONFIG options that match a regex, > such as this, which lists boards which define SPL_FIT_GENERATOR and > anything not starting with ROCKCHIP: > >./tools/moveconfig.py -f SPL_FIT_GENERATOR ~ROCKCHIP.* > > Add sup

Re: [PATCH 03/24] spl: x86: Correct the binman symbols for SPL

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > These symbols are incorrect, meaning that binman cannot find the > associated entry. This leads to errors like: > > binman: Section '/binman/simple-bin': Symbol '_binman_spl_prop_size' >in entry '/binman/simple-bin/u-boot-spl/u-boot-spl-nodtb': >En

Re: [PATCH 04/24] spl: Allow disabling binman symbols in SPL

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > When CONFIG_SPL_FIT is enabled we do not access U-Boot directly in > the image, since it is embedded in a FIT which is parsed at runtime. > > Provide a CONFIG option to drop the symbols in this case. > > Signed-off-by: Simon Glass > --- > > common/spl/

Re: [PATCH 06/24] dtoc: Support adding a string list to a device tree

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > Add a new function to add a string list. > > Signed-off-by: Simon Glass > --- > > tools/dtoc/fdt.py | 18 ++ > tools/dtoc/test_fdt.py | 8 > 2 files changed, 26 insertions(+) > > diff --git a/tools/dtoc/fdt.py b/tools/dto

Re: [PATCH 09/24] dtoc: Support reading a list of arguments

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > It is helpful to support a string or stringlist containing a list of > space-separated arguments, for example: > >args = "-n fred", "-a", "123"; > > This resolves to the list: > >-n fred -a 123 Would be clearer as ['-n', 'fred', '-a', '123'] >

Re: [PATCH 11/24] elf: Add a way to read segment information from an ELF file

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > Add a function which reads the segments and the entry address. > > Also fix a comment nit in the tests while we are here. > > Signed-off-by: Simon Glass > --- > > tools/binman/elf.py | 37 + > tools/binman/elf_t

Re: [PATCH 14/24] binman: Support a list of strings with the mkimage etype

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > At present the 'args' property of the mkimage entry type is a string. This > makes it difficult to include CONFIG options in that property. In > particular, this does not work: > >args = "-n CONFIG_SYS_SOC -E" > > since the preprocessor does not opera

Re: [PATCH 16/24] binman: Move entry-data collection into a Entry method

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Collecting the data from a list of entries and putting it in a file is > a useful operation that will be needed by other entry types. Put this into > a method in the Entry class. > > Add some documentation about how to collect data for an entry type. > >

Re: [PATCH 17/24] binman: fit: Refactor to reduce function size

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Split subnode and property processing into separate functions to make > the _AddNode() function a little smaller. Tweak a few comments. > > This does not change any functionality. > > Signed-off-by: Simon Glass > --- I know this just moves code around a

Re: [PATCH 20/24] binman: Support splitting an ELF file into multiple nodes

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Some boards need to load an ELF file using the 'loadables' property, but > the file has segments at different memory addresses. This means that it > cannot be supplied as a flat binary. > > Allow generating a separate node in the FIT for each segment in th

Re: [PATCH 22/24] rockchip: Support building the all output files in binman

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Add the required binman images to replace the Makefile rules which are > currently used. This includes subsuming: > >- tpl/u-boot-tpl-rockchip.bin if TPL is enabled >- idbloader.img if either or both of SPL and TPL are enabled >- u-boot.itb2 if

Re: [PATCH v2] dm: Fix OF_BAD_ADDR definition

2022-02-15 Thread Patrice CHOTARD
Hi Jan On 2/14/22 16:21, Jan Kiszka wrote: > On 04.01.22 08:42, Patrice Chotard wrote: >> When OF_LIVE flag is enabled on a 64 bits platform, there is an >> issue when dev_read_addr() is called and need to perform an address >> translation using __of_translate_address(). >> >> In case of error, __

Re: [PATCH v3] power: zynqmp: Add power domain driver for ZynqMP

2022-02-15 Thread Michal Simek
po 7. 2. 2022 v 10:27 odesílatel Michal Simek napsal: > > Driver should be enabled by CONFIG_POWER_DOMAIN=y and > CONFIG_ZYNQMP_POWER_DOMAIN=y. Power domain driver doesn't have own DT node > but it uses zynqmp firmware DT node that's why there is a need to bind > driver when firmware node is found

Re: [PATCH v2 1/2] phy: zynqmp: Add support for sata and DP phy initialization

2022-02-15 Thread Michal Simek
po 7. 2. 2022 v 10:36 odesílatel Michal Simek napsal: > > DP is untested but just c&p from Linux driver. Sata is tested on kv260-revA > board which has SATA connector populated. > > Signed-off-by: Michal Simek > > --- > > Changes in v2: > Revoke default case - reported by T Karthik Reddy > > dri

Re: [PATCH] video: Add missing dependency for DM_GPIO

2022-02-15 Thread Michal Simek
pá 4. 2. 2022 v 8:37 odesílatel Michal Simek napsal: > > Seps driver also requires DM_GPIO to be enabled. > > Signed-off-by: Michal Simek > --- > > drivers/video/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index

Re: [PATCH] xilinx: Remove GPIO_EXTRA_HEADER selection

2022-02-15 Thread Michal Simek
pá 4. 2. 2022 v 8:40 odesílatel Michal Simek napsal: > > Platform specific headers are empty that's why there is no need to include > them. That's why remove them for Zynq/ZynqMP and Versal. > > Signed-off-by: Michal Simek > --- > > arch/arm/Kconfig | 4 > arch/arm/

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-15 Thread Marek Behún
On Tue, 15 Feb 2022 00:28:34 +0100 Pali Rohár wrote: > In function build_mem_map() prepares also mapping for CCI-400 and * prepare > AP BootROM address space. > > A53 AP BootROM by default starts at address 0xfff0 and is 16 kB long. RVBAR_EL3 register has value 0

Re: [PATCH 7/7] microblaze: exception: drop user exception support

2022-02-15 Thread Michal Simek
On 2/13/22 09:09, Ovidiu Panait wrote: A user exception is triggered by inserting a bralid/brki jump to "C_BASE_VECTORS+0x8" in the software flow. Because u-boot microblaze code does not deal with MMU-related features such as user-mode/privileged-mode separation, there are no code sequences th

[PATCH] kontron-sl-mx8mm: change kernel_addr_r and scriptaddr

2022-02-15 Thread Heiko Thiery
Currently the space between kernel_addr_r and the fdt_addr_r is only 32MB. To have enought space to load kernel images bigger than 32MB change the kernel_addr_r to CONFIG_SYS_LOAD_ADDR. Also set the scriptaddr to this value. Cc: Frieder Schrempf Signed-off-by: Heiko Thiery --- include/configs/k

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-15 Thread Alper Nebi Yasak
On 14/02/2022 12:09, Jan Kiszka wrote: > On 07.02.22 23:08, Alper Nebi Yasak wrote: >> The binman FIT entry type shares some code with the Section entry type. >> This shared code is bound to grow, since FIT entries are conceptually a >> variation of Section entries. >> >> Make FIT entry type a subc

Re: [PATCH] arm: am33xx: Fix early debug UART initialization

2022-02-15 Thread Tom Rini
On Tue, Feb 15, 2022 at 11:53:41AM +0100, Felix Brack wrote: > Hello Tom, > > On 14.02.22 23:45, Tom Rini wrote: > > On Mon, Feb 14, 2022 at 05:56:52PM +0100, Felix Brack wrote: > >> The changes from commit 0dba45864b2a ("arm: Init the debug UART") > >> prevent the early debug UART from being init

Re: [PATCH v2] dm: Fix OF_BAD_ADDR definition

2022-02-15 Thread Jan Kiszka
On 15.02.22 12:56, Patrice CHOTARD wrote: > Hi Jan > > On 2/14/22 16:21, Jan Kiszka wrote: >> On 04.01.22 08:42, Patrice Chotard wrote: >>> When OF_LIVE flag is enabled on a 64 bits platform, there is an >>> issue when dev_read_addr() is called and need to perform an address >>> translation using

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-15 Thread Pali Rohár
On Tuesday 15 February 2022 13:11:25 Marek Behún wrote: > On Tue, 15 Feb 2022 00:28:34 +0100 > Pali Rohár wrote: > > > In function build_mem_map() prepares also mapping for CCI-400 and > * prepare > > AP BootROM address space. > > > > A53 AP BootROM by default starts

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-15 Thread Marek Behún
On Tue, 15 Feb 2022 14:04:47 +0100 Pali Rohár wrote: > On Tuesday 15 February 2022 13:11:25 Marek Behún wrote: > > On Tue, 15 Feb 2022 00:28:34 +0100 > > Pali Rohár wrote: > > > > > In function build_mem_map() prepares also mapping for CCI-400 and > > * prepare

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: a37xx: Fix comment with name of the function

2022-02-15 Thread Marek Behún
On Tue, 15 Feb 2022 00:28:35 +0100 Pali Rohár wrote: > Function is named build_mem_map, not a3700_build_mem_map. > > Signed-off-by: Pali Rohár Reviewed-by: Marek Behún

Re: [PATCH u-boot-mvebu 1/3] arm: mvebu: a37xx: Fix calling build_mem_map()

2022-02-15 Thread Marek Behún
On Tue, 15 Feb 2022 00:28:33 +0100 Pali Rohár wrote: > Function build_mem_map() modifies global variable mem_map. This variable is > used by the get_page_table_size() function which is called by function > arm_reserve_mmu() (as aliased macro PGTABLE_SIZE). Function > arm_reserve_mmu() is called e

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-15 Thread Marek Behún
On Tue, 15 Feb 2022 14:15:17 +0100 Marek Behún wrote: > > In _production version_ where is no debug capability and no access to > > any memory (just ability to boot) is is probably not needed, but none of > > A3720 board is building this kind of version (by default). And in case > > BootROM is ma

Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-15 Thread Jorge Ramirez-Ortiz, Foundries
On 15/02/22, Michal Simek wrote: > Hi, > > On 2/14/22 21:10, Ricardo Salveti wrote: > > Hi Michal, > > > > This is a bit similar to the issue raised on iMX8-based targets a few > > days ago, which is forcing the environment location based on the boot > > mode and not allowing the user to use a di

Re: bind/unbind command not working for usb_ether

2022-02-15 Thread Patrice CHOTARD
Hi Tim On 2/10/22 18:04, Tim Harvey wrote: > Greetings, > > I'm trying to understand how to use the U-Boot bind command to bind > the usb_ether driver to the usb class to register a USB ethernet > gadget network device as referenced in: > commit 02291d83fdaaf ("doc: add bind/unbind command docume

Re: bind/unbind command not working for usb_ether

2022-02-15 Thread Patrice CHOTARD
Hi Tim On 2/10/22 18:04, Tim Harvey wrote: > Greetings, > > I'm trying to understand how to use the U-Boot bind command to bind > the usb_ether driver to the usb class to register a USB ethernet > gadget network device as referenced in: > commit 02291d83fdaaf ("doc: add bind/unbind command docume

Re: [PATCH v2] dm: Fix OF_BAD_ADDR definition

2022-02-15 Thread Patrice CHOTARD
Hi Jan On 2/15/22 14:00, Jan Kiszka wrote: > On 15.02.22 12:56, Patrice CHOTARD wrote: >> Hi Jan >> >> On 2/14/22 16:21, Jan Kiszka wrote: >>> On 04.01.22 08:42, Patrice Chotard wrote: When OF_LIVE flag is enabled on a 64 bits platform, there is an issue when dev_read_addr() is called an

Re: [PATCH v2] dm: Fix OF_BAD_ADDR definition

2022-02-15 Thread Jan Kiszka
On 15.02.22 14:34, Patrice CHOTARD wrote: > Hi Jan > > On 2/15/22 14:00, Jan Kiszka wrote: >> On 15.02.22 12:56, Patrice CHOTARD wrote: >>> Hi Jan >>> >>> On 2/14/22 16:21, Jan Kiszka wrote: On 04.01.22 08:42, Patrice Chotard wrote: > When OF_LIVE flag is enabled on a 64 bits platform, th

[PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-15 Thread Rafał Miłecki
From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often user-space. This binding allows describing environment data location and its format clearly. In some/many cases it should be clea

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-15 Thread Heinrich Schuchardt
On 2/15/22 10:09, Masami Hiramatsu wrote: Hi Heinrich, I and Takahiro found that the capsule update test case and test framework didn't expect that a command can reboot the sandbox and the sandbox can reboot while booting, which happens when my "Reset system after CapsuleUpdate on disk" patch

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-15 Thread Heinrich Schuchardt
On 2/15/22 14:51, Heinrich Schuchardt wrote: On 2/15/22 10:09, Masami Hiramatsu wrote: Hi Heinrich, I and Takahiro found that the capsule update test case and test framework didn't expect that a command can reboot the sandbox and the sandbox can reboot while booting, which happens when my "Re

Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-15 Thread Michal Simek
Hi, On 2/15/22 14:27, Jorge Ramirez-Ortiz, Foundries wrote: On 15/02/22, Michal Simek wrote: Hi, On 2/14/22 21:10, Ricardo Salveti wrote: Hi Michal, This is a bit similar to the issue raised on iMX8-based targets a few days ago, which is forcing the environment location based on the boot mod

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-15 Thread Michal Simek
On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often user-space. This binding allows describing environment data location and its format c

Re: [PATCH] kontron-sl-mx8mm: change kernel_addr_r and scriptaddr

2022-02-15 Thread Michael Walle
Hi Heiko, > Currently the space between kernel_addr_r and the fdt_addr_r is only > 32MB. To have enought space to load kernel images bigger than 32MB change the > kernel_addr_r to CONFIG_SYS_LOAD_ADDR. Also set the scriptaddr to this > value. Did you check and align the values with the almost sta

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-15 Thread Heinrich Schuchardt
On 2/15/22 10:05, Masami Hiramatsu wrote: Since now the capsule_on_disk will restart the u-boot sandbox right after the capsule update, if CONFIG_EFI_CAPSULE_ON_DISK_EARLY=y, the boot with a new capsule file will repeat reboot sequence. On the other hand, if CONFIG_EFI_CAPSULE_ON_DISK_EARLY=n, th

[PATCH] arm: pdu001: Fix early debugging UART

2022-02-15 Thread Felix Brack
The changes from commit 0dba45864b2a ("arm: Init the debug UART") prevent the early debug UART from being initialized correctly. To fix this we not just configure the pin multiplexer but add setting up early clocks. Signed-off-by: Felix Brack --- board/eets/pdu001/Makefile | 6 +- board/eet

Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-15 Thread Ilias Apalodimas
Hi, Took me some time to go through the whole thread, but here it goes. On Tue, Feb 15, 2022 at 12:08:30PM +0530, Sughosh Ganu wrote: > On Tue, 15 Feb 2022 at 07:21, AKASHI Takahiro > wrote: > > > > Sughosh, > > > > On Mon, Feb 14, 2022 at 11:12:22AM +0530, Sughosh Ganu wrote: > > > hi Takahir

Re: [PATCH v2] imx8m: clock_imx8mq: Add the ecspi clocks

2022-02-15 Thread Angus Ainslie
On 2022-02-15 00:01, Marek Vasut wrote: On 2/15/22 01:51, Angus Ainslie wrote: On 2022-02-14 16:25, Marek Vasut wrote: On 2/14/22 21:51, Angus Ainslie wrote: Enable the clocks for spi buses 1 through 3 Signed-off-by: Angus Ainslie --- Changes since v1: added MXC_CSPI_CLK to ECSPI1_CLK_ROOT

Re: [PATCH] rpi: always set fdt_addr to the correct value

2022-02-15 Thread Matthias Brugger
On 18/02/2022 03:44, Jaehoon Chung wrote: On 22. 2. 14. 20:25, Marek Szyprowski wrote: The fdt_addr env have meaning only for the current runtime and it depends on the dtb size or firmware version. If one save the environment to disk and the loads it on the latter boot, the fdt_addr might cha

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-15 Thread Sean Anderson
On 2/15/22 9:02 AM, Michal Simek wrote: On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often user-space. This binding allows describing en

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-15 Thread Michal Simek
On 2/15/22 15:57, Sean Anderson wrote: On 2/15/22 9:02 AM, Michal Simek wrote: On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often use

Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-15 Thread Sean Anderson
On 2/15/22 8:54 AM, Michal Simek wrote: Hi, On 2/15/22 14:27, Jorge Ramirez-Ortiz, Foundries wrote: On 15/02/22, Michal Simek wrote: Hi, On 2/14/22 21:10, Ricardo Salveti wrote: Hi Michal, This is a bit similar to the issue raised on iMX8-based targets a few days ago, which is forcing the e

[PATCH 2/2] stm32mp1: bsec: add missing dev in function comment

2022-02-15 Thread Patrick Delaunay
Add the missing @dev reference in some function description. Fixes: b66bfdf238b9 ("arm: stm32mp: bsec: migrate trace to log macro") Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/bsec.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/ma

[PATCH 1/2] stm32mp: bsec: add permanent lock write support

2022-02-15 Thread Patrick Delaunay
Add support of the permanent lock support in U-Boot proper when BSEC is not managed by secure monitor (TF-A SP_MIN or OP-TEE). This patch avoid issue with stm32key command and fuse command on basic boot for this missing feature of U-Boot BSEC driver. Reported-by: Johann Neuhauser Signed-off-by:

[PATCH 1/2] mmc: fix error message for unaligned erase request

2022-02-15 Thread Patrick Delaunay
Fix the end address in the message for unaligned erase request in mmc_berase() when start + blkcnt is aligned to erase_grp_size. for example: - start = 0x2000 - 26 - count = 26 - erase_grp_size = 0x400 Caution! Your devices Erase group is 0x400 The erase range would be change to 0x2000~

[PATCH 2/2] env: mmc : align erase address and size on erase_grp_size

2022-02-15 Thread Patrick Delaunay
On eMMC device, the erase_grp_size > 1 so the address and size for the erase block command in env/mmc.c can be unaligned on erase group size and some strange trace occurs and the result is not guarantee by MMC devices. The SD-Card behavior doesn't change as erase_grp_size = 1 for SD-Card. For exa

Re: [PATCH] kontron-sl-mx8mm: change kernel_addr_r and scriptaddr

2022-02-15 Thread Heiko Thiery
Hi, Am Di., 15. Feb. 2022 um 15:03 Uhr schrieb Michael Walle : > > Hi Heiko, > > > Currently the space between kernel_addr_r and the fdt_addr_r is only > > 32MB. To have enought space to load kernel images bigger than 32MB change > > the > > kernel_addr_r to CONFIG_SYS_LOAD_ADDR. Also set the scr

Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-15 Thread Michal Simek
On 2/15/22 16:02, Sean Anderson wrote: On 2/15/22 8:54 AM, Michal Simek wrote: Hi, On 2/15/22 14:27, Jorge Ramirez-Ortiz, Foundries wrote: On 15/02/22, Michal Simek wrote: Hi, On 2/14/22 21:10, Ricardo Salveti wrote: Hi Michal, This is a bit similar to the issue raised on iMX8-based tar

Re: bind/unbind command not working for usb_ether

2022-02-15 Thread Tim Harvey
On Tue, Feb 15, 2022 at 5:29 AM Patrice CHOTARD wrote: > > Hi Tim > > On 2/10/22 18:04, Tim Harvey wrote: > > Greetings, > > > > I'm trying to understand how to use the U-Boot bind command to bind > > the usb_ether driver to the usb class to register a USB ethernet > > gadget network device as ref

Re: [PATCH v2] imx8m: clock_imx8mq: Add the ecspi clocks

2022-02-15 Thread Marek Vasut
On 2/15/22 15:55, Angus Ainslie wrote: On 2022-02-15 00:01, Marek Vasut wrote: On 2/15/22 01:51, Angus Ainslie wrote: On 2022-02-14 16:25, Marek Vasut wrote: On 2/14/22 21:51, Angus Ainslie wrote: Enable the clocks for spi buses 1 through 3 Signed-off-by: Angus Ainslie --- Changes since v1

[PATCH] crypto: aspeed: fix polling RSA status wrong issue

2022-02-15 Thread Neal Liu
Check interrupt status to see if RSA engine is completed. After completion of the task, write-clear the status to finish operation. Add missing register base for completion. Signed-off-by: Neal Liu --- drivers/crypto/aspeed/aspeed_acry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

RE: [PATCH] crypto: aspeed: fix polling RSA status wrong issue

2022-02-15 Thread Neal Liu
> -Original Message- > From: ChiaWei Wang > Sent: Tuesday, February 15, 2022 5:58 PM > To: Neal Liu ; Ryan Chen > ; u-boot@lists.denx.de > Cc: BMC-SW > Subject: RE: [PATCH] crypto: aspeed: fix polling RSA status wrong issue > > > From: Neal Liu > > Sent: Tuesday, February 15, 2022 4:55

[PATCH v2] crypto: aspeed: fix polling RSA status wrong issue

2022-02-15 Thread Neal Liu
Check interrupt status to see if RSA engine is completed. After completion of the task, write-clear the status to finish operation. Add missing register base for completion. Fixes: 89c36cca0b6 ("crypto: aspeed: Add AST2600 ACRY support") Signed-off-by: Neal Liu Reviewed-by: Chia-Wei Wang --- d

[PATCH 5/7] spi: dw: Actually mask interrupts

2022-02-15 Thread Niklas Cassel
From: Sean Anderson The designware spi driver unconditionally uses polling. The comment to spi_hw_init() also states that the function should disable interrupts. According to the DesignWare DW_apb_ssi Databook, value 0xff in IMR enables all interrupts. Since we want to mask all interrupts write

[PATCH 4/7] spi: dw: Force set K210 fifo length to 31

2022-02-15 Thread Niklas Cassel
From: Damien Le Moal The Canaan Kendryte K210 SoC DW apb_ssi v4 spi controller is documented to have a 32 word deep TX and RX FIFO, which spi_hw_init() detects. However, when the RX FIFO is filled up to 32 entries (RXFLR = 32), an RX FIFO overrun error occurs. Avoid this problem by force setting

[PATCH 2/7] k210: dts: add missing power bus clocks

2022-02-15 Thread Niklas Cassel
From: Damien Le Moal Linux drivers for many of the K210 peripherals depend on the power bus clock to be specified. Add the missing clocks and their names to avoid problems when booting Linux using u-boot DT. Signed-off-by: Damien Le Moal Signed-off-by: Niklas Cassel --- arch/riscv/dts/k210.dt

[PATCH 1/7] k210: use the board vendor name rather than the marketing name

2022-02-15 Thread Niklas Cassel
From: Damien Le Moal "kendryte" is the marketing name for the K210 RISC-V SoC produced by Canaan Inc. Rather than "kendryte,k210", use the usual "canaan,k210" vendor,SoC compatibility string format in the device tree files and use the SoC name for file names. With these changes, the device tree f

[PATCH 6/7] pinctrl: k210: Fix loop in k210_pc_get_drive()

2022-02-15 Thread Niklas Cassel
From: Niklas Cassel The loop exited too early so the k210_pc_drive_strength[0] array element was never used. Original Linux patch by Dan Carpenter: https://lore.kernel.org/linux-gpio/20220209180804.GA18385@kili/ Fixes: 7224d5ccf8e1 ("pinctrl: Add support for Kendryte K210 FPIOA") Signed-off-by:

[PATCH 7/7] pinctrl: k210: Fix bias-pull-up

2022-02-15 Thread Niklas Cassel
From: Niklas Cassel Using bias-pull-up would actually cause the pin to have its pull-down enabled. Fix this. Original Linux patch by Sean Anderson: https://lore.kernel.org/linux-gpio/20220209182822.640905-1-sean...@gmail.com/ Fixes: 7224d5ccf8e1 ("pinctrl: Add support for Kendryte K210 FPIOA")

[PATCH 3/7] k210: dts: fix fpioa node

2022-02-15 Thread Niklas Cassel
From: Damien Le Moal Linux kernel fpioa pinctrl driver expects the sysctl phandle and the power bit offset of the fpioa device to be specified as a single property "canaan,k210-sysctl-power". Replace the "canaan,k210-sysctl" and "canaan,k210-power-offset" properties with "canaan,k210-sysctl-power

[PATCH 0/7] canaan k210 SoC fixes

2022-02-15 Thread Niklas Cassel
From: Niklas Cassel Hello there, This series improves the support for the canaan k210 SoC. Patch 1 renames a few compatible strings so that the k210 compatible strings are identical to the ones used in Linux. Patch 2 add missing power bus clocks, which is needed if supplying the u-boot device

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-15 Thread Jan Kiszka
On 15.02.22 13:27, Alper Nebi Yasak wrote: > On 14/02/2022 12:09, Jan Kiszka wrote: >> On 07.02.22 23:08, Alper Nebi Yasak wrote: >>> The binman FIT entry type shares some code with the Section entry type. >>> This shared code is bound to grow, since FIT entries are conceptually a >>> variation of

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-15 Thread Jan Kiszka
On 15.02.22 17:50, Jan Kiszka wrote: > On 15.02.22 13:27, Alper Nebi Yasak wrote: >> On 14/02/2022 12:09, Jan Kiszka wrote: >>> On 07.02.22 23:08, Alper Nebi Yasak wrote: The binman FIT entry type shares some code with the Section entry type. This shared code is bound to grow, since FIT e

Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-15 Thread Sughosh Ganu
hi Ilias, On Tue, 15 Feb 2022 at 20:10, Ilias Apalodimas wrote: > > Hi, > > Took me some time to go through the whole thread, but here it goes. > > On Tue, Feb 15, 2022 at 12:08:30PM +0530, Sughosh Ganu wrote: > > On Tue, 15 Feb 2022 at 07:21, AKASHI Takahiro > > wrote: > > > > > > Sughosh, > >

Re: bind/unbind command not working for usb_ether

2022-02-15 Thread Patrice CHOTARD
Hi Tim On 2/15/22 17:09, Tim Harvey wrote: > On Tue, Feb 15, 2022 at 5:29 AM Patrice CHOTARD > wrote: >> >> Hi Tim >> >> On 2/10/22 18:04, Tim Harvey wrote: >>> Greetings, >>> >>> I'm trying to understand how to use the U-Boot bind command to bind >>> the usb_ether driver to the usb class to regi

Re: [PATCH v2] imx8m: clock_imx8mq: Add the ecspi clocks

2022-02-15 Thread Angus Ainslie
On 2022-02-15 08:45, Marek Vasut wrote: On 2/15/22 15:55, Angus Ainslie wrote: On 2022-02-15 00:01, Marek Vasut wrote: On 2/15/22 01:51, Angus Ainslie wrote: On 2022-02-14 16:25, Marek Vasut wrote: On 2/14/22 21:51, Angus Ainslie wrote: Enable the clocks for spi buses 1 through 3 Signed-off

  1   2   >