On 08/02/2022 21:49, Simon Glass wrote:
> The _defconfig suffix is unnecessary when showing matching boards. Drop
> it.
>
> Signed-off-by: Simon Glass <s...@chromium.org>
> ---
>
> tools/moveconfig.py | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/tools/moveconfig.py b/tools/moveconfig.py
> index 1bcf58caf1..5ef5a95eb6 100755
> --- a/tools/moveconfig.py
> +++ b/tools/moveconfig.py
> @@ -91,7 +91,20 @@ SIZES = {
> 'SZ_4G': 0x100000000
> }
>
> +RE_REMOVE_DEFCONFIG = re.compile(r'(.*)_defconfig')
> +
> ### helper functions ###
> +def remove_defconfig(defc):
> + """Drop the _defconfig suffix on a string
> +
> + Args:
> + defc (str): String to convert
> +
> + Returns:
> + str: string with the '_defconfig' suffix removed
> + """
> + return RE_REMOVE_DEFCONFIG.match(defc)[1]
> +
I think defc.split('_defconfig')[0] (or defc.partition) would work good
enough here and this function may be unnecessary.
> def check_top_directory():
> """Exit if we are not at the top of source directory."""
> for fname in 'README', 'Licenses':
> @@ -1638,7 +1651,7 @@ def do_find_config(config_list):
> print(f"Error: Not in Kconfig: %s" % ' '.join(adhoc))
> else:
> print(f'{len(out)} matches')
> - print(' '.join(out))
> + print(' '.join([remove_defconfig(item) for item in out]))
The square brackets aren't necessary here, but not really harmful either.
>
>
> def prefix_config(cfg):
