Re: [BUG] double free in dfu_free_entities()

2021-03-11 Thread Lukasz Majewski
Hi Heinrich, > Hello Lukasz, > > Jose and I have observed segmentation violations when > dfu_free_entities() is called. > Thanks for finding them. > In our scenario we have: > > dfu_alt_info= > sf 0:0=u-boot-bin raw 0x10 0x5;u-boot-env raw 0x15 > 0x20 > > dfu_free_entities()

Re: [BUG] double free in dfu_free_entities()

2021-03-11 Thread Heinrich Schuchardt
On 3/11/21 9:18 AM, Lukasz Majewski wrote: Hi Heinrich, Hello Lukasz, Jose and I have observed segmentation violations when dfu_free_entities() is called. Thanks for finding them. In our scenario we have: dfu_alt_info= sf 0:0=u-boot-bin raw 0x10 0x5;u-boot-env raw 0x15 0x2000

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
On Thu, Mar 11, 2021 at 08:50:22AM +0100, Heinrich Schuchardt wrote: > On 3/5/21 11:22 PM, Ilias Apalodimas wrote: > > On the following patches we allow for an initrd path to be stored in > > Boot variables. Specifically we encode in the FIlePathList[] of > > the EFI_LOAD_OPTIONS for each Boot

Re: [PATCH 3/6] efi_loader: Introduce helper functions for EFI

2021-03-11 Thread Heinrich Schuchardt
On 05.03.21 23:22, Ilias Apalodimas wrote: > A following patch introduces a different logic for loading initrd's > based on the EFI_LOAD_FILE2_PROTOCOL. > Since similar logic can be applied in the future for other system files > (i.e DTBs), let's add some helper functions which will retrieve and >

Re: [PATCH 2/4] net: phy: drop #ifdef CONFIG_DM_ETH around phy_connect_fixed

2021-03-11 Thread Bin Meng
On Wed, Feb 17, 2021 at 6:48 AM Vladimir Oltean wrote: > > From: Vladimir Oltean > > In drivers/net/phy/Kconfig, CONFIG_PHY_FIXED already depends on > CONFIG_DM_ETH, so the function prototype definition when CONFIG_DM_ETH=n > does nothing, so it can be dropped. It is also never reachable, since >

Re: [PATCH 02/20] net: phy: xilinx: Convert to use APIs which support live DT

2021-03-11 Thread Bin Meng
Hi Vladimir, On Fri, Mar 5, 2021 at 7:05 AM Vladimir Oltean wrote: > > On Thu, Mar 04, 2021 at 01:36:45PM +0800, Bin Meng wrote: > > It looks that I need to rebase my series on top of yours? > > That would be nice, thank you. It would also create some sort of > incentive to finally get my patches

Re: [PATCH 02/20] net: phy: xilinx: Convert to use APIs which support live DT

2021-03-11 Thread Vladimir Oltean
On Thu, Mar 11, 2021 at 06:33:39PM +0800, Bin Meng wrote: > Hi Vladimir, > > On Fri, Mar 5, 2021 at 7:05 AM Vladimir Oltean > wrote: > > > > On Thu, Mar 04, 2021 at 01:36:45PM +0800, Bin Meng wrote: > > > It looks that I need to rebase my series on top of yours? > > > > That would be nice, thank

[PATCH] mtd: spi-nor-ids: add dual and quad mode support to mx25l12805d

2021-03-11 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier The NOR flash MX25L12835F reuse the JEDEC ID of the MX25l12805D but supports dual and quad mode. Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf Datasheet: https://www.macronix.com/Lists/Datasheet/Attachme

Re: [PATCH 02/20] net: phy: xilinx: Convert to use APIs which support live DT

2021-03-11 Thread Bin Meng
Hi Vladimir, On Thu, Mar 11, 2021 at 6:37 PM Vladimir Oltean wrote: > > On Thu, Mar 11, 2021 at 06:33:39PM +0800, Bin Meng wrote: > > Hi Vladimir, > > > > On Fri, Mar 5, 2021 at 7:05 AM Vladimir Oltean > > wrote: > > > > > > On Thu, Mar 04, 2021 at 01:36:45PM +0800, Bin Meng wrote: > > > > It l

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Heinrich Schuchardt
On 11.03.21 10:10, Ilias Apalodimas wrote: > On Thu, Mar 11, 2021 at 08:50:22AM +0100, Heinrich Schuchardt wrote: >> On 3/5/21 11:22 PM, Ilias Apalodimas wrote: >>> On the following patches we allow for an initrd path to be stored in >>> Boot variables. Specifically we encode in the FIlePathLi

Re: [PATCH] arm: stm32mp1: Set soc_type, soc_pkg, soc_rev env variables

2021-03-11 Thread Patrick DELAUNAY
Hi Marek, On 3/5/21 3:18 PM, Marek Vasut wrote: Split up get_soc_name(), clean the decoding up a bit, and set up environment variables which contain the SoC type, package, revision. This is useful on SoMs, where multiple SoC options are populated. Signed-off-by: Marek Vasut Cc: Patrick Delauna

Re: [PATCH 02/20] net: phy: xilinx: Convert to use APIs which support live DT

2021-03-11 Thread Vladimir Oltean
On Thu, Mar 11, 2021 at 06:58:33PM +0800, Bin Meng wrote: > Hi Vladimir, > > On Thu, Mar 11, 2021 at 6:37 PM Vladimir Oltean > wrote: > > > > On Thu, Mar 11, 2021 at 06:33:39PM +0800, Bin Meng wrote: > > > Hi Vladimir, > > > > > > On Fri, Mar 5, 2021 at 7:05 AM Vladimir Oltean > > > wrote: > >

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
Hi Heinrich [...] > >>> + * @load_option: device paths to search > >>> + * @size: size of the discovered device path > >>> + * @guid: guid to search for > >>> + * > >>> + * Return: device path or NULL. Caller must free the returned value > >> > >> Please, keep the text alig

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Heinrich Schuchardt
Am 11. März 2021 12:36:04 MEZ schrieb Ilias Apalodimas : >Hi Heinrich > >[...] > >> >>> + * @load_option: device paths to search >> >>> + * @size:size of the discovered device path >> >>> + * @guid:guid to search for >> >>> + * >> >>> + * Return: device path or NULL. Caller m

Re: [PATCH] mtd: spi-nor-ids: add dual and quad mode support to mx25l12805d

2021-03-11 Thread Pratyush Yadav
Hi Stefan, On 11/03/21 10:55AM, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > The NOR flash MX25L12835F reuse the JEDEC ID of the MX25l12805D but > supports dual and quad mode. There is some discussion going on over at the Linux side [0] about these two flashes and how to pr

Re: [PATCH 4/6] efi_loader: Replace config option for initrd loading

2021-03-11 Thread Heinrich Schuchardt
On 05.03.21 23:23, Ilias Apalodimas wrote: > Up to now we install EFI_LOAD_FILE2_PROTOCOL to load an initrd > unconditionally. Although we correctly return various EFI exit codes > depending on the file status (i.e EFI_NO_MEDIA, EFI_NOT_FOUND etc), the > kernel loader, only falls back to the cmdlin

[PATCH] mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages

2021-03-11 Thread Maxim Kochetkov
Linux commit a75bbe71a27 ("mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages") Per ONFI specification (Rev. 4.0), if the CRC of the first parameter page read is not valid, the host should read redundant parameter page copies. Fix FSL NAND driver to read the two redundant

[PATCH 0/4] Add rt-thread art-pi board support

2021-03-11 Thread dillon . minfei
From: dillon min These patches aim to adds u-boot support on art-pi board. the board resources: - stm32h750xbh6 128k flash, 1024k sram - 32MiB sdram - 16MiB spi flash - 8MiB qspi flash - onboard wifi, bt, fm the detail board information can be found at: https://art-pi.gitee.io/website/ dillon

[PATCH 1/4] ARM: dts: stm32: split sdram pin & timing parameter into specific board dts

2021-03-11 Thread dillon . minfei
From: dillon min As different boards has their own sdram hw connection, mount different sdram modules, so move sdram timing parameter and pin configuration to their board device tree. Signed-off-by: dillon min --- arch/arm/dts/stm32h7-u-boot.dtsi | 95 -- a

[PATCH 2/4] ARM: dts: stm32: Add RT-Thread art-pi board support

2021-03-11 Thread dillon . minfei
From: dillon min All these files are add for support rt-thread art-pi board the detail board information can be found at: https://art-pi.gitee.io/website/ board resources: - stm32h750xbh6 128k flash, 1024k sram - 32MiB sdram - 16MiB spi flash - 8MiB qspi flash - onboard wifi, bt, fm Signed-off-

[PATCH 3/4] board: Add rt-thread art-pi board support

2021-03-11 Thread dillon . minfei
From: dillon min This patch adds support for rt-thread art-pi board. for more information about art-pi, please goto: https://art-pi.gitee.io/website/ Signed-off-by: dillon min --- arch/arm/mach-stm32/stm32h7/Kconfig | 4 ++ board/st/stm32h750-art-pi/Kconfig| 19 +

[PATCH 4/4] ram: stm32: fix strsep failed on read only memory

2021-03-11 Thread dillon . minfei
From: dillon min strsep will change data from original memory address, in case the memory is in non-sdram/sram place, will run into a bug(hang at SDRAM: ) just add a temporary array to store bank_name[] to fix this bug. Fixes: f303aaf ("ram: stm32: add second SDRAM bank management") Signed-off-

Re: [PATCH 4/6] efi_loader: Replace config option for initrd loading

2021-03-11 Thread Ilias Apalodimas
On Thu, Mar 11, 2021 at 01:23:05PM +0100, Heinrich Schuchardt wrote: > On 05.03.21 23:23, Ilias Apalodimas wrote: > > Up to now we install EFI_LOAD_FILE2_PROTOCOL to load an initrd > > unconditionally. Although we correctly return various EFI exit codes > > depending on the file status (i.e EFI_NO_

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Heinrich Schuchardt
On 11.03.21 12:44, Heinrich Schuchardt wrote: > Am 11. März 2021 12:36:04 MEZ schrieb Ilias Apalodimas > : >> Hi Heinrich >> >> [...] >> >> + * @load_option: device paths to search >> + * @size:size of the discovered device path >> + * @guid:guid to search for >> +

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Heinrich Schuchardt
On 05.03.21 23:23, Ilias Apalodimas wrote: > The UEFI spec allow a packed array of UEFI device paths in the > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > describe the loaded image but the rest are OS specific. > > Previous patches parse the device path and try to use the second

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
Hi Heinrich, [...] > >> No, the structure is added in cmd/efidebug.c code. > >> It's created with efi_dp_append_instance() on > >> - const struct efi_initrd_dp id_dp > >> - file path of initrd > >> > >> which will create: > >> kernel path,end(0xff), > >> VenMedia(), end(0x01), > > This end node i

Re: [PATCH 6/6] doc: Update uefi documentation for initrd loading options

2021-03-11 Thread Heinrich Schuchardt
On 05.03.21 23:23, Ilias Apalodimas wrote: > Document the command line options for efidebug and initrd loading > > Signed-off-by: Ilias Apalodimas > --- > doc/uefi/uefi.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/uefi/uefi.rst b/doc/uefi/uefi.rst > index b3494c22e073..b

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Ilias Apalodimas
On Thu, Mar 11, 2021 at 01:38:33PM +0100, Heinrich Schuchardt wrote: > > + } > > + > > + initrd_dp = > > + efi_dp_append_instance((const struct efi_device_path *)&id_dp, > > Please, pass &id_dp.end here to avoid a superfluous end node. Wont this make efi_dp_size() loop endlessly?

Re: [PATCH u-boot 16/39] build: use thin archives instead of incremental linking

2021-03-11 Thread Marek Behun
On Tue, 9 Mar 2021 21:00:00 +0800 Bin Meng wrote: > > --start-group is useless now. > > > $(u-boot-main) > > \ > > - --end-group > > \ > > + --no-wh

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Heinrich Schuchardt
On 11.03.21 13:39, Ilias Apalodimas wrote: > Hi Heinrich, > > [...] No, the structure is added in cmd/efidebug.c code. It's created with efi_dp_append_instance() on - const struct efi_initrd_dp id_dp - file path of initrd which will create: kernel path,end(0xff),

Re: [PATCH u-boot 17/39] build: support building with Link Time Optimizations

2021-03-11 Thread Marek Behun
On Tue, 9 Mar 2021 21:30:26 +0800 Bin Meng wrote: > > +config LTO > > + bool "Enable Link Time Optimizations" > > + depends on ARCH_SUPPORTS_LTO > > + default n > > nits: this line is not needed as the default value is n if omitted This is for consistency. The other options

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
On Thu, Mar 11, 2021 at 01:44:05PM +0100, Heinrich Schuchardt wrote: > On 11.03.21 13:39, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > [...] > No, the structure is added in cmd/efidebug.c code. > It's created with efi_dp_append_instance() on > - const struct efi_initrd_dp id_dp >

Re: [PATCH 4/6] efi_loader: Replace config option for initrd loading

2021-03-11 Thread Heinrich Schuchardt
On 11.03.21 13:30, Ilias Apalodimas wrote: > On Thu, Mar 11, 2021 at 01:23:05PM +0100, Heinrich Schuchardt wrote: >> On 05.03.21 23:23, Ilias Apalodimas wrote: >>> Up to now we install EFI_LOAD_FILE2_PROTOCOL to load an initrd >>> unconditionally. Although we correctly return various EFI exit codes

[PATCH 0/4 v7] Add ESRT and test ESRT creation

2021-03-11 Thread Jose Marinho
The following 4 commits add the ESRT and provide tests for the functionality. The first commit adds the ESRT as defined in the UEFI 2.8 specification. An empty ESRT is created during the execution of the efi_init_obj_list(). The ESRT is updated when: 1) a FMP protocol is installed in the system:

[PATCH 1/4 v7] efi: Add ESRT to the EFI system table

2021-03-11 Thread Jose Marinho
The ESRT is initialised during efi_init_objlist after efi_initialize_system_table(). The ESRT is recreated from scratch at the following events: - successful UpdateCapsule; - FMP instance install. The code ensures that every ESRT entry has a unique fw_class value. Limitations: - The ESRT is not

[PATCH 3/4 v7] efi: ESRT creation tests

2021-03-11 Thread Jose Marinho
This commmit exercises the ESRT creation in a EFI selftest. A fake FMP, with TEST_ESRT_NUM_ENTRIES FW images, is installed in the system leading to the corresponding ESRT entries being populated. The ESRT entries are checked against the datastructure used to initialize the FMP. Invocation fro

[PATCH 2/4 v7] cmd: efi: ESRT table debug print

2021-03-11 Thread Jose Marinho
This commit enables the ESRT printing from the u-boot shell by invoking: - efidebug capsule esrt CC: Heinrich Schuchardt CC: Sughosh Ganu CC: AKASHI Takahiro CC: Ilias Apalodimas CC: Andre Przywara CC: Alexander Graf CC: n...@arm.com Signed-off-by: Jose Marinho --- cmd/efidebug.c | 84 +++

[PATCH 4/4 v7] Test the ESRT creation within an existing pytest.

2021-03-11 Thread Jose Marinho
This commit slightly extends test_efi_capsule_fw3. In order to run the test the following must be added to sandbox_defconfig: +CONFIG_CMD_SF=y +CONFIG_CMD_MEMORY=y +CONFIG_CMD_FAT=y +CONFIG_DFU=y The ESRT is printed in the u-boot shell by calling efidebug esrt. The test ensures that,

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
> I am not referring to efidebug. > > The user can update EFI variables with any binary content using an EFI binary > or OS functions. > > E.g. copy a binary file to the efi variables file system in Linux. Right, I was mostly thinking SetVariable which still goes through u-boot. Copying an ent

[PATCH 0/7] Add FU740 chip and HiFive Unmatched board support

2021-03-11 Thread Green Wan
This patch set is to add SiFive fu740 chip and HiFive Unmatched board support. Patches are split into several parts: - [PATCH 1/7] dts for fu740 - [PATCH 2/7] support for fu740 cpu - [PATCH 3/7, 4/7] support for fu740 clk and ram - [PATCH 5/7] add pcie driver - [PATCH 6/7] add unmatched

[PATCH 2/7] riscv: cpu: fu740: Add support for cpu fu740

2021-03-11 Thread Green Wan
Add SiFive fu740 cpu to support RISC-V arch Signed-off-by: Green Wan --- arch/riscv/Kconfig| 8 + arch/riscv/cpu/fu740/Kconfig | 37 + arch/riscv/cpu/fu740/Makefile | 12 +++ arch/riscv/cpu/fu740/cache.c |

[PATCH 1/7] riscv: dts: add fu740 support

2021-03-11 Thread Green Wan
Add dts support for fu740 Signed-off-by: Green Wan --- arch/riscv/dts/Makefile | 1 + arch/riscv/dts/fu740-c000-u-boot.dtsi | 105 arch/riscv/dts/fu740-c000.dtsi| 329 ++ include/dt-bindings/clock/sifive-fu740-prci.

[PATCH 4/7] drivers: ram: add fu740 support

2021-03-11 Thread Green Wan
Add fu740 support for ram. Signed-off-by: Green Wan --- drivers/ram/sifive/Kconfig | 8 +- drivers/ram/sifive/Makefile | 2 +- drivers/ram/sifive/sifive_ddr.c | 410 3 files changed, 415 insertions(+), 5 deletions(-) create mode 100644 drive

[PATCH 5/7] drivers: pci: add pcie support for fu740

2021-03-11 Thread Green Wan
Add pcie driver for SiFive fu740, the driver depends on fu740 gpio, clk and reset driver to do init. Force running at Gen1 for better capatible enumeration. Several devices are tested: a) M.2 NVMe SSD b) USB-to-PCI adapter c) Ethernet adapter (E1000 compatible) Signed-off-by: Green Wan --- driv

[PATCH 3/7] drivers: clk: add fu740 support

2021-03-11 Thread Green Wan
Add fu740 support. One abstract layer is added for supporting multiple chips such as fu540 and fu740. Signed-off-by: Green Wan --- drivers/clk/sifive/Kconfig | 8 +- drivers/clk/sifive/Makefile | 4 +- drivers/clk/sifive/fu540-prci.c | 769 ++-

[PATCH 6/7] board: sifive: add HiFive Unmatched board support

2021-03-11 Thread Green Wan
Add dts, defconfig and board support for HiFive Unmatched. Signed-off-by: Green Wan --- arch/riscv/dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 arch/riscv/dts/hifive-unmatched-a00-u-boot.dtsi| 40 + arch/riscv/dts/hifive-unmatched-a00.dts| 263 boa

[PATCH 7/7] drivers: net: macb: add fu740 support

2021-03-11 Thread Green Wan
Add fu740 support to macb ethernet driver Signed-off-by: Green Wan --- drivers/net/macb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 57ea45e..df65d82 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -592,7 +

Re: [PATCH 1/7] riscv: dts: add fu740 support

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > Add dts support for fu740 The commit summary should mention both fu740 and HiFive Unmatched > > Signed-off-by: Green Wan > --- > arch/riscv/dts/Makefile | 1 + > arch/riscv/dts/fu740-c000-u-boot.dtsi | 105 +++

Re: [PATCH 2/7] riscv: cpu: fu740: Add support for cpu fu740

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > Add SiFive fu740 cpu to support RISC-V arch > > Signed-off-by: Green Wan > --- > arch/riscv/Kconfig| 8 + > arch/riscv/cpu/fu740/Kconfig | 37 + > arch/riscv/cpu/fu740/Makefile

Re: [PATCH 4/7] drivers: ram: add fu740 support

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > Add fu740 support for ram. > > Signed-off-by: Green Wan > --- > drivers/ram/sifive/Kconfig | 8 +- > drivers/ram/sifive/Makefile | 2 +- > drivers/ram/sifive/sifive_ddr.c | 410 > > 3 file

Re: [PATCH 5/7] drivers: pci: add pcie support for fu740

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > Add pcie driver for SiFive fu740, the driver depends on > fu740 gpio, clk and reset driver to do init. Force running at Gen1 > for better capatible enumeration. > > Several devices are tested: > a) M.2 NVMe SSD > b) USB-to-PCI adapter > c) Ether

Re: [PATCH 6/7] board: sifive: add HiFive Unmatched board support

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > Add dts, defconfig and board support for HiFive Unmatched. > > Signed-off-by: Green Wan > --- > arch/riscv/dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 > > arch/riscv/dts/hifive-unmatched-a00-u-boot.dtsi| 40 + >

Re: [PATCH 7/7] drivers: net: macb: add fu740 support

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > Add fu740 support to macb ethernet driver > > Signed-off-by: Green Wan > --- > drivers/net/macb.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 57ea45e..df65d82

Re: [PATCH 5/7] drivers: pci: add pcie support for fu740

2021-03-11 Thread Green Wan
Bin Meng 於 2021年3月11日 週四,下午10:14寫道: > On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > > > Add pcie driver for SiFive fu740, the driver depends on > > fu740 gpio, clk and reset driver to do init. Force running at Gen1 > > for better capatible enumeration. > > > > Several devices are tested: >

Re: [PULL] u-boot-usb/master

2021-03-11 Thread Tom Rini
On Wed, Mar 10, 2021 at 12:58:47PM +0100, Marek Vasut wrote: > The following changes since commit b764bf21e60901133fd5eec6a003409c581dd519: > > Merge https://source.denx.de/u-boot/custodians/u-boot-x86 (2021-03-09 > 07:21:51 -0500) > > are available in the Git repository at: > > git://sourc

Re: [PATCH 5/7] drivers: pci: add pcie support for fu740

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 10:25 PM Green Wan wrote: > > > > Bin Meng 於 2021年3月11日 週四,下午10:14寫道: >> >> On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: >> > >> > Add pcie driver for SiFive fu740, the driver depends on >> > fu740 gpio, clk and reset driver to do init. Force running at Gen1 >> > for b

Re: [PATCH 7/7] drivers: net: macb: add fu740 support

2021-03-11 Thread Green Wan
Bin Meng 於 2021年3月11日 週四,下午10:22寫道: > On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: > > > > Add fu740 support to macb ethernet driver > > > > Signed-off-by: Green Wan > > --- > > drivers/net/macb.c | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/

Re: [PATCH 7/7] drivers: net: macb: add fu740 support

2021-03-11 Thread Bin Meng
On Thu, Mar 11, 2021 at 10:42 PM Green Wan wrote: > > > > Bin Meng 於 2021年3月11日 週四,下午10:22寫道: >> >> On Thu, Mar 11, 2021 at 9:50 PM Green Wan wrote: >> > >> > Add fu740 support to macb ethernet driver >> > >> > Signed-off-by: Green Wan >> > --- >> > drivers/net/macb.c | 8 +++- >> > 1 file

Re: [PATCH] board: stm32mp1: use CONFIG_SYS_MMC_ENV_DEV when available

2021-03-11 Thread Patrice CHOTARD
Hi Patrick On 3/1/21 1:17 PM, Patrick Delaunay wrote: > Check whether user has explicitly defined the mmc device to use > in mmc_get_env_dev() with CONFIG_SYS_MMC_ENV_DEV. > > On STMicroelectronics boards the used mmc device for environment is > the instance of boot device provided by the ROM cod

[PATCH v1] imx: bootaux fix elf loading

2021-03-11 Thread Max Krummenacher
This reverts the arch/arm/mach-imx/imx_bootaux.c changes of commit 805b3cac1e0c. The loader function name was changed so that it does not clash with the generically available function in lib/elf.c. imx-bootaux loads an elf file linked for an auxilary core. Thus the loader function requires address

[PATCH u-boot-marvell RESEND] ddr: marvell: a38x: Add more space for additional info from SPD

2021-03-11 Thread Marek Behún
From: Sujeet Baranwal commit 258be123226f8f5cd516b7813fe201fb7d7416e9 upstream. At this moment, only page 0 of SPD is being read but to support smbios, we need to read page 1 also which has more info. In order to do that, we need to allocate more space. Signed-off-by: Sujeet Baranwal Tested-by

Re: [PATCH u-boot 18/39] build: LTO: move platform libs into --start-group list

2021-03-11 Thread Marek Behun
On Tue, 9 Mar 2021 23:24:01 +0800 Bin Meng wrote: > On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > > > When building with LTO, move $(PLATFORM_LIBS) into the --start-group / > > --end-group list. > > This should be --whole-archive > > > Otherwise some functions declared in assembly m

[PATCH 0/4] Updates for Toradex boards

2021-03-11 Thread Oleksandr Suvorov
This patchset includes fixes and improvements for Toradex boards. Igor Opaniuk (1): colibri_imx6: adjust boot order Oleksandr Suvorov (2): apalis/colibri_imx6: remove video= settings board: toradex: apalis-imx8x: fix build instructions Philippe Schenker (1): colibri_imx6ull/imx7: add

[PATCH 1/4] colibri_imx6: adjust boot order

2021-03-11 Thread Oleksandr Suvorov
From: Igor Opaniuk Remove duplicate of mmc0, set this boot order: 1) SD 2) eMMC 3) USB 4) DHCP boot Fixes: 0e15165bc4e0 ("colibri_imx6: boot env configuration updates") Signed-off-by: Igor Opaniuk Signed-off-by: Oleksandr Suvorov --- include/configs/colibri_imx6.h | 1 - 1 file changed, 1 de

[PATCH 2/4] colibri_imx6ull/imx7: add missing tdxargs variable

2021-03-11 Thread Oleksandr Suvorov
From: Philippe Schenker All the other boards have tdxargs specified for setting manual kernel command-line arguments. Add them also to NAND-based boards. Signed-off-by: Philippe Schenker Signed-off-by: Oleksandr Suvorov --- include/configs/colibri-imx6ull.h | 2 +- include/configs/colibri_im

[PATCH 3/4] apalis/colibri_imx6: remove video= settings

2021-03-11 Thread Oleksandr Suvorov
Since Toradex provides the full set of overlays for Linux kernel for display interfaces for both Apalis iMX6Q and Colibri iMX6DL modules, the video= settings are obsolete. Remove them. Signed-off-by: Oleksandr Suvorov --- include/configs/apalis_imx6.h | 5 + include/configs/colibri_imx6.h

[PATCH 4/4] board: toradex: apalis-imx8x: fix build instructions

2021-03-11 Thread Oleksandr Suvorov
Fix an URL for downloading the SCFW binary for an Apalis iMX8X and improve u-boot image build instructions. Signed-off-by: Oleksandr Suvorov --- doc/board/toradex/apalix-imx8x.rst | 33 -- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/doc/board/tora

Re: [PATCH v1] imx: bootaux fix elf loading

2021-03-11 Thread Oleksandr Suvorov
On Thu, Mar 11, 2021 at 7:18 PM Max Krummenacher wrote: > > This reverts the arch/arm/mach-imx/imx_bootaux.c changes of commit > 805b3cac1e0c. The loader function name was changed so that it does > not clash with the generically available function in lib/elf.c. > > imx-bootaux loads an elf file li

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Heinrich Schuchardt
On 3/11/21 2:31 PM, Ilias Apalodimas wrote: I am not referring to efidebug. The user can update EFI variables with any binary content using an EFI binary or OS functions. E.g. copy a binary file to the efi variables file system in Linux. Right, I was mostly thinking SetVariable which still g

[PATCH 1/6] spl: LOAD_FIT_FULL: Fix selection of the "fdt" node

2021-03-11 Thread Alexandru Gagniuc
The correct FDT to use is described by the "fdt" property of the configuration node. When the fit_unamep argument to fit_image_load() is "fdt", we get the "/images/fdt" node. This is incorrect, as it ignores the "fdt" property of the config node, and in most cases, the "/images/fdt" node doesn't ex

[PATCH 0/6] SPL: FIT: Fix some omissions of SPL_LOAD_FIT_FULL and bootm

2021-03-11 Thread Alexandru Gagniuc
Although this series focuses on SPL_LOAD_FIT_FULL, some of the fixes will also apply to bootm, as they are sharing significant amounts of code. Originally SPL_LOAD_FIT_FULL could not start either a linux FIT or a u-boot image. It didn't even take FIT images generated automatically by mkimage, as p

[PATCH 2/6] spl: LOAD_FIT_FULL: Do not hard-code os to IH_OS_U_BOOT

2021-03-11 Thread Alexandru Gagniuc
The information on the OS should be contained in the FIT, as the self-explanatory "os" property of a node under /images. Hard-coding this to U_BOOT might send us down the wrong path later in the boot process. Signed-off-by: Alexandru Gagniuc --- common/spl/spl.c | 5 +++-- 1 file changed, 3 inse

[PATCH 6/6] image-fit: Accept OP-TEE images when booting a FIT

2021-03-11 Thread Alexandru Gagniuc
OP-TEE images are normally packaged with type = "tee; os = "tee"; However, fit_image_load() thinks that is somehow invalid. however if they were declared as type = "kernel", os = "linux", fit_image_load() would happily accept them and allow the boot to continue. There is no technic

[PATCH 4/6] spl: LOAD_FIT_FULL: Support 'kernel' and 'firmware' properties

2021-03-11 Thread Alexandru Gagniuc
The 'firmware' property of a config node takes precedence over the 'kernel' property. 'standalone' is deprecated. However, give users a couple of releases where 'standalone' still works, but warns loudly. Signed-off-by: Alexandru Gagniuc --- common/spl/spl.c | 19 ++- 1 file chan

[PATCH 3/6] spl: LOAD_FIT_FULL: Relocate FDT for u-boot payloads

2021-03-11 Thread Alexandru Gagniuc
U-Boot expects the FDT to be located right after the _end linker symbol (see fdtdec.c: board_fdt_blob_setup()) The "basic" LOAD_FIT path is aware of this limitation, and relocates the FDT at the expected location. Guessing the expected location probably only works reliably on 32-bit arm, and it fe

[PATCH 5/6] image-fit: Accept IH_TYPE_FIRMWARE in fit_image_load() as valid

2021-03-11 Thread Alexandru Gagniuc
Consider the following FIT: images { whipple {}; }; configurations { conf-1 { firmware = "whipple"; }; }; Getting the 'firmware' image with fit_image_load() is not possible, as it doesn't under

[PATCH] net: gem: Fix setting PCS auto-negotiation state

2021-03-11 Thread Robert Hancock
The code was trying to disable PCS auto-negotiation when a fixed-link node is present and enable it otherwise. However, the PCS registers were being written before the PCSSEL bit was set in the network configuration register, and it appears that in this state, PCS register writes are ignored. The r

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread AKASHI Takahiro
Ilias, I may have missed your past discussions, but any way, On Thu, Mar 11, 2021 at 01:36:04PM +0200, Ilias Apalodimas wrote: > Hi Heinrich > > [...] > > > >>> + * @load_option: device paths to search > > >>> + * @size: size of the discovered device path > > >>> + * @guid: guid to

Re: [PATCH 3/4] net: mdio: teach dm_eth_phy_connect to connect to fixed PHY

2021-03-11 Thread Bin Meng
Hi Vladimir, On Wed, Feb 17, 2021 at 6:48 AM Vladimir Oltean wrote: > > From: Vladimir Oltean > > It would be desirable for top-level callers of PHYLIB to deal with as > little complexity as possible, and when they call dm_eth_phy_connect, > they get a struct phy_device that "just works". > > Th

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
Akashi-san, On Fri, Mar 12, 2021 at 11:50:32AM +0900, AKASHI Takahiro wrote: > Ilias, > > I may have missed your past discussions, but any way, It's on the boot-architecture mailing list [1] > > On Thu, Mar 11, 2021 at 01:36:04PM +0200, Ilias Apalodimas wrote: > > > [...] > > > My underst

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread AKASHI Takahiro
On Fri, Mar 12, 2021 at 06:10:29AM +0200, Ilias Apalodimas wrote: > Akashi-san, > > On Fri, Mar 12, 2021 at 11:50:32AM +0900, AKASHI Takahiro wrote: > > Ilias, > > > > I may have missed your past discussions, but any way, > > It's on the boot-architecture mailing list [1] > > > > > On Thu, M

Re: [PATCH 2/6] efi_loader: Add device path related functions for initrd via Boot####

2021-03-11 Thread Ilias Apalodimas
On Fri, Mar 12, 2021 at 01:32:50PM +0900, AKASHI Takahiro wrote: [...] > > > > > My understanding is that we have: > > > > > > > > > > kernel path,end(0xff), > > > > > VenMedia(), /* no end node here */ > > > > > initrd1, end(0x01), > > > > > initrd2, end(0xff) > > > > > > > > No, the structure i

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread AKASHI Takahiro
Ilias, Sorry, but I will have to repeat my question for better understandings. On Sat, Mar 06, 2021 at 12:23:01AM +0200, Ilias Apalodimas wrote: > The UEFI spec allow a packed array of UEFI device paths in the > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > describe the loaded

Re: [PATCH v2 2/5] sysinfo: Provide some global/default IDs

2021-03-11 Thread Simon Glass
On Fri, 5 Mar 2021 at 13:12, Sean Anderson wrote: > > This adds an ID for a board revision. Existing IDs have been moved above > SYSINFO_ID_END to allow for future expansion. > > Signed-off-by: Sean Anderson > --- > > Changes in v2: > - Set BOARD_HWVERSION to SYSINFO_ID_REVISION, as they represen

Re: [PATCH v2 3/5] sysinfo: Require that sysinfo_detect be called before other methods

2021-03-11 Thread Simon Glass
On Fri, 5 Mar 2021 at 13:12, Sean Anderson wrote: > > This has the uclass enforce calling detect() before other methods. This > allows drivers to cache information in detect() and perform (cheaper) > retrieval in the other accessors. This also modifies the only instance > where this sequencing wa

Re: [PATCH v6 1/4] x86: qemu: move QFW to its own uclass

2021-03-11 Thread Simon Glass
On Sat, 6 Mar 2021 at 21:01, Asherah Connor wrote: > > We move qfw into its own uclass and split the PIO functions into a > specific driver for that uclass. The PIO driver is selected in the > qemu-x86 board config (this covers x86 and x86_64). > > include/qfw.h is cleaned up and documentation ad

Re: [PATCH v6 4/4] qemu: arm: select QFW, MMIO on qemu-arm

2021-03-11 Thread Simon Glass
On Sat, 6 Mar 2021 at 21:01, Asherah Connor wrote: > > Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and > arm64). > > Signed-off-by: Asherah Connor > > --- > > (no changes since v5) > > Changes in v5: > * Split adding MMIO driver to QEMU arm/64 into own commit. > * Use the generi

Re: [PATCH] cmd: part: number: remove inconsistent 0x from returned value

2021-03-11 Thread Simon Glass
Hi Stefan, On Mon, 8 Mar 2021 at 03:45, Stefan Herbrechtsmeier wrote: > > Hi, > > Am 06.03.2021 um 21:12 schrieb Tom Rini: > > On Fri, Mar 05, 2021 at 07:35:24AM -0700, Simon Glass wrote: > >> Hi, > >> > >> On Fri, 5 Mar 2021 at 07:33, Stefan Herbrechtsmeier > >> wrote: > >>> > >>> Hi Eugeniu, >

Re: [PATCH u-boot] api: fix a potential serious bug caused by undef CONFIG_SYS_64BIT_LBA

2021-03-11 Thread Simon Glass
On Sat, 6 Mar 2021 at 15:43, Marek Behún wrote: > > The api_public.h header file undefined macro CONFIG_SYS_64BIT_LBA. > > But api/api_storage.c includes this header before including part.h, > causing the type of lbaint_t and subsequently the type signature of > blk_dread() and blk_dwrite() functi

Re: [RFC PATCH u-boot 02/12] sandbox: errno: avoid conflict with libc's errno

2021-03-11 Thread Simon Glass
On Tue, 2 Mar 2021 at 21:12, Marek Behún wrote: > > When building with LTO, the system libc's `errno` variable used in > arch/sandbox/cpu/os.c conflicts with U-Boot's `errno` (defined in > lib/errno.c) with the following error: > .../ld: errno@@GLIBC_PRIVATE: TLS definition in /lib64/libc.so.6 >

Re: [PATCH v4 4/5] test: scmi: add local variables for scmi agent reference

2021-03-11 Thread Simon Glass
On Mon, 8 Mar 2021 at 14:38, Etienne Carriere wrote: > > Add local variables agent0/agent1 to refer to SCMI sandbox context > agent and ease readability of the test. > > For consistency, rename regul_dev to regul0_dev and remove sandbox_voltd > in dm_test_scmi_voltage_domains(). > > Signed-off-by:

Re: [PATCH v4 5/5] regulator: scmi: fix header file inclusion order

2021-03-11 Thread Simon Glass
On Mon, 8 Mar 2021 at 14:38, Etienne Carriere wrote: > > Fix header file inclusion order in SCMI regulators driver. > > Signed-off-by: Etienne Carriere > --- > Changes in v4 > - new change added to the series. > --- > drivers/firmware/scmi/scmi_agent-uclass.c | 3 +-- > 1 file changed, 1 inserti

Re: [PATCH 1/2] terminal: correct stdio_dev invocations

2021-03-11 Thread Simon Glass
On Wed, 10 Mar 2021 at 04:39, Asherah Connor wrote: > > stdio_dev methods have taken a pointer to themselves since 709ea543 > (nearly 7 years ago). > > Signed-off-by: Asherah Connor > --- > > cmd/terminal.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Simon

Re: [PATCH 01/16] dm: core: Add helper to compare node names

2021-03-11 Thread Simon Glass
Hi Kishon, On Tue, 9 Mar 2021 at 05:27, Kishon Vijay Abraham I wrote: > > Add helper to compare node names. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/core/ofnode.c | 13 + > include/dm/ofnode.h | 9 + > 2 files changed, 22 insertions(+) > > diff --git a/dr

Re: [PATCH 02/16] drivers: reset: Handle gracefully NULL pointers

2021-03-11 Thread Simon Glass
Hi Kishon, On Tue, 9 Mar 2021 at 05:27, Kishon Vijay Abraham I wrote: > > From: Jean-Jacques Hiblot > > Prepare the way for a managed reset API by handling NULL pointers without > crashing nor failing. > > Signed-off-by: Jean-Jacques Hiblot > Signed-off-by: Vignesh Raghavendra > Signed-off-by:

Re: [PATCH 2/2] terminal: only serial_reinit_all if available

2021-03-11 Thread Simon Glass
On Wed, 10 Mar 2021 at 04:39, Asherah Connor wrote: > > serial_reinit_all() is only available if CONFIG_SERIAL is defined (i.e. > !CONFIG_DM_SERIAL). > > Signed-off-by: Asherah Connor > > --- > > cmd/terminal.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCHv5 0/6] SCP03 control, documentation and tests.

2021-03-11 Thread Simon Glass
Hi Foundries, On Wed, 10 Mar 2021 at 09:59, Jorge Ramirez-Ortiz, Foundries wrote: > > On 14/02/21, Jorge Ramirez-Ortiz wrote: > > Simply adding the reviewed-by tags to the v5 series. > > why has this not been merged yet? You can check in patchwork to see whose queue it is in. Regards, Simon

Re: [PATCH v2] tee: optee: Change printing during optee_probe

2021-03-11 Thread Simon Glass
Hi Ilias, On Wed, 10 Mar 2021 at 06:35, Ilias Apalodimas wrote: > > Right now the error messages when optee has a version mismatch or shared > memory is not configured are done with a debug(). > That's not very convenient since you have to enable debugging to figure > out what's going on, althoug

Re: [PATCH v6 3/4] qemu: add MMIO driver for QFW

2021-03-11 Thread Simon Glass
On Sat, 6 Mar 2021 at 21:01, Asherah Connor wrote: > > Add MMIO driver for QFW. > > Note that there is no consumer as of this patch. > > Signed-off-by: Asherah Connor > --- > > (no changes since v5) > > Changes in v5: > * Split MMIO driver into its own commit. > * Add CONFIG_QFW_MMIO for selectio

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Ilias Apalodimas
Akashi-san > > [...] > > +/** > > + * add_initrd_instance() - Append a device path to load_options pointing > > to an > > + *inirtd > > + if (!initrd_dp) { > > + printf("Cannot append media vendor device path path\n"); > > + goto out; > > + } > > +

  1   2   >