On Tue, 9 Mar 2021 21:00:00 +0800 Bin Meng <bmeng...@gmail.com> wrote:
> > --start-group is useless now. > > > $(u-boot-main) > > \ > > - --end-group > > \ > > + --no-whole-archive --end-group > > \ > > and --end-group > I will test this > > - rm -f $@; $(AR) rcs$(KBUILD_ARFLAGS) $@) > > + rm -f $@; $(AR) cDPrsT $@ $(filter $(obj-y), $^), \ > > + rm -f $@; $(AR) cPrsT$(KBUILD_ARFLAGS) $@) > > nits: should we use D for the empty one for consistency? OK > > > > $(builtin-target): $(obj-y) FORCE > > $(call if_changed,link_o_target) > > @@ -362,7 +361,7 @@ $(modorder-target): $(subdir-ym) FORCE > > # > > ifdef lib-target > > quiet_cmd_link_l_target = AR $@ > > -cmd_link_l_target = rm -f $@; $(AR) rcs$(KBUILD_ARFLAGS) $@ $(lib-y) > > +cmd_link_l_target = rm -f $@; $(AR) cPrs$(KBUILD_ARFLAGS) $@ $(lib-y) > > It looks this line change is not needed Hmm. I will look into this, maybe I added it just for consistency. > Otherwise LGTM: > Reviewed-by: Bin Meng <bmeng...@gmail.com> THX
