Re: [PATCH v3 01/11] tpm: Don't include cr50 in TPL/SPL

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:25:57AM -0700, Simon Glass wrote: > At present the security chip is not used in these U-Boot phases. Update > the Makefile to exclude it. > > Fix a few logging statements while we are here. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/t

Re: [PATCH v3 02/11] tpm: Use logging in the uclass

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:25:58AM -0700, Simon Glass wrote: > Update this to use log_debug() instead of the old debug(). > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/tpm/tpm-uclass.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v3 03/11] tpm: Add debugging of request in tpm_sendrecv_command()

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:25:59AM -0700, Simon Glass wrote: > The response is shown but not the request. Update the code to show both > if debugging is enabled. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > lib/tpm-common.c | 11 --- > 1 file changed, 8 insertions

Re: [PATCH v3 04/11] tpm: Add an API that can support v1.2 and v2

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:00AM -0700, Simon Glass wrote: > There are two different TPM standards. U-Boot supports both but each has > its own set of functions. We really need a single TPM API that can call > one or the other. This is not always possible as there are some > differences between t

Re: [PATCH v3 05/11] tpm: Switch TPMv1 over to use the new API

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:01AM -0700, Simon Glass wrote: > Take over the plain 'tpm_...' functions for use by the new TPM API. Rename > all the TPMv1 functions so they are called from the API. > > Update the TPMv1 functions so that they are called from the API. Change > existing users to use t

Re: [PATCH v3 06/11] tpm: Add a basic API implementation for TPMv2

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:02AM -0700, Simon Glass wrote: > Add support for TPMv2 versions of API functions. So far this is not > complete as the standard is quite large, but it implements everything > currently available for TPMv2 in U-Boot. > > Signed-off-by: Simon Glass > --- > > (no chang

Re: [PATCH v3 07/11] tpm: Reduce duplication in a few functions

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:03AM -0700, Simon Glass wrote: > Update tpm2_clear() and tpm2_pcr_extend() so that the command size > is not repeated twice. Add a small comment to the latter. > > Signed-off-by: Simon Glass > --- > > (no changes since v2) > > Changes in v2: > - Add comments for th

Re: [PATCH v3 08/11] tpm: Add an implementation of define_space

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:04AM -0700, Simon Glass wrote: > Add support for this so that the TPM can be set up for use with > Chromium OS verified boot. > > Signed-off-by: Simon Glass > --- [...] > + /* > + * Fill the command structure starting from the first buffer: > + *

Re: [PATCH v3 09/11] tpm: Add TPM2 support for read/write values

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:05AM -0700, Simon Glass wrote: > Implement this API function for TPM2. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > include/tpm-common.h | 3 ++ > include/tpm-v2.h | 38 > lib/tpm-v2.c | 84 ++

Re: [PATCH v3 10/11] tpm: Add TPM2 support for write_lock

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:06AM -0700, Simon Glass wrote: > Implement this API function for TPM2. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > include/tpm-v2.h | 12 > lib/tpm-v2.c | 23 +++ > lib/tpm_api.c| 2 +- > 3 files cha

Re: [PATCH v3 11/11] tpm: Allow disabling platform hierarchy with TPM2

2021-01-25 Thread Ilias Apalodimas
On Sat, Jan 23, 2021 at 10:26:07AM -0700, Simon Glass wrote: > With TPM2 we don't actually lock the TPM once verified boot is finished. > Instead we disable the platform hierarchy which serves the same purpose. > Add an implementation of this so we can safely boot into the kernel. > > Signed-off-b

Re: [PATCH v2 1/3] mem: spi-mem: add declaration for spi_mem_default_supports_op

2021-01-25 Thread Pratyush Yadav
On 25/01/21 03:55AM, Mathew McBride wrote: > spi_mem_default_supports_op is used internally by controller > drivers to verify operation semantics are correct. > > It is used internally inside spi-mem but has not (in U-Boot) > been declared in spi-mem.h for external use. > > Signed-off-by: Mathew

Re: [RFC PATCH v2 1/2] optee: obtain emmc rpmb info from dt

2021-01-25 Thread Jens Wiklander
Hi Igor, On Sun, Jan 24, 2021 at 11:39:45AM +0200, Igor Opaniuk wrote: > From: Igor Opaniuk > > Add support for rpmb-dev property in optee node. > Prioritize that provided eMMC info from DT for RPMB operations over > the one provided by OP-TEE OS core in RPC calls. > > Signed-off-by: Igor Opani

Re: [PATCH v3 01/20] mmc: sdhci: Add helper functions for UHS modes

2021-01-25 Thread Aswath Govindraju
Hi Simon, On 24/01/21 7:33 am, Simon Glass wrote: > Hi Aswath, > > On Thu, 21 Jan 2021 at 05:41, Aswath Govindraju wrote: >> >> From: Faiz Abbas >> >> Add a set_voltage() function which handles the switch from 3.3V to 1.8V >> for SD card UHS modes. >> >> Signed-off-by: Faiz Abbas >> Signed-off

RE: IMX8MM SD UHS support

2021-01-25 Thread Bough Chen
Hi Tim and Andrey, I find the root cause, it is because during the 1.8v voltage switch process, SD clock do not gate off/ on according to the SD spec. For i.MX usdhc, if want to gate off the sd card clock, need to clear the bit 8 of VEND_SPEC, and set this bit to gate on the sd card clock. For t

[PATCH 1/1] avb: AVB_VERIFY depends on MMC

2021-01-25 Thread Heinrich Schuchardt
AVB Verified Boot uses functions related to MMC. Signed-off-by: Heinrich Schuchardt --- common/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/Kconfig b/common/Kconfig index d8982ba377..be4dd815c0 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -561,6 +561,7 @@ config HASH

Re: [PATCH 1/1] avb: AVB_VERIFY depends on MMC

2021-01-25 Thread Igor Opaniuk
Hi Heinrich, On Mon, Jan 25, 2021 at 1:18 PM Heinrich Schuchardt wrote: > > AVB Verified Boot uses functions related to MMC. > > Signed-off-by: Heinrich Schuchardt > --- > common/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/Kconfig b/common/Kconfig > index d8982ba377.

Re: [RFC PATCH v2 1/2] optee: obtain emmc rpmb info from dt

2021-01-25 Thread Igor Opaniuk
Hi Jens, On Mon, Jan 25, 2021 at 10:50 AM Jens Wiklander wrote: > > Hi Igor, > > On Sun, Jan 24, 2021 at 11:39:45AM +0200, Igor Opaniuk wrote: > > From: Igor Opaniuk > > > > Add support for rpmb-dev property in optee node. > > Prioritize that provided eMMC info from DT for RPMB operations over >

[PATCH 0/2] disk: part: sandbox support in dev_print()

2021-01-25 Thread Heinrich Schuchardt
Without the series the fatinfo command shows an error for host file backed block devices: => host bind 0 ../sandbox.img => fatinfo host 0:1 Interface: Unknown Device 0: Unhandled device type: 9 Filesystem: FAT16 "NO NAME" => With the series reasonable information is

[PATCH 2/2] disk: part: sandbox support in dev_print()

2021-01-25 Thread Heinrich Schuchardt
Commands like 'fatinfo' call dev_print() to print device information. If the block device is created via 'host bind', we should print accurate information. Signed-off-by: Heinrich Schuchardt --- disk/part.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disk/part.c b/disk/part.c index b69fd

[PATCH 1/2] sandbox: fill block device meta information

2021-01-25 Thread Heinrich Schuchardt
Provide information about host backed block device. Mark the device created by 'host bind' as removable. Signed-off-by: Heinrich Schuchardt --- drivers/block/sandbox.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/block/sandbox.c b/drivers/block/sandbox.c index 34c26c

Pull request for documentation tag doc-2021-04-rc1-2

2021-01-25 Thread Heinrich Schuchardt
The following changes since commit 69d29fe1c0aeb33f42633a7d30b7921c02aa: Merge tag 'efi-2021-04-rc1-3' of https://gitlab.denx.de/u-boot/custodians/u-boot-efi (2021-01-23 19:07:00 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/

Re: [RFC PATCH v2 1/2] optee: obtain emmc rpmb info from dt

2021-01-25 Thread Jens Wiklander
On Mon, Jan 25, 2021 at 12:50 PM Igor Opaniuk wrote: > > Hi Jens, > > On Mon, Jan 25, 2021 at 10:50 AM Jens Wiklander > wrote: > > > > Hi Igor, > > > > On Sun, Jan 24, 2021 at 11:39:45AM +0200, Igor Opaniuk wrote: > > > From: Igor Opaniuk > > > > > > Add support for rpmb-dev property in optee no

[PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver

2021-01-25 Thread Vladimir Oltean
From: Vladimir Oltean DSA stands for Distributed Switch Architecture and it is a subsystem introduced in the Linux kernel to support switches that: - have an Ethernet link up to the CPU - use some form of tagging to identify the source/destination port for Rx/Tx - may be cascaded in tree-like s

[PATCH v4 1/7] net: phy: fixed: support speeds of 2500 and 10000

2021-01-25 Thread Vladimir Oltean
From: Vladimir Oltean Unlike the Linux fixed PHY driver, the one in U-Boot does not attempt to emulate the clause 22 register set of a gigabit copper PHY driver through the swphy framework. Therefore, the limitation of being unable to support speeds higher than gigabit in fixed-link does not appl

[PATCH v4 2/7] net: phy: introduce fixed_phy_create for DSA CPU ports

2021-01-25 Thread Vladimir Oltean
From: Vladimir Oltean The DSA (Distributed Switch Architecture) implementation has made a design decision when it got introduced to the Linux kernel in 2008. That was to hide away from the user the CPU-facing Ethernet MAC, since it does not make sense to register it as a struct net_device (UCLASS

[PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test

2021-01-25 Thread Vladimir Oltean
From: Claudiu Manoil The DSA sandbox driver is used for unit testing the DSA class code. It implements a simple 2 port switch plus 1 CPU port, and uses a very simple tag to identify the ports. The DSA sandbox device is connected via CPU port to a regular Ethernet sandbox device, called 'dsa-test-

[PATCH v4 3/7] net: Introduce DSA class for Ethernet switches

2021-01-25 Thread Vladimir Oltean
From: Claudiu Manoil DSA stands for Distributed Switch Architecture and it covers switches that are connected to the CPU through an Ethernet link and generally use frame tags to pass information about the source/destination ports to/from CPU. Front panel ports are presented as regular ethernet de

[PATCH v4 5/7] drivers: net: Add Felix DSA switch driver

2021-01-25 Thread Vladimir Oltean
From: Alex Marginean This driver is used for the Ethernet switch integrated into LS1028A NXP. Felix on LS1028A has 4 front panel ports and two internal ports, I/O to/from the switch is done through an ENETC Ethernet interface. The 4 front panel ports are available as Ethernet interfaces and can b

[PATCH v4 6/7] arm: dts: ls1028a: Add Ethernet switch node and dependencies

2021-01-25 Thread Vladimir Oltean
From: Alex Marginean The definition follows the DSA binding in kernel and describes the switch, its ports and PHYs. The switch node has the same structure as in Linux and this patch enables it (and relevant ports) for the LS1028A RDB board. ENETC PF6 is the 2nd Eth controller linked to the swit

[PATCH v4 7/7] configs: ls1028a: Enable the Ethernet switch driver in defconfig

2021-01-25 Thread Vladimir Oltean
From: Alex Marginean The switch driver for LS1028A Ethernet switch is now compiled in for the NXP LS1028A reference design boards and for the Kontron SMARC-sAL28. Signed-off-by: Alex Marginean Signed-off-by: Claudiu Manoil Signed-off-by: Vladimir Oltean Acked-by: Michael Walle --- v4: enable

[PATCH v8 0/4] OP-TEE I2C trampoline and associated tests

2021-01-25 Thread Igor Opaniuk
From: Igor Opaniuk This patchset allows OP-TEE to communicate with I2C devices; a typical use case would be servicing U-Boot requests that require underlying cryptographic operations implemented by an I2C chip. On a board fitted with the NXP SE050 I2C secure element, OP-TEE can route some of the

[PATCH v8 1/4] drivers: tee: i2c trampoline driver

2021-01-25 Thread Igor Opaniuk
From: Jorge Ramirez-Ortiz This commit gives the secure world access to the I2C bus so it can communicate with I2C slaves (typically those would be secure elements like the NXP SE050). A similar service implementation has been merged in linux: c05210ab ("drivers: optee: allow op-tee to access dev

[PATCH v8 2/4] test: py: add pygit2 and pyelftools to requirements.txt

2021-01-25 Thread Igor Opaniuk
From: Igor Opaniuk Add pygit2 and pyelftools to the list of packages for virtualenv needed to run all sets of pytests.This fixes warnings like: binman.elf_test.TestElf.testDecodeElf (subunit.RemotedTestCase): Python elftools not available Signed-off-by: Igor Opaniuk Reviewed-by: Simon Glass -

[PATCH v8 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-25 Thread Igor Opaniuk
From: Igor Opaniuk This adds support for RPC test trusted application emulation, which permits to test reverse RPC calls to TEE supplicant. Currently it covers requests to the I2C bus from TEE. Signed-off-by: Igor Opaniuk Reviewed-by: Simon Glass Reviewed-by: Jens Wiklander Acked-by: Etienne

[PATCH v8 4/4] test: dm: tee: extend with RPC test

2021-01-25 Thread Igor Opaniuk
From: Igor Opaniuk Extend existing DM tee tests adding test coverage for reverse RPC calls. Currently this commit only adds tests for I2C requests from TEE driver to TEE supplicant, for instance reading/writing data to emulated i2c eeprom defines in standard sandbox test device tree (arch/sandbox

Re: [PATCH v4 6/7] arm: dts: ls1028a: Add Ethernet switch node and dependencies

2021-01-25 Thread Michael Walle
Am 2021-01-25 13:23, schrieb Vladimir Oltean: From: Alex Marginean The definition follows the DSA binding in kernel and describes the switch, its ports and PHYs. The switch node has the same structure as in Linux and this patch enables it (and relevant ports) for the LS1028A RDB board. EN

Re: [PATCH 1/5] arm: dts: r8a774a1: Import DTS queued for Linux 5.12-rc1

2021-01-25 Thread Marek Vasut
On 1/25/21 12:22 AM, Adam Ford wrote: On Sun, Jan 24, 2021 at 11:10 AM Marek Vasut wrote: On 1/13/21 12:52 AM, Adam Ford wrote: Update the RZ/G2M dtsi and r8a774a1-beacon-rzg2m-kit kit from Renesas repo destined to become 5.12-rc1. I picked a DT sync for Linux 5.10 from Biju (on CC), does y

Re: [PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver

2021-01-25 Thread Michael Walle
Am 2021-01-25 13:23, schrieb Vladimir Oltean: From: Vladimir Oltean DSA stands for Distributed Switch Architecture and it is a subsystem introduced in the Linux kernel to support switches that: - have an Ethernet link up to the CPU - use some form of tagging to identify the source/destination p

Re: [PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver

2021-01-25 Thread Vladimir Oltean
On Mon, Jan 25, 2021 at 02:02:07PM +0100, Michael Walle wrote: > Works now. Tested on Kontron sl28 var2 with two switch > ports routed to two SGMII lanes. > > Tested-by: Michael Walle [on kontron_sl28] Thanks for the patience!

[PATCH 0/1] Add flash protection support for Winbond's w25q128

2021-01-25 Thread Su Baocheng
From: Su Baocheng According to datasheets, all 3 types of w25q128 support ST Micro-like flash protection that using BP{0-2}/TB bits in status register. Su Baocheng (1): mtd: spi-nor-ids: Add support of flash protection to w25q128 drivers/mtd/spi/spi-nor-ids.c | 12 +++- 1 file chang

[PATCH 1/1] mtd: spi-nor-ids: Add support of flash protection to w25q128

2021-01-25 Thread Su Baocheng
From: Su Baocheng The NOR flash w25q128 denoted by JEDEC ID 0xef4018 actually represents various models. From Winbond's website, I could only find 3 types of them: W25Q128JV-IQ/JQ datasheet:https://www.winbond.com/resource-files/ w25q128jv%20revg%2004082019%20plus.pdf W25Q128FV (SPI

Re: [PATCH] mmc: mmc_spi: Do not drop first RX byte after CMD TX

2021-01-25 Thread Jiaxun Yang
在 2021/1/24 下午7:38, Meng, Bin 写道: It looks somehow this email did not arrive the mailing list? Yes, it is waiting list moderator for approval as it's my first mail to U-Boot list. As for the patch, U-Boot mms_spi driver does nothing wrong. The dropped byte is for Ncr as required by the sp

[PATCH V2 00/17] usb: gadget: update

2021-01-25 Thread peng . fan
From: Peng Fan V2: Fix imx6dl_mamoj size SPL exceeded issue V1: This patchset is to upstream NXP downstream gadget driver patches for feature update. Jun Li (2): usb: gadget: set correct usb_configuration for os_desc_config usb: gadget: update os_desc_config when add config Li Jun (13):

[PATCH V2 01/17] usb: gadget: Add ep_config call back to usb_gadget_ops

2021-01-25 Thread peng . fan
From: Ye Li Since some new fields in usb_ep structure been moved to usb_ss_ep. The CDNS3 gadget driver should replies on this operation to bind the usb_ss_ep with the endpoint descriptor when function layer uses usb_ep_autoconfig to add endpoint descriptors to gadget. So that CDNS3 driver can kno

[PATCH V2 02/17] usb: gadget: don't change ep name for dwc3 while ep autoconfig

2021-01-25 Thread peng . fan
From: Li Jun As the SDP protocol use the predefined ep num for communication, we can't change its name hence reset its ep num while do ep autoconfig, this is only apply for SPL. Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/epautoconf.c | 2 ++ 1 file changed, 2 inserti

[PATCH V2 03/17] usb: gadget: OS String support

2021-01-25 Thread peng . fan
From: Li Jun This is a porting patch from linux kernel: 19824d5eeece ("usb: gadget: OS String support"), original commit log see below: "There is a custom (non-USB IF) extension to the USB standard: http://msdn.microsoft.com/library/windows/hardware/gg463182 They grant permission to use the sp

[PATCH V2 04/17] usb: gadget: move utf8_to_utf16le to header file

2021-01-25 Thread peng . fan
From: Li Jun As other users may use utf8_to_utf16le() to convert the utf8 to utf16 for usb, so move it to head file. Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/usbstring.c | 74 + include/linux/utf.h| 75 +++

[PATCH V2 05/17] usb: gadget: add Kconfig for OS descriptors

2021-01-25 Thread peng . fan
From: Peng Fan Add Kconfig for OS descriptors Signed-off-by: Peng Fan --- drivers/usb/gadget/Kconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 7c0df5c264..4a3b22e6de 100644 --- a/drivers/usb/gadget/Kconfig +++ b/d

[PATCH V2 06/17] usb: gadget: OS Feature Descriptors support

2021-01-25 Thread peng . fan
From: Li Jun This is a proting patch from linux kernel: 37a3a533429e ("usb: gadget: OS Feature Descriptors support"), the original commit log see below: There is a custom (non-USB IF) extension to the USB standard: http://msdn.microsoft.com/library/windows/hardware/gg463182 They grant permissi

[PATCH V2 08/17] usb: gadget: fastboot: add ext properties for WCID

2021-01-25 Thread peng . fan
From: Li Jun Add device interface GUID for Microsoft Extended Properties Feature Descriptor. Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/f_fastboot.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/usb/gadget/f_fastboot.c

[PATCH V2 07/17] usb: gadget: add WCID support for mfgtool

2021-01-25 Thread peng . fan
From: Li Jun Enable WCID(Microsoft Compatible ID Feature Descriptor) for mfgtool. Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/composite.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/comp

[PATCH V2 09/17] usb: gadget: set correct usb_configuration for os_desc_config

2021-01-25 Thread peng . fan
From: Jun Li The current way to set cdev->os_desc_config is wrong if user restart fastboot, as the old config is not used anymore and new allocated usb_configuration will be used, so set the os_desc_config while usb_add_config. Reviewed-by: Ye Li Signed-off-by: Li Jun Signed-off-by: Peter Chen

[PATCH V2 10/17] usb: gadget: update os_desc_config when add config

2021-01-25 Thread peng . fan
From: Jun Li Always use the new added config for os_desc_config to fix cdev-> os_desc_config may miss set in case we restart usb gadget driver. Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/composite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH V2 11/17] usb: gadget: add super speed support

2021-01-25 Thread peng . fan
From: Li Jun This patch is to add usb gadget super speed support in common driver, including BOS descriptor and select the super speed descriptor from function driver. Reviewed-by: Ye Li Reviewed-by: Peter Chen Tested-by: faqiang.zhu Signed-off-by: Li Jun Signed-off-by: Peng Fan --- driver

[PATCH V2 12/17] usb: fastboot: add super speed support

2021-01-25 Thread peng . fan
From: Li Jun Add super speed EP config. Reviewed-by: Ye Li Reviewed-by: Peter Chen Tested-by: faqiang.zhu Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/f_fastboot.c | 47 ++--- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a

[PATCH V2 13/17] usb: gadget: dnl: set dnl to be super speed

2021-01-25 Thread peng . fan
From: Li Jun Set its max_speed to be super speed. Reviewed-by: Ye Li Reviewed-by: Peter Chen Tested-by: faqiang.zhu Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/g_dnl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadg

[PATCH V2 14/17] usb: composite: force gadget to be USB2 for HS only function

2021-01-25 Thread peng . fan
From: Li Jun If one of functions is not super speed capable, we need force the udc to be high speed, this is an equivalent implementation of usb_gadget_udc_set_speed() in kernel but simple, which set the gadget max_speed to be high speed, so afterwards when start gadget duc can set the HW to be U

[PATCH V2 15/17] usb: udc: ci: update speed handling

2021-01-25 Thread peng . fan
From: Li Jun Remove the gadget driver speed check, and set its max_speed to be USB_SPEED_HIGH. Reviewed-by: Ye Li Reviewed-by: Peter Chen Tested-by: faqiang.zhu Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/ci_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletion

[PATCH V2 16/17] usb: gadget: fastboot: use correct max packet size

2021-01-25 Thread peng . fan
From: Li Jun Change to use wMaxPacketSize of current speed EP desc for request length wrap up. Reviewed-by: Peter Chen Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/f_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_fa

[PATCH V2 17/17] usb: gaget: ci: set ep's desc when enable ep

2021-01-25 Thread peng . fan
From: Li Jun As we need standard usb_ep's desc, so set it when enable ep. Reviewed-by: Peter Chen Signed-off-by: Li Jun Signed-off-by: Peng Fan --- drivers/usb/gadget/ci_udc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c inde

Re: [PATCH] clk: stm32mp1: add support of I2C6_K

2021-01-25 Thread Patrice CHOTARD
Hi Patrick On 1/22/21 3:34 PM, Patrick Delaunay wrote: > Add support of missing I2C6_K with bit 3 of RCC_MC_APB5ENSETR = > I2C6EN: I2C6 peripheral clocks enable. > > This patch allows customer to use I2C6 in SPL or in U-Boot > as other I2C instance, already support in clk driver. > > Signed-off-

Pull request: u-boot-imx u-boot-imx-20210125

2021-01-25 Thread Stefano Babic
ository at: https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git tags/u-boot-imx-20210125 for you to fetch changes up to 4f37aa957939937f9f5b472f829ab81ef13c479a: ARM: imx: add i.MX8MN lpddr4 image cfg file (2021-01-23 14:0

[PATCH] pci: pci_mvebu: Disable config access to PCI host bridge ports

2021-01-25 Thread Stefan Roese
This patch changes the PCI config routines in the Armada XP / 38x driver to not allow access to the PCIe root ports. While updating the Armada XP based theadorable to the latest mainline and testing it with the DM PCI driver I noticed, that the PCI root bridge was being configured incorrectly. Res

[PATCH 2/2] arm: mvebu: theadorable: Set deephasis bit in PCIe configs very early

2021-01-25 Thread Stefan Roese
Testing has shown, that the quality of the PCIe signals and also the stability of correct link establishment on the 2 PCIe ports is better, when the deemphasis bit is set in the PCIe config register. This needs to be done very early, even before the SERDES setup code is run. This way, the first li

[PATCH 1/2] arm: mvebu: theadorable: Enhance "pcie" test cmd to check link width/speed

2021-01-25 Thread Stefan Roese
This patch changes the board specific "pcie" U-Boot command to not only check for PCIe device existance but also for the correct link speed and width that has been established. This cmd can be used by U-Boot scripts for automated testing, if the PCIe setup is correct. Meaning, that all PCIe devices

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-01-25 Thread Köry Maincent
Hello Simon, On Sun, 24 Jan 2021 13:24:14 -0700 Simon Glass wrote: > Hi Kory, > > On Fri, 22 Jan 2021 at 08:23, Kory Maincent wrote: > > > > The commit cd2faeba1a moves the location where we save the flags to the gpio > > descriptor but it adds a "!" character. > > This breaks the condition we

[PULL] u-boot-atmel-2021.04-b

2021-01-25 Thread Eugen.Hristev
Hi Tom, Please pull tag u-boot-atmel-2021.04-b , the second set of new atmel features for 2021.04 cycle. This feature set includes macb updates for all interfaces and new sama7g5 variant support; micrel ksz9031 DLL support; a new board from Giant based on Adafruit feather form factor which con

Re: [patch v3 0/9] rk3399 (Pinebook pro) EDP support

2021-01-25 Thread Peter Robinson
On Fri, Nov 20, 2020 at 1:29 PM Arnaud Patard wrote: > > This patchset add support for the rk3399 eDP. It has been tested on the > pinebook > pro and Google Kevin chromeos devices. > > The changes have been written by studying the linux code, since I didn't find > any > manual for theses part of

[RFC 1/1] disk: PARTITIONS should depend on HAVE_BLOCK_DEVICE

2021-01-25 Thread Heinrich Schuchardt
Partitions are only relevant for block devices. Signed-off-by: Heinrich Schuchardt --- I still need to check if the part command is needed on boards w/o DISTRO_DEFAULTS. --- cmd/Kconfig | 4 ++-- disk/Kconfig | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/Kconfig b/cm

Re: [PATCH 0/2] Console/stdio use after free

2021-01-25 Thread Nicolas Saenz Julienne
Hi Andy, Simon On Wed, 2021-01-20 at 17:57 +0200, Andy Shevchenko wrote: > On Wed, Jan 20, 2021 at 4:05 PM Nicolas Saenz Julienne > wrote: > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > > introduces a use after free in usb_kbd_remove(): > > > > - usbkbd's stdio dev

Re: [PATCH 1/2] stdio: Introduce stdio_valid()

2021-01-25 Thread Nicolas Saenz Julienne
On Sat, 2021-01-23 at 19:03 -0700, Simon Glass wrote: > Hi Nicolas, > > On Wed, 20 Jan 2021 at 07:05, Nicolas Saenz Julienne > wrote: > > > > stdio_valid() will confirm that a struct stdio_dev pointer is indeed > > valid. > > > > Signed-off-by: Nicolas Saenz Julienne > > --- > >  common/stdio.

Re: [PATCH 02/11] pinctrl: single: fix the loop counter variable type

2021-01-25 Thread Pratyush Yadav
Hi Dario, On 23/01/21 07:27PM, Dario Binacchi wrote: > The patch changes the variable 'n' type from phys_addr_t to int. This information can very easily be obtained by reading the diff. The commit message should also explain _why_ the change is made. For example here it would be a good idea to

Re: [PATCH 03/11] pinctrl: single: fix debug messages formatting

2021-01-25 Thread Pratyush Yadav
Hi Dario, On 23/01/21 07:27PM, Dario Binacchi wrote: > The printf '%pa' format specifier appends the '0x' prefix to the > displayed address. Furthermore, the offset variable is displayed with > the '%x' format specifier instead of '%pa'. I agree with Simon that the commit message does not explain

Re: [PATCH 1/5] net: Introduce DSA class for Ethernet switches

2021-01-25 Thread Tom Rini
On Tue, Jan 19, 2021 at 05:15:26PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 19 Jan 2021 at 14:00, Tom Rini wrote: > > > > On Tue, Jan 19, 2021 at 11:06:10AM -0700, Simon Glass wrote: > > > Hi Claudiu, > > > > > > On Fri, 15 Jan 2021 at 09:47, Claudiu Manoil > > > wrote: > > > > > > > > >

[PULL] u-boot-mips

2021-01-25 Thread Daniel Schwierzeck
Hi Tom, please pull updates for MIPS. This adds support for Mediatek MT7620 SoCs. Gitlab CI: https://gitlab.denx.de/u-boot/custodians/u-boot-mips/-/pipelines/6039 Azure: https://dev.azure.com/danielschwierzeck/u-boot/_build/results?buildId=15&view=results The following changes since commit 69d

[U-Boot] Question: PCIe enumeration of PEX switch does not go thru

2021-01-25 Thread ramkrish maladi
Hi   U-boot is unable to enumerate pericom PCIe switch and subsequent end point devices on our board (arm v8.2, 64-bit)   When booted to linux, we see the same enumerated with endpoints   Have any one come ever come across this issue and found a workaround to it?   I hope we no need to have

Re: [PULL] u-boot-atmel-2021.04-b

2021-01-25 Thread Tom Rini
On Mon, Jan 25, 2021 at 10:44:42AM +, eugen.hris...@microchip.com wrote: > Hi Tom, > > Please pull tag u-boot-atmel-2021.04-b , the second set of new atmel > features for 2021.04 cycle. > > This feature set includes macb updates for all interfaces and new > sama7g5 variant support; micrel

Re: Pull request for documentation tag doc-2021-04-rc1-2

2021-01-25 Thread Tom Rini
On Mon, Jan 25, 2021 at 01:14:21PM +0100, Heinrich Schuchardt wrote: > The following changes since commit 69d29fe1c0aeb33f42633a7d30b7921c02aa: > > Merge tag 'efi-2021-04-rc1-3' of > https://gitlab.denx.de/u-boot/custodians/u-boot-efi (2021-01-23 19:07:00 > -0500) > > are available in the

Re: Pull request: u-boot-imx u-boot-imx-20210125

2021-01-25 Thread Tom Rini
b.denx.de/u-boot/custodians/u-boot-rockchip (2021-01-21 > 07:39:47 -0500) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-20210125 > > for you to fetch changes up to 4f37aa957939937f9f5b472f829ab81ef1

Re: [RESEND 6/7] Revert "fastboot: Add default fastboot_set_reboot_flag implementation"

2021-01-25 Thread Tom Rini
On Mon, Jan 25, 2021 at 07:16:37PM +0200, Roman Kovalivskyi wrote: > Hi Lukasz, > > On 1/23/21 5:08 PM, Lukasz Majewski wrote: > > Hi Roman, > > > > > This reverts commit 0ebf9842e56c5b8cb7cb1f990bb452cc14af6225. > > > > > > Current generic implementation of fastboot_set_reboot_flag is somewhat

Re: [RESEND 6/7] Revert "fastboot: Add default fastboot_set_reboot_flag implementation"

2021-01-25 Thread Marek Vasut
On 1/25/21 6:16 PM, Roman Kovalivskyi wrote: [...] Could you please share some info on how do you build it (used defconfig, error messages, used compiler, etc.)? I cannot reproduce those issues on my side. I've tried to rebase my patches onto the current master and rebase was done cleanly,

[PATCH 1/1] doc: board: fix Microchip MPFS Icicle Kit doc

2021-01-25 Thread Heinrich Schuchardt
Two sibling headings (here eMMC) cannot have the same title. Warning, treated as error: doc/board/microchip/mpfs_icicle.rst:423:duplicate label board/microchip/mpfs_icicle:emmc, other instance in doc/board/microchip/mpfs_icicle.rst make[1]: *** [doc/Makefile:69: htmldocs] Error 2 * Correct the he

Re: [PATCH] ata: sunxi: fix debug messages

2021-01-25 Thread Simon Glass
Hi Dario, On Sun, 24 Jan 2021 at 11:13, Dario Binacchi wrote: > > It is useless and misleading to print the ret variable that is not set > by the dev_read_addr routine. Also, move the '\n' character after the > round bracket that contains the error code. > > Signed-off-by: Dario Binacchi > --- >

Re: [PATCH 1/1] cmd: correct long text loadb, loadx, loady

2021-01-25 Thread Simon Glass
On Fri, 22 Jan 2021 at 11:00, Heinrich Schuchardt wrote: > > The first argument is the load address and not an offset. > > The second argument cannot be entered without the first one. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/load.c | 12 ++-- > 1 file changed, 6 insertions(+),

Re: [PATCH v2 1/1] dm: core: describe uclass_root_s

2021-01-25 Thread Simon Glass
On Sun, 24 Jan 2021 at 13:56, Heinrich Schuchardt wrote: > > make htmldocs creates a warning: > > ./include/asm-generic/global_data.h:443: > warning: Function parameter or member 'uclass_root_s' > not described in 'global_data' > > Correct the member descriptions. > > Cc: Simon Glass > Signed-off

[PATCH 1/1] doc: fix doc/develop/logging.rst

2021-01-25 Thread Heinrich Schuchardt
Sphinx 3 builds fail due to doc/develop/logging.rst producing duplicate labels. Include logging.h only once in the API section and use cross-references for the enums log_level_t and log_category_t. Signed-off-by: Heinrich Schuchardt --- doc/api/index.rst | 1 + doc/api/logging.rst |

Re: [RESEND 6/7] Revert "fastboot: Add default fastboot_set_reboot_flag implementation"

2021-01-25 Thread Roman Kovalivskyi
Hi Lukasz, On 1/23/21 5:08 PM, Lukasz Majewski wrote: Hi Roman, This reverts commit 0ebf9842e56c5b8cb7cb1f990bb452cc14af6225. Current generic implementation of fastboot_set_reboot_flag is somewhat messy and requires some additional configuration option to be enabled besides CMD_BCB, so it rev

Re: [RFC 1/1] disk: PARTITIONS should depend on HAVE_BLOCK_DEVICE

2021-01-25 Thread Tom Rini
On Mon, Jan 25, 2021 at 05:28:39PM +0100, Heinrich Schuchardt wrote: > Partitions are only relevant for block devices. > > Signed-off-by: Heinrich Schuchardt > --- > I still need to check if the part command is needed on boards > w/o DISTRO_DEFAULTS. > --- > cmd/Kconfig | 4 ++-- > disk/Kconfi

[PATCH 1/1] doc: remove illegal characters

2021-01-25 Thread Heinrich Schuchardt
Avoid errors when generating the HTML documentation like: 'ascii' codec can't decode byte 0xc2 Correct capitalization of 'U-Boot'. Signed-off-by: Heinrich Schuchardt --- doc/board/freescale/b4860qds.rst| 2 +- doc/board/microchip/mpfs_icicle.rst | 4 ++-- doc/board/sifive/fu540.rst

[PATCH 1/1] .gitlab-ci: install doc/sphinx/requirements.txt

2021-01-25 Thread Heinrich Schuchardt
Install all requirements according to doc/sphinx/requirements.txt in the virtual environment used for testing 'make htmldocs'. Signed-off-by: Heinrich Schuchardt --- .azure-pipelines.yml | 6 +- .gitlab-ci.yml | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.azur

Re: [PATCH 1/1] doc: remove illegal characters

2021-01-25 Thread Pali Rohár
Hello Heinrich! Does this change mean that UTF-8 is now disallowed in U-Boot? On Monday 25 January 2021 22:48:56 Heinrich Schuchardt wrote: > Avoid errors when generating the HTML documentation like: > > 'ascii' codec can't decode byte 0xc2 This sounds like an incorrect configuration of too

Re: [PATCH v3 01/20] mmc: sdhci: Add helper functions for UHS modes

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > Add a set_voltage() function which handles the switch from 3.3V to 1.8V > for SD card UHS modes. > > Signed-off-by: Faiz Abbas > Signed-off-by: Aswath Govindraju > --- > drivers/mmc/sdhci.c | 80 ++

Re: [RFC 1/1] disk: PARTITIONS should depend on HAVE_BLOCK_DEVICE

2021-01-25 Thread Heinrich Schuchardt
On 1/25/21 10:02 PM, Tom Rini wrote: On Mon, Jan 25, 2021 at 05:28:39PM +0100, Heinrich Schuchardt wrote: Partitions are only relevant for block devices. Signed-off-by: Heinrich Schuchardt --- I still need to check if the part command is needed on boards w/o DISTRO_DEFAULTS. --- cmd/Kconfig

Re: [PATCH v3 02/20] mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post()

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > There are some speed modes that work without switching the dll on. > Unconditionally switch off the DLL before setting clock frequency to > support this case. The software will automatically enable DLL for speed > modes that requ

Re: [PATCH v3 03/20] mmc: am654_sdhci: Convert flag fields to BIT macro

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > Convert the flags field defines to use the BIT() macro. > > Signed-off-by: Faiz Abbas > Signed-off-by: Aswath Govindraju Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/am654_sdhci.c | 8 ---

Re: [PATCH v3 05/20] mmc: am654_sdhci: Add support for AM65x SR2.0

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > Add Support for AM65x PG2.0. Use the SoC bus framework to fixup > the platform data and do DLL calibration if the revision is 1.0 Is there no method to get the revision from H/W? If not, looks good tome. > > Signed-off-by: Fai

Re: [PATCH v3 04/20] mmc: am654_sdhci: Add flag for PHY calibration

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > Not all controllers need calibration for the PHY DLL. Add a DLL_CALIB > flag to indicate the same. > > Also move the write of trm_icp and driver strength to the set_clock() > function to match the kernel configuration flow. > >

Re: [PATCH v3 06/20] mmc: am654_sdhci: Add support for input tap delay

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > DLL need only be enabled for speed modes and clock frequencies at or > above 50 MHz. For speed modes that don't enable the DLL, we need to > configure a static input delay value. This involves reading an optional > itap-del-sel-*

Re: [PATCH v3 07/20] mmc: am654_sdhci: Add support for writing to clkbuf_sel

2021-01-25 Thread Jaehoon Chung
On 1/21/21 9:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > Add support for writing new clock buffer select property for both > the am654x and j721e 4 bit IPs > > Signed-off-by: Faiz Abbas > Signed-off-by: Aswath Govindraju Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > -

  1   2   >