For printing unsigned int we have to use %u not %d.
Signed-off-by: Heinrich Schuchardt
---
drivers/adc/meson-saradc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/adc/meson-saradc.c b/drivers/adc/meson-saradc.c
index 13a8f49dc5..406583e474 100644
--- a/drivers/adc/
For printing unsigned int %u has to be used.
Signed-off-by: Heinrich Schuchardt
---
drivers/dfu/dfu_sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
index 318e43c179..76b629a334 100644
--- a/drivers/dfu/dfu_sf.c
+++ b/drivers/df
On Sunday, December 27, 2020, Pali Rohár wrote:
> On Friday 17 January 2020 12:44:51 Andy Shevchenko wrote:
> > If someone wants to use shared (by installed OS) eMMC partition to
> > the Windows to boot from, it's not possible due to U-Boot limitations.
> >
> > Describe this case and possible wor
Calling calloc() for 0 members does not make any sense.
Setting ch_priv->busy_desc = NULL for ch_priv->desc_cnt > 0 is equally
unreasonable.
The current code will lead to a NULL dereference in bcm6348_iudma_enable().
The assignments for ch_priv->busy_desc are obviously swapped.
Signed-off-by: He
Freeing a buffer before calling hang() is superfluous. Removing the call
reduces the SPL size.
Signed-off-by: Heinrich Schuchardt
---
drivers/mmc/fsl_esdhc_spl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c
index afe55fad9d..bee7
Hello Heinrich,
This is not swapped.
busy_desc is only used in RX. Please, check the rest of the driver:
https://github.com/u-boot/u-boot/blob/master/drivers/dma/bcm6348-iudma.c
Regards,
Álvaro.
El 27/12/2020 a las 10:26, Heinrich Schuchardt escribió:
Calling calloc() for 0 members does not ma
This sort of code does not make much sense:
if (ondie_ecc_enabled) {
if (ondie_ecc_enabled) {
Remove the inner if.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt
---
drivers/mtd/nand/raw/zynq_nand.c | 10 --
1 file changed, 4 insertions(+), 6 del
If no GPIO controller is found, the return value should not depend on a
random value on the stack. Initialize variable ret.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
Avoid calling free(addr) twice if the device for ucode is not found.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt
---
drivers/qe/qe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c
index 1a829b5a4c..259e4e3e67 100644
--- a/drive
On 12/27/20 11:18 AM, Álvaro Fernández Rojas wrote:
Hello Heinrich,
This is not swapped.
busy_desc is only used in RX. Please, check the rest of the driver:
https://github.com/u-boot/u-boot/blob/master/drivers/dma/bcm6348-iudma.c
Regards,
Álvaro.
Thanks for reviewing. Why is calloc called wit
drivers/mtd/mw_eeprom.c contains code that never worked. mw_eeprom_write()
and mw_eeprom_read() have incorrect loop conditions:
while (len <= 2) {
CONFIG_MW_EEPROM is not set anywhere. So let's simply drop the module.
Signed-off-by: Heinrich Schuchardt
---
drivers/mtd/Makefile| 1
Up to now the escape key was not correctly detected in UEFI applications.
We had to hit it twice for a single escape to be recognized.
Use a 10 ms delay to detect if we are dealing with the escape key or an
escape sequence.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_console.c | 1
IS_ENABLED() contains parentheses. But we should still put extra
parentheses around it in an if statement for readability.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_boottime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/
load_options passed from do_efibootmgr() to do_bootefi_exec() may contain
invalid data from the stack which will lead to an invalid free().
Fixes: 0ad64007feb9 ("efi_loader: set load options in boot manager")
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_bootmgr.c | 2 +-
1 file chan
On Sunday, December 27, 2020, Heinrich Schuchardt
wrote:
> If no GPIO controller is found, the return value should not depend on a
> random value on the stack. Initialize variable ret.
>
> The problem was indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/pinctrl/medi
On Sun, Nov 29, 2020 at 6:53 PM Pali Rohár wrote:
>
> Now when usbtty serial console is fixed in U-Boot enable it for Nokia RX-51
> board by default.
>
> CONFIG_CONSOLE_MUX is already used and U-Boot console is available for
> all in/out devices. Therefore there is no need to have separate command
On Sunday 29 November 2020 17:46:05 Pali Rohár wrote:
> With current implementation there is an issue in musb driver that it
> loose receiving bytes from USB bus when too many a characters are send
> over USB tty from computer. Typing on keyboard to kermit terminal
> connected to /dev/ttyACM0 is wo
On Sunday 27 December 2020 18:28:25 Andy Shevchenko wrote:
> On Sun, Nov 29, 2020 at 6:53 PM Pali Rohár wrote:
> >
> > Now when usbtty serial console is fixed in U-Boot enable it for Nokia RX-51
> > board by default.
> >
> > CONFIG_CONSOLE_MUX is already used and U-Boot console is available for
>
On Sun, Dec 27, 2020 at 6:35 PM Pali Rohár wrote:
> On Sunday 27 December 2020 18:28:25 Andy Shevchenko wrote:
> > On Sun, Nov 29, 2020 at 6:53 PM Pali Rohár wrote:
> > >
> > > Now when usbtty serial console is fixed in U-Boot enable it for Nokia
> > > RX-51
> > > board by default.
> > >
> > > C
On 20-06-22 14:12:59, Michal Simek wrote:
Hi,
On 20. 06. 20 20:06, Florian Klink wrote:
Hey,
I tried building latest master 2b8692bac1e8795cbb87b0d00213fd193409851d,
for a zynq device, and did according to the documentation:
$ export DEVICE_TREE=zynq-zc702
$ make xilinx_zynq_virt_defconfig
$
On Sunday 27 December 2020 18:42:19 Andy Shevchenko wrote:
> On Sun, Dec 27, 2020 at 6:35 PM Pali Rohár wrote:
> > On Sunday 27 December 2020 18:28:25 Andy Shevchenko wrote:
> > > On Sun, Nov 29, 2020 at 6:53 PM Pali Rohár wrote:
> > > >
> > > > Now when usbtty serial console is fixed in U-Boot e
On 23/12/20, Jens Wiklander wrote:
> Hi Jorge,
hey
>
> On Mon, Dec 21, 2020 at 07:15:40PM +0100, Jorge Ramirez-Ortiz wrote:
> > This commit gives the secure world access to the I2C bus so it can
> > communicate with I2C slaves (tipically those would be secure elements
> > like the NXP SE050).
>
If no GPIO controller is found, the return value should not depend on a
random value on the stack. Initialize variable ret.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt
---
v2:
move the assigment to the certain code-path (Andy)
---
drivers/pinctrl/mediatek/p
This adds the dts and entry in CONFIG_OF_LIST for the Digilent Zynq PYNQ
Board(s).
They're Zynq 7000 - based boards, the Z1 is from Digilent, the Z2 from
TUL.
They have a slightly different audio system, and a different pin header,
but these aren't really accessible from the PS, only from the PL,
Make it more obvious what .dts file was expected by the build system.
When adding support for a new board, I kept getting this error message,
assuming I passed a wrong DEVICE_TREE parameter.
However, what was really the mistake was that the entry in
`arch/arm/dts/Makefile` was missing, and u-boot
On 20-12-27 17:48:51, Florian Klink wrote:
On 20-06-22 14:12:59, Michal Simek wrote:
I tried building latest master 2b8692bac1e8795cbb87b0d00213fd193409851d,
for a zynq device, and did according to the documentation:
$ export DEVICE_TREE=zynq-zc702
$ make xilinx_zynq_virt_defconfig
$ make
Read
Hi Dennis,
On 12/26/20 5:44 PM, dennis laplacian1 wrote:
> Hi Jaehoon Chung,
> for your comment:
> "ditto. if (IS_ENABLED()) instead of #if.
> And i don't know why doesn't check this in mmc_erase_t().
> Then it doesn't need to pass arg as argument."
>
> I check the support of secure erase in the
Hi Ravik,
On 12/24/20 4:57 AM, Ravik Hasija wrote:
> Similar to usbboot, add command line to boot from raw mmc partition
> using common_diskboot(), which supports legacy or FIT images.
>
> Usage:
> mmcboot loadAaddr dev:part
>
> Where defaults to CONFIG_SYS_LOAD_ADDR, and
> defaults to ${bootd
On 12/27/20 6:50 PM, Heinrich Schuchardt wrote:
> Freeing a buffer before calling hang() is superfluous. Removing the call
> reduces the SPL size.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/fsl_esdhc_spl.c | 3 ---
> 1 fi
Add missing commas.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_boottime.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index 4deb051c4e..9062b2dc3d 100644
--- a/lib/efi_loader/efi_boottime.c
+
On Sun, 2020-12-27 at 21:18 +0100, Heinrich Schuchardt wrote:
> If no GPIO controller is found, the return value should not depend on a
> random value on the stack. Initialize variable ret.
>
> The problem was indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> v2:
> move
> -Original Message-
> From: Lim, Elly Siew Chin
> Sent: Thursday, December 24, 2020 6:21 PM
> To: u-boot@lists.denx.de
> Cc: Marek Vasut ; Tan, Ley Foon
> ; See, Chin Liang ;
> Simon Goldschmidt ; Chee, Tien Fong
> ; Westergreen, Dalon
> ; Simon Glass ; Gan,
> Yau Wai ; Lim, Elly Siew
32 matches
Mail list logo
