Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-20 Thread Stefano Babic
On 14/09/2015 14:11, Fabio Estevam wrote: > On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: >> We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set >> wcr, since this will override bits set before reset_cpu. >> >> Use clrsetbits_le32 instead of writew to fix this issue. > > There is a

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Stefano Babic
On 14/09/2015 07:34, Peng Fan wrote: > When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. > Also If still checking mux_ctrl_ofs, we have no chance to set iomux > for i.MX7D IOMUXC_LPSR_SW_MUX_CTL_PAD_GPIO1_IO00, because the mux_ctrl_ofs > for this register is 0. > > Signed

Re: [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code

2015-09-20 Thread Stefano Babic
On 14/09/2015 16:06, Fabio Estevam wrote: > iox74lv_set() is not used anywhere, so let's remove it. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engin

Re: [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible

2015-09-20 Thread Stefano Babic
On 14/09/2015 16:06, Fabio Estevam wrote: > Make the internal symbols static when possible. > > This prevents sparse build warnings. > > Signed-off-by: Fabio Estevam > --- > board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev()

2015-09-20 Thread Stefano Babic
On 14/09/2015 16:06, Fabio Estevam wrote: > get_board_rev() is not actually providing the board revision. > > It just returns the CPU revision instead. > > As the CPU revision is already printed on boot, there is no > reason to have get_board_rev(), so let's remove it. > > Signed-off-by: Fabio

Re: [U-Boot] [PATCH 2/5] mx7dsabreasd: Remove dead code

2015-09-20 Thread Stefano Babic
On 13/09/2015 18:06, Fabio Estevam wrote: > From: Fabio Estevam > > iox74lv_set() is not used anywhere, so let's remove it. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ==

Re: [U-Boot] [PATCH 3/5] mx7dsabresd: Include USB header

2015-09-20 Thread Stefano Babic
On 13/09/2015 18:06, Fabio Estevam wrote: > From: Fabio Estevam > > Include in order to fix the following sparse warning: > > board/freescale/mx7dsabresd/mx7dsabresd.c:538:5: warning: symbol > 'board_ehci_hcd_init' was not declared. Should it be static? > > Signed-off-by: Fabio Estevam > -

Re: [U-Boot] [PATCH 1/5] mx7dsabresd: Staticize when possible

2015-09-20 Thread Stefano Babic
On 13/09/2015 18:06, Fabio Estevam wrote: > From: Fabio Estevam > > Make the internal symbols static when possible. > > This prevents sparse build warnings. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic --

Re: [U-Boot] [PATCH 5/5] mx7dsabresd: Remove unused config option

2015-09-20 Thread Stefano Babic
On 13/09/2015 18:06, Fabio Estevam wrote: > From: Fabio Estevam > > CONFIG_FEC_DMA_MINALIGN is not used anywhere, so let's remove it. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic --

Re: [U-Boot] [PATCH 4/5] mx7dsabresd: Remove get_board_rev()

2015-09-20 Thread Stefano Babic
On 13/09/2015 18:06, Fabio Estevam wrote: > From: Fabio Estevam > > get_board_rev() is not actually providing the board revision. > > It just returns the CPU revision instead. > > As the CPU revision is already printed on boot, there is no > reason to have get_board_rev(), so let's remove it.

Re: [U-Boot] [PATCH 1/2] imx: mx7: drop select CPU_V7 for board target

2015-09-20 Thread Stefano Babic
On 14/09/2015 16:18, Peng Fan wrote: > drop select CPU_V7 for board target, since ARCH_MX7 selects CPU_V7. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ==

Re: [U-Boot] [PATCH 2/2] imx: mx7dsabresd: drom SYS_SOC from board Kconfig

2015-09-20 Thread Stefano Babic
Hi Peng, On 14/09/2015 16:18, Peng Fan wrote: > We have defined this kconfig entry in arch/arm/cpu/armv7/mx7/Kconfig, > no need to redefine it in board Kconfig. > Fixed "drom" in commit message with "drop". > Signed-off-by: Peng Fan > Cc: Stefano Babic > --- Applied to u-boot-imx, thanks !

Re: [U-Boot] [PATCH V3] mtd: nand: mxs check maximum ecc that platfrom supports

2015-09-20 Thread Stefano Babic
On 07/09/2015 10:12, Peng Fan wrote: > Check maximum ecc strength for each platfrom to avoid the calculated ecc > exceed the limitation. > > Signed-off-by: Peng Fan > Signed-off-by: Han Xu > Tested-By: Tim Harvey > Reviewed-by: Marek Vasut > Acked-by: Scott Wood > Cc: Stefano Babic > --- >

Re: [U-Boot] [PATCH] imx6, aristaintetos2: add me as maintainer

2015-09-20 Thread Stefano Babic
On 17/09/2015 10:39, Heiko Schocher wrote: > Add me as Maintainer for the aristainetos2b board. > > Signed-off-by: Heiko Schocher > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engine

Re: [U-Boot] [PATCH 0/3] Pending patches for Congatec QMX6 SPL support

2015-09-20 Thread Stefano Babic
Hi Otavio, On 18/09/2015 19:34, Otavio Salvador wrote: > This patchset includes all changes we have pending for proper > SPL support and board revamp. > > > Otavio Salvador (3): > cgtqmx6eval: Add fastboot support > cgtqmx6eval: Add SPL support > iomux-v3: Take MX6D in consideration for im

Re: [U-Boot] [PATCH 2/3] cgtqmx6eval: Add SPL support

2015-09-20 Thread Stefano Babic
Hi Otavio, On 18/09/2015 19:34, Otavio Salvador wrote: > Congatec has several MX6 boards based on quad, dual, dual-lite and solo. > > Add SPL support so that all the variants can be supported. > > Signed-off-by: Otavio Salvador > --- > > arch/arm/cpu/armv7/mx6/Kconfig |

Re: [U-Boot] [PATCH] imximage: fix commands other than write_data

2015-09-20 Thread Stefano Babic
On 15/09/2015 03:06, Troy Kisky wrote: > When CHECK_BITS_SET was added, they forgot to add > a new command table, and instead overwrote the > previous table. > > Signed-off-by: Troy Kisky > > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- =

[U-Boot] Missing maintainer and status for imx6 boards

2015-09-20 Thread Stefano Babic
Hi Peng, the following boards you recently pushed are missing info about status and maintainer. This generates a warning by build. WARNING: no status info for 'mx6qpsabreauto' WARNING: no maintainers for 'mx6qpsabreauto' WARNING: no status info for 'mx6ul_9x9_evk' WARNING: no maintainers for 'mx

[U-Boot] [PATCH v6] nios2: convert altera_jtag_uart to driver model

2015-09-20 Thread Thomas Chou
Convert altera_jtag_uart to driver model. Signed-off-by: Thomas Chou Acked-by: Marek Vasut Reviewed-by: Simon Glass --- v2 add ioremap. make the change to dts compatible with linux. v3 use fdt address translation patch from Stefan Roese. fix watchdog and loop as Marek suggested. v4

Re: [U-Boot] [PATCH] imximage: fix commands other than write_data

2015-09-20 Thread Stefano Babic
Hi Troy, On 15/09/2015 03:06, Troy Kisky wrote: > When CHECK_BITS_SET was added, they forgot to add > a new command table, and instead overwrote the > previous table. > > Signed-off-by: Troy Kisky > > --- > This patch breaks building boards with SPL: Building current source for 85 boards (6

Re: [U-Boot] [PATCH 0/3] Pending patches for Congatec QMX6 SPL support

2015-09-20 Thread Stefano Babic
On 20/09/2015 10:07, Stefano Babic wrote: > Hi Otavio, > > On 18/09/2015 19:34, Otavio Salvador wrote: >> This patchset includes all changes we have pending for proper >> SPL support and board revamp. >> >> >> Otavio Salvador (3): >> cgtqmx6eval: Add fastboot support >> cgtqmx6eval: Add SPL

Re: [U-Boot] [PATCH 1/7] omap-common: Common omap_die_id definition

2015-09-20 Thread Paul Kocialkowski
Hi, Le vendredi 04 septembre 2015 à 14:14 -0400, Tom Rini a écrit : > On Thu, Aug 27, 2015 at 07:37:08PM +0200, Paul Kocialkowski wrote: > > > This introduces a common definition for omap_die_id, that aims at providing > > a > > common interface for accessing omap platform's die id bits. > > >

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Benoît Thébaudeau
Hi Stefano, Peng, Fabio, all, Sorry for seeing this only now, but... On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: > > > On 14/09/2015 07:34, Peng Fan wrote: >> When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. This assumption is wrong. This check was there for a

[U-Boot] [PATCH v3] nios2: convert altera_uart to driver model

2015-09-20 Thread Thomas Chou
Convert altera_uart to driver model. Signed-off-by: Thomas Chou Reviewed-by: Simon Glass Acked-by: Marek Vasut --- v2 fix coding style as Marek suggested. v3 add early debug uart. fix coding style as Simon suggested. arch/nios2/dts/3c120_devboard.dts | 1 + drivers/serial/Kconfig

Re: [U-Boot] [PATCH v3 1/4] sunxi: move SPL-related definitions to platform-specific include

2015-09-20 Thread Hans de Goede
Hi, On 09/18/2015 03:58 AM, Bernhard Nortmann wrote: Am 17.09.2015 um 18:52 schrieb Bernhard Nortmann: The sunxi platform currently doesn't seem to make any use of the asm/arch-sunxi/spl.h file. This patch moves some declarations from tools/mksunxiboot.c into it. This enables us to reuse those

Re: [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXIto NAND_SUNXI

2015-09-20 Thread Hans de Goede
Hi, On 09/18/2015 07:43 AM, Olliver Schinagl wrote: Hans de Goede redhat.com> writes: Hey Hans, We eventually want to add full nand support, since it makes no sense to build SPL with nand support and u-boot without, or the other way around, a single option will suffice. Renaming the Kconfig

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Peng Fan
On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >Hi Stefano, Peng, Fabio, all, > >Sorry for seeing this only now, but... > >On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: >> >> >> On 14/09/2015 07:34, Peng Fan wrote: >>> When setting iomux for a pin mux, there is no need

[U-Boot] [PATCH] imx: boards: Add maintainers info

2015-09-20 Thread Peng Fan
Add MAINTAINERS info for mx6slevk_spl, mx6ul_9x9_evk and mx6qpsabreauto. Signed-off-by: Peng Fan Cc: Stefano Babic --- board/freescale/mx6qsabreauto/MAINTAINERS | 2 ++ board/freescale/mx6slevk/MAINTAINERS| 2 ++ board/freescale/mx6ul_14x14_evk/MAINTAINERS | 1 + 3 files changed, 5 in

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Stefano Babic
Hi Peng, On 20/09/2015 15:02, Peng Fan wrote: > On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >> Hi Stefano, Peng, Fabio, all, >> >> Sorry for seeing this only now, but... >> >> On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: >>> >>> >>> On 14/09/2015 07:34, Peng Fan wr

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Benoît Thébaudeau
Hi Peng, On Sun, Sep 20, 2015 at 3:02 PM, Peng Fan wrote: > On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >>Hi Stefano, Peng, Fabio, all, >> >>Sorry for seeing this only now, but... >> >>On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: >>> >>> >>> On 14/09/2015 07:34, P

[U-Boot] [PATCH v2] sunxi_nand_spl: Be smarter about where to look for backup u-boot.bin

2015-09-20 Thread Hans de Goede
We know when u-boot is written to its own partition, in this case the layout always is: eb 0 spl eb 1 spl-backup eb 2 u-boot eb 3 u-boot-backup eb: erase-block So if we cannot load u-boot from its primary offset we know exactly where to look for it. Signed-off-by: Hans de Goede --- Changes in

[U-Boot] [PATCH v3 1/4] dm: tpm: Move tpm_tis_i2c to tpm_i2c_infineon

2015-09-20 Thread Christophe Ricard
As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like Atmel or STMicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: - Adding

[U-Boot] [PATCH v3 2/4] dm: tpm: Add Driver Model support for tpm_atmel_twi driver

2015-09-20 Thread Christophe Ricard
tpm_atmel_twi can fit perfectly to the new UCLASS_TPM class. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: None drivers/tpm/Kconfig | 2 +- drivers/tpm/tpm_atmel_twi.c | 74 - 2 files changed, 54 insertions(+), 2

[U-Boot] [PATCH v3 3/4] dm: tpm: Remove every compilation switch for TPM driver model

2015-09-20 Thread Christophe Ricard
As every TPM drivers support UCLASS_TPM, we can only rely on DM_TPM functions. This simplify a bit the code. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: None common/cmd_tpm.c | 13 + drivers/tpm/tpm_tis_infineon.c | 1 - include/tis.h

[U-Boot] [PATCH v3 4/4] dm: tpm: Every TPM drivers should depends on DM_TPM

2015-09-20 Thread Christophe Ricard
Every TPM drivers should now depends on DM_TPM and not only TPM. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: None drivers/tpm/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tpm/Kconfig b/drivers/tpm/Kconfig index ff2cdbe

[U-Boot] [PATCH v3 0/4] Move tpm_tis_i2c to tpm_tis_infineon and convert last tpm driver to use DM_TPM

2015-09-20 Thread Christophe Ricard
Hi Simon, This patch serie move tpm_tis_i2c driver to tpm_tis_infineon. It also convert the latest tpm driver tpm_atmel_twi to DM_TPM. In this version i am only adding mention to Tom Rini review Best Regards Christophe Changes in v3: - Adding mention to Tom Rini review Christophe Ricard (4):

Re: [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver

2015-09-20 Thread Bin Meng
Hi Olliver, On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl wrote: > From: Olliver Schinagl > > The designware driver has a build guard which makes it to only work when > using the PHYLIB. With b68fe152272 the PHYLIB was added to the net > Kconfig but not selected by all hardware depending on

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Peng Fan
On Sun, Sep 20, 2015 at 05:02:58PM +0200, Benoît Thébaudeau wrote: >Hi Peng, > >On Sun, Sep 20, 2015 at 3:02 PM, Peng Fan wrote: >> On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >>>Hi Stefano, Peng, Fabio, all, >>> >>>Sorry for seeing this only now, but... >>> >>>On Sun, Sep 2

[U-Boot] [PATCH 1/4] exynos: Properly initialize host_caps in s5p_sdhci_core_init()

2015-09-20 Thread Tobias Jakobi
The sdhci_host struct is allocated in s5p_sdhci_init() but the fields are not initialized. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index 4db51d6..e9c43a9 100644 --- a/drivers/mm

[U-Boot] [PATCH 0/4] Fix operation on Odroid devices

2015-09-20 Thread Tobias Jakobi
Hello, currently operation on Exynos4412-based Odroid devices is broken. The bootloader stops with this message: Card did not respond to voltage select! *** Warning - MMC init failed, using default environment This series fixes error handling in the s5p sdhci driver and the cause of the issue, w

[U-Boot] [PATCH 2/4] exynos: Fix passing of errors in exynos_mmc_init()

2015-09-20 Thread Tobias Jakobi
exynos_mmc_init() always returns zero, so for the caller it looks like it never fails. Correct this by returning the error code of process_nodes(). For process_nodes() do something similar and return early when do_sdhci_init() fails. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 10

[U-Boot] [PATCH 3/4] exynos: be more verbose in process_nodes()

2015-09-20 Thread Tobias Jakobi
In case sdhci_get_config() or do_sdhci_init() fail, show the error code that was returned. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index bc2102a..6b

[U-Boot] [PATCH 4/4] exynos: fix and cleanup do_sdhci_init()

2015-09-20 Thread Tobias Jakobi
The CD check is currently inverted. dm_gpio_get_value() returns one when a card is detected. All other values (zero when there is no card, or negative values for the internal errors) indicate failure. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 20 +++- 1 file chan