Re: [U-Boot] [PATCH] ARM926: Add mb to the cache invalidate/flush

2012-10-13 Thread Albert ARIBAUD
Hi Marek, First, a (long) preamble with some general considerations: A. This patch does not fix an actual issues; it is a prospective patch, modifying code which so far has not malfunctioned, or at least has not been reported to malfunction. B. My comments on the patch below are based on the gen

[U-Boot] File placement in Soc / board dirs and make issues (was: [PATCH V3 17/32] imximage.cfg: run files through C preprocessor)

2012-10-13 Thread Albert ARIBAUD
Hi Tom, On Thu, 11 Oct 2012 16:15:02 -0700, Tom Rini wrote: > On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babic wrote: > > [snip] > > One reason to move into the board directory is that there was a decision > > to move rules related to only one arch or SOC where they belong to, that > > i

Re: [U-Boot] u-boot-tegra/master and /next have been updated and uploaded to denx.de

2012-10-13 Thread Albert ARIBAUD
Hi Stephen, On Fri, 12 Oct 2012 15:30:42 -0600, Stephen Warren wrote: > On 10/12/2012 03:26 PM, Tom Warren wrote: > > Folks, > > > > u-boot-tegra/next has been updated with new patches from Lucas, Marc, and > > Stephen, rebased against u-boot-arm, and pushed to denx.de. > > u-boot-tegra/next r

Re: [U-Boot] [PATCH v5 09/16] arm: Add control over cachability of memory regions

2012-10-13 Thread Albert ARIBAUD
Hi Simon, No comment on the patch itself except for one general question: On Mon, 8 Oct 2012 14:42:29 -0700, Simon Glass wrote: > Add support for adjusting the cachability of an L1 section by updating > the MMU. The mmu_set_region_dcache() function allows drivers to make > these changes after

Re: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support

2012-10-13 Thread xiangfu liu
Hi Marek This file was wrote by Ingenic people. I don't have time to convert it to C(I am not very good in mips assembler). the .S file implement basic USB stack. this C code ( http://projects.qi-hardware.com/index.php/p/xburst-tools/source/tree/master/xbboot) implement the host app. the host app

Re: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support

2012-10-13 Thread Marek Vasut
Dear xiangfu liu, > Hi Marek > > This file was wrote by Ingenic people. I don't have time to convert it to > C(I am not very good in mips assembler). the .S file implement basic USB > stack. We already do have an USB stack. > this C code ( > http://projects.qi-hardware.com/index.php/p/xburst-to

Re: [U-Boot] [PATCH v5 1/2] qi_lb60: add nand spl support

2012-10-13 Thread Xiangfu Liu
On 10/13/2012 10:59 AM, Marek Vasut wrote: >> From: Xiangfu >> > >> > The JZ4740 CPU can load 8KB from two different addresses: >> >1. the normal area up to 8KB starting from NAND flash address 0x >> >2. the backup area up to 8KB starting from NAND flash address 0x2000 >> >

Re: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support

2012-10-13 Thread xiangfu liu
Hi Marek On Sat, Oct 13, 2012 at 8:23 PM, Marek Vasut wrote: > Dear xiangfu liu, > > > Hi Marek > > > > This file was wrote by Ingenic people. I don't have time to convert it to > > C(I am not very good in mips assembler). the .S file implement basic USB > > stack. > > We already do have an USB

Re: [U-Boot] [PATCH v5 1/2] qi_lb60: add nand spl support

2012-10-13 Thread Marek Vasut
Dear Xiangfu Liu, > On 10/13/2012 10:59 AM, Marek Vasut wrote: > >> From: Xiangfu > >> > >> > The JZ4740 CPU can load 8KB from two different addresses: > >> >1. the normal area up to 8KB starting from NAND flash address > >> >0x 2. the backup area up to 8KB starting from NAND f

Re: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support

2012-10-13 Thread Marek Vasut
Dear xiangfu liu, > Hi Marek > > On Sat, Oct 13, 2012 at 8:23 PM, Marek Vasut wrote: > > Dear xiangfu liu, > > > > > Hi Marek > > > > > > This file was wrote by Ingenic people. I don't have time to convert it > > > to C(I am not very good in mips assembler). the .S file implement > > > basic U

Re: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support

2012-10-13 Thread Xiangfu Liu
On 10/13/2012 08:52 PM, Marek Vasut wrote: > Dear xiangfu liu, > >> > Hi Marek >> > >> > On Sat, Oct 13, 2012 at 8:23 PM, Marek Vasut wrote: >>> > > Dear xiangfu liu, >>> > > > > > Hi Marek > > > > > > This file was wrote by Ingenic people. I don't have time to convert > >

Re: [U-Boot] [PATCH v5 1/2] qi_lb60: add nand spl support

2012-10-13 Thread Xiangfu Liu
Hi Marek I will look into CPU-specific. come out with new patches. Xiangfu On 10/13/2012 08:50 PM, Marek Vasut wrote: > This is CPU-specific , right? So it should be some kind of CPU-specific > override > in CPU-specific directory, not polute the main Makefile. > > Best regards, > Marek Vasut

Re: [U-Boot] File placement in Soc / board dirs and make issues (was: [PATCH V3 17/32] imximage.cfg: run files through C preprocessor)

2012-10-13 Thread Tom Rini
On Sat, Oct 13, 2012 at 3:11 AM, Albert ARIBAUD wrote: > Hi Tom, > > On Thu, 11 Oct 2012 16:15:02 -0700, Tom Rini wrote: > >> On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babic wrote: >> >> [snip] >> > One reason to move into the board directory is that there was a decision >> > to move rule

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Stephen Warren, In message <5076f9bd.5050...@wwwdotorg.org> you wrote: > > However, U-Boot is reported to only use Signed-off to indicate the > original author(s), so I can see how the git committer field isn't Delete the "original" here. Once a patch has been commited to a tree, it cannot

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Scott Wood, In message <1349974486.6903.5@snotra> you wrote: > > Is this documented anywhere? > > http://www.denx.de/wiki/U-Boot/DevelopmentProcess says, "U-Boot has > adopted the Linux kernel signoff policy". > > Actual behavior is probably inconsistent between custodians. This is docum

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Stephen Warren, In message <5076fb24.1080...@wwwdotorg.org> you wrote: > > True, tags can be moved. However, the point wasn't that they're > immutable, but that using them can decouple the pull process from the > commit process. For example, I could: > > git checkout -b foo bar > git am > gi

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Stephen Warren, In message <50770155.20...@wwwdotorg.org> you wrote: > > and in particular, the following parts of that doc is what tells me that > committers should always add S-o-b even if the commit didn't change: > > > Developer's Certificate of Origin 1.1 > > > > By mak

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Scott Wood, In message <1349979213.6903.11@snotra> you wrote: > > I've been signing off patches I apply to the NAND tree. I recall > stopping at one point in the past because someone complained, and then > starting again -- not sure if someone else complained about doing it > *that* wa

Re: [U-Boot] [RFC PATCH 2/2] fs: add partition switch libary, implement ls and fsload commands

2012-10-13 Thread Pavel Herrmann
Hi On Wednesday 10 October 2012 18:05:07 Stephen Warren wrote: > ...snip... > Makefile|3 +- > common/Makefile |2 + > common/cmd_fs.c | 86 ++ > fs/Makefile | 47 > fs/fs.c | 216 > +++

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <20121011203003.02f27b2d@lilith> you wrote: > > > > The Signed-off-by: tag indicates that the signer was involved in the > > > development of the patch, or that he/she was in the patch's delivery path. > > My bad. I've indeed misread the Linux doc. However, the U-

[U-Boot] [PATCH v3 0/5] Nokia RX-51 support

2012-10-13 Thread Pali Rohár
This patch series add support for new board Nokia RX-51 (aka N900). This patch series supersedes version v2. Patch details: Already commited (dropped) patches: cfb_console: Fix function console_back cfb_console: Add function console_clear and console_clear_line cfb_console: Add functions fo

[U-Boot] [PATCH v3 3/5] Add power bus message definitions in twl4030.h

2012-10-13 Thread Pali Rohár
* Code copied from linux kernel 3.0.0 from file include/linux/i2c/twl.h Signed-off-by: Pali Rohár --- include/twl4030.h | 98 + 1 file changed, 98 insertions(+) diff --git a/include/twl4030.h b/include/twl4030.h index 9cd32ab..0c17f59 100644

[U-Boot] [PATCH v3 4/5] cfb_console: Add support for some ANSI terminal escape codes

2012-10-13 Thread Pali Rohár
* This patch add support for move cursor, reverse colors and clear console via ANSI espace codes in cfb_console driver * ANSI escape codes can be enabled/disabled via CONFIG_CFB_CONSOLE_ANSI Signed-off-by: Pali Rohár --- Changes since v2: - Fixed multiline comments Changes since v1: -

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Scott Wood, In message <1349980244.6903.13@snotra> you wrote: > > > The number of people working on next should be small and manageable. > > More people likely use next than some custodian branches, and those are > supposed to be rebase-free... > > Wouldn't anyone developing code for the

[U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

2012-10-13 Thread Pali Rohár
Signed-off-by: Pali Rohár --- arch/arm/include/asm/setup.h |5 + arch/arm/lib/bootm.c |5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index 89df4dc..78a7fac 100644 --- a/arch/arm/include/asm/setup.h +++ b/ar

Re: [U-Boot] [PATCH V3 2/4] FAT: make use of disk_partition_t.part

2012-10-13 Thread Pavel Herrmann
Hi On Wednesday 10 October 2012 12:14:00 Stephen Warren wrote: > From: Stephen Warren > > This removes the standalone cur_part_nr variable, opening the way to > replacing fat_register_device() with fat_set_blk_dev(). > > Note that when get_partition_info() fails and we use the entire disk, > th

[U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Pali Rohár
If dram bank size is calculated at runtime, it can be zero on some boards. This patch added code which ignore these zero bank size in ATAG_MEM. Signed-off-by: Pali Rohár --- arch/arm/lib/bootm.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/13/12 12:30, Wolfgang Denk wrote: [snip] > Yes, I am aware it is also possible to interpret this as "anybody > in the patch's delivery path" - but even then I cannot derive any > obligation for such a passer-on to add his SoB. While also IANAL

Re: [U-Boot] U-Boot git usage model

2012-10-13 Thread Wolfgang Denk
Dear Tom, In message <5079d95e.4070...@ti.com> you wrote: > > While also IANAL (and I try and stay out of these discussions), paging > around in the kernel log it sure seems like Linus and akpm both add > S-O-B when they git am something in (perhaps why there is git am > --signoff?) but not when i

Re: [U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, ... missing commit message ... > Signed-off-by: Pali Rohár > --- > arch/arm/include/asm/setup.h |5 + > arch/arm/lib/bootm.c |5 + > 2 files changed, 10 insertions(+) ... missing changelog ... > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/incl

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > If dram bank size is calculated at runtime, it can be zero on some boards. > This patch added code which ignore these zero bank size in ATAG_MEM. > > Signed-off-by: Pali Rohár > --- > arch/arm/lib/bootm.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/ar

Re: [U-Boot] [PATCH v3 3/5] Add power bus message definitions in twl4030.h

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > * Code copied from linux kernel 3.0.0 from file include/linux/i2c/twl.h Missing commit ... see http://www.denx.de/wiki/U-Boot/Patches#Attributing_Code_Copyrights_Sign [...] Missing changelog [...] Best regards, Marek Vasut ___ U-Bo

Re: [U-Boot] [PATCH v3 4/5] cfb_console: Add support for some ANSI terminal escape codes

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > * This patch add support for move cursor, reverse colors and clear console >via ANSI espace codes in cfb_console driver > * ANSI escape codes can be enabled/disabled via CONFIG_CFB_CONSOLE_ANSI > > Signed-off-by: Pali Rohár > --- Missing v3? > Changes since v2: >-

Re: [U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 01:43:25 Marek Vasut wrote: > Dear Pali Rohár, > > ... missing commit message ... > Is not subject enought? > > Signed-off-by: Pali Rohár > > --- > > > > arch/arm/include/asm/setup.h |5 + > > arch/arm/lib/bootm.c |5 + > > 2 files changed, 10 i

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > Based on previous work by: Alistair Buxton > > Signed-off-by: Pali Rohár > Cc: Ивайло Димитров Can we please stick to ASCII instead of UTF8? Cc: Ivaylo Dimitrov (if I'm not mistaken) > --- > Changes since v2: >- Added documentation in doc/README.nokia_rx51 >- Upda

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 01:45:06 Marek Vasut wrote: > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > > > > + if (bd->bi_dram[i].size == 0) > > + continue; > > This doesn't look right at all, your board is misconfigured if > bd->bi_dram[i] == 0. Did you miscon

Re: [U-Boot] [PATCH v3 3/5] Add power bus message definitions in twl4030.h

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 01:46:30 you wrote: > Dear Pali Rohár, > > > * Code copied from linux kernel 3.0.0 from file > > include/linux/i2c/twl.h > Missing commit ... see > http://www.denx.de/wiki/U-Boot/Patches#Attributing_Code_Copyrig > hts_Sign "... provide terse but precise information which

Re: [U-Boot] [PATCH v3 3/5] Add power bus message definitions in twl4030.h

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 01:46:30 you wrote: > > Dear Pali Rohár, > > > > > * Code copied from linux kernel 3.0.0 from file > > > include/linux/i2c/twl.h > > > > Missing commit ... see > > http://www.denx.de/wiki/U-Boot/Patches#Attributing_Code_Copyrig > > hts_Sign > > "...

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote: > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > > > > > > + if (bd->bi_dram[i].size == 0) > > > + continue; > > > > This doesn't look right at all, your board is misconfigured if > > bd->bi_dr

Re: [U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 01:43:25 Marek Vasut wrote: > > Dear Pali Rohár, > > > > ... missing commit message ... > > Is not subject enought? Sorry, but no. > > > Signed-off-by: Pali Rohár > > > --- > > > > > > arch/arm/include/asm/setup.h |5 + > > > arch/arm/lib

Re: [U-Boot] [PATCH v3 4/5] cfb_console: Add support for some ANSI terminal escape codes

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 01:48:20 Marek Vasut wrote: > Dear Pali Rohár, > > > * This patch add support for move cursor, reverse colors and > > clear console> > >via ANSI espace codes in cfb_console driver > > > > * ANSI escape codes can be enabled/disabled via > > CONFIG_CFB_CONSOLE_ANSI>

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 02:17:01 Marek Vasut wrote: > Dear Pali Rohár, > > > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote: > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > > > > > > > > + if (bd->bi_dram[i].size == 0) > > > > + continue; >

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 02:17:01 Marek Vasut wrote: > > Dear Pali Rohár, > > > > > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote: > > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > > > > > > > > > > + if (bd->bi_dram[i].size == 0) > > > > > +

Re: [U-Boot] [PATCH v3 4/5] cfb_console: Add support for some ANSI terminal escape codes

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 01:48:20 Marek Vasut wrote: > > Dear Pali Rohár, > > > > > * This patch add support for move cursor, reverse colors and > > > clear console> > > > > > >via ANSI espace codes in cfb_console driver > > > > > > * ANSI escape codes can be enable

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 02:27:05 Marek Vasut wrote: > Dear Pali Rohár, > > > On Sunday 14 October 2012 02:17:01 Marek Vasut wrote: > > > Dear Pali Rohár, > > > > > > > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote: > > > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > > > > > > >

Re: [U-Boot] [PATCH v3 3/5] Add power bus message definitions in twl4030.h

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 02:16:10 Marek Vasut wrote: > Dear Pali Rohár, > > > On Sunday 14 October 2012 01:46:30 you wrote: > > > Dear Pali Rohár, > > > > > > > * Code copied from linux kernel 3.0.0 from file > > > > include/linux/i2c/twl.h > > > > > > Missing commit ... see > > > http://www.denx.

Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 02:27:05 Marek Vasut wrote: > > Dear Pali Rohár, > > > > > On Sunday 14 October 2012 02:17:01 Marek Vasut wrote: > > > > Dear Pali Rohár, > > > > > > > > > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote: > > > > > > > for (i = 0; i < CONFIG_NR

Re: [U-Boot] [PATCH v3 3/5] Add power bus message definitions in twl4030.h

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 14 October 2012 02:16:10 Marek Vasut wrote: > > Dear Pali Rohár, > > > > > On Sunday 14 October 2012 01:46:30 you wrote: > > > > Dear Pali Rohár, > > > > > > > > > * Code copied from linux kernel 3.0.0 from file > > > > > include/linux/i2c/twl.h > > > > > > > > Miss

Re: [U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

2012-10-13 Thread Pali Rohár
On Sunday 14 October 2012 02:18:02 Marek Vasut wrote: > Dear Pali Rohár, > > > On Sunday 14 October 2012 01:43:25 Marek Vasut wrote: > > > Dear Pali Rohár, > > > > > > ... missing commit message ... > > > > Is not subject enought? > > Sorry, but no. > Commit message: With this patch is possible to