Re: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

[Pali Rohár]

On Sunday 14 October 2012 02:27:05 Marek Vasut wrote:
> Dear Pali Rohár,
>
> > On Sunday 14 October 2012 02:17:01 Marek Vasut wrote:
> > > Dear Pali Rohár,
> > >
> > > > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote:
> > > > > >     for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
> > > > > >
> > > > > > +           if (bd->bi_dram[i].size == 0)
> > > > > > +                   continue;
> > > > >
> > > > > This doesn't look right at all, your board is
> > > > > misconfigured
> > > > > if
> > > > > bd->bi_dram[i] == 0. Did you misconfigure
> > > > > CONFIG_NR_DRAM_BANKS
> > > > > ?
> > > >
> > > > On some N900 devices there are two banks and on some only
> > > > one. If there is only one it has size 256 MB and if there
> > > > are two both has 128 MB. CONFIG_NR_DRAM_BANKS must be
> > > > specified at compile time, but for N900 I need runtime
> > > > detection.
> > >
> > > How can that be? Are these two banks contiguous?
> >
> > Yes.
>
> And how does the memory map differ in case of device with one
> 256MB block then ?
>

Memory map is same, from 0x80000000 to 0x90000000.

For two bank devices uboot reports:
size000000 start�000000
size000000 start�000000

And for one:
size000000 start�000000
size000000 start�000000

--
Pali Rohár
pali.ro...@gmail.com

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot