Re: [U-Boot] [PATCH v2] nios2: Pseudo implement dcache_status/enable/disable()

2011-10-20 Thread Thomas Chou
On 10/18/2011 12:35 AM, Joachim Foerster wrote: > AFAIK the NIOS2 architecture does not have any possibility to > dynamically switch off the data cache. So _status() always reports 1 and > _enable/_disable() just issue a flush of everything. > > For example, common/cmd_elf.c depends on these symbol

[U-Boot] BOARD_LATE_INIT <-> CONFIG_BOARD_LATE_INIT

2011-10-20 Thread Helmut Raiger
Hi, is there a sound reason, why BOARD_LATE_INIT isn't named like other CONFIG options? I'm inclined to fix this as it took me some time to find out why my board_late_init() wasn't called. Helmut -- Scanned by MailScanner. ___ U-Boot mailing li

Re: [U-Boot] [Resend PATCH V2] misc: pmic: fix regression in pmic_fsl.c (SPI)

2011-10-20 Thread Stefano Babic
On 10/20/2011 08:34 AM, Helmut Raiger wrote: > This fixes write access to PMIC registers, the bug was > introduced partly in commit 64aac65099 and in commit c9fe76dd91. > It was tested on an i.mx31 with a mc13783. > > Signed-off-by: Helmut Raiger > --- > V2: threw in the wrong read back line (ag

Re: [U-Boot] BOARD_LATE_INIT <-> CONFIG_BOARD_LATE_INIT

2011-10-20 Thread Stefano Babic
On 10/20/2011 09:17 AM, Helmut Raiger wrote: > Hi, > Hi Helmut, > is there a sound reason, why BOARD_LATE_INIT isn't named like > other CONFIG options? I'm inclined to fix this as it took me some time > to find out why my board_late_init() wasn't called. I assume that the name was not chan

[U-Boot] [PATCH] arm:exynos4:samsung Support for NURI target

2011-10-20 Thread Lukasz Majewski
This patch adds support for Samsung's Exynos4 (C210) Nuri reference board. New exynos4_nuri board has been added to boards.cfg Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park Cc: Minkyu Kang --- Checkpatch output: total: 0 errors, 0 warnings, 891 lines checked --- board/sa

[U-Boot] [PATCH v2] pci_ftpci100: Implementation FTPCI100 PCI driver

2011-10-20 Thread Macpaul Lin
From: Gavin Guo FTPCI100 is a SoC PCI componenet of Faraday company. Which is usually built into SoC chips for providing embedded PCI functions. Signed-off-by: Gavin Guo Signed-off-by: Macpaul Lin --- Changes for v2: - clean up lines over 80 charaters. drivers/pci/Makefile |1 +

Re: [U-Boot] [PATCH] Makefile: prevent libgcc to be linked twice

2011-10-20 Thread Nicolas Ferre
On 10/18/2011 06:06 PM, Mike Frysinger : > On Tuesday 18 October 2011 04:30:27 Nicolas Ferre wrote: >> On 10/17/2011 07:25 PM, Mike Frysinger : >>> On Monday 17 October 2011 09:41:15 Nicolas Ferre wrote: If we define USE_PRIVATE_LIBGCC, PLATFORM_LIBS is used during link. During this last

[U-Boot] [PATCH v3] nios2: Pseudo implement dcache_status/enable/disable()

2011-10-20 Thread Joachim Foerster
AFAIK the NIOS2 architecture does not have any possibility to dynamically switch off the data cache. So _status() always reports 1 and _enable/_disable() just issue a flush of everything. For example, common/cmd_elf.c depends on these symbols. Signed-off-by: Joachim Foerster --- Changes for v3:

[U-Boot] [PATCH] adp-ag102: add andes_pcu

2011-10-20 Thread Macpaul Lin
fix andes_pcuu Signed-off-by: Macpaul Lin --- include/andes_pcu.h | 367 - include/andestech/andes_pcu.h | 367 + include/configs/adp-ag102.h |2 +- 3 files changed, 368 insertions(+), 368 deletions

Re: [U-Boot] [PATCH] adp-ag102: add andes_pcu

2011-10-20 Thread 馬克泡
Hi Wolfgang, 2011/10/20 Macpaul Lin : > fix andes_pcuu > > Signed-off-by: Macpaul Lin > --- Sorry for sending wrong patch in working branch. Please ingnore it. Thanks! -- Best regards, Macpaul Lin ___ U-Boot mailing list U-Boot@lists.denx.de http://

[U-Boot] OMAP3 NAND ECC bug report

2011-10-20 Thread Arno Steffen
I did tests with OMAP3 uboot. The SW-ECC (testet 1 bit, 4 bit BCH) doesn't correct errors in environment (during power-up). Compiling uboot for default HW-ECC - correction works fine. Testet with TI's PSP 4.02.00.07 (almost like arago latest version). I modified single bits by adding a patch (than

[U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-20 Thread Dirk Eibach
Signed-off-by: Dirk Eibach --- drivers/gpio/Makefile |1 + drivers/gpio/pca9698.c | 143 include/pca9698.h | 34 +++ 3 files changed, 178 insertions(+), 0 deletions(-) create mode 100644 drivers/gpio/pca9698.c create mode 100

[U-Boot] [PATCH v5] ppc4xx: Add Io64 board support

2011-10-20 Thread Dirk Eibach
Board support for the Guntermann & Drunck Io64. Signed-off-by: Dirk Eibach --- Changes for v2: - Added MAINTAINERS entry - Cleaned up issues reported by checkpatch Changes for v3: - migrated board specific init_func_fpga() to board_early_init_r() Changes for v4: - call dtt_init() to start

Re: [U-Boot] [STATUS] "Quality" of patches / testing.

2011-10-20 Thread Detlev Zundel
Hi Wolfgang, [...] > Note # 3 at http://www.denx.de/wiki/U-Boot/Patches says: > > Before sending the patch, you must run the MAKEALL script on > your patched source tree and make sure that no errors or > warnings are reported for any of the boards. Well, at least > not any

Re: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-20 Thread Stefan Roese
On Thursday 20 October 2011 11:12:20 Dirk Eibach wrote: > Signed-off-by: Dirk Eibach Next time please update the patch version in the subject and add the changes below the "---" line. Other than this: Acked-by: Stefan Roese Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang

[U-Boot] [PATCH v3] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-20 Thread Dirk Eibach
Signed-off-by: Dirk Eibach --- Changes for v2: - fixed parameters for memset() in pca9698_set_output() Changes for v3: - add license info to pca9698.h - adapt API to standard GPIO API drivers/gpio/Makefile |1 + drivers/gpio/pca9698.c | 143 +++

Re: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-20 Thread Eibach, Dirk
> Next time please update the patch version in the subject and > add the changes below the "---" line. Other than this: Oops, wrong serialization of save / git-send-email. I did a resend. Cheers Dirk ___ U-Boot mailing list U-Boot@lists.denx.de htt

[U-Boot] [PATCH] cosmetic: s/BOARD_LATE_INIT/CONFIG_BOARD_LATE_INIT

2011-10-20 Thread Helmut Raiger
This renames BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT. Alongside it removes some leftover #define BOARD_LATE_INIT1 Signed-off-by: Helmut Raiger --- arch/arm/lib/board.c |2 +- arch/sandbox/lib/board.c |2 +- arch/sh/lib/board.c

Re: [U-Boot] [PATCH] cosmetic: s/BOARD_LATE_INIT/CONFIG_BOARD_LATE_INIT

2011-10-20 Thread Stefano Babic
On 10/20/2011 11:53 AM, Helmut Raiger wrote: > This renames BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT. > Alongside it removes some leftover > #define BOARD_LATE_INIT 1 > > Signed-off-by: Helmut Raiger > --- Hi Helmut, > arch/arm/lib/board.c |2 +- > arch/sandb

Re: [U-Boot] [PATCH] mii: miiphy register address width change

2011-10-20 Thread Kumar Nath, Chandan
Hi Mike, This patch was acked on September 21, but in latest code base I could not find this patch. Is there anything left which I need to take care in my patch. If so, please let me know so that this can be picked up. Regards Chandan > -Original Message- > From: Mike Frysinger [mailto:

[U-Boot] Message delivered from Microsoft Forefront Protection for Exchange Server Quarantine

2011-10-20 Thread ForefrontServerProtection
The body from the message ""Re: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port"", originally sent to you by u-boot-boun...@lists.denx.de (u-boot-boun...@lists.denx.de), has been forwarded to you from the Microsoft Forefront Server Protection Quarantine area. This message body may have be

Re: [U-Boot] [PATCH] cosmetic: s/BOARD_LATE_INIT/CONFIG_BOARD_LATE_INIT

2011-10-20 Thread Stefano Babic
On 10/20/2011 01:17 PM, Helmut Raiger wrote: > On 10/20/2011 12:12 PM, Stefano Babic wrote: >> >> I know there is not yet a description of the switch in the README file. >> However, we should take this occasion to add the right documentation. >> >> Change also the README file, adding the meaning of

[U-Boot] Pull request for u-boot-marvell.git

2011-10-20 Thread Prafulla Wadaskar
Hi Albert Please kindly pull The following changes since commit 457c2c8e1e1d201beb32961acb5520cf240373ab: Fabio Estevam (1): imx: fix coding style are available in the git repository at: u-boot-marvell.git master branch. Ajay Bhargav (4): SPI: Add SPI driver support for Marvel

[U-Boot] [PATCH] mv_common.c: get rid of 'defined but not used' warning

2011-10-20 Thread Michael Jones
When CONFIG_ENV_IS_NOWHERE, got following warning: mv_common.c:32:14: warning: 'entries_to_keep' defined but not used. Get rid of this warning. Signed-off-by: Michael Jones --- board/matrix_vision/common/mv_common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/board/

Re: [U-Boot] [PATCH] mv_common.c: get rid of 'defined but not used' warning

2011-10-20 Thread Andre Schwarz
Am 20.10.2011 13:37, schrieb Michael Jones: > When CONFIG_ENV_IS_NOWHERE, got following warning: > mv_common.c:32:14: warning: 'entries_to_keep' defined but not used. > Get rid of this warning. > > Signed-off-by: Michael Jones Acked-by: Andre Schwarz > --- > board/matrix_vision/common/mv_common

Re: [U-Boot] [PATCH 5/7] omap_gpmc: use SOFTECC in SPL if it's enabled

2011-10-20 Thread Simon Schwarz
Hi Ilya, On 10/18/2011 01:33 AM, Ilya Yanok wrote: > Use software ECC for the SPL build if support for software ECC in SPL is > enabled. I'am curious: Is there a special reason for having software ecc in SPL? Regards Simon ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH v2] pci_ftpci100: Implementation FTPCI100 PCI driver

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 04:16:25 Macpaul Lin wrote: > --- /dev/null > +++ b/drivers/pci/pci_ftpci100.c > > +#ifndef __io > +#define __io > +#endif this is most likely wrong. drop it. > +#include > +#include /* u32, u16 used by pci.h */ > +#include > +#include > +#include the asm/ i

Re: [U-Boot] [PATCH V4 1/3] lcd: add clear and draw bitmap declaration

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 01:38:44 Che-Liang Chiou wrote: > --- a/include/lcd.h > +++ b/include/lcd.h > > +int lcd_display_bitmap(ulong bmp_image, int x, int y); nice. can you fix common/cmd_bmp.c while you're at it and delete the inline extern decl for this func ? -mike signature.asc Descr

Re: [U-Boot] [PATCH V4 2/3] tools: logo: add static and unused to bmp arrays

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 01:38:45 Che-Liang Chiou wrote: > The generated header bmp_logo.h is useful even outside common/lcd.c for > the logo dimension. However, the problem is, the generated bmp_logo.h > cannot be included multiple times because bmp_logo_palette[] and > bmp_logo_bitmap[] are d

Re: [U-Boot] [PATCH V4 3/3] api: export LCD device to external apps

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 01:38:46 Che-Liang Chiou wrote: > --- a/api/api.c > +++ b/api/api.c > > +/* > + * pseudo signature: > + * > + * int API_display_get_info(int type, struct display_info *di) > + */ > +static int API_display_get_info(va_list ap) > +{ > + int type; > + struct displa

Re: [U-Boot] [PATCH] mii: miiphy register address width change

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 06:34:33 Kumar Nath, Chandan wrote: > This patch was acked on September 21, but in latest code base I could not > find this patch. Is there anything left which I need to take care in my > patch. If so, please let me know so that this can be picked up. i don't merge net

Re: [U-Boot] [PATCH] mii: miiphy register address width change

2011-10-20 Thread Kumar Gala
On Oct 20, 2011, at 8:26 AM, Mike Frysinger wrote: > On Thursday 20 October 2011 06:34:33 Kumar Nath, Chandan wrote: >> This patch was acked on September 21, but in latest code base I could not >> find this patch. Is there anything left which I need to take care in my >> patch. If so, please let

Re: [U-Boot] [PATCH] mii: miiphy register address width change

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 09:55:34 Kumar Gala wrote: > On Oct 20, 2011, at 8:26 AM, Mike Frysinger wrote: > > On Thursday 20 October 2011 06:34:33 Kumar Nath, Chandan wrote: > >> This patch was acked on September 21, but in latest code base I could > >> not find this patch. Is there anything left

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <8b4ac84d-1f22-4326-b75a-fb3cc39a5...@boeing.com> you wrote: > > By that definition, my board cannot safely use U-Boot's "reset" command. You can call halt() or panic() as last stage of your reset implementation. Heh. Mike writes the same ;-) > Would you acce

Re: [U-Boot] [PATCH] mii: miiphy register address width change

2011-10-20 Thread Kumar Nath, Chandan
> -Original Message- > From: Mike Frysinger [mailto:vap...@gentoo.org] > Sent: Thursday, October 20, 2011 7:28 PM > To: Kumar Gala > Cc: Kumar Nath, Chandan; u-boot@lists.denx.de List; Andy Fleming > Subject: Re: [U-Boot] [PATCH] mii: miiphy register address width change > > On Thursday 20

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Wolfgang Denk
Dear Stephen Warren, In message <74cdbe0f657a3d45afbb94109fb122ff173d51b...@hqmail01.nvidia.com> you wrote: > > > Please give me a bit more context - how much is "a few 10s of bytes", > > and which exact parts of the code are we talkign about? > > How much? However much adding an extra value int

[U-Boot] [PATCH V2] cosmetic: s/BOARD_LATE_INIT/CONFIG_BOARD_LATE_INIT

2011-10-20 Thread Helmut Raiger
This renames BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT. Along the way it removes some leftover #define BOARD_LATE_INIT1 and adds some basic documentation for board specific callbacks in README. Signed-off-by: Helmut Raiger --- V2: added some docu in README README

Re: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message <1319063459-4804-2-git-send-email-diand...@chromium.org> you wrote: > It appears that there are a handful of places in u-boot that we want > to munge the linux command line. This adds some helper functions that > make that easier. > > Signed-off-by: Doug Anderson

Re: [U-Boot] [PATCH 2/4] cosmetic: Fixup fixup_silent_linux() for checkpatch

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message <1319063459-4804-3-git-send-email-diand...@chromium.org> you wrote: > Signed-off-by: Doug Anderson > Reviewed-by: Anton Staaf > --- > common/cmd_bootm.c | 25 + > 1 files changed, 13 insertions(+), 12 deletions(-) Applied, thanks. Best

Re: [U-Boot] [PATCH 3/4] bootm: Avoid 256-byte overflow in fixup_silent_linux()

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message <1319063459-4804-4-git-send-email-diand...@chromium.org> you wrote: > This makes fixup_silent_linux() use malloc() to allocate its > working space, meaning that our maximum kernel command line > should only be limited by malloc(). Previously it was silently > overfl

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message <1319063459-4804-5-git-send-email-diand...@chromium.org> you wrote: > Signed-off-by: Doug Anderson > --- > common/cmd_bootm.c | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) As before, I see very little (actually, none at all) need for such f

Re: [U-Boot] [PATCH 5/7] omap_gpmc: use SOFTECC in SPL if it's enabled

2011-10-20 Thread Ilya Yanok
Hi Simon, On 20.10.2011 16:00, Simon Schwarz wrote: >> Use software ECC for the SPL build if support for software ECC in SPL is >> enabled. > > I'am curious: Is there a special reason for having software ecc in SPL? Well, yes. On OMAP2+ ECC mode defaults to software (incompatible with HW mode; 2

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <510974e8-a0c8-4e81-a034-b52f2aed1...@boeing.com> you wrote: > > > so why can't you have your do_reset() board hook negotiate with the other > > CPU > > to reset the system ? > > That's what I originally implemented. The problem is the negotiation can take > a

Re: [U-Boot] [STATUS] "Quality" of patches / testing.

2011-10-20 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > OK I have done this. It's a little rough but at least a starting Thanks! > point. I hope you really like Python because there is plenty of it :-) Actually I don't (didn't really learn it yet), but then I don;t have to if I can just use the stuff :-

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Stephen Warren
Wolfgang Denk wrote at Thursday, October 20, 2011 8:04 AM: > In message <74cdbe0f657a3d45afbb94109fb122ff173d51b...@hqmail01.nvidia.com> > you wrote: > > > > > Please give me a bit more context - how much is "a few 10s of bytes", > > > and which exact parts of the code are we talkign about? > > >

[U-Boot] No prompt on mx25pdk boot

2011-10-20 Thread Hugo Holgersson
Dear readers, I have problems running U-Boot on my i.MX 25 PDK board. I have tried two methods: (A) git clone git://www.denx.de/git/u-boot-imx.git master nano board/freescale/mx25pdk/imximage.cfg # change to BOOT_FROM nand make CROSS_COMPILE=arm-none-linux-gnueabi- mx25pdk_config make CROSS_C

Re: [U-Boot] No prompt on mx25pdk boot

2011-10-20 Thread Fabio Estevam
Hi Hugo, On Thu, Oct 20, 2011 at 2:04 PM, Hugo Holgersson wrote: > Dear readers, > > I have problems running U-Boot on my i.MX 25 PDK board. > > I have tried two methods: > > (A) > git clone git://www.denx.de/git/u-boot-imx.git master > nano board/freescale/mx25pdk/imximage.cfg  # change to BOOT_

Re: [U-Boot] No prompt on mx25pdk boot

2011-10-20 Thread Fabio Estevam
On Thu, Oct 20, 2011 at 2:42 PM, Hugo Holgersson wrote: > Hi Fabio! > > No I have not, I need to find one SD card. For flashing the SD card with u-boot.imx you can follow doc/README.imximage file. > Meanwhile, do you have any tips and tricks to aid the debugging on this board? > > For example, c

Re: [U-Boot] No prompt on mx25pdk boot

2011-10-20 Thread Hugo Holgersson
Hi Fabio! No I have not, I need to find one SD card. Meanwhile, do you have any tips and tricks to aid the debugging on this board? For example, can the JTAG-connector of the debug board serve me anyhow? Unfortunately, I do not own the Abatron BDI2000 device, I only got the Segger J-Link. B

Re: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

2011-10-20 Thread Doug Anderson
Wolfgang, On Thu, Oct 20, 2011 at 7:36 AM, Wolfgang Denk wrote: > Sorry, but could you please explain why anybody would need this? > I'm happy to explain. :) In our setup, the Linux command line is constructed (in part) by reading from the disk. When we load the kernel, we also load the kern

Re: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 13:06:23 Doug Anderson wrote: > Based on your comments, I'll assume that you're not interested in the more > general command line munging tools and will abandon them for now until > there is a clear need for them. what is the difference in compiled sizes ? if the abstr

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-20 Thread Doug Anderson
Wolfgang, On Thu, Oct 20, 2011 at 7:42 AM, Wolfgang Denk wrote: > As before, I see very little (actually, none at all) need for such > function. Things like that should be handled usign environment > variables in a clever way. > > Please explain why you think this code is needed. > I'm not sur

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Moffett, Kyle D
On Oct 20, 2011, at 10:02, Wolfgang Denk wrote: > Dear "Moffett, Kyle D", > In message <8b4ac84d-1f22-4326-b75a-fb3cc39a5...@boeing.com> you wrote: >> >> Would you accept a patch which makes it possible for a board to not >> implement a "reset" command at all? >> >> There are a few places in comm

[U-Boot] [PATCH v2] bootm: Avoid 256-byte overflow in fixup_silent_linux()

2011-10-20 Thread Doug Anderson
This makes fixup_silent_linux() use malloc() to allocate its working space, meaning that our maximum kernel command line should only be limited by malloc(). Previously it was silently overflowing the stack. Signed-off-by: Doug Anderson --- v2: This is a simpler version of patch 3/4 in my previou

[U-Boot] [PATCH] bootm: Use "panic()" in non-recoverable error conditions

2011-10-20 Thread Kyle Moffett
All of these errors are various kinds of fatal memory overwrite conditions and so should be handled by panic(). This fixes a bug in which the error message might not get all the way out to the serial console before the system reboots; panic() has a built-in delay after doing a printf() before call

Re: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

2011-10-20 Thread Doug Anderson
Mike, On Thu, Oct 20, 2011 at 10:15 AM, Mike Frysinger wrote: > what is the difference in compiled sizes ? if the abstracted funcs add > negligible overhead, i think merging these locally in the bootm code might > make sense in a pure clean up sense ... > Compared to the simple version I just

Re: [U-Boot] [PATCH] mii: miiphy register address width change

2011-10-20 Thread Kumar Gala
On Oct 20, 2011, at 9:03 AM, Kumar Nath, Chandan wrote: >> -Original Message- >> From: Mike Frysinger [mailto:vap...@gentoo.org] >> Sent: Thursday, October 20, 2011 7:28 PM >> To: Kumar Gala >> Cc: Kumar Nath, Chandan; u-boot@lists.denx.de List; Andy Fleming >> Subject: Re: [U-Boot] [PATC

Re: [U-Boot] [PATCH V4 2/3] tools: logo: add static and unused to bmp arrays

2011-10-20 Thread Wolfgang Denk
Dear Che-Liang Chiou, in message <201110200842.02506.vap...@gentoo.org> Mike Frysinger wrote: > > i'm not sure this is the right way to go. what if we split bmp_logo.h > instead > into bmp_logo_data.h (which has the array contents) and bmp_log.h (which has > the defines and externs for the da

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Wolfgang Denk
Dear Stephen Warren, In message <74cdbe0f657a3d45afbb94109fb122ff173d51c...@hqmail01.nvidia.com> you wrote: > > > > > Please give me a bit more context - how much is "a few 10s of bytes", > > > > and which exact parts of the code are we talkign about? > > > > > > How much? However much adding an

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Stephen Warren
Wolfgang Denk wrote at Thursday, October 20, 2011 12:57 PM: > In message <74cdbe0f657a3d45afbb94109fb122ff173d51c...@hqmail01.nvidia.com> > you wrote: > > > > > > > Please give me a bit more context - how much is "a few 10s of bytes", > > > > > and which exact parts of the code are we talkign abou

Re: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message you wrote: > > I'm happy to explain. :) In our setup, the Linux command line is > constructed (in part) by reading from the disk. When we load the kernel, we > also load the kernel command line. It is convenient for us if this kernel > command line on disk cont

[U-Boot] [PATCH 0/8] tegra2: Implement SPI flash and saved environment

2011-10-20 Thread Simon Glass
Enable SPI flash on the Tegra2 Seaboard along with a saved 8KB environment. This involves a few pieces: - Tegra2 SPI driver - Seaboard config changes - a SPI / UART switch to handle switching between SPI and console UART This series applies cleanly on top of Stephen Warren's latest patch series

[U-Boot] [PATCH 2/8] tegra2: Add UARTB support

2011-10-20 Thread Simon Glass
UARTB is used on some boards, so support it here. Signed-off-by: Simon Glass --- board/nvidia/common/board.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c index a5da310..a2d45c1 100644 --- a/board/nvid

[U-Boot] [PATCH 1/8] tegra2: Tidy UART selection

2011-10-20 Thread Simon Glass
UART selection is done with a lot of #ifdefs. This cleans things up a little. Signed-off-by: Simon Glass --- board/nvidia/common/board.c | 57 +- 1 files changed, 34 insertions(+), 23 deletions(-) diff --git a/board/nvidia/common/board.c b/board/nvidia/

[U-Boot] [PATCH 3/8] tegra2: spi: Add SPI driver for SPIFLASH on Seaboard

2011-10-20 Thread Simon Glass
From: Tom Warren This driver supports SPI on Tegra2, running at 48MHz. Signed-off-by: Tom Warren --- arch/arm/include/asm/arch-tegra2/tegra2_spi.h | 75 board/nvidia/common/board.c |4 + drivers/spi/Makefile |1 + drivers/spi/tegra2

[U-Boot] [PATCH 7/8] tegra2: spi: Support SPI / UART switch

2011-10-20 Thread Simon Glass
Add the SPI / UART switch logic into the Tegra2 SPI driver so that it can co-exist with the NS16550 UART. Signed-off-by: Simon Glass --- drivers/spi/tegra2_spi.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/spi/tegra2_spi.c b/drivers/spi/tegra2_spi.c

[U-Boot] [PATCH 6/8] tegra2: Implement SPI / UART GPIO switch

2011-10-20 Thread Simon Glass
The Tegra2 Seaboard has the unfortunate feature that SPI and the console UART are multiplexed on the same pins. We need to switch between one and the other during SPI and console activity. This new file implements a switch and keeps track of which peripheral owns the pins. It also flips over the c

[U-Boot] [PATCH 4/8] tegra2: config: Enable SPI flash on Seaboard

2011-10-20 Thread Simon Glass
The Seaboard includes a Winbond 4MB flash part. Signed-off-by: Simon Glass --- include/configs/seaboard.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h index 7d29144..7e8c8cc 100644 --- a/include/config

[U-Boot] [PATCH 5/8] tegra2: Enable SPI environment on Seaboard

2011-10-20 Thread Simon Glass
This uses the SPI flash on Seaboard to store an 8KB environment. Signed-off-by: Simon Glass --- include/configs/harmony.h |3 +++ include/configs/seaboard.h |6 ++ include/configs/tegra2-common.h |3 +-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/i

[U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code

2011-10-20 Thread Simon Glass
On Seaboard the UART and SPI interfere with each other. This causes the UART to receive spurious zero bytes after SPI transactions and also means that SPI can corrupt a few output characters when it starts up if they are still in the UART buffer. This updates the board to use the SPI/UART switch t

[U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET

2011-10-20 Thread Kyle Moffett
This new #define is set by default in config_cmd_defaults.h, and config_cmd_all.h, but this allows boards to conditionally omit the "reset" command if necessary. Signed-off-by: Kyle Moffett --- README|1 + common/cmd_boot.c |2 ++ include/config_cmd_al

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Simon Glass
Hi Wolfgang, On Thu, Oct 20, 2011 at 12:03 PM, Stephen Warren wrote: > Wolfgang Denk wrote at Thursday, October 20, 2011 12:57 PM: >> In message <74cdbe0f657a3d45afbb94109fb122ff173d51c...@hqmail01.nvidia.com> >> you wrote: >> > >> > > > > Please give me a bit more context - how much is "a few 1

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message you wrote: > > I'm not sure I understand your comment. It sounds to me like you're saying > that fixup_silent_linux() (which already exists in u-boot code) shouldn't be > needed anymore in u-boot. ...and maybe you're considering it deprecated? I consider at leas

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <5bf60315-656d-4173-8722-9e2ec99aa...@boeing.com> you wrote: > > For the boards that *do* set CONFIG_PANIC_HANG, none of the fatal > errors in common/cmd_bootm.c should cause U-Boot to reset, they are > all valid panic() conditions, such as GZIP overwrite errors

Re: [U-Boot] [PATCH] bootm: Use "panic()" in non-recoverable error conditions

2011-10-20 Thread Wolfgang Denk
Dear Kyle Moffett, In message <1319134031-28503-1-git-send-email-kyle.d.moff...@boeing.com> you wrote: > All of these errors are various kinds of fatal memory overwrite > conditions and so should be handled by panic(). This fixes a bug in > which the error message might not get all the way out t

Re: [U-Boot] [PATCH 5/8] tegra2: Enable SPI environment on Seaboard

2011-10-20 Thread Tom Warren
Simon, > -Original Message- > From: Simon Glass [mailto:s...@chromium.org] > Sent: Thursday, October 20, 2011 12:03 PM > To: U-Boot Mailing List > Cc: Albert ARIBAUD; Tom Warren; Stephen Warren; Simon Glass > Subject: [PATCH 5/8] tegra2: Enable SPI environment on Seaboard > > This uses th

[U-Boot] [PATCH] usb: align usb_endpoint_descriptor to 16-bit boundary

2011-10-20 Thread Stefan Kristiansson
The usb_endpoint_descriptor struct is 7 bytes large and is defined as an array (ep_desc[USB_MAXENDPOINTS]) in the usb_interface struct in include/usb.h This fact will result in that every odd index in that array will start at an uneven address, this in turn makes accesses to u16 wMaxPacketSize una

Re: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message you wrote: > > ...then, we can decide if we want to add the abstract munging tools and > where to add them (either a separate lib/cmdline.c file or direct into > bootm). If you want them, I'll submit a patch with all of your review > feedback addressed and a seco

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Wolfgang Denk
Dear Stephen Warren, In message <74cdbe0f657a3d45afbb94109fb122ff173d51c...@hqmail01.nvidia.com> you wrote: > > Sorry, but why exactly? Because I'm short of time, and would consider it helpful if you explain that you mean? > The patch I posted doesn't add size to the U-Boot binary without the >

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > My comment was that if code size could increase slightly the code > could have less #ifdefs. Wolfgang said that it could not, and > therefore my comments do not apply. Please ignore them Wolfgang and > Stephen. DOn;t give up to oearly. My opinion is

Re: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

2011-10-20 Thread Stephen Warren
Wolfgang Denk wrote at Thursday, October 20, 2011 1:39 PM: > In message > you > wrote: > > > > My comment was that if code size could increase slightly the code > > could have less #ifdefs. Wolfgang said that it could not, and > > therefore my comments do not apply. Please ignore them Wolfgang

Re: [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote: > This new #define is set by default in config_cmd_defaults.h, and > config_cmd_all.h, but this allows boards to conditionally omit the > "reset" command if necessary. ignoring the related issues as i'm sure Wolfgang will chime in ... > ---

Re: [U-Boot] [PATCH 5/8] tegra2: Enable SPI environment on Seaboard

2011-10-20 Thread Simon Glass
Hi Tom, On Thu, Oct 20, 2011 at 12:31 PM, Tom Warren wrote: > Simon, > >> -Original Message- >> From: Simon Glass [mailto:s...@chromium.org] >> Sent: Thursday, October 20, 2011 12:03 PM >> To: U-Boot Mailing List >> Cc: Albert ARIBAUD; Tom Warren; Stephen Warren; Simon Glass >> Subject: [

Re: [U-Boot] [PATCH 3/8] tegra2: spi: Add SPI driver for SPIFLASH on Seaboard

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 15:03:24 Simon Glass wrote: > This driver supports SPI on Tegra2, running at 48MHz. the summary says "SPIFLASH" and "Seaboard". sounds like this is a tegra2 SoC issue, and so driver/board specific info shouldn't be in the summary. adding notes to the changelog as to

Re: [U-Boot] [PATCH 6/8] tegra2: Implement SPI / UART GPIO switch

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 15:03:27 Simon Glass wrote: > The Tegra2 Seaboard has the unfortunate feature that SPI and the console > UART are multiplexed on the same pins. We need to switch between one > and the other during SPI and console activity. so how does printf()/debug() work in the spi dr

Re: [U-Boot] [PATCH] bootm: Use "panic()" in non-recoverable error conditions

2011-10-20 Thread Moffett, Kyle D
On Oct 20, 2011, at 15:31, Wolfgang Denk wrote: > Dear Kyle Moffett, > In message <1319134031-28503-1-git-send-email-kyle.d.moff...@boeing.com> you > wrote: >> All of these errors are various kinds of fatal memory overwrite >> conditions and so should be handled by panic(). This fixes a bug in >>

Re: [U-Boot] [PATCH 7/8] tegra2: spi: Support SPI / UART switch

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 15:03:28 Simon Glass wrote: > --- a/drivers/spi/tegra2_spi.c > +++ b/drivers/spi/tegra2_spi.c > > +#include /* for NS16550_drain and NS16550_clear */ except you don't use those funcs in this file ... so this include shouldn't be here ? > +#include "uart-spi-fix.h" t

Re: [U-Boot] [PATCH 6/8] tegra2: Implement SPI / UART GPIO switch

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 15:03:27 Simon Glass wrote: > +void uart_enable(NS16550_t regs); > +void spi_enable(void); also, you're not really enabling these devices, you're switching the pinmux. so perhaps a better name would be "pinmux_select_uart()" ? or something similar ? -mike signatur

Re: [U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 15:03:29 Simon Glass wrote: > --- a/board/nvidia/seaboard/seaboard.c > +++ b/board/nvidia/seaboard/seaboard.c > > +/* TODO: Remove this code when the SPI switch is working */ > +#ifndef CONFIG_SPI_UART_SWITCH eh ? isn't it working after these patches ? -mike signatur

Re: [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET

2011-10-20 Thread Moffett, Kyle D
On Oct 20, 2011, at 15:53, Mike Frysinger wrote: > On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote: >> --- a/common/cmd_boot.c >> +++ b/common/cmd_boot.c >> @@ -71,8 +71,10 @@ U_BOOT_CMD( >> >> #endif >> >> +#ifdef CONFIG_CMD_RESET >> U_BOOT_CMD( >> reset, 1, 0,do_reset, >>

Re: [U-Boot] Pull request for u-boot-marvell.git

2011-10-20 Thread Albert ARIBAUD
Hi Prafulla, Le 20/10/2011 13:36, Prafulla Wadaskar a écrit : > Hi Albert > > Please kindly pull > The following changes since commit 457c2c8e1e1d201beb32961acb5520cf240373ab: >Fabio Estevam (1): > imx: fix coding style > > are available in the git repository at: > >u-boot-marvell

Re: [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 16:10:10 Moffett, Kyle D wrote: > On Oct 20, 2011, at 15:53, Mike Frysinger wrote: > > On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote: > >> --- a/common/cmd_boot.c > >> +++ b/common/cmd_boot.c > >> @@ -71,8 +71,10 @@ U_BOOT_CMD( > >> > >> #endif > >> > >> +#if

Re: [U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code

2011-10-20 Thread Simon Glass
Hi Mike, On Thu, Oct 20, 2011 at 1:09 PM, Mike Frysinger wrote: > On Thursday 20 October 2011 15:03:29 Simon Glass wrote: >> --- a/board/nvidia/seaboard/seaboard.c >> +++ b/board/nvidia/seaboard/seaboard.c >> >> +/* TODO: Remove this code when the SPI switch is working */ >> +#ifndef CONFIG_SPI_U

Re: [U-Boot] [PATCH v2 REPOST 3/3] tegra2: Enable CONFIG_SYS_RELATIVE_IMAGES

2011-10-20 Thread Simon Glass
Hi Stephen, On Wed, Oct 19, 2011 at 8:24 AM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, October 18, 2011 7:04 PM: >> On Tue, Oct 18, 2011 at 2:11 PM, Stephen Warren wrote: >> > v2: New patch >> > >> > Signed-off-by: Stephen Warren >> >> Looks good - how do I make such an image so I c

Re: [U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 16:23:33 Simon Glass wrote: > On Thu, Oct 20, 2011 at 1:09 PM, Mike Frysinger wrote: > > On Thursday 20 October 2011 15:03:29 Simon Glass wrote: > >> --- a/board/nvidia/seaboard/seaboard.c > >> +++ b/board/nvidia/seaboard/seaboard.c > >> > >> +/* TODO: Remove this code

Re: [U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code

2011-10-20 Thread Simon Glass
Hi Mike, On Thu, Oct 20, 2011 at 1:34 PM, Mike Frysinger wrote: > On Thursday 20 October 2011 16:23:33 Simon Glass wrote: >> On Thu, Oct 20, 2011 at 1:09 PM, Mike Frysinger wrote: >> > On Thursday 20 October 2011 15:03:29 Simon Glass wrote: >> >> --- a/board/nvidia/seaboard/seaboard.c >> >> +++ b

Re: [U-Boot] [PATCH v2 REPOST 3/3] tegra2: Enable CONFIG_SYS_RELATIVE_IMAGES

2011-10-20 Thread Stephen Warren
Simon Glass wrote at Thursday, October 20, 2011 2:27 PM: > Hi Stephen, > > On Wed, Oct 19, 2011 at 8:24 AM, Stephen Warren wrote: > > Simon Glass wrote at Tuesday, October 18, 2011 7:04 PM: > >> On Tue, Oct 18, 2011 at 2:11 PM, Stephen Warren wrote: > >> > v2: New patch > >> > > >> > Signed-off-

Re: [U-Boot] [PATCH 5/8] tegra2: Enable SPI environment on Seaboard

2011-10-20 Thread Tom Warren
Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Thursday, October 20, 2011 12:58 PM > To: Tom Warren > Cc: U-Boot Mailing List; Albert ARIBAUD; Stephen Warren > Subject: Re: [PATCH 5/8] tegra2: Enable SPI environment on Seaboard

Re: [U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code

2011-10-20 Thread Mike Frysinger
On Thursday 20 October 2011 16:44:26 Simon Glass wrote: > Given the current mess around the eserial structure definition macros > I would need to copy that again and create a set of _putc(), _puts() > functions for each UART I think. It could be done once serial is > cleaned up, but really don't wa

[U-Boot] [PATCH v2] ne2000: Convert to new net-multi model, fixes build of three boards

2011-10-20 Thread Bernhard Kaindl
This fixes the build of the two sh boards shmin and r7780mp and qemu-mips which currently fail to build due to dropped pre-CONFIG_NET_MULTI code. This v2 patch minimizes the number of lines in the diff for easy review and to eliminate any possible accidential changes resulting from moving lines of

  1   2   >