On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote:
> This new #define is set by default in config_cmd_defaults.h, and
> config_cmd_all.h, but this allows boards to conditionally omit the
> "reset" command if necessary.

ignoring the related issues as i'm sure Wolfgang will chime in ...

> --- a/common/cmd_boot.c
> +++ b/common/cmd_boot.c
> @@ -71,8 +71,10 @@ U_BOOT_CMD(
> 
>  #endif
> 
> +#ifdef CONFIG_CMD_RESET
>  U_BOOT_CMD(
>       reset, 1, 0,    do_reset,
>       "Perform RESET of the CPU",
>       ""
>  );
> +#endif

would be a good time to split this into a dedicated common/cmd_reset.c

> --- a/include/config_cmd_all.h
> +++ b/include/config_cmd_all.h
>
> --- a/include/config_cmd_defaults.h
> +++ b/include/config_cmd_defaults.h

updating these files is not sufficient and will break boards.  drop the hunks 
to 
these files and update include/config_defaults.h instead.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to