Re: [U-Boot] [PATCH v2 3/3] ppc/p1_p1_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Dudhat Dipen-B09055
-Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Thursday, October 08, 2009 7:33 PM To: Dudhat Dipen-B09055 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v2 3/3] ppc/p1_p1_RDB: DDR Relocation support for NAND/SD/eSPI Boot [snip] > --- a/nand_spl/boa

[U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini If source and destination are aligned, this copies ulong values until possible, trailing part is copied by byte. Thanks for the details to Wolfgang Denk, Mike Frysinger, Peter Tyser, Chris Moore. Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- lib_generic/s

[U-Boot] [PATCH V3 2/3] lib_generic memset: fill one word at a time if possible

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini If the destination is aligned, fill ulong values until possible. Then fill remaining part by bytes. Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- lib_generic/string.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff -

[U-Boot] [PATCH V3 3/3] lcd: remove '#if 0' 32-bit scroll, now memcpy does it

2009-10-09 Thread Alessandro Rubini
Actually, we should use memmove here, as areas overlap, but memmove is not yet optimized. From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- common/lcd.c | 21 - 1 files changed, 0 insertions(+), 21 deletions(-) diff --git a/common/lcd.c

[U-Boot] [PATCH 1/2] fix cpuat91 compile warning

2009-10-09 Thread Eric Benard
main.c: In function 'abortboot': main.c:122: warning: too few arguments for format Signed-off-by: Eric Benard --- include/configs/cpuat91.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/cpuat91.h b/include/configs/cpuat91.h index 0d3acf6..8746f70 100

[U-Boot] [PATCH 2/2] fix CPU9260/CPU9G20 compile warnings

2009-10-09 Thread Eric Benard
nand_util.c:45:2: warning: #warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output! Signed-off-by: Eric Benard --- include/configs/cpu9260.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/configs/cpu9260.h b/include/configs/cpu9260.h index 4ef8566..

Re: [U-Boot] [PATCH V2 1/3] memcpy: copy one word at a time if possible

2009-10-09 Thread Mark Jackson
Chris Moore wrote: > I agree wholeheartedly with the idea but shouldn't it be more like this > (untested) code : > > void * memcpy(void *dest, const void *src, size_t count) > > { > char *d8, *s8; > unsigned long *dl = dest, *sl = src; > In here, would it be overkill to add byte co

Re: [U-Boot] [PATCH V3 1/3] lib_generic memcpy : copy one word at a time if possible

2009-10-09 Thread Mike Frysinger
On Friday 09 October 2009 05:12:20 Alessandro Rubini wrote: > + /* while all data is aligned (common case), copy a word at a time */ > + if ( (((ulong)dest | (ulong)src | count) & (sizeof(*dl) - 1)) == 0) { i think you want to drop the count from the list, otherwise we dont consume the le

Re: [U-Boot] [PATCH V2 1/3] memcpy: copy one wor d at a time if possible

2009-10-09 Thread Mike Frysinger
On Friday 09 October 2009 06:11:16 Mark Jackson wrote: > Chris Moore wrote: > > I agree wholeheartedly with the idea but shouldn't it be more like this > > (untested) code : > > > > void * memcpy(void *dest, const void *src, size_t count) > > > > { > > char *d8, *s8; > > unsigned long *dl =

Re: [U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible

2009-10-09 Thread Alessandro Rubini
> i think you want to drop the count from the list, otherwise we dont consume > the leading groups of 4 bytes if count isnt a multiple of 4. Yes, same for memset. See Wolfgang it was not 10% more? These micro optimizations are hairy, as you need to measure them to make sure they work. Ok, V4 tom

Re: [U-Boot] [PATCH V2 1/3] memcpy: copy one word at a time if possible

2009-10-09 Thread Wolfgang Denk
Dear Chris Moore, In message <4acebf19.4010...@free.fr> you wrote: > > I agree wholeheartedly with the idea but shouldn't it be more like this > (untested) code : Thanks for catching this. Of course you are right - my code was untested as well, as usual ;-) Best regards, Wolfgang Denk -- DE

[U-Boot] [PATCH 1/8] video: add amba-clcd prime-cell

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- drivers/video/Makefile |1 + drivers/video/amba.c | 86 include/amba_clcd.h| 85 +++ 3 files changed, 1

[U-Boot] [PATCH 2/8] include/nomadik.h: add physical address for cldc

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- include/nomadik.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/nomadik.h b/include/nomadik.h index d9405fd..ea65b2d 100644 --- a/include/nomadik.h +++ b/include/nomadik.h @@

[U-Boot] [PATCH 3/8] drivers/misc: add stmpe2401 port extender and keypad controller

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- drivers/misc/Makefile|1 + drivers/misc/stmpe2401.c | 176 ++ include/stmpe2401.h | 66 + 3 files changed, 243 insertions(+), 0 deleti

[U-Boot] [PATCH 4/8] nhk8815.h: define we need stmpe

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- include/configs/nhk8815.h |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/include/configs/nhk8815.h b/include/configs/nhk8815.h index a00c2fb..e1be45b 100644 --- a/include/configs

[U-Boot] [PATCH 5/8] lcd: make 16bpp work

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- common/lcd.c | 26 -- 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/common/lcd.c b/common/lcd.c index 4e31618..d05c025 100644 --- a/common/lcd.c +++ b/common/lcd.c @@

[U-Boot] [PATCH 0/8] ARM Nomadik: video and keypad for nhk8815 (and RFC inside)

2009-10-09 Thread Alessandro Rubini
This adds support for display and keypad on the Nomadik evaluation kit. I tried to split the changes as best as I can. First the amba-lcd is added as a generic driver, although it receives pre-computed register values, as it misses the code to assemble register bits from higher-level parameters.

[U-Boot] [PATCH 6/8] nhk8815: added keypad

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- board/st/nhk8815/Makefile |5 ++- board/st/nhk8815/keypad.c | 100 board/st/nhk8815/nhk8815.c |5 ++ include/configs/nhk8815.h |3 + 4 files changed,

[U-Boot] [PATCH 7/8] nhk8815: start lower in RAM, so the 800x480 frame buffer fits

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- board/st/nhk8815/config.mk |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/board/st/nhk8815/config.mk b/board/st/nhk8815/config.mk index 590393b..faf1d53 100644 --- a/board/st/nhk

[U-Boot] [PATCH 8/8] nhk8815: added lcd support

2009-10-09 Thread Alessandro Rubini
From: Alessandro Rubini Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- board/st/nhk8815/Makefile |1 + board/st/nhk8815/lcd.c | 89 board/st/nhk8815/nhk8815.c |4 ++ include/configs/nhk8815.h | 10 + 4 files change

Re: [U-Boot] OneNAND operations.

2009-10-09 Thread Kyungmin Park
Sorry for late reply. At current implementation. only block write supported. Of course, I wrote the partial write. I will post the latest patches. Sorry. Please wait until next Monday Thank you, Kyungmin Park On Thu, Oct 8, 2009 at 6:10 PM, Tuma wrote: > Hello, All! > My next question is abou

Re: [U-Boot] [PATCH v2 3/3] ppc/p1_p1_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Kumar Gala
On Oct 9, 2009, at 2:01 AM, Dudhat Dipen-B09055 wrote: >> + >> +void initsdram(void) >> +{ >> + >> +volatile ccsr_ddr_t *ddr= (ccsr_ddr_t > *)CONFIG_SYS_MPC85xx_DDR_ADDR; >> +int d_init, dbw; >> +volatile ccsr_gpio_t *pgpio = (void *) >> (CONFIG_SYS_MPC85xx_GPIO_ADDR); >> +unsigne

[U-Boot] MIPS cpu has problem detecting CFI

2009-10-09 Thread myuboot
I think I found a problem in cpu/mips/start.S. gp register is used to point to the SDRAM. But after gp is adjusted to proper location, a C function flush_cache is called. But this function actually changes gp register before gp is used to jump to SDRAM. That makes the u-boot run from flash and fai

[U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Dipen Dudhat
DDR support to boot from NAND/eSDHC/eSPI on P1 & P2 RDB platforms. Specifically this support needed when L2 Cache size is less than 512K. Signed-off-by: Dipen Dudhat --- - Applies to http://git.denx.de/u-boot.git - Changes from v2: integrated kumar's comments. board/freescale/p1_p2_rdb/config.mk

Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Scott Wood
On Fri, Oct 09, 2009 at 11:12:04PM +0530, Dipen Dudhat wrote: > DDR support to boot from NAND/eSDHC/eSPI on P1 & P2 RDB platforms. > Specifically this support needed when L2 Cache size is less than 512K. If you're going to use this for eSDHC and eSPI, why is it sitting under nand_spl? -Scott

Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Kumar Gala
On Oct 9, 2009, at 12:42 PM, Dipen Dudhat wrote: > +void initsdram(void) > +{ > + > + volatile ccsr_ddr_t *ddr= (ccsr_ddr_t *)CONFIG_SYS_MPC85xx_DDR_ADDR; > + int d_init, dbw; > + volatile ccsr_gpio_t *pgpio = (void *) > (CONFIG_SYS_MPC85xx_GPIO_ADDR); > + unsigned int ddr_size;

Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation supportfor NAND/SD/eSPI Boot

2009-10-09 Thread Dudhat Dipen-B09055
-Original Message- From: Wood Scott-B07421 Sent: Friday, October 09, 2009 11:48 PM To: Dudhat Dipen-B09055 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation supportfor NAND/SD/eSPI Boot On Fri, Oct 09, 2009 at 11:12:04PM +0530, Dipen Dudhat wrot

Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation supportfor NAND/SD/eSPI Boot

2009-10-09 Thread Scott Wood
Dudhat Dipen-B09055 wrote: > > -Original Message- > From: Wood Scott-B07421 > Sent: Friday, October 09, 2009 11:48 PM > To: Dudhat Dipen-B09055 > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation > supportfor NAND/SD/eSPI Boot > > On Fri, Oct 0

Re: [U-Boot] [PATCH] mpc83xx: cosmetic comment update relating to SPD EEPROM

2009-10-09 Thread Kim Phillips
On Fri, 2 Oct 2009 18:54:20 -0400 Paul Gortmaker wrote: > commit 6d0f6bcf337c5261c08fabe12982178c2c489d76 did the big > rename of CFG_ macros to CONFIG_SYS macros. But it missed > a couple of instances within comments. > > Signed-off-by: Paul Gortmaker > --- applied. Thank you, Kim

Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Dudhat Dipen-B09055
-Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Friday, October 09, 2009 11:51 PM To: Dudhat Dipen-B09055 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation support for NAND/SD/eSPI Boot On Oct 9, 2009, at 12:42 PM,

Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Relocation support for NAND/SD/eSPI Boot

2009-10-09 Thread Kumar Gala
On Oct 9, 2009, at 3:19 PM, Dudhat Dipen-B09055 wrote: > > > -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, October 09, 2009 11:51 PM > To: Dudhat Dipen-B09055 > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH v3 3/3] ppc/p1_p2_RDB: DDR Re

[U-Boot] [PATCH v2] sf: new driver for Winbond W25X16/32/64 devices

2009-10-09 Thread Mike Frysinger
From: Jason McMullan Signed-off-by: Jason McMullan Signed-off-by: Mike Frysinger --- v2 - fix up issues after talking to Jason Wolfgang: is this ok to merge for this release ? it's been sitting around for a long time and the only problem with it was legal stuff from Jason. i found hi

[U-Boot] [PATCH] sf: add GPL-2 license info

2009-10-09 Thread Mike Frysinger
Some of the new spi flash files were missing explicit license lines. Signed-off-by: Mike Frysinger CC: Haavard Skinnemoen --- this needs Haavard's approval since he wrote/submitted the original code common/cmd_sf.c |2 ++ drivers/mtd/spi/atmel.c |1 + drivers/mtd/spi/sp

[U-Boot] MPC85xx UPM NAND

2009-10-09 Thread Alemao
Hi all, I have used UPM in a MPC83xx with LBC running at 64MHz. Now I have a MPC85xx, with LBC at 41MHz. It only works if I put a delay in drivers/mtd/nand/fsl_upm.c : nand_write_buf(), otherwise I lost one byte. But it takes t long writing, which makes their use impractical. I saw in board

Re: [U-Boot] AT91 SD/MMC Patches

2009-10-09 Thread Dan Christensen
I've made a bit of progress on this with some off-list help by Albin Tonnerre. On Thu, Sep 24, 2009 at 8:24 PM, Dan Christensen wrote: > Hello.  I'm attempting to use the AT91 SD/MMC patches with my > AT91SAM9G45-EK-ES devkit to boot a Linux kernel off of an SD card. > > Starting with 2009.08, I'

[U-Boot] [PATCH-ARM 3/4, v3] Clean-up of s3c24x0 drivers excluding nand driver

2009-10-09 Thread kevin.morf...@fearnside-systems.co.uk
This patch re-formats the arm920t s3c24x0 driver files, excluding the nand driver, in preparation for changes to add support for the Embest SBC2440-II Board. The changes are as follows: - re-indent the code using Lindent - make sure register layouts are defined using a C struct - replace the uppe

[U-Boot] [PATCH-ARM 4/4, v3] Clean-up of s3c24x0 nand driver]

2009-10-09 Thread kevin.morf...@fearnside-systems.co.uk
This patch re-formats the arm920t s3c24x0 nand driver in preparation for changes to add support for the Embest SBC2440-II Board. The changes are as follows: - re-indent the code using Lindent - make sure register layouts are defined using a C struct - replace the upper-case typedef'ed C struct nam

Re: [U-Boot] Relocation size penalty calculation

2009-10-09 Thread Graeme Russ
On Fri, Oct 9, 2009 at 10:12 AM, Joakim Tjernlund wrote: >> >> On Fri, Oct 9, 2009 at 9:27 AM, J. William Campbell >> wrote: >> > Graeme Russ wrote: >> >> >> >> On Fri, Oct 9, 2009 at 2:58 AM, J. William Campbell >> >> wrote: >> >> >> >>> >> >>> Graeme Russ wrote: >> >>> >> >> Out of c

Re: [U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible

2009-10-09 Thread Chris Moore
Alessandro Rubini a écrit : > From: Alessandro Rubini > > If source and destination are aligned, this copies ulong values > until possible, trailing part is copied by byte. Thanks for the details > to Wolfgang Denk, Mike Frysinger, Peter Tyser, Chris Moore. > > Signed-off-by: Alessandro Rubini >

Re: [U-Boot] [PATCH V3 2/3] lib_generic memset: fill one word at a time if possible

2009-10-09 Thread Chris Moore
Similar remarks to those for memcpy : Alessandro Rubini a écrit : > From: Alessandro Rubini > > If the destination is aligned, fill ulong values until possible. > Then fill remaining part by bytes. > > Signed-off-by: Alessandro Rubini > Acked-by: Andrea Gallo > --- > lib_generic/string.c | 2