Re: [U-Boot] [PATCH] omap3: mmc: mmc2 support

2009-04-02 Thread Minkyu Kang
Hi, >> } >> >> unsigned char mmc_board_init(void) > unsigned char? > why in omap3_mmc.c, many functions return the unsigned char. I don't know why too :( but if we need it can be changed. >> +switch (curr_device) { >> +case 1: >> +writel(readl(&t2_base->pbias_lite) | PBIA

Re: [U-Boot] [PATCH] omap3: mmc: mmc2 support

2009-04-01 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:07 Sat 28 Mar , Minkyu Kang wrote: > There are 3 MMC/SD/SDIO host controllers inside the device. > This patch will support mmc2 and mmc3(mmc3 have not tested) > > Signed-off-by: Minkyu Kang > --- > drivers/mmc/omap3_mmc.c | 74 > - > inc

Re: [U-Boot] [PATCH] omap3: mmc: mmc2 support

2009-03-27 Thread Wolfgang Denk
Dear Dirk, In message <49cc0cc9.7060...@googlemail.com> you wrote: > Minkyu Kang wrote: > > There are 3 MMC/SD/SDIO host controllers inside the device. > > This patch will support mmc2 and mmc3. > > By this patch, the MMC controller actually used is configured by > CONFIG_MMC_INDEX at compile ti

Re: [U-Boot] [PATCH] omap3: mmc: mmc2 support

2009-03-27 Thread Minkyu Kang
> By this patch, the MMC controller actually used is configured by > CONFIG_MMC_INDEX at compile time? I.e. setting CONFIG_MMC_INDEX to 1 > will use mmc1, 2 will switch to mmc2 and CONFIG_MMC_INDEX 3 will > switch to mmc3? > > If I got this right, do you think we can do this at runtime? E.g. > impl

Re: [U-Boot] [PATCH] omap3: mmc: mmc2 support

2009-03-26 Thread Dirk Behme
Minkyu Kang wrote: > There are 3 MMC/SD/SDIO host controllers inside the device. > This patch will support mmc2 and mmc3. By this patch, the MMC controller actually used is configured by CONFIG_MMC_INDEX at compile time? I.e. setting CONFIG_MMC_INDEX to 1 will use mmc1, 2 will switch to mmc2 and