Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-26 Thread Fabio Estevam
Hi Eric, On Tue, Mar 26, 2013 at 12:24 PM, Eric Nelson wrote: > Since this convention is shared among at least SABRE Lite, SABRE SD, > Nitrogen6x and Wandboard, wouldn't a weak function in imx-common/cpu.c > be a better choice? > > +#ifdef CONFIG_REVISION_TAG > +u32 __weak get_board_rev(void) >

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-26 Thread Eric Nelson
On 03/26/2013 08:24 AM, Eric Nelson wrote: Hi Fabio, > > --- a/board/boundary/nitrogen6x/nitrogen6x.c +++ b/board/boundary/nitrogen6x/nitrogen6x.c @@ -330,7 +330,7 @@ int board_mmc_init(bd_t *bis) u32 get_board_rev(void) { -return 0x63000; +return get_cpu_rev(); } #ifdef CON

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-26 Thread Eric Nelson
Hi Fabio, On 03/15/2013 02:06 PM, Fabio Estevam wrote: From: Fabio Estevam As nitrogen6x boards support different i.MX6 flavors (quad, dual-lite and solo) the correct CPU revision needs to passed to the kernel, so call get_cpu_rev() instead of hardcoding it. Freescale 3.0.35 kernel assumes th

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-25 Thread Fabio Estevam
On Mon, Mar 25, 2013 at 11:25 PM, Fabio Estevam wrote: > Hi Eric, > > On Mon, Mar 25, 2013 at 4:14 PM, Eric Nelson > wrote: > >> The Gstreamer VPU plugin breaks on Solo and Quad if get_board_rev() >> doesn't return 0x61xxx or 0x63xxx. Oddly, the code in vpu_lib.c >> loads firmware based on the 61

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-25 Thread Fabio Estevam
Hi Eric, On Mon, Mar 25, 2013 at 4:14 PM, Eric Nelson wrote: > The Gstreamer VPU plugin breaks on Solo and Quad if get_board_rev() > doesn't return 0x61xxx or 0x63xxx. Oddly, the code in vpu_lib.c > loads firmware based on the 61 or 63 reference and yet still > nominally works on a Solo with a h

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-25 Thread Eric Nelson
Hi Fabio, On 03/16/2013 01:27 PM, Eric Nelson wrote: Hi Fabio, > That said, I don't think any of this can or should be done without identifying the down-stream code that might break. I've seen code that scrapes /proc/cpuinfo for the "Revision:" line and uses that. My memory is hazy, but I

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Eric Nelson
Hi Fabio, On 03/16/2013 12:48 PM, Fabio Estevam wrote: Hi Eric, On Sat, Mar 16, 2013 at 1:13 PM, Eric Nelson wrote: At the moment, it doesn't. I would really like to see us (the i.MX6 community) standardize the use of some fuses to specifically mean board revision. We're contemplating some

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Wolfgang Denk
Dear Fabio Estevam, In message you wrote: > > Would this approach work? > > http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/tree/board/freescale/common/fsl_sys_rev.c?h=imx_v2009.08_3.0.0 I bet there is a to of existing ways to encode and pass such information - in NOR flash, EEPROM, e

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Wolfgang Denk
Dear Dirk Behme, In message <5144a401.9020...@gmail.com> you wrote: > > I think the OMAP/Beagle community introduced serial EEPROMs to > identify their (add on) boards. There are many such ad-hoc approaches, and most of them are just a PITA. If you are trying to optimize boot times, it is reall

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Wolfgang Denk
Dear Eric Nelson, In message <51449a34.7080...@boundarydevices.com> you wrote: > > At the moment, it doesn't. > > I would really like to see us (the i.MX6 community) standardize > the use of some fuses to specifically mean board revision. No. This is a very bad idea. We've been working long en

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Fabio Estevam
Hi Eric, On Sat, Mar 16, 2013 at 1:13 PM, Eric Nelson wrote: > At the moment, it doesn't. > > I would really like to see us (the i.MX6 community) standardize > the use of some fuses to specifically mean board revision. > > We're contemplating some board changes such as switching the > ethernet P

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Dirk Behme
Am 16.03.2013 17:13, schrieb Eric Nelson: On 03/16/2013 07:58 AM, Fabio Estevam wrote: Hi Eric, On Fri, Mar 15, 2013 at 9:20 PM, Eric Nelson wrote: This is the **board** revision, right? At first glance, the kernel seems to be getting the silicon revision from the same place as get_cpu_rev(

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Eric Nelson
On 03/16/2013 07:58 AM, Fabio Estevam wrote: Hi Eric, On Fri, Mar 15, 2013 at 9:20 PM, Eric Nelson wrote: This is the **board** revision, right? At first glance, the kernel seems to be getting the silicon revision from the same place as get_cpu_rev(): https://github.com/boundarydevices/linu

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-16 Thread Fabio Estevam
Hi Eric, On Fri, Mar 15, 2013 at 9:20 PM, Eric Nelson wrote: > This is the **board** revision, right? > > At first glance, the kernel seems to be getting the silicon revision > from the same place as get_cpu_rev(): > > https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.0.35_1.1.1/

Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-15 Thread Eric Nelson
On 03/15/2013 02:06 PM, Fabio Estevam wrote: From: Fabio Estevam As nitrogen6x boards support different i.MX6 flavors (quad, dual-lite and solo) the correct CPU revision needs to passed to the kernel, so call get_cpu_rev() instead of hardcoding it. Freescale 3.0.35 kernel assumes that the CPU

[U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

2013-03-15 Thread Fabio Estevam
From: Fabio Estevam As nitrogen6x boards support different i.MX6 flavors (quad, dual-lite and solo) the correct CPU revision needs to passed to the kernel, so call get_cpu_rev() instead of hardcoding it. Freescale 3.0.35 kernel assumes that the CPU revision is passed passed from the bootloader.