Re: [PATCH 3/3] rockchip: Fix binman error

2025-02-06 Thread Quentin Schulz
Hi Simon, On 2/6/25 1:46 PM, Simon Glass wrote: Hi Quentin, On Wed, 5 Feb 2025 at 06:00, Quentin Schulz wrote: Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: After adding the below configs, binman produces an error. CONFIG_SPL_DFU CONFIG_SPL_ENV_SUPPORT

Re: [PATCH] Add 'bootsource' /chosen property

2025-02-06 Thread Quentin Schulz
Hi Simon, On 2/6/25 1:33 PM, Simon Glass wrote: Hi Quentin, On Wed, 5 Feb 2025 at 02:12, Quentin Schulz wrote: From: Quentin Schulz Bootloaders typically can be loaded from different storage media, such as eMMC, SD card, SPI flash, EEPROM, but also from non-persistent media such as USB

Re: [PATCH 5/6] rockchip: mkimage: Add support for up to 4 input files

2025-02-06 Thread Quentin Schulz
On 2/5/25 8:00 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 17:43, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format can support up to 4 embedded images that can be loaded by the BootROM using the back-to-bootrom method. Currently two input

Re: [PATCH 6/6] rockchip: mkimage: Add option for image load address and flag

2025-02-06 Thread Quentin Schulz
Hi Jonas, On 2/5/25 8:54 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 17:51, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format supports defining a load address and flag for each embedded image. Add initial support for writing the image load

Re: [PATCH 2/6] rockchip: mkimage: Print image information for all embedded images

2025-02-06 Thread Quentin Schulz
Hi Jonas, On 2/5/25 8:36 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 16:57, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: [...] --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -331,8 +331,6 @@ static void rkcommon_set_header0_v2(void *buf, struct

Re: [PATCH v3 2/5] rockchip: io-domain: Add CONFIG_SPL_ROCKCHIP_IODOMAIN

2025-02-06 Thread Quentin Schulz
Hi Justin, On 2/5/25 6:16 PM, Justin Klaassen wrote: Allows use of the Rockchip IO-domain driver in SPL to configure the GPIO to match the voltage supplied by specific regulators (e.g. "vcc_sdio"). Signed-off-by: Justin Klaassen Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v3 1/5] rockchip: io-domain: Add debug logging for regulators during probe

2025-02-06 Thread Quentin Schulz
Hi Justin, On 2/5/25 6:16 PM, Justin Klaassen wrote: Log the value of the regulators during initialization of the IO-domain driver to aid in debugging GPIO voltage configuration problems. Signed-off-by: Justin Klaassen Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 2/5] rockchip: Improve ARMv7 support for ROCKCHIP_COMMON_STACK_ADDR

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/27/25 12:48 AM, Jonas Karlman wrote: A few Rockchip ARMv7 SoCs use 0x6000 as DRAM base address instead of Are there known exceptions? Among the list you provided I see RV1126 is missing but is ARMv7-based. Is it an oversight or done on purpose? I couldn't quickly find the

Re: [PATCH 6/6] rockchip: mkimage: Add option for image load address and flag

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format supports defining a load address and flag for each embedded image. Add initial support for writing the image load address and flag to the v2 image format header. This may later be used for RK3576 to embed a minimal initial

Re: [PATCH 5/6] rockchip: mkimage: Add support for up to 4 input files

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format can support up to 4 embedded images that can be loaded by the BootROM using the back-to-bootrom method. Currently two input files can be passed in using the datafile parameter, separated by a colon (":"). Extend the datafi

Re: [PATCH 3/6] rockchip: mkimage: Print boot0 and boot1 parameters

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 2/5/25 5:42 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 17:04, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format embeds boot0 and boot1 parameters, the vendor tool boot_merger may write these parameters based on the rkboot

Re: [PATCH 4/6] rockchip: mkimage: Add option to change image offset alignment

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The vendor boot_merger tool support a ALIGN parameter that is used to define offset alignment of the embedded images. Vendor use this for RK3576 to change offset alignment from the common 2 KiB to 4 KiB, presumably it may have something to do

Re: [PATCH 3/6] rockchip: mkimage: Print boot0 and boot1 parameters

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format embeds boot0 and boot1 parameters, the vendor tool boot_merger may write these parameters based on the rkboot miniall.ini files. E.g. a RK3576 boot image may contain a boot1 parameter that signals BootROM or vendor blobs to

Re: [PATCH 2/6] rockchip: mkimage: Print image information for all embedded images

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format can embed up to 4 data files compared to the two init and boot data files using the older image format. Add support for displaying more of the image header information that exists in the v2 image format, e.g. image load add

Re: [PATCH 1/6] rockchip: mkimage: Split size_and_off and size_and_nimage

2025-02-05 Thread Quentin Schulz
Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: Split 32-bit size_and_off and size_and_nimage fields of the v2 image format header into their own 16-bit size, offset and num_images fields. Set num_images based on number of images passed by the datafile parameter and size based on the offset

[PATCH] Add 'bootsource' /chosen property

2025-02-05 Thread Quentin Schulz
From: Quentin Schulz Bootloaders typically can be loaded from different storage media, such as eMMC, SD card, SPI flash, EEPROM, but also from non-persistent media such as USB (via proprietary protocols loading directly into SRAM, or fastboot, DFU, etc..), JTAG, ... This information is usually

Re: [PATCH 3/3] rockchip: Fix binman error

2025-02-05 Thread Quentin Schulz
Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: After adding the below configs, binman produces an error. CONFIG_SPL_DFU CONFIG_SPL_ENV_SUPPORT CONFIG_SPL_USB_DWC3_GENERIC CONFIG_SPL_USB_GADGET binman: Section '/binman/simple-bin-spi': Symbol '_binman_u_boot_any_prop_size' in en

Re: [PATCH 2/3] rockchip: Fix SPL link error for Radxa ROCK Pi 4

2025-02-05 Thread Quentin Schulz
Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: If CONFIG_EFI_CAPSULE_FIRMWARE_RAW, CONFIG_SPL_ENV_SUPPORT, and CONFIG_SPL_DFU are enabled, linking u-boot-spl will fail. LD spl/u-boot-spl ld.bfd: drivers/dfu/dfu.o: in function `dfu_init_env_entities': /home/radxa/u-boot/drivers/dfu/d

Re: [PATCH] rockchip: Enable OF_LIBFDT_OVERLAY by default

2025-02-04 Thread Quentin Schulz
Hi Chen-Yu, On 2/4/25 6:53 PM, Chen-Yu Tsai wrote: On Wed, Feb 5, 2025 at 1:49 AM Quentin Schulz wrote: Hi Chen-Yu, On 2/4/25 6:21 PM, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Device tree overlays are immensely useful. Enable it by default by implying it from ARCH_ROCKCHIP. Signed-off-by

Re: [PATCH] rockchip: rk3399: grf: Fix enum typos for UART2

2025-02-04 Thread Quentin Schulz
Fix the ones that are wrong. Fixes: a2c08df3813b ("pinctrl: add driver for rk3399") Fixes: fa72de10452c ("rockchip: arm64: rk3399: move grf register definitions to grf_rk3399.h") Signed-off-by: Chen-Yu Tsai Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH] rockchip: Enable OF_LIBFDT_OVERLAY by default

2025-02-04 Thread Quentin Schulz
Hi Chen-Yu, On 2/4/25 6:21 PM, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Device tree overlays are immensely useful. Enable it by default by implying it from ARCH_ROCKCHIP. Signed-off-by: Chen-Yu Tsai --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig

Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs

2025-02-04 Thread Quentin Schulz
Hi Chen-Yu, On 2/4/25 6:23 PM, Chen-Yu Tsai wrote: From: Chen-Yu Tsai The IO domain driver controls the I/O voltage for various pins, MMC included. Enable it by default for all supported Rockchip SoCs. Signed-off-by: Chen-Yu Tsai Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 3/5] regulator: rk8xx: Add CONFIG_SPL_REGULATOR_RK8XX

2025-02-04 Thread Quentin Schulz
a separate patch as the addition of the symbol and the modification of the C file aren't per se co-dependent. Their order wouldn't even matter in that case. In any case, looks good to me so: Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 3/5] regulator: rk8xx: Add CONFIG_SPL_REGULATOR_RK8XX

2025-02-04 Thread Quentin Schulz
a separate patch as the addition of the symbol and the modification of the C file aren't per se co-dependent. Their order wouldn't even matter in that case. In any case, looks good to me so: Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 1/5] rockchip: io-domain: Add debug logging for regulators during probe

2025-02-04 Thread Quentin Schulz
Hi Justin, On 1/28/25 10:37 PM, Justin Klaassen wrote: [You don't often get email from jus...@tidylabs.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Log the value of the regulators during initialization of the IO-domain driver to aid in debugging GPIO volt

Re: [PATCH v2 2/5] rockchip: io-domain: Add CONFIG_SPL_ROCKCHIP_IODOMAIN

2025-02-04 Thread Quentin Schulz
Hi Justin On 1/28/25 10:37 PM, Justin Klaassen wrote: Allows use of the Rockchip IO-domain driver in SPL to configure the GPIO to match the voltage supplied by specific regulators (e.g. "vcc_sdio"). Signed-off-by: Justin Klaassen --- Changes in v2: - Added separate patch for added CONFIG_SPL_

[PATCH v2 13/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RV1108

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rv1108.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 12/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3399

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 11/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3368

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3368.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 08/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3288

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 10/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3328

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 09/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3308

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3308.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 04/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3066

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3066.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 07/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3228

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk322x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 06/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3188

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3188.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 02/13] pinctrl: rockchip: constify rockchip_pin_ctrl for PX30

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-px30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockchip/pi

[PATCH v2 05/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3128

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3128.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 03/13] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3036

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3036.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH v2 00/13] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-01-31 Thread Quentin Schulz
ies[1], my PX30 Ringneck, RK3399 Puma and RK3588 Tiger all reach U-Boot CLI. No further testing (like booting into Linux userspace) was done. [1] https://lore.kernel.org/u-boot/20250130072100.27297-1-ilias.apalodi...@linaro.org/ Signed-off-by: Quentin Schulz --- Changes in v2: - remove removal

[PATCH v2 01/13] pinctrl: rockchip: fix bank's pin_base computing

2025-01-31 Thread Quentin Schulz
From: Quentin Schulz The logic in the core reads the nr_pins of the controller and uses it as the index of the first pin in the bank (pin_base) it currently parses. It then increments the number of pins in the controller before going to the next bank. This works "fine" for control

Re: [PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-01-30 Thread Quentin Schulz
Hi Jonas, On 1/29/25 3:20 PM, Jonas Karlman wrote: Hi Quentin, On 2025-01-29 13:42, Quentin Schulz wrote: While testing some WIP work done by Ilias Apalodimas on guaranteeing read-only memory areas truly are handled as read-only[1], my RK3588 Tiger couldn't reach U-Boot CLI anymore becau

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-01-29 Thread Quentin Schulz
On 1/29/25 6:38 PM, Marek Vasut wrote: On 1/29/25 6:10 PM, Quentin Schulz wrote: Hi Marek, Hi, On 1/12/25 11:36 PM, Marek Vasut wrote: Add support for starting TFA from U-Boot running in EL3 as part of fitImage boot, so the user can start U-Boot in the highest privilege level on the

Re: [PATCH v3 3/9] ARM: renesas: Simplify board Makefiles

2025-01-29 Thread Quentin Schulz
. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v3 2/9] ARM: renesas: Drop R8A779A0 V3U Falcon SPL Makefile entry

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/29/25 6:04 PM, Marek Vasut wrote: The SPL on R-Car V3U Falcon is never built, remove the Makefile entry. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 3/3] arm64: renesas: Add TFA BL31 handoff support

2025-01-29 Thread Quentin Schulz
On 1/29/25 6:00 PM, Marek Vasut wrote: On 1/29/25 5:02 PM, Quentin Schulz wrote: +void armv8_switch_to_el2_prep(u64 args, u64 mach_nr, u64 fdt_addr, +  u64 arg4, u64 entry_point, u64 es_flag) +{ +    typedef void __noreturn (*image_entry_noargs_t)(void

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/12/25 11:36 PM, Marek Vasut wrote: Add support for starting TFA from U-Boot running in EL3 as part of fitImage boot, so the user can start U-Boot in the highest privilege level on the platform, bundle TFA, Linux, DT into a single fitImage and boot such a bundle as a whole. There

Re: [PATCH v2 2/8] ARM: renesas: Simplify board Makefiles

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/29/25 5:42 PM, Marek Vasut wrote: On 1/29/25 3:54 PM, Quentin Schulz wrote: Hi Marek, Hi, On 1/18/25 12:15 PM, Marek Vasut wrote: Introduce board/renesas/common/Makefile and remove the multiple duplicate copies of obj := ../common/*.o from board Makefiles. Let the build

Re: [PATCH 3/3] arm64: renesas: Add TFA BL31 handoff support

2025-01-29 Thread Quentin Schulz
On 1/29/25 5:02 PM, Quentin Schulz wrote: Hi Marek, On 1/12/25 11:36 PM, Marek Vasut wrote: Implement custom U_BOOT_FIT_LOADABLE_HANDLER and armv8_switch_to_el2_prep() handling in case the TFA was loaded. The loadables handler sets up custom handoff structure used by Renesas TFA fork in

Re: [PATCH 3/3] arm64: renesas: Add TFA BL31 handoff support

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/12/25 11:36 PM, Marek Vasut wrote: Implement custom U_BOOT_FIT_LOADABLE_HANDLER and armv8_switch_to_el2_prep() handling in case the TFA was loaded. The loadables handler sets up custom handoff structure used by Renesas TFA fork in fixed location in DRAM and indicates the TFA has b

[PATCH] rockchip: theobroma-systems: use HAVE_VENDOR_COMMON_LIB to simplify Makefile

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz The build system uses HAVE_VENDOR_COMMON_LIB to automatically include board/$(VENDOR)/common/Makefile, therefore let's use that to implicitly include board/theobroma-systems/common/Makefile and compile the common.c file when building proper. Signed-off-by: Quentin S

Re: [PATCH v2 8/8] arm64: renesas: Deduplicate R-Car Gen3 and Gen4 SPL

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/18/25 12:15 PM, Marek Vasut wrote: Move R-Car Gen3 and Gen4 jump_to_image_no_args() into dedicated rcar64-spl.c file. The implementation of jump_to_image_no_args() is identical. No functional change. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 7/8] arm64: renesas: Deduplicate board_early_init_f()

2025-01-29 Thread Quentin Schulz
function is empty. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 3/8] ARM: renesas: Rename common/common.c to common/rcar64-common.c

2025-01-29 Thread Quentin Schulz
common/rcar64-common.c @@ -18,8 +18,6 @@ #include #include -#ifdef CONFIG_RCAR_64 - This file was already made rcar_64 specific in the previous patch, so you could have made that change in the previous commit. Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 2/8] ARM: renesas: Simplify board Makefiles

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/18/25 12:15 PM, Marek Vasut wrote: Introduce board/renesas/common/Makefile and remove the multiple duplicate copies of obj := ../common/*.o from board Makefiles. Let the build system include the common Makefile using the HAVE_VENDOR_COMMON_LIB and build the common objects that are

Re: [PATCH v2 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common

2025-01-29 Thread Quentin Schulz
/common/Makefile to be extended with actual content later in this series. This is a preparatory patch for board Makefile simplification. No functional change so far. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 1/3] rockchip: Fix TPL link error

2025-01-29 Thread Quentin Schulz
Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: Rockchip RK3399 targets build TPL. If CONFIG_SPL_USB_DWC3_GENERIC and CONFIG_SPL_USB_GADGET are enabled, linking u-boot-tpl will fail. LD tpl/u-boot-tpl ld.bfd: drivers/usb/dwc3/dwc3-generic.o: in function `dwc3_glue_bind_common': /home

[PATCH 01/14] pinctrl: rockchip: remove unused base_pin bank member

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz Each bank has a base_pin member that is only set in the core and never used, so it can be removed. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 1 - drivers/pinctrl/rockchip/pinctrl-rockchip.h | 2 -- 2 files changed, 3

[PATCH 04/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3036

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3036.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 14/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RV1108

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rv1108.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 13/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3399

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 11/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3328

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 10/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3308

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3308.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 12/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3368

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3368.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 09/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3288

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 08/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3228

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk322x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 06/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3128

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3128.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 07/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3188

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3188.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 03/14] pinctrl: rockchip: constify rockchip_pin_ctrl for PX30

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-px30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockchip/pi

[PATCH 05/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3066

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3066.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 02/14] pinctrl: rockchip: remove unused nr_pins controller member

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz Each controller has an nr_pins member that is set either through the rockchip_pin_ctrl struct or from the core (or both). This is an issue because on RK3568, RK3588 and RV1126, the struct is const, this means it shouldn't be modified at all. This will trigger a CPU

[PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-01-29 Thread Quentin Schulz
e constify done on top of Ilias branch[1], my PX30 Ringneck, RK3399 Puma and RK3588 Tiger all reach U-Boot CLI. No further test (like booting into Linux userspace) was done. [1] https://source.denx.de/u-boot/custodians/u-boot-tpm/-/tree/fix_memory_permissions Signed-off-by: Quentin Schulz -

[PATCH next 3/3] rockchip: ringneck-px30: enable DT overlay support

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz Haikou carrierboard allows multiple adapter boards to be connected, for now there exists the following adapter boards compatible with PX30 Ringneck: - Haikou Video Demo on the Video Connector, - Haikou LVDS 9904379 on the Video Connector, So support DT overlays so we can

[PATCH next 2/3] rockchip: px30: add fdtoverlay_addr_r default value to support FDTO

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz In order to be able to use Device Tree Overlays, the fdtoverlay_addr_r needs to be specified. Follow what's been done for other Rockchip SoCs and leave 1MiB for the base DTB before the address for the overlay. Signed-off-by: Quentin Schulz --- include/co

[PATCH next 1/3] rockchip: px30: enable RNG for all boards

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz I don't see a reason why this should only be enabled on a per-board basis. The rng IP is inside the SoC and doesn't seem to rely on anything external to it, therefore let's enable it on the SoC DTSI and remove the now empty px30-evb-u-boot.dtsi. Signed-

[PATCH next 0/3] rockchip: px30: enable RNG globally + DT overlay support for PX30 Ringneck

2025-01-29 Thread Quentin Schulz
ys on PX30 Ringneck, for that to work the fdtoverlay_addr_r env variable needs to be set and the OF_LIBFDT_OVERLAY symbol to be enabled. Signed-off-by: Quentin Schulz --- Quentin Schulz (3): rockchip: px30: enable RNG for all boards rockchip: px30: add fdtoverlay_addr_r default value to su

[PATCH v4] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: [PATCH v3] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
Hi Marek, On 1/22/25 3:32 PM, Marek Vasut wrote: On 1/22/25 3:21 PM, Quentin Schulz wrote: [...] @@ -2395,17 +2395,18 @@ int boot_get_fdt_fit(struct bootm_headers *images, ulong addr,   /* we need to apply overlays */   #ifdef CONFIG_OF_LIBFDT_OVERLAY -    image_start = addr

Re: [PATCH v3] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
Hi all, On 1/22/25 2:57 PM, Quentin Schulz wrote: From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM

[PATCH v3] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: [PATCH RFC v2] image: apply FDTOs on FDT image node without a load property

2025-01-21 Thread Quentin Schulz
Hi Marek, On 1/21/25 12:55 AM, Marek Vasut wrote: On 1/16/25 12:46 PM, Quentin Schulz wrote: From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load

Re: [RFC] Adding bootsource and reset-source* to /chosen

2025-01-17 Thread Quentin Schulz
Hi Rob, On 1/14/25 9:36 PM, Rob Herring wrote: On Fri, Dec 13, 2024 at 12:08 PM Quentin Schulz wrote: Hi all, In U-Boot, there are multiple stages which can be loaded from different media each. On Rockchip SoCs, it mostly goes this way, SoC BootROM loads from a medium (storage or over USB

Re: [PATCH v3 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2025-01-17 Thread Quentin Schulz
Hi Łukasz, Kever, On 11/27/24 11:21 PM, Łukasz Czechowski wrote: Hi Kever, On 2024/11/27 03:42 Kever Yang wrote: Hi Lukasz, I got a new error base on patch [1], see full log here [2]. Looking at the file efi_stub.c that is used in the failing configuration it looks to me that some f

Re: [PATCH next RFC 0/5] rockchip: panic() when DRAM init fails

2025-01-17 Thread Quentin Schulz
Hi Kever, On 11/5/24 6:21 PM, Quentin Schulz wrote: I am the unfortunate owner of an RK3399 Puma that is failing DRAM init every now and then with the following cryptic error message: """ pctl_start: Failed to init pctl channel 0 """ When it fails, the current

[PATCH RFC v2] image: apply FDTOs on FDT image node without a load property

2025-01-16 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: 回复: [PATCH] linker_lists: Update the alignment using CONFIG_LINKER_LIST_ALIGN

2025-01-16 Thread Quentin Schulz
Hi, On 1/16/25 1:24 AM, 黄利亚 wrote: Sorry for the confusion and disruption.  I haven't submitted patches this way before,  and my English is not very good.  I was conducted according to the steps  in the https://docs.u-boot.org/en/latest/develop/patman.html operation. The patch is fine, it is

Re: [PATCH 6/6] block: Remove "select BLK" from non-block drivers

2025-01-16 Thread Quentin Schulz
Hi Tom, On 1/15/25 9:20 PM, Tom Rini wrote: On Wed, Jan 15, 2025 at 06:49:45PM +0100, Quentin Schulz wrote: Hi Tom, On 1/14/25 5:59 PM, Tom Rini wrote: On Tue, Jan 14, 2025 at 02:53:48PM +0100, Quentin Schulz wrote: Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: Now that block drivers are

Re: [PATCHv2 4/6] blk: Make block subsystems select BLK

2025-01-15 Thread Quentin Schulz
ms. As just replied on v1, I would have liked an explicit mention that yes, this diff doesn't include a change to PVBLOCK symbol, because it already does the right thing. Signed-off-by: Tom Rini Reviewed-by: Peter Robinson Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 6/6] block: Remove "select BLK" from non-block drivers

2025-01-15 Thread Quentin Schulz
Hi Tom, On 1/14/25 5:59 PM, Tom Rini wrote: On Tue, Jan 14, 2025 at 02:53:48PM +0100, Quentin Schulz wrote: Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: Now that block drivers are all selecting the BLK symbol, there's no need for other options to be select'ing BLK so that othe

Re: [PATCH 4/6] blk: Make block subsystems select BLK

2025-01-15 Thread Quentin Schulz
Hi Tom, On 1/14/25 5:58 PM, Tom Rini wrote: On Tue, Jan 14, 2025 at 02:45:25PM +0100, Quentin Schulz wrote: Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: The BLK symbol has a few meanings, one of which is that it controls the driver model portion of a "block device". Rather than h

Re: Simon Glass's future with Das U-Boot project?

2025-01-15 Thread Quentin Schulz
Hi Tom, On 1/2/25 5:13 PM, Tom Rini wrote: Hey all, While I had hoped that the quiet of the last week or so had meant that things would perhaps return to how they had been before, Simon's large patch series and then comments on the TPM+bloblist patch have shown otherwise. I would appreciate

Re: [PATCH] arm: Remove redundant loading of image copy start offset.Because the beginning is already computed

2025-01-15 Thread Quentin Schulz
Hi Liya, On 1/15/25 2:56 AM, 1425075...@qq.com wrote: [You don't often get email from 1425075...@qq.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Liya Huang <1425075...@qq.com> Please have some commit log in there justifying the change. There seem

Re: [PATCH 3/5] pxe_utils: Allow the FDT to be missing

2025-01-15 Thread Quentin Schulz
Hi Simon, On 1/15/25 2:16 AM, Simon Glass wrote: Hi Quentin, On Tue, 14 Jan 2025 at 08:13, Quentin Schulz wrote: Hi Simon, On 12/20/24 5:01 AM, Simon Glass wrote: The devicetree file may not be provided, so avoid a failure in that case. Can you provide a bit more information on when

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-01-15 Thread Quentin Schulz
Hi Marek, Biju, On 1/13/25 2:31 PM, Biju Das wrote: Hi Marex, -Original Message- From: Marek Vasut Sent: 13 January 2025 12:40 Subject: Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables On 1/13/25 1:15 PM, Biju Das wrote: Hi Marex, Thanks for the patch

Re: [PATCH 0/7] board: rockchip: add FriendlyElec NanoPi R3S

2025-01-15 Thread Quentin Schulz
Hi Tianling, On 1/14/25 5:14 PM, Tianling Shen wrote: Hi Quentin, On 2025/1/14 23:21, Quentin Schulz wrote: Hi Tianling, On 1/14/25 3:49 PM, Tianling Shen wrote: Hi Quentin, On 2025/1/14 22:39, Quentin Schulz wrote: Hi Tianling, On 12/26/24 10:20 AM, Tianling Shen wrote: The NanoPi R3S

Re: [PATCH] linker_lists: Update the alignment using CONFIG_LINKER_LIST_ALIGN

2025-01-15 Thread Quentin Schulz
Hi Liya, On 1/14/25 8:09 AM, 1425075...@qq.com wrote: [You don't often get email from 1425075...@qq.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Liya Huang <1425075...@qq.com> This patch updates the alignment of linker lists to use the CONFIG_LINKE

Re: [PATCH 2/3] video: rockchip: rk3328: filter unsupported modes

2025-01-15 Thread Quentin Schulz
Hi Vasily, On 1/14/25 6:24 AM, Vasily Khoruzhick wrote: While RK3328 is capable of 4K resolution, dw-hdmi driver in u-boot seems to have some issue with 4K. 1440p or lower works fine. Limit max resolution by 2560x1440x60Hz, by filtering the modes with pixel clock > 297MHz Fixes: f3ea872970d603

Re: [PATCH] Makefile: Make sure all linker input objects exist

2025-01-15 Thread Quentin Schulz
" which allows me to use HAVE_VENDOR_COMMON_LIB mechanism with an empty Makefile for TPL/SPL build stage, so: Tested-by: Quentin Schulz Looking forward to being able to use HAVE_VENDOR_COMMON_LIB! Though I could actually always include the file and just ifdef CONFIG_XPL_BUILD in common.o, but let

Re: [PATCH 8/8] arm64: renesas: Deduplicate R-Car Gen3 and Gen4 SPL

2025-01-15 Thread Quentin Schulz
, Reviewed-by: Quentin Schulz --- Cc: Adam Ford Cc: Biju Das Cc: Lad Prabhakar Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- board/renesas/common/Makefile | 4 +++- board/renesas/common/gen3-spl.c | 21

Re: [PATCH 3/8] ARM: renesas: Rename common/common.c to common/rcar64-common.c

2025-01-15 Thread Quentin Schulz
Hi Marek, On 1/12/25 11:34 PM, Marek Vasut wrote: The common.c content is specific to 64-bit R-Car SoCs, rename the file to rcar64-common.c and remove R-Car 64-bit ifdeffery in the file. No functional change. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 2/8] ARM: renesas: Simplify board Makefiles

2025-01-15 Thread Quentin Schulz
This honestly was a bit difficult to review and felt like more than one change was made at once. The #if !IS_ENABLED(CONFIG_XPL_BUILD) changes could have been made in a separate commit I believe. In any case, makes sense to me: Reviewed-by: Quentin Schulz Would have liked a link to h

  1   2   3   4   5   6   7   8   9   10   >