Hi Liya,
On 1/15/25 2:56 AM, 1425075...@qq.com wrote:
[You don't often get email from 1425075...@qq.com. Learn why this is important
at https://aka.ms/LearnAboutSenderIdentification ]
From: Liya Huang <1425075...@qq.com>
Please have some commit log in there justifying the change. There seems
to be some issues with the commit title so probably part of it should be
in the commit log rather than in the title (one needs an empty line
between the commit title and the start of the commit log when editing
the commit "description" with a text editor).
Reviewed-by: Simon Glass <s...@chromium.org>
Reviewed-by: Pali Rohár <p...@kernel.org>
Same remark as for your other patch
(https://lore.kernel.org/u-boot/3d51107a-4761-4de8-9bae-a462c2a8e...@cherry.de/),
pasting here what I said there:
"""
This... is odd. I don't see an earlier version of that patch and your
name/mail only returns two patches on the U-Boot mailing list. I believe
Reviewed-by needs to be publicly given on the ML as they are a proof of
review by the mentioned person and is usually a trust mark for
maintainers to merge code. Here it may have been added without Simon's
consent. Now imagine Simon is not answering for a few days/weeks, the
maintainer could still believe Simon went through a proper review and
merge that patch taking that into account while no review may actually
have been conducted. This is making me uncomfortable.
[...]
I'm not saying review wasn't done properly, but its acknowledgment
should be made public by the mentioned person instead of being put into
the v1.
Have I missed an earlier version or discussion maybe?
"""
Even odder is that Pali has explicitly requested to not be receiving any
mail from the U-Boot project anymore, c.f.
https://lore.kernel.org/u-boot/20231106090908.7938-1-xypron.g...@gmx.de/.
That doesn't exclude him for doing reviews of course but that is still
odd. I'm explicitly keeping him in Cc here as I am not sure this went
through the proper review process and he may not want his name put in
there acknowledging something he might not have done.
Cheers,
Quentin
