Hi Marek,
On 1/29/25 5:42 PM, Marek Vasut wrote:
On 1/29/25 3:54 PM, Quentin Schulz wrote:
Hi Marek,
Hi,
On 1/18/25 12:15 PM, Marek Vasut wrote:
Introduce board/renesas/common/Makefile and remove the multiple
duplicate copies of obj := ../common/*.o from board Makefiles.
Let the build system include the common Makefile using the
HAVE_VENDOR_COMMON_LIB and build the common objects that are
shared by all the boards that way. No functional change intended.
Some of the remaining board files which include board specific
settings have been updated to use obj-y += to avoid rewriting
the board obj-y target and avoid dropping object files from the
build.
The board/renesas/common/Makefile is now also used when building
RZG2L targets which also set CONFIG_RCAR_64 symbol and 32bit R-Car
Gen2 targets, however, this common code is specific to 64bit R-Car
only. Inhibit the build of this common code for RZG2L using extra
ifndef CONFIG_RZG2L and do not include any code for R-Car Gen2 so
far.
[...]
-ifdef CONFIG_XPL_BUILD
-obj-y := ../common/gen3-spl.o
-else
-obj-y := ../common/gen4-common.o ../common/common.o
-endif
Was this a mistake on Falcon? It used to use the gen3-spl while being
a gen4?
Falcon is V3U which is something between the two generations, but the
SPL is not even being built, so the whole SPL part can be removed.
Indeed, could benefit from a small explanation in the commit log or a
separate commit to remove this unused piece of code.
Reviewed-by: Quentin Schulz <quentin.sch...@cherry.de>
Thanks!
Quentin
