Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2013-10-03 Thread Vipin Kumar
from the mail itself Regards Vipin On Fri, Oct 4, 2013 at 9:40 AM, Vipin Kumar wrote: On 10/4/2013 1:22 AM, Jagan Teki wrote: Any update on this. This should already be in u-boot mainline Regards Vipin On Wed, Jun 12, 2013 at 9:25 PM, Armando Visconti wrote: On 06/12/2013 05:

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2013-10-03 Thread Vipin Kumar
On 10/4/2013 1:22 AM, Jagan Teki wrote: Any update on this. This should already be in u-boot mainline Regards Vipin On Wed, Jun 12, 2013 at 9:25 PM, Armando Visconti wrote: On 06/12/2013 05:29 PM, Jagan Teki wrote: On Wed, Jun 12, 2013 at 8:49 PM, Armando Visconti wrote: But if yo

Re: [U-Boot] [PATCH] drivers/net/designware - respect "bus mode" register contents on SW reset

2013-09-25 Thread Vipin Kumar
vers/net/designware.c +++ b/drivers/net/designware.c @@ -112,7 +112,7 @@ static int mac_reset(struct eth_device *dev) ulong start; int timeout = CONFIG_MACRESET_TIMEOUT; - writel(DMAMAC_SRST,&dma_p->busmode); + writel(readl(&dma_p->busmode) | DMAMA

Re: [U-Boot] [PATCH v2] drivers/net/designware - fix alignment of buffer descriptors

2013-09-25 Thread Vipin Kumar
On 9/25/2013 8:57 PM, Alexey Brodkin wrote: It's important that buffer descriptors are aligned in accordance to GMAC data bus width (32/64/128-bit). It's safe to align to 128-bit (16-bytes) for every bus width type. If buffer descriptor is improperly aligned GMAC discards lower bits of provided

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Vipin Kumar
On 7/1/2013 11:02 AM, Axel Lin wrote: The questions raised here are valid and it forced me to re-read the datasheet. For your convenience, I must tell you that the device is actually pl061 from ARM, so the driver can also be named so. The datasheet is here http://infocenter.arm.com/help/index.j

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Vipin Kumar
On 6/30/2013 2:27 PM, Axel Lin wrote: 2013/6/30 Michael Trimarchi: Hi Il giorno 30/giu/2013 06:18, "Axel Lin" ha scritto: 2013/6/21 Michael Trimarchi: On 06/21/2013 06:40 AM, Vipin Kumar wrote: On 6/20/2013 7:26 PM, Axel Lin wrote: 2013/6/20 Marek Vasut Dear Axel Lin,

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Vipin Kumar
On 6/20/2013 7:26 PM, Axel Lin wrote: 2013/6/20 Marek Vasut Dear Axel Lin, In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value argument is 0 or 1. Thus the GPIOs never set to low. This patch fixes this bug. Signed-off-by: Axel Lin --- drivers

Re: [U-Boot] gpio: Question about gpio_set_value() implementation in spear_gpio.c

2013-06-19 Thread Vipin Kumar
On 6/19/2013 7:14 PM, Axel Lin wrote: Current code looks strange because no matter the value argument is 0 or 1 it always calls writel(1<< gpio,®s->gpiodata[DATA_REG_ADDR(gpio)]); And then gpio_get_value() always return 1. I'm wondering if it needs to be fixed, something like below cha

Re: [U-Boot] [PATCH 4/7] usb: hub: Fix enumration timeout

2013-03-27 Thread Vipin Kumar
10). This should give us a required check for 10 seconds, and thereby we don't need to add additional mdelay of 100 microseconds in each cycle. Signed-off-by: Vivek Gautam CC: Vipin Kumar --- common/usb_hub.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/common/usb

Re: [U-Boot] [Drivers PATCH 14/19] net/macb: workaround for transmission hang issue

2013-02-28 Thread Vipin Kumar
On 3/1/2013 12:58 PM, Albert ARIBAUD wrote: Hi Vipin, On Fri, 1 Mar 2013 09:11:33 +0530, Vipin Kumar wrote: On 2/28/2013 6:29 PM, Albert ARIBAUD wrote: On Sun, 3 Feb 2013 12:19:26 +0100, Albert ARIBAUD wrote: Hi Vipin, On Fri, 2 Nov 2012 23:09:59 +0530, Vipin Kumar wrote: From

Re: [U-Boot] [Drivers PATCH 14/19] net/macb: workaround for transmission hang issue

2013-02-28 Thread Vipin Kumar
On 2/28/2013 6:29 PM, Albert ARIBAUD wrote: On Sun, 3 Feb 2013 12:19:26 +0100, Albert ARIBAUD wrote: Hi Vipin, On Fri, 2 Nov 2012 23:09:59 +0530, Vipin Kumar wrote: From: Shiraz Hashim It is observed on SPEAr320S RMII#1 interface that on transmitting packets the MAC dma hangs randomly

Re: [U-Boot] [Drivers PATCH 14/19] net/macb: workaround for transmission hang issue

2013-02-28 Thread Vipin Kumar
On 3/1/2013 8:38 AM, Bo Shen wrote: Hi All, On 02/28/2013 08:59 PM, Albert ARIBAUD wrote: On Sun, 3 Feb 2013 12:19:26 +0100, Albert ARIBAUD wrote: Hi Vipin, On Fri, 2 Nov 2012 23:09:59 +0530, Vipin Kumar wrote: From: Shiraz Hashim It is observed on SPEAr320S RMII#1 interface that on

Re: [U-Boot] [PATCH v4] imls: Add support to list images in NAND device

2013-02-19 Thread Vipin Kumar
On 2/20/2013 6:45 AM, Scott Wood wrote: On 12/17/2012 02:32:48 AM, Vipin Kumar wrote: This patch adds support to list images in NAND flash through imls Signed-off-by: Vipin Kumar --- Changes in v4 - Keep stdout dumps in one line - Continue even after read errors for all the blocks README

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2013-02-05 Thread Vipin Kumar
On 2/3/2013 7:28 PM, Albert ARIBAUD wrote: Hi Vipin, On Thu, 6 Dec 2012 14:52:55 +0530, Vipin Kumar wrote: Certain ARMV7 cpus eg. CortexA9 contains a local and a global timer within the CPU core itself. This patch adds generic support for local timer. Signed-off-by: Vipin Kumar --- arch

Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-23 Thread Vipin Kumar
On 1/23/2013 12:25 PM, Albert ARIBAUD wrote: Hi Vipin, My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot I su

Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-22 Thread Vipin Kumar
Provide a short patch title and a longer description in the patch itself. that would be much more readable On 1/22/2013 7:40 PM, Frank Dols wrote: Signed-off-by: Frank Dols --- drivers/net/designware.c | 108 +++--- drivers/net/designware.h |4 +-

Re: [U-Boot] [PATCH 0/2] make u-boot/drivers/net/designware cache supportive

2013-01-22 Thread Vipin Kumar
On 1/22/2013 7:40 PM, Frank Dols wrote: Hello Vipin, As discussed, see included the patches to make your u-boot/drivers/net/designware Ethernet device driver cache support aware. You dont need to write u-boot/drivers in the patch subject. It is anyway implicit :) Vipin First patch is about

Re: [U-Boot] [PATCH v3] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
On 12/18/2012 5:35 AM, Scott Wood wrote: On 12/17/2012 02:22:40 AM, Vipin Kumar wrote: On 12/14/2012 11:40 PM, Scott Wood wrote: On 12/14/2012 03:32:04 AM, Vipin Kumar wrote: + + switch (genimg_get_format(buffer)) { + case IMAGE_FORMAT_LEGACY: + header = (const image_header_t *)buffer; + len

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-17 Thread Vipin Kumar
On 12/17/2012 11:20 PM, Wolfgang Denk wrote: Dear "Dennis Lan (dlan)", In message you wrote: What would be the use of such timer support? Is there any code that actually needs it, and why does it need anything beyond the existing timer support we have? I think vipin here is trying to

[U-Boot] [PATCH] usbtty: adapt buffers for large packet support

2012-12-17 Thread Vipin Kumar
From: Shiraz Hashim Increase buffer sizes at driver and tty level to accommodate kermit large packet support. Signed-off-by: Shiraz Hashim --- drivers/serial/usbtty.c | 2 +- include/usbdevice.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/serial/usbtty.

[U-Boot] [PATCH] usb/host/ehci: Add support for EHCI on spear

2012-12-17 Thread Vipin Kumar
Add EHCI support for spear boards Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar --- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-spear.c | 59 +++ 2 files changed, 60 insertions(+) create mode 100644 drivers/usb/host/ehci

[U-Boot] [PATCH v4] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
This patch adds support to list images in NAND flash through imls Signed-off-by: Vipin Kumar --- Changes in v4 - Keep stdout dumps in one line - Continue even after read errors for all the blocks README | 3 +- common/cmd_bootm.c | 167

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
On 12/15/2012 12:29 AM, Scott Wood wrote: On 12/14/2012 03:23:26 AM, Vipin Kumar wrote: On 12/14/2012 3:22 AM, Scott Wood wrote: On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: + imgdata = malloc(read_size); + if (!imgdata

Re: [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P

2012-12-17 Thread Vipin Kumar
On 12/7/2012 8:17 PM, Wolfgang Denk wrote: Dear Vipin Kumar, In message<50c1b9a6.1020...@st.com> you wrote: Can you please suggest what is the best way here. Wolfgang, Albert ? I don't like this patch at all. It introduces yet more architecture specific stuff to lib/board.

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-16 Thread Vipin Kumar
On 12/16/2012 1:14 PM, Dennis Lan (dlan) wrote: Hi On Sat, Dec 15, 2012 at 6:20 AM, Wolfgang Denk mailto:w...@denx.de>> wrote: Dear Vipin Kumar, In message <50caf0cb.1050...@st.com <mailto:50caf0cb.1050...@st.com>> you wrote: > ping again pong ;-)

Re: [U-Boot] [PATCH v3] imls: Add support to list images in NAND device

2012-12-14 Thread Vipin Kumar
+ + switch (genimg_get_format(buffer)) { + case IMAGE_FORMAT_LEGACY: + header = (const image_header_t *)buffer; + len = image_get_image_size(header); + + ret = nand

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-14 Thread Vipin Kumar
ping again On 12/6/2012 2:52 PM, Vipin KUMAR wrote: Certain ARMV7 cpus eg. CortexA9 contains a local and a global timer within the CPU core itself. This patch adds generic support for local timer. Signed-off-by: Vipin Kumar --- arch/arm/cpu/armv7/Makefile | 11 ++- arch/arm/cpu

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-14 Thread Vipin Kumar
On 12/14/2012 3:22 AM, Scott Wood wrote: On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: Or better, just have one CONFIG_CMD_IMLS and have it operate on whatever flash types are configured into U-Boot. I didn't do it because until now the CONFIG_CMD_IMLS config is tightly bound with flash

Re: [U-Boot] [PATCH v3] usbh/ehci: Increase timeout for enumeration

2012-12-14 Thread Vipin Kumar
On 12/13/2012 6:41 PM, Marek Vasut wrote: Dear Vipin Kumar, The current logic reads the port status just once after usb_hub_power_on and expects the portstatus and portchange to report the connection status immediately and correctly. Few pen drives are not able to report both of them

Re: [U-Boot] [PATCH v3] imls: Add support to list images in NAND device

2012-12-14 Thread Vipin Kumar
On 12/14/2012 3:29 AM, Scott Wood wrote: On 12/13/2012 04:38:18 AM, Vipin Kumar wrote: + for (off = 0; off < nand->size; off += nand->erasesize) { + const image_header_t *header; + int ret; + + if (nand_block_isbad(nand, off)) + continue; + + len = sizeof(buffer); + + ret = nand_read(

[U-Boot] [PATCH v2 2/2] net/macb: Add arch specific routine to get mdio control

2012-12-13 Thread Vipin Kumar
. Signed-off-by: Shiraz Hashim Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- Changes in v2 Used __weak instead of __attribute__((weak... Improve patch comment drivers/net/macb.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index

[U-Boot] [PATCH v2 1/2] net/designware: Do not select MIIPORT for RGMII interface

2012-12-13 Thread Vipin Kumar
Do not select MIIPORT for RGMII interface Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- drivers/net/designware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index bf21a08..46f6601 100644 --- a/drivers/net

[U-Boot] [PATCH v3] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-13 Thread Vipin Kumar
From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar --- Changes in v3 Added void to spi_init arguments

[U-Boot] [PATCH v3] usbh/ehci: Increase timeout for enumeration

2012-12-13 Thread Vipin Kumar
-boot Note: This 10 second timeout is based purely on several experiments done with the broken pen drives Signed-off-by: Vipin Kumar Acked-by: Igor Grinberg --- Changes in v3 Added comment (in patch comment as well as code) for the reasons for choosing 10 seconds as timeout common/usb_hub.c

[U-Boot] [PATCH v3] imls: Add support to list images in NAND device

2012-12-13 Thread Vipin Kumar
This patch adds support to list images in NAND flash through imls Signed-off-by: Vipin Kumar --- README | 3 +- common/cmd_bootm.c | 166 - 2 files changed, 167 insertions(+), 2 deletions(-) diff --git a/README b/README index

Re: [U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration

2012-12-12 Thread Vipin Kumar
On 12/12/2012 4:55 PM, Marek Vasut wrote: Dear Vipin Kumar, + ulong start = get_timer(0); + + do { + ret = usb_get_port_status(dev, i + 1, portsts); + if (ret< 0) { + USB_HUB_PRI

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Vipin Kumar
[...] README | 3 +- common/cmd_bootm.c | 133 - 2 files changed, 134 insertions(+), 2 deletions(-) diff --git a/README b/README index 2077c3b..ec5c31e 100644 --- a/README +++ b/README @@ -831,7 +831,8 @@ The following opti

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Vipin Kumar
On 12/13/2012 1:54 AM, Wolfgang Denk wrote: Dear Vipin Kumar, In message you wrote: imls does not list the images in NAND devices. This patch implements this support for legacy type images. ... -static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +static void

[U-Boot] [PATCH v2] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-12 Thread Vipin Kumar
From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar --- drivers/spi/Makefile| 1 + drivers/spi

Re: [U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration

2012-12-12 Thread Vipin Kumar
On 12/12/2012 5:10 PM, Igor Grinberg wrote: On 12/12/12 11:54, Vipin Kumar wrote: +ulong start = get_timer(0); + +do { +ret = usb_get_port_status(dev, i + 1, portsts); +if (ret< 0) { +USB_HUB_PRINTF("get_port_status

Re: [U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-12 Thread Vipin Kumar
On 12/12/2012 4:40 PM, Armando VISCONTI wrote: + +/* SSP registers mapping */ +#define SSP_CR0 0x000 +#define SSP_CR1 0x004 +#define SSP_DR 0x008 +#define SSP_SR 0x00C +#define SSP_CPSR 0x010 +#define SSP_IMSC 0x014 +#define SSP_RIS 0x018 +#define SSP_MIS 0x01C +#define SSP_ICR 0x020 +#define SSP

Re: [U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine to get mdio control

2012-12-12 Thread Vipin Kumar
On 12/12/2012 4:37 PM, Stefan Roese wrote: On 12/06/2012 08:10 AM, Vipin Kumar wrote: From: Shiraz Hashim SPEAr310 and SPEAr320 Ethernet interfaces share same MDIO lines to control their respective phys. Currently their is a fixed configuration in which only a particular MAC can use the MDIO

Re: [U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine to get mdio control

2012-12-12 Thread Vipin Kumar
ping. one more :) On 12/6/2012 12:40 PM, Vipin KUMAR wrote: From: Shiraz Hashim SPEAr310 and SPEAr320 Ethernet interfaces share same MDIO lines to control their respective phys. Currently their is a fixed configuration in which only a particular MAC can use the MDIO lines. Call an arch

Re: [U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-12 Thread Vipin Kumar
On 12/12/2012 3:48 PM, Stefan Roese wrote: On 12/06/2012 07:56 AM, Vipin Kumar wrote: From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-12 Thread Vipin Kumar
ping On 12/6/2012 2:52 PM, Vipin KUMAR wrote: Certain ARMV7 cpus eg. CortexA9 contains a local and a global timer within the CPU core itself. This patch adds generic support for local timer. Signed-off-by: Vipin Kumar --- arch/arm/cpu/armv7/Makefile | 11 ++- arch/arm/cpu/armv7

Re: [U-Boot] [PATCH resend 1/2] net/designware: Do not select MIIPORT for RGMII interface

2012-12-12 Thread Vipin Kumar
ping On 12/6/2012 12:40 PM, Vipin KUMAR wrote: Do not select MIIPORT for RGMII interface Signed-off-by: Vipin Kumar --- drivers/net/designware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index bf21a08..46f6601

Re: [U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-12 Thread Vipin Kumar
Ping. Can I get a few Reviewed-by's :) On 12/6/2012 1:35 PM, Stefan Roese wrote: (Added Mike to Cc) On 12/06/2012 07:56 AM, Vipin Kumar wrote: From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wid

Re: [U-Boot] [PATCH resend] sdhci: Add sdhci support for spear devices

2012-12-12 Thread Vipin Kumar
Stefan, Wolfgang, Can you please add relevant people if not present already in this mail Regards Vipin On 12/6/2012 12:14 PM, Vipin KUMAR wrote: Signed-off-by: Vipin Kumar --- drivers/mmc/Makefile | 1 + drivers/mmc/spear_sdhci.c | 44 2

Re: [U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration

2012-12-12 Thread Vipin Kumar
+ ulong start = get_timer(0); + + do { + ret = usb_get_port_status(dev, i + 1, portsts); + if (ret< 0) { + USB_HUB_PRINTF("get_port_status failed\n"); + break; +

[U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Vipin Kumar
imls does not list the images in NAND devices. This patch implements this support for legacy type images. Signed-off-by: Vipin Kumar --- Hello Scott, There has been sometime since you reviewed the first version of this patch. http://lists.denx.de/pipermail/u-boot/2012-November/139631.html I am

Re: [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets

2012-12-07 Thread Vipin Kumar
On 12/7/2012 4:14 PM, Stefan Roese wrote: On 12/07/2012 10:47 AM, Vipin Kumar wrote: On 12/6/2012 5:38 PM, Stefan Roese wrote: On 12/06/2012 10:29 AM, Vipin Kumar wrote: Signed-off-by: Vipin Kumar Is this new build target really needed? Please take a look at the recently added/renamed

Re: [U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration

2012-12-07 Thread Vipin Kumar
On 12/7/2012 3:48 PM, Igor Grinberg wrote: On 12/07/12 12:03, Igor Grinberg wrote: On 12/07/12 10:58, Vipin Kumar wrote: The current logic reads the port status just once after usb_hub_power_on and expects the portstatus and portchange to report the connection status immediately and

Re: [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets

2012-12-07 Thread Vipin Kumar
On 12/6/2012 5:38 PM, Stefan Roese wrote: On 12/06/2012 10:29 AM, Vipin Kumar wrote: Signed-off-by: Vipin Kumar Is this new build target really needed? Please take a look at the recently added/renamed targets (e.g. u-boot-with-spl.bin or u-boot-img.bin). Hmm, this is an mkimage version of

Re: [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P

2012-12-07 Thread Vipin Kumar
On 12/6/2012 4:56 PM, Stefan Roese wrote: On 12/06/2012 10:56 AM, Vipin Kumar wrote: +#ifdef CONFIG_BOOT_PARAMS_P + /* Boot params passed to Linux */ + gd->bd->bi_boot_params = CONFIG_BOOT_PARAMS_P; +#endif Again an ugly #ifdef. Why not something like this instead: De

Re: [U-Boot] [PATCH resend] misc/crypto: Add support for C3

2012-12-07 Thread Vipin Kumar
On 12/6/2012 5:26 PM, Stefan Roese wrote: On 12/06/2012 10:15 AM, Vipin Kumar wrote: C3 is a cryptographic controller which is used by the SPL when DDR ECC support is enabled. Basically, the DDR ECC feature requires the initialization of ECC values before the DDR can actually be used. To

[U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration

2012-12-07 Thread Vipin Kumar
-boot Signed-off-by: Vipin Kumar --- Hello Marek, Igor, I found another way to handle it. Please let me know if it is OK from the USB stack poit of view. The fact is that a few pens do not report a connected status in portstatus while they report a connection change in portchange after a

Re: [U-Boot] [PATCH v2 0/7] mtd/st_smi: Add fixes for smi driver

2012-12-06 Thread Vipin Kumar
On 12/6/2012 5:12 PM, Stefan Roese wrote: Hi Vipin, On 12/06/2012 10:05 AM, Vipin Kumar wrote: As you can see, I have added your Acked-by to patches 2, 3, 4, 6 The reset are still pending. If you can quickly close them, I can send a pull-request for these patches I'm fine with all pa

Re: [U-Boot] [PATCH] fsmc: Skip BBT scan for bad block management

2012-12-06 Thread Vipin Kumar
On 12/7/2012 12:57 AM, Scott Wood wrote: On 12/06/2012 01:21:28 AM, Vipin Kumar wrote: This patch forces to read the bad block marker from location 0 in large page nand devices and location 5 in small page devices. Signed-off-by: Vipin Kumar Reviewed-by: Shiraz Hashim --- drivers/mtd/nand

Re: [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P

2012-12-06 Thread Vipin Kumar
On 12/6/2012 3:14 PM, Stefan Roese wrote: On 12/06/2012 10:29 AM, Vipin Kumar wrote: A lot of ARM boards are using board_init routine just to initialize boot_params variable in the global data structure. This patch lets the board config files to define a CONFIG_BOOT_PARAMS_P option which is

[U-Boot] [PATCH resend] misc/crypto: Add support for C3

2012-12-06 Thread Vipin Kumar
can be done using * CPU * CPU (with Dcache enabled) * C3 The current SPL code uses C3 because the initialization using the CPU is slow and we do not have enough memory in SPL to initialize page tables required to enable MMU and Dcache Signed-off-by: Vipin Kumar Reviewed-by: Shiraz Hashim

[U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P

2012-12-06 Thread Vipin Kumar
utines would not be required in the respective board directories and a weak definition becomes necessary before their removal from the code. Signed-off-by: Vipin Kumar --- README | 6 ++ arch/arm/lib/board.c | 12 2 files changed, 18 insertions(+) diff --git a/RE

[U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets

2012-12-06 Thread Vipin Kumar
Signed-off-by: Vipin Kumar --- Makefile | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Makefile b/Makefile index 8a04727..7f416f4 100644 --- a/Makefile +++ b/Makefile @@ -499,6 +499,13 @@ $(obj)u-boot.sb: $(obj)u-boot.bin $(obj)spl/u-boot-spl.bin elftosb

[U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-06 Thread Vipin Kumar
Certain ARMV7 cpus eg. CortexA9 contains a local and a global timer within the CPU core itself. This patch adds generic support for local timer. Signed-off-by: Vipin Kumar --- arch/arm/cpu/armv7/Makefile | 11 ++- arch/arm/cpu/armv7/ca9_ltimer.c | 152

Re: [U-Boot] [PATCH v2 0/7] mtd/st_smi: Add fixes for smi driver

2012-12-06 Thread Vipin Kumar
Hello Stefan, As you can see, I have added your Acked-by to patches 2, 3, 4, 6 The reset are still pending. If you can quickly close them, I can send a pull-request for these patches Thanks for a fast review Regards Vipin On 12/6/2012 2:17 PM, Vipin KUMAR wrote: Modifications in v2 (Review

Re: [U-Boot] [PATCH resend] usbh/ehci: Increase timeout for enumeration

2012-12-06 Thread Vipin Kumar
On 12/6/2012 1:06 PM, Igor Grinberg wrote: On 12/06/12 08:58, Vipin Kumar wrote: On 12/6/2012 12:17 PM, Igor Grinberg wrote: On 12/06/12 08:30, Vipin Kumar wrote: Few pen drives take longer than usual for enumeration. The u-boot unlike linux does not depend on interrupts and works in polling

Re: [U-Boot] [PATCH resend 0/7] mtd/st_smi: Add fixes for smi driver

2012-12-06 Thread Vipin Kumar
On 12/6/2012 2:02 PM, Stefan Roese wrote: On 12/06/2012 09:19 AM, Vipin Kumar wrote: Since I'm the CFI (NOR parallel) flash custodian, I can take these patches through my repository as well. If there is a dependency with some of your platforms patches, then the patches can go through yo

[U-Boot] [PATCH v2 6/7] mtd/st_smi: Use page sizes respective to flash

2012-12-06 Thread Vipin Kumar
The page size is a flash dependent property and the driver was using a macro in place of page size. This patch uses the proper page size wrt the flash device connected on board Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- drivers/mtd/st_smi.c | 41

[U-Boot] [PATCH v2 7/7] mtd/st_smi: Add mtd support for smi

2012-12-06 Thread Vipin Kumar
This patch adds mtd device support for smi devices Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 167 ++- 1 file changed, 166 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index 0ed6c0d..c4780c3

[U-Boot] [PATCH v2 5/7] mtd/st_smi: Write to flash in a tight loop

2012-12-06 Thread Vipin Kumar
bytes to be written. Additionally, enable burst mode before this loop so that the controller does not deselect the chip if the transfer is finished. Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a

[U-Boot] [PATCH v2 4/7] mtd/st_smi: Avoid issuing multiple WE commands

2012-12-06 Thread Vipin Kumar
At the start of an smi_write, if the destination address is page aligned, the Write Enable command is getting issued twice. This patch fixes it by keeping a flag. Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- drivers/mtd/st_smi.c | 13 + 1 file changed, 5 insertions(+), 8

[U-Boot] [PATCH v2 3/7] mtd/st_smi: Add support for Micron N25Q128 Flash

2012-12-06 Thread Vipin Kumar
From: Armando Visconti Signed-off-by: Vipin Kumar Signed-off-by: Armando Visconti Acked-by: Stefan Roese --- drivers/mtd/st_smi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index 30bfa3f..99b9576 100644 --- a/drivers/mtd/st_smi.c +++ b

[U-Boot] [PATCH v2 2/7] mtd/st_smi: Rearrange the supported devices in alphabetical order

2012-12-06 Thread Vipin Kumar
Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- drivers/mtd/st_smi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index 63b10fc..30bfa3f 100644 --- a/drivers/mtd/st_smi.c +++ b/drivers/mtd/st_smi.c

[U-Boot] [PATCH v2 1/7] mtd/st_smi: Clear error flags while initiating a fresh write

2012-12-06 Thread Vipin Kumar
-by: Vipin Kumar --- drivers/mtd/st_smi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index 7507e5d..63b10fc 100644 --- a/drivers/mtd/st_smi.c +++ b/drivers/mtd/st_smi.c @@ -392,6 +392,8 @@ static int smi_write(unsigned int *src_addr, unsigned

[U-Boot] [PATCH v2 0/7] mtd/st_smi: Add fixes for smi driver

2012-12-06 Thread Vipin Kumar
the list of devices - Avoid issuing multiple write enable commands Armando Visconti (1): mtd/st_smi: Add support for Micron N25Q128 Flash Vipin Kumar (6): mtd/st_smi: Clear error flags while initiating a fresh write mtd/st_smi: Rearrange the supported devices in alphabetical order mtd

Re: [U-Boot] [PATCH resend 7/7] mtd/st_smi: Add mtd support for smi

2012-12-06 Thread Vipin Kumar
On 12/6/2012 1:32 PM, Stefan Roese wrote: On 12/06/2012 07:21 AM, Vipin Kumar wrote: This patch adds mtd device support for smi devices Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 167 ++- 1 file changed, 165 insertions(+), 2

Re: [U-Boot] [PATCH resend 0/7] mtd/st_smi: Add fixes for smi driver

2012-12-06 Thread Vipin Kumar
On 12/6/2012 1:05 PM, Stefan Roese wrote: Hi Vipin, On 12/06/2012 07:21 AM, Vipin Kumar wrote: Hello, This patch-set adds simple fixes for smi driver used in spear devices. Modifications include - Add MTD support for smi driver - Write to flash in a tight loop - Alphabetically sort the list

Re: [U-Boot] [PATCH resend 1/7] mtd/st_smi: Clear error flags while initiating a fresh write

2012-12-06 Thread Vipin Kumar
On 12/6/2012 1:07 PM, Stefan Roese wrote: On 12/06/2012 07:21 AM, Vipin Kumar wrote: SMI controller reports an error when the code tries to write on the flash area with Write Enable command not issued or the bank has come out of the write mode. This error is reported even with a fresh write

[U-Boot] [PATCH] fsmc: Skip BBT scan for bad block management

2012-12-05 Thread Vipin Kumar
This patch forces to read the bad block marker from location 0 in large page nand devices and location 5 in small page devices. Signed-off-by: Vipin Kumar Reviewed-by: Shiraz Hashim --- drivers/mtd/nand/fsmc_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd

[U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine to get mdio control

2012-12-05 Thread Vipin Kumar
. Signed-off-by: Shiraz Hashim Signed-off-by: Vipin Kumar --- drivers/net/macb.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8bacbda..45fbbd7 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -163,6 +163,13 @@ static u16

[U-Boot] [PATCH resend 1/2] net/designware: Do not select MIIPORT for RGMII interface

2012-12-05 Thread Vipin Kumar
Do not select MIIPORT for RGMII interface Signed-off-by: Vipin Kumar --- drivers/net/designware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index bf21a08..46f6601 100644 --- a/drivers/net/designware.c +++ b/drivers

Re: [U-Boot] [PATCH resend] usbh/ehci: Increase timeout for enumeration

2012-12-05 Thread Vipin Kumar
On 12/6/2012 12:17 PM, Igor Grinberg wrote: On 12/06/12 08:30, Vipin Kumar wrote: Few pen drives take longer than usual for enumeration. The u-boot unlike linux does not depend on interrupts and works in polling and timeout mode. This patch increases this timeout to increase the set of usb

[U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-05 Thread Vipin Kumar
From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar --- Dear Wolfgang, Stefan, There seems to be no

[U-Boot] [PATCH resend] sdhci: Add sdhci support for spear devices

2012-12-05 Thread Vipin Kumar
Signed-off-by: Vipin Kumar --- drivers/mmc/Makefile | 1 + drivers/mmc/spear_sdhci.c | 44 2 files changed, 45 insertions(+) create mode 100644 drivers/mmc/spear_sdhci.c diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile index a1dd730

[U-Boot] [PATCH resend] usbh/ehci: Increase timeout for enumeration

2012-12-05 Thread Vipin Kumar
Few pen drives take longer than usual for enumeration. The u-boot unlike linux does not depend on interrupts and works in polling and timeout mode. This patch increases this timeout to increase the set of usb sticks that can be enumerated by u-boot Signed-off-by: Vipin Kumar --- common

[U-Boot] [PATCH resend 7/7] mtd/st_smi: Add mtd support for smi

2012-12-05 Thread Vipin Kumar
This patch adds mtd device support for smi devices Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 167 ++- 1 file changed, 165 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index 0e529a4..4d1a6bd

[U-Boot] [PATCH resend 6/7] mtd/st_smi: Use page sizes respective to flash

2012-12-05 Thread Vipin Kumar
The page size is a flash dependent property and the driver was using a macro in place of page size. This patch uses the proper page size wrt the flash device connected on board Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 41 + include

[U-Boot] [PATCH resend 5/7] mtd/st_smi: Write to flash in a tight loop

2012-12-05 Thread Vipin Kumar
bytes to be written. Additionally, enable burst mode before this loop so that the controller does not deselect the chip if the transfer is finished. Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a

[U-Boot] [PATCH resend 4/7] mtd/st_smi: Avoid issuing multiple WE commands

2012-12-05 Thread Vipin Kumar
At the start of an smi_write, if the destination address is page aligned, the Write Enable command is getting issued twice. This patch fixes it by keeping a flag. Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[U-Boot] [PATCH resend 3/7] mtd/st_smi: Add support for Micron N25Q128 Flash

2012-12-05 Thread Vipin Kumar
From: Armando Visconti Signed-off-by: Armando Visconti --- drivers/mtd/st_smi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index c3e35c0..a46b273 100644 --- a/drivers/mtd/st_smi.c +++ b/drivers/mtd/st_smi.c @@ -91,6 +91,7 @@ static struct fla

[U-Boot] [PATCH resend 2/7] mtd/st_smi: Rearrange the supported devices in alphabetical order

2012-12-05 Thread Vipin Kumar
Signed-off-by: Vipin Kumar --- drivers/mtd/st_smi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index fad4420..c3e35c0 100644 --- a/drivers/mtd/st_smi.c +++ b/drivers/mtd/st_smi.c @@ -62,24 +62,24

[U-Boot] [PATCH resend 0/7] mtd/st_smi: Add fixes for smi driver

2012-12-05 Thread Vipin Kumar
these to you as there is no direct maintainer of mtd in u-boot. I can add these in my pull-request once you review these patches Thanks in advance Vipin Armando Visconti (1): mtd/st_smi: Add support for Micron N25Q128 Flash Vipin Kumar (6): mtd/st_smi: Clear error flags while initiating a fresh

[U-Boot] [PATCH resend 1/7] mtd/st_smi: Clear error flags while initiating a fresh write

2012-12-05 Thread Vipin Kumar
-by: Vipin Kumar --- drivers/mtd/st_smi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/st_smi.c b/drivers/mtd/st_smi.c index 7507e5d..fad4420 100644 --- a/drivers/mtd/st_smi.c +++ b/drivers/mtd/st_smi.c @@ -392,6 +392,8 @@ static int smi_write(unsigned int *src_addr, unsigned

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-12-02 Thread Vipin Kumar
On 11/30/2012 6:04 PM, Wolfgang Denk wrote: Dear Armando Visconti, In message<50b89534.6040...@st.com> you wrote: Not sure what are next steps for this patchset. Is someone going to review it, or part of it? Or is Vipin expected to do something on the repository assigned to him (maybe he alr

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-20 Thread Vipin Kumar
Hello u-boot team, Can you please provide some comments on this patch-set Please consider this for inclusion Regards Vipin On 11/2/2012 11:09 PM, Vipin KUMAR wrote: This patchset is split in several pieces - Drivers: This is essentially a few new drivers and fixes in already exiasting

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-12 Thread Vipin Kumar
On 11/11/2012 1:20 PM, Wolfgang Denk wrote: Dear Stefan, In message<509f4194.9070...@denx.de> you wrote: Vipin, please send your public ssh key to Wolfgang so that we can create the new "spear" U-Boot git repository for you. Hello Wolfgang Will this be only SPEAr, or should we expect ot

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-07 Thread Vipin Kumar
On 11/7/2012 7:40 PM, Stefan Roese wrote: Hi Vipin, On 11/02/2012 06:39 PM, Vipin Kumar wrote: This patchset is split in several pieces - Drivers: This is essentially a few new drivers and fixes in already exiasting drivers - Enhancement: This series enhances the already existing spear

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-07 Thread Vipin Kumar
On 11/7/2012 7:40 PM, Stefan Roese wrote: Hi Vipin, On 11/02/2012 06:39 PM, Vipin Kumar wrote: This patchset is split in several pieces - Drivers: This is essentially a few new drivers and fixes in already exiasting drivers - Enhancement: This series enhances the already existing spear

Re: [U-Boot] [Drivers PATCH 17/19] imls: Add support to list images in NAND device

2012-11-06 Thread Vipin Kumar
On 11/7/2012 5:00 AM, Scott Wood wrote: On 11/02/2012 12:40:02 PM, Vipin Kumar wrote: imls does not list the images in NAND devices. This patch implements this support for legacy type images. Signed-off-by: Vipin Kumar --- common/cmd_bootm.c | 98

[U-Boot] [Drivers PATCH 10/19] usb/gadget/designware_otg: Add support for designware otg

2012-11-02 Thread Vipin Kumar
Signed-off-by: Vipin Kumar --- drivers/serial/usbtty.h |2 + drivers/usb/gadget/Makefile |1 + drivers/usb/gadget/designware_otg.c | 1063 +++ include/usb/designware_otg.h| 500 4 files changed, 1566 insertions

[U-Boot] [SPEAr Enhancement PATCH 6/9] spear320-hmi: Add support for hmi machine

2012-11-02 Thread Vipin Kumar
Signed-off-by: Vipin Kumar --- MAINTAINERS| 1 + board/st/spear/Makefile| 1 + board/st/spear/spear320hmi.c | 120 + board/st/spear/spear_common.c | 2 + boards.cfg | 2 + include/configs/spear320

  1   2   3   4   5   >