report failure to send email explicitly.
Tested by running the script on a patch with style violations,
observed error messages in the script output.
Signed-off-by: Vadim Bendebury
---
Changes in v2:
- modified the error message for accuracy
tools/patman/patman.py | 7 ++-
1 file changed, 6
On Wed, Sep 3, 2014 at 3:14 PM, Doug Anderson wrote:
> Vadim,
>
> On Wed, Sep 3, 2014 at 12:16 PM, Vadim Bendebury wrote:
>> For an occasional user of patman some failures are not obvious: for
>> instance when checkpatch reports warnings, the dry run still reports
>> t
report failure to send email explicitly.
Tested by running the script on a patch with style violations,
observed error messages in the script output.
Signed-off-by: Vadim Bendebury
---
tools/patman/patman.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/patman
On Tue, Feb 25, 2014 at 3:43 PM, Simon Glass wrote:
> Hi Masahiro,
>
> On 24 February 2014 05:36, Masahiro Yamada wrote:
>> HOSTCFLAGS_autoconf.mk.dep was added by commit 422322f
>> but it has never been used.
>>
>> Cc: Vadim Bendebury
>> Cc: Simon G
e, Nov 12, 2013 at 3:13 PM, Albert ARIBAUD
>>> wrote:
>>> > On Tue, 12 Nov 2013 15:00:06 -0200, Otavio Salvador
>>> > wrote:
>>> >
>>> >> On Tue, Nov 12, 2013 at 2:55 PM, Vadim Bendebury (вб)
>>> >> wrote:
>>&
scription for it as I could see.
>
All right, that's what I figured :). Thank you for the explanation,
--vb
> Thanks,
> Lei
>
>> -Original Message-
>> From: vben...@gmail.com [mailto:vben...@gmail.com] On Behalf Of Vadim
>> Bendebury
>> Sent: T
Hello Lei,
I am looking into adding eMMC support for some intel SDHCI controllers
based on this common SDHCI driver submission.
One thing which is not quite clear is the quirks - can you (or
somebody else on this list) please shed some light on what the quirks
are. Is there some kind of formal de
nk you, Simon!
--vb
>
> On Wed, Sep 4, 2013 at 8:25 PM, Vadim Bendebury wrote:
>> this is the tweak
>>
>> -- Forwarded message --
>> From: Vadim Bendebury
>> Date: Wed, Sep 4, 2013 at 11:49 AM
>> Subject: Compiling certain files with extr
Does u-boot provide the ability to change compilation options 'on the
fly', say when certain files need to be compiled for symbolic
debugging? I looked but did not find any.
How about something like this:
vvv
$ git diff config.mk
diff --git a/config.mk
On Tue, Apr 30, 2013 at 2:14 PM, Tom Rini wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 04/30/2013 04:49 PM, Doug Anderson wrote:
>> Tom,
>>
>> On Tue, Apr 30, 2013 at 1:35 PM, Tom Rini wrote:
>>> And I guess having this knowledge correct for the kernel is
>>> useful in other co
On Tue, May 14, 2013 at 3:15 PM, Tom Rini wrote:
> On Tue, May 14, 2013 at 02:27:32PM -0700, Simon Glass wrote:
>> Hi Tom,
>>
>> On Tue, May 14, 2013 at 2:21 PM, Tom Rini wrote:
>> > On Mon, May 13, 2013 at 03:12:07PM -0700, Simon Glass wrote:
>> >> Hi Tom,
>> >>
>> >> On Thu, Mar 21, 2013 at 7:3
On Mon, May 6, 2013 at 7:37 AM, Simon Glass wrote:
>
> HI Vadim,
>
> On Thu, May 2, 2013 at 11:12 PM, Vadim Bendebury wrote:
> > [the original patch removed, re-sending from a registered address]
> >
> > So, I spent some more time debugging a system which requires t
[the original patch removed]
So, I spent some more time debugging a system which requires this
patch: a system, where on a SPI interface a response to a command
could come way later then the command data transmission completes.
The original patch was trying to address many corner cases, but come
[the original patch removed, re-sending from a registered address]
So, I spent some more time debugging a system which requires this
patch: a system, where on a SPI interface a response to a command
could come way later then the command data transmission completes.
The original patch was trying t
On Thu, Mar 21, 2013 at 11:29 PM, Rajeshwari Shinde
wrote:
> Support interfaces with a preamble before each received message.
>
> We handle this when the client has requested a SPI_XFER_END, meaning
> that we must close of the transaction. In this case we read until we
> see the preamble (or a tim
On Mon, Mar 25, 2013 at 4:17 AM, Akshay Saraswat wrote:
>
> From: Naveen Krishna Chatradhi
>
> Adding NACK logic for i2c write.
> Verified by reading and writing to device with address 9 on i2c-0.
>
> Signed-off-by: Naveen Krishna Chatradhi
> Signed-off-by: Akshay Saraswat
> ---
> drivers/i2c/
Apparently due to a missed rebase conflict resolution
board_early_init_f() is included twice in the list of initialization
functions.
Leave only the first occurrence.
. built and boot an Exynos 5250 target
Signed-off-by: Vadim Bendebury
---
common/board_f.c | 3 ---
1 file changed, 3
On Tue, Apr 2, 2013 at 11:27 PM, Akshay Saraswat wrote:
> This patch enables cpu freq support for exynos5 by adding
> config for it.
>
> Signed-off-by: Akshay Saraswat
> ---
> include/configs/exynos5250-dt.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/configs/exynos5250-d
se an error, it used to before this change.
Signed-off-by: Vadim Bendebury
---
Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 12763ce..23f266a 100644
--- a/Makefile
+++ b/Makefile
@@ -406,8 +406,10 @@ ALL-y += $(obj)u-boot.srec $(obj)u-
On Thu, Jan 31, 2013 at 9:23 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message
> you
> wrote:
>> Just wanted to let everybody know that there has been a mirror set up
>> on Google infrastructure which polls git://git.denx.de/u-boot.git
>> eve
Just wanted to let everybody know that there has been a mirror set up
on Google infrastructure which polls git://git.denx.de/u-boot.git
every 5 minutes.
URL for browsing is https://u-boot.googlesource.com, and
https://u-boot-review.googlesource.com is actually a gerrit instance
ready to be used
ded to the list
> and this can only be done if you confirm your employer.
>
> So, if you are on the CC list and work at Google, please reply-all
> with a quick email stating this (without top posting).
>
> Regards,
> Simon
All emails from vben...@chromium.org come from me
On Thu, Jan 10, 2013 at 9:05 AM, Simon Glass wrote:
> Hi Vadim,
>
> On Wed, Jan 9, 2013 at 6:00 PM, Vadim Bendebury wrote:
>> To make it usable in git trees not providing a patch checker
>> implementation, add a command line option, allowing to suppress patch
>> chec
--help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury
---
Changes in v4:
. now properly corrected typo in the error message
Changes in v3:
. corrected typo in the error message
Changes in v2:
. addressed comments WRT use of double negative
.
--help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury
---
Changes in v3:
. corrected typo in the error message
Changes in v2:
. addressed comments WRT use of double negative
. added code to gracefully handle absence of checkpatch.cl
tools/p
--help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury
---
Changes in v2:
. addressed comments WRT use of double negative
. added code to gracefully handle absence of checkpatch.cl
tools/patman/checkpatch.py | 10 +-
tools/patman/patm
--help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury
---
tools/patman/checkpatch.py | 10 +-
tools/patman/patman.py | 14 ++
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tools/patman/checkpatch.py b/
On Wed, Jan 9, 2013 at 2:57 PM, Doug Anderson wrote:
> Vadim,
>
> On Wed, Jan 9, 2013 at 2:07 PM, Vadim Bendebury wrote:
>>>> +parser.add_option('--no-check', action='store_true', dest='no_check',
>>>> + def
On Wed, Jan 9, 2013 at 2:22 PM, Simon Glass wrote:
> Hi Vadim,
>
> On Wed, Jan 9, 2013 at 2:16 PM, Vadim Bendebury wrote:
>> On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass wrote:
>>> Hi Vadim,
>>>
>>> Looks good! Please can you add a single character optio
t;
>> Thanks for the patch! Looks good in general, though please add the
>> "patman" prefix to the first line of your commit message.
>>
>>
>> On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury wrote:
>>> To make it usable in git trees not providing a p
On Wed, Jan 9, 2013 at 2:01 PM, Vadim Bendebury wrote:
> To make it usable in git trees not providing a patch checker
> implementation, add a command line option, allowing to suppress patch
> check. While we are at it, sort debug options alphabetically.
>
>. unit test passes:
&
generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury
---
tools/patman/patman.py | 14 ++--
generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury
---
tools/patman/patman.py | 14 ++--
On Wed, Dec 5, 2012 at 5:23 PM, Fabio Estevam wrote:
> On Wed, Dec 5, 2012 at 10:46 PM, Simon Glass wrote:
>> From: Vadim Bendebury
>>
>> Provide u-boot console functions to access IO space registers. A no
>> thrills implementation, accessing one register a
On Sat, Nov 3, 2012 at 8:26 AM, Wolfgang Denk wrote:
> Dear Simon Glass,
>
> In message <1351902453-27956-16-git-send-email-...@chromium.org> you
> wrote:
> > From: Vadim Bendebury
> >
> > Provide u-boot console functions to access IO space registers. A no
&
does it seem falling apart?
cheers,
/vb
> Signed-off-by: Marek Vasut
> Cc: Vadim Bendebury
> Cc: Tom Rini
> ---
> Makefile |1 -
> README| 10 -
> drivers/tpm/Makefile | 43
>
On Sat, Dec 10, 2011 at 2:42 AM, Graeme Russ wrote:
> Hi Vadim,
>
> Oops, dropped the ML...
>
> On Dec 10, 2011 9:20 PM, "Graeme Russ" wrote:
>>
>> Hi Vadim,
>>
>> On Dec 10, 2011 12:14 PM, "Graeme Russ" wrote:
>> >
On Fri, Dec 9, 2011 at 3:57 PM, Graeme Russ wrote:
>
> Hi Vadim,
>
> On Dec 10, 2011 10:31 AM, "Vadim Bendebury" wrote:
> >
> > There have been a couple of unused variable cases, causing compilation
> > warnings when building the eNET target.
> >
&
registers discarding the
values.
The source code is being modified accordingly.
TEST:
- the eNET target now builds cleanly
- examining disassembled sc520_timer.o shows that the registers are
still being accessed in the beginning of the function.
Signed-off-by: Vadim Bendebury
---
[Resend with the
registers discarding the
values.
The source code is being modified accordingly.
TEST:
- the eNET target now builds cleanly
- examining disassembled sc520_timer.o shows that the registers are
still being accessed in the beginning of the function.
Signed-off-by: Vadim Bendebury
---
arch/x86/cpu
Dear Wolfgang Denk,
On Tue, Dec 6, 2011 at 11:47 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
[..]
>
> Applied, thanks.
>
Thank you!
>
> But _please_ get used to providing full change logs to your patches.
> This is patch v6, so I would like to see a history for
Change-Id: I22a33c3e5b2e20eec9557a7621bd463b30389d73
Signed-off-by: Vadim Bendebury
CC: Wolfgang Denk
---
v5 with A function comment header correction.
Makefile |3 +
README| 10 +
drivers/tpm/Makefile | 43
drivers/tpm/generic_lpc_tp
Dear Wolfgang Denk,
On Sun, Oct 16, 2011 at 1:53 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message
> you
> wrote:
>>
>> because this chip is sensitive to the access cycle size (byte versus word).
>>
>> When using macros one can rely
Change-Id: I22a33c3e5b2e20eec9557a7621bd463b30389d73
Signed-off-by: Vadim Bendebury
CC: Wolfgang Denk
---
The v5 patch does the following:
- replaces the structure definition used to represent the TPM device with a
pointer to a single locality.
- replaces register wrapper macros with wrapper functions.
Re-tested both
Dear Wolfgang Denk,
On Sun, Oct 16, 2011 at 1:31 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message
> you
> wrote:
>>
>> > Yes, I consider this weird, too. And you failed to provide a good
>> > explanation why you think this would be need
Dear Wolfgang Denk,
On Sun, Oct 16, 2011 at 1:04 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message
> you
> wrote:
>>
>> Also, what about situations when one reviewer requests a certain
>> implementation and another one finds it inappropriat
On Sun, Oct 16, 2011 at 5:28 AM, Marek Vasut wrote:
> On Sunday, October 16, 2011 05:45:40 AM Vadim Bendebury wrote:
>> On Sat, Oct 15, 2011 at 8:31 PM, Marek Vasut wrote:
>> > On Sunday, October 16, 2011 03:04:33 AM Vadim Bendebury wrote:
>> >> On Sat, Oct 15
Change-Id: I22a33c3e5b2e20eec9557a7621bd463b30389d73
Signed-off-by: Vadim Bendebury
CC: Wolfgang Denk
---
v4 converts BURST_COUNT into a function. No explicit 'inline' keyword is used,
as it is considered unnecessary with current gcc in cases like this.
Side by side diffs between v4 and v3 can be seen at
http://
Wolfgang Denk,
On Sun, Oct 16, 2011 at 12:35 AM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message
> you
> wrote:
>>
>> >> I am not sure what is wrong with a short macro in this case - is this
>> >> against the coding style?
>> &g
On Sat, Oct 15, 2011 at 8:31 PM, Marek Vasut wrote:
> On Sunday, October 16, 2011 03:04:33 AM Vadim Bendebury wrote:
>> On Sat, Oct 15, 2011 at 2:09 PM, Marek Vasut wrote:
>> > On Saturday, October 15, 2011 08:47:39 PM Vadim Bendebury wrote:
>> >> Dear Marek Vasut,
On Sat, Oct 15, 2011 at 6:20 PM, Vadim Bendebury wrote:
>
> sorry, sent this and the other patchset with a wrong version number,
> will resend with the correct number.
>
or maybe not - looks like the latest patches were sent with the
correct version number (v3) but gmail reader
On Sat, Oct 15, 2011 at 6:13 PM, Vadim Bendebury wrote:
> TPM (Trusted Platform Module) is an integrated circuit and
> software platform that provides computer manufacturers with the
> core components of a subsystem used to assure authenticity,
> integrity and confidentiality.
>
ne byte short), an error is reported:
boot > tpm 0x0 0xc1 0x0 0x0 0x0 0xc 0x0 0x0 0x0 0x99 0x0
generic_lpc_tpm.c:311 unexpected TPM status 0xff000888
generic_lpc_tpm.c:516 failed sending data to TPM
tpm command failed
boot >
Change-Id: I3f3c5bfec8b852e208c4e99ba37b0f2b875140b0
Signed-off-by:
Change-Id: I22a33c3e5b2e20eec9557a7621bd463b30389d73
Signed-off-by: Vadim Bendebury
CC: Wolfgang Denk
---
Makefile |3 +
README| 10 +
drivers/tpm/Makefile | 43
drivers/tpm/generic_lpc_tpm.c | 485 +
inc
On Sat, Oct 15, 2011 at 12:42 PM, Mike Frysinger wrote:
> On Friday 14 October 2011 23:38:50 Vadim Bendebury wrote:
>> --- /dev/null
>> +++ b/drivers/tpm/generic_lpc_tpm.c
>>
>> +#define TPM_TIMEOUT_ERR (~0)
>> +#define TPM_DRIVER_ERR
On Sat, Oct 15, 2011 at 12:25 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message <20111015033850.74ad541...@eskimo.mtv.corp.google.com> you wrote:
>> TPM (Trusted Platform Module) is an integrated circuit and
>> software platform that provides computer man
On Sat, Oct 15, 2011 at 2:09 PM, Marek Vasut wrote:
> On Saturday, October 15, 2011 08:47:39 PM Vadim Bendebury wrote:
>> Dear Marek Vasut,
>>
>> thank you for your comments, please see below:
>>
>> On Sat, Oct 15, 2011 at 11:08 AM, Marek Vasut wrote:
>> &
Dear Wolfgang Denk,
On Sat, Oct 15, 2011 at 12:44 PM, Wolfgang Denk wrote:
> Dear Vadim Bendebury,
>
> In message
> you
> wrote:
>>
>> >> + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
>> >> + * Released under the 2-clau
On Sat, Oct 15, 2011 at 12:08 PM, Mike Frysinger wrote:
> On Saturday 15 October 2011 14:02:29 Marek Vasut wrote:
>> On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote:
>> > --- /dev/null
>> > +++ b/common/cmd_tpm.c
>> > @@ -0,0 +1,111 @@
>
On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger wrote:
> On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote:
>> Vadim Bendebury wrote:
>> > > Two underscores aren't a good practice.
>> >
>> > I did this as a result of a previous review. Do you ha
On Sat, Oct 15, 2011 at 12:42 PM, Mike Frysinger wrote:
> On Friday 14 October 2011 23:38:50 Vadim Bendebury wrote:
>> --- /dev/null
>> +++ b/drivers/tpm/generic_lpc_tpm.c
>>
>> +#define TPM_TIMEOUT_ERR (~0)
>> +#define TPM_DRIVER_ERR
Dear Marek Vasut,
thank you for your comments, please see below:
On Sat, Oct 15, 2011 at 11:08 AM, Marek Vasut wrote:
> On Saturday, October 15, 2011 05:38:50 AM Vadim Bendebury wrote:
>> TPM (Trusted Platform Module) is an integrated circuit and
>> software platform that pr
Dear Marek Vasut,
thank you for your comments, please see below:
On Sat, Oct 15, 2011 at 11:02 AM, Marek Vasut wrote:
> On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote:
>> The command gets an arbitrary number of arguments (up to 30), which
>> are interpreted as
ne byte short), an error is reported:
boot > tpm 0x0 0xc1 0x0 0x0 0x0 0xc 0x0 0x0 0x0 0x99 0x0
generic_lpc_tpm.c:311 unexpected TPM status 0xff000888
generic_lpc_tpm.c:516 failed sending data to TPM
tpm command failed
boot >
Signed-off-by: Vadim Bendebury
CC: Wolfgang Denk
---
comm
d is being used in three different
functional ChromeOS machines (Pinetrail and Sandy Bridge Intel
chipsets) all using the same Infineon SLB 9635 TT 1.2 device.
A u-boot cli command allowing access to the TPM was also
implemented and is being submitted as a second patch.
Signed-off-by: Vadim Ben
On Mon, Oct 10, 2011 at 1:48 PM, Wolfgang Denk wrote:
>
[..]
>
> > Yet another inconvenience though is the requirement to be able to
> > trace accesses to the registers. Some of the registers can be accessed
> > in 32 bit mode or 8 bit mode, and this determines how many bytes get
>
> Can you not a
Wolfgang, thank you for your comments, I'll address them in a
follow-up submission, but I have a question regarding the register
access (and the issue was indeed brought up by vapier@ at an earlier
review on a different submission).
On Mon, Oct 10, 2011 at 3:45 AM, Wolfgang Denk wrote:
>
> > +#de
ess to the TPM was also
implemented and will be submitted separately.
Change-Id: I22a33c3e5b2e20eec9557a7621bd463b30389d73
Signed-off-by: Vadim Bendebury
CC: Wolfgang Denk
---
Makefile |3 +
README|8 +
drivers/tpm/Makefile | 27 +
On Thu, Sep 29, 2011 at 4:15 PM, Graeme Russ wrote:
> Hi Vadim,
>
> On Wed, Sep 28, 2011 at 12:55 AM, Vadim Bendebury
> wrote:
>> On Tue, Sep 27, 2011 at 4:22 AM, Graeme Russ wrote:
>>> Hi Vadim,
>>>
>>> On 27/09/11 08:50, Vadim Bendebury wrote:
On Tue, Sep 27, 2011 at 4:22 AM, Graeme Russ wrote:
> Hi Vadim,
>
> On 27/09/11 08:50, Vadim Bendebury wrote:
>> On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote:
>>> Allow redirection of console output prior to console initialisation to a
>>> tempora
On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote:
> Allow redirection of console output prior to console initialisation to a
> temporary buffer.
>
> To enable this functionality, the board configuration file must define:
> - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer
> - CONFIG_PRE_
71 matches
Mail list logo
