On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass <s...@google.com> wrote:
> Hi Vadim,
>
> Looks good! Please can you add a single character option?
>
Simon, I could not think of a good single letter option to pick, so I
did not, but if you have a suggestion I implement it.
> Can you also please add an option to skip the 'apply' step? This takes
> quite a bit of time, and it would be nice to have a 'fast' option.
>
does it have to be in this CL?
cheers,
/vb
> Regards,
> Simon
>
> On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson <diand...@chromium.org> wrote:
>> Vadim,
>>
>> Thanks for the patch! Looks good in general, though please add the
>> "patman" prefix to the first line of your commit message.
>>
>>
>> On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury <vben...@chromium.org> wrote:
>>> To make it usable in git trees not providing a patch checker
>>> implementation, add a command line option, allowing to suippress patch
>>
>> s/suippress/suppress
>>
>>> +parser.add_option('--no-check', action='store_true', dest='no_check',
>>> + default=False,
>>> + help="Don't check for patch compliance")
>>
>> IMHO It would be slightly better to use action='store_false',
>> dest='check', and default=True (just to avoid so many
>> double-negatives).
>>
>>
>> -Doug
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
