Re: [U-Boot] [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot support

2013-01-17 Thread Tabi Timur-B04825
Xie Shaohui-B21989 wrote: > [S.H] I thought one patch doing one thing even it's simple. > I'm fine with the merge if you insist. Well, it is a matter of opinion. I don't insist, but I think it would be easier for everyone if you did merge these patches. Each one is very short, and they are all

Re: [U-Boot] [PATCH] powerpc/p5040: add serdes2 memory map register define

2013-01-17 Thread Tabi Timur-B04825
On Thu, Jan 17, 2013 at 9:26 AM, Roy Zang wrote: > Signed-off-by: Roy Zang > --- Why? We don't need this for P5040 support. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/l

Re: [U-Boot] [PATCH] powerpc/mpc85xx: Add BSC9132/BSC9232 processor support

2013-01-14 Thread Tabi Timur-B04825
On Mon, Jan 14, 2013 at 10:26 PM, Prabhakar Kushwaha wrote: > #define SVR_9130 0x860001 > #define SVR_9131 0x86 > +#define SVR_9132 0x861000 > +#define SVR_9132_E 0x861800 > +#define SVR_9232 0x861400 Remove SVR_9132_E. See commit 48f6a5c348453fc3ab33aaa91e5e

Re: [U-Boot] [PATCH] powerpc/mpc85xx: Add property 'fsl, sec-era' in device tree node 'crypto'.

2013-01-10 Thread Tabi Timur-B04825
On Thu, Jan 10, 2013 at 5:49 AM, Vakul Garg wrote: > If property 'fsl,sec-era' is already present, it is updated. > This property is required so that applications can ascertain which > descriptor commands are supported on a particular CAAM version. > > Signed-off-by: Vakul Garg > Cc: Andy Fleming

Re: [U-Boot] [PATCH] Introduce a global bool type

2013-01-08 Thread Tabi Timur-B04825
On Mon, Jan 7, 2013 at 4:39 PM, Wolfgang Denk wrote: > > This seems broken to me. Can we rather try8 and get rid of all this > "bool" stuff instead? It's just obfuscating the code... Like Scott said, we sometimes copy code from Linux that uses 'bool', so it's simpler if we just retain this comm

Re: [U-Boot] Please pull u-boot-mpc85xx.git

2012-12-03 Thread Tabi Timur-B04825
On Wed, Nov 28, 2012 at 1:39 AM, Andy Fleming wrote: > > Timur Tabi (5): > powerpc/85xx/p5040: add CONFIG_SYS_PPC64, del > CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC > powerpc/85xx: add support for the Freescale P5040DS Superhydra > reference board > powerpc/85xx: implement check for err

Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration

2012-11-01 Thread Tabi Timur-B04825
On Thu, Nov 1, 2012 at 11:20 AM, Tabi Timur-B04825 wrote: > >> To solve this problem, move CONFIG_FSL_SATA_V2 to board >> configuration header file. > > http://patchwork.ozlabs.org/patch/126958/ To be clear, I think you should say in the patch description that your patch eff

Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration

2012-11-01 Thread Tabi Timur-B04825
On Thu, Nov 1, 2012 at 3:13 AM, Roy Zang wrote: > board configuration file is included before asm/config_mpc85xx.h. > however, CONFIG_FSL_SATA_V2 is defined in asm/config_mpc85xx.h. > it will never take effective in the board configuration file for > this kind of code : > > #ifdef CONFIG_FSL_SATA

Re: [U-Boot] [PATCH v2 22/22] powerpc/mpc85xx/p2020rdb-pca: Use L2 SRAM for SPL boot

2012-10-29 Thread Tabi Timur-B04825
On Mon, Oct 29, 2012 at 9:05 PM, Scott Wood wrote: > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h > index ba7a364..f02ba2b 100644 > --- a/include/configs/p1_p2_rdb_pc.h > +++ b/include/configs/p1_p2_rdb_pc.h > @@ -38,6 +38,7 @@ > #define __SW_BOOT_MASK 0x0

Re: [U-Boot] Please pull u-boot-mpc85xx.git

2012-10-22 Thread Tabi Timur-B04825
On Mon, Oct 22, 2012 at 5:36 PM, Andy Fleming wrote: > Timur Tabi (4): > powerpc/mpc85xx: fix Unicode characters in release.S > powerpc/85xx: define SRIO LIODN functions only if SRIO is defined > powerpc/85xx: move SRIO configuration out of corenet_ds.h > powerpc/85xx: Add

Re: [U-Boot] [PATCH] powerpc/fm: fix TBI PHY address settings

2012-10-12 Thread Tabi Timur-B04825
On Fri, Oct 12, 2012 at 1:25 AM, Shaohui Xie wrote: > From: shaohui xie > > TBI PHY address (TBIPA) register is set in general frame manager > phy init funciton dtsec_init_phy() in drivers/net/fm/eth.c, and > it is supposed to set TBIPA on FM1@DTSEC1 in case of FM1@DTSEC1 > isn't used directly, w

Re: [U-Boot] arch/powerpc/lib/board.c:get_effective_memsize() for 4GB+ systems

2012-09-21 Thread Tabi Timur-B04825
Robert Thorhuus wrote: > I really see the advantage of keeping this map you have. It is of > course more compatible with different OSEs and you do not need to do > anything special with 32/64 bit cores. But at the same time you never > take advantage of a 64 bit core with this approach. U-Boot is

Re: [U-Boot] [PATCH] SBx81CFC960: embed Fman microcode in the bootloader

2012-09-21 Thread Tabi Timur-B04825
judge.pack...@gmail.com wrote: > .../SBx81CFC960/fsl_fman_ucode_P2041_101_8.bin | Bin 0 -> 7240 bytes > .../SBx81CFC960/fsl_fman_ucode_P2041_101_8.c | 607 > Including the firmware itself in the patch is a bad idea. I do not want any Freescale firmware to be

Re: [U-Boot] arch/powerpc/lib/board.c:get_effective_memsize() for 4GB+ systems

2012-09-20 Thread Tabi Timur-B04825
On Thu, Sep 20, 2012 at 3:24 PM, Robert Thorhuus wrote: > I'm using 64 bit mpc85xx cores. U-Boot runs in 32-bit mode even on a 64-bit code. > Mapping the whole memory from the beginning was of course just an initial > thought. > But for me it looks like the code is just not able to deal with m

Re: [U-Boot] [PATCH 1/2] libfdt: Add support for appending the values to a existing property

2012-09-15 Thread Tabi Timur-B04825
On Sat, Sep 15, 2012 at 9:36 AM, Jerry Van Baren wrote: > Queued up 2 of 2 patches to the u-boot-fdt "next" branch. I'll issue a > pull request when the merge window opens. I thought libfdt patches were suppose to go to dtc.git? -- Timur Tabi Linux kernel developer at Freescale __

Re: [U-Boot] [u-boot-release] [PATCH 4/5] powerpc/85xx: Add P5040 processor support

2012-09-10 Thread Tabi Timur-B04825
Kim Phillips wrote: >> Cryptography acceleration (SEC 5.0) at up to 40 Gbps SerDes > > it's a SEC 5.2, but... Ok. >> Dual four channel >> Support for hardware virtualization and partitioning enforcement >> Extra privileged level for hypervisor support >> QorIQ Trust Architecture 1

Re: [U-Boot] [PATCH 6/6] powerpc/mpc8xxx: fix core id for multicore booting

2012-08-29 Thread Tabi Timur-B04825
On Fri, Aug 17, 2012 at 1:20 PM, York Sun wrote: > > + * 8-19 CHIP_ID,2’b00 - SoC 1 > + * all others - reserved > + * 20-24 CLUSTER_ID 5’b0 - CCM 1 > + * all others - reserved > + * 25-26 CORE_CLUSTER_ID 2’b00 - cluster 1 > + *

Re: [U-Boot] [PATCH] powerpc: Fix declaration type for I/O functions

2012-08-23 Thread Tabi Timur-B04825
On Thu, Aug 23, 2012 at 12:24 PM, Andy Fleming wrote: > I'm guessing this change increased the amount of inlining. Sadly, the > subsequent patches, which were intended to shrink the SPL build, were > not enough to fix this problem. Maybe there are places where we can use raw I/O instead of acces

Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

2012-07-15 Thread Tabi Timur-B04825
Or Yoram-R56270 wrote: > 1. Correct the v1 documentation to specify 23 MAC addresses and placing the > CRC at 0xCC. > 2. Create a new code and documentation for v2, specifying 31 MAC addresses > and placing the CRC at 0xFC. Both of these are unnecessary. My patch fixes the code to match the spe

Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

2012-07-13 Thread Tabi Timur-B04825
sun york-R58495 wrote: > I agree it was a broken design. Now we are using all available space > and put CRC to the very end. It is not perfect but should work. *sigh* The design was never broken, the code was just wrong. The CRC has always supposed to have been at the end. -- Timur Tabi Linu

Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

2012-07-13 Thread Tabi Timur-B04825
Wolfgang Denk wrote: >> >My patch provides transparent updates to handle it. It will read broken >> >EEPROMs and verify the CRC in the old location, and if you have re-save >> >the EEPROM, it will put the CRC in the right place. > It will work by chance, accessing random data. This is crap. It

Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

2012-07-13 Thread Tabi Timur-B04825
Wolfgang Denk wrote: > This is a totally broken design then, when you have a growing data > structure where vital information fields get shifted. In such case, > the CRC should have been at the beginning, so it never changes > location. Or even better, you should not have used a binary data > stru

Re: [U-Boot] [PATCH 2/2] net: abort network initialization if the PHY driver fails

2012-07-05 Thread Tabi Timur-B04825
Nobuhiro Iwamatsu wrote: >> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c >> index eee41d7..7a3d16b 100644 >> --- a/drivers/net/fec_mxc.c >> +++ b/drivers/net/fec_mxc.c >> @@ -510,7 +510,12 @@ static int fec_open(struct eth_device *edev) >> fec_eth_phy_config(edev); >

Re: [U-Boot] [PATCH 18/24] mxc_i2c.c: finish adding CONFIG_I2C_MULTI_BUS support

2012-06-24 Thread Tabi Timur-B04825
On Fri, Jun 22, 2012 at 2:41 PM, Troy Kisky wrote: > > Correct and correct. If you need i2c working before relocation, you cannot > enable MULTI_BUS. That sounds like a really strong limitation of MULTI_BUS. i2c is necessary for SPD, which is needed to initialize DDR. -- Timur Tabi Linux kerne

Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.

2012-06-13 Thread Tabi Timur-B04825
On Jun 12, 2012, at 7:54 PM, "Wood Scott-B07421" wrote: > > You mean to replace this tool? There are other PBL things that may need > to be done, such as reconfiguring the SPI speed so it doesn't take > forever to read out the rest of the PBL image. My tool builds and RCW image. I could chang

Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.

2012-06-12 Thread Tabi Timur-B04825
On Jun 8, 2012, at 6:09 PM, "Wood Scott-B07421" wrote: >> >> I have two questions: >> 1. Is there a plan that we submit Timur' tool to open source? > > I hope so. If not, the RCW will have to be provided directly as a > hexdump/binary/etc. Where do you think my compiler should go? > >> 2.

Re: [U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment

2012-05-17 Thread Tabi Timur-B04825
Scott Wood wrote: >> > Well, as with most of our boards, NOR is the default configuration. Also, >> > there's no NAND support upstream yet. > What isn't upstream, besides the muxing hack? Does it need the 4K page > hack? There's no NAND support at all. However, I just tried the two SDK patche

Re: [U-Boot] [PATCH v2] powerpc/p1022ds: Add sdcard and spi boot support to P1022DS

2012-04-27 Thread Tabi Timur-B04825
On Thu, Apr 26, 2012 at 8:57 AM, Dirk Eibach wrote: > Signed-off-by: Dirk Eibach > Cc: Timur Tabi > --- > Changes in v2: > - add Cc > - split up original patch series > >  board/freescale/p1022ds/p1022ds.c |    4 ++ >  board/freescale/p1022ds/tlb.c     |   10 ++ >  boards.cfg                

Re: [U-Boot] [PATCH] powerpc/83xx: increment malloc heap size for the MPC832x MDS boards

2012-03-17 Thread Tabi Timur-B04825
On Sat, Mar 17, 2012 at 6:19 PM, Wolfgang Denk wrote: > Doubling it is kind of aggressive strategy.  You know exactly how much > free room needs to be guaranteed, so why don't you auto-adjust the > size? > >> -#define CONFIG_SYS_MALLOC_LEN        (128 * 1024)    /* Reserved for malloc >> */ >> +

Re: [U-Boot] [PATCH] PowerPC: enable the SATA for p1/p2 rdb-pc platform

2012-03-09 Thread Tabi Timur-B04825
On Fri, Mar 9, 2012 at 1:54 AM, wrote: > -#define CONFIG_SATA_SIL3114 > +#define CONFIG_SATA_SIL This is not "enabling" SATA. This is choosing the correct driver. You can only use the word "enable" if the feature was intentionally disabled before, e.g. because the driver did not exist yet. You

Re: [U-Boot] [PATCH][v2]powerpc/8xxx:Add MPH controller support in USB device-tree fixup

2012-02-07 Thread Tabi Timur-B04825
On Mon, Feb 6, 2012 at 11:17 PM, Ramneek Mehresh wrote: > > +                       start_offset, compat_mph); >        if (node_offset < 0) { > -               printf("WARNING: could not find compatible node %s: %s.\n", > -                       compat, fdt_strerror(node_offset)); > -            

Re: [U-Boot] [PATCH 1/3] i2c: add i2c_core and prepare for new multibus support

2012-01-18 Thread Tabi Timur-B04825
On Tue, Jan 17, 2012 at 1:12 AM, Simon Glass wrote: > From: Heiko Schocher > > This Patch introduce the new i2c_core file, which holds > the I2C core functions, for the rework of the multibus/ > multiadapter support. > Also adds changes in i2c.h for the new I2C multibus/multiadapter > support. Th

Re: [U-Boot] [GIT PULL] please pull u-boot-mpc85xx

2012-01-16 Thread Tabi Timur-B04825
On Thu, Jan 12, 2012 at 5:49 PM, Tabi Timur-B04825 wrote: > Are you going to make another pull request before the window closes? The reason I ask is that you're missing some of my patches. http://patchwork.ozlabs.org/project/uboot/list/?submitter=timur -- Timur Tabi Linux kernel deve

Re: [U-Boot] [PATCH 5/8] powerpc/boot: Slave module for boot from SRIO

2012-01-10 Thread Tabi Timur-B04825
Liu Gang-B34182 wrote: > Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented? And where is the code > that uses it? > [Liu Gang-B34182] Sorry I documented this definition in "[PATCH 6/8] > powerpc/boot: Slave uploads ucode when boot from SRIO", You need to update the README. That's where all t

Re: [U-Boot] [PATCH 6/8] powerpc/boot: Slave uploads ucode when boot from SRIO

2012-01-10 Thread Tabi Timur-B04825
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang wrote: > When boot from SRIO, slave's ucode can be stored in master's memory space, > then slave can fetch the ucode image through SRIO interface. What kind of ucode is this? Fman or QE? > + > +       /* configure inbound window for slave's ucode */ > +

Re: [U-Boot] [PATCH 5/8] powerpc/boot: Slave module for boot from SRIO

2012-01-10 Thread Tabi Timur-B04825
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang wrote: > > +#define CONFIG_SYS_QE_FMAN_FW_IN_REMOTE > +#define CONFIG_SYS_QE_FMAN_FW_ADDR     0 Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented? And where is the code that uses it? -- Timur Tabi Linux kernel developer at Freescale _

Re: [U-Boot] [PATCH 2/8] powerpc/env: Correct the compilation errors when defined CONFIG_ENV_IS_NOWHERE

2012-01-10 Thread Tabi Timur-B04825
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang wrote: > > There will be a confict if defined CONFIG_ENV_IS_NOWHERE and > CONFIG_ENV_IS_IN_FLASH. This doesn't make any sense. How can the environment be nowhere *and* also in flash, at the same time? -- Timur Tabi Linux kernel developer at Freescale _

Re: [U-Boot] [PATCH] powerpc/bootm: Flush ramdisk and device tree image when booting on MP

2011-12-07 Thread Tabi Timur-B04825
On Wed, Dec 7, 2011 at 8:42 AM, Kumar Gala wrote: > +       if (flag & BOOTM_STATE_OS_PREP) { > +               boot_prep_linux(images); >                return 0; > +       } > >        if (flag & BOOTM_STATE_OS_GO) { >                boot_jump_linux(images); >                return 0; >        

Re: [U-Boot] [PATCH] powerpc/p3060qds: Add board related support for P3060QDS platform

2011-12-05 Thread Tabi Timur-B04825
On Tue, Nov 22, 2011 at 2:51 AM, Shengzhou Liu wrote: > > +#ifdef CONFIG_PHYS_64BIT > +       puts("36-bit Addressing\n"); > +#endif We're not doing this any more. The 'bdinfo' command will be updated to display this information instead. Since Kumar already applied this patch, please post a fol

Re: [U-Boot] [PATCH] powerpc/85xx: clean up and document the QE/FMAN microcode macros

2011-11-19 Thread Tabi Timur-B04825
Kumar Gala wrote: >> > #ifdef CONFIG_QE >> > /* QE microcode/firmware address */ >> > -#define CONFIG_SYS_QE_FW_ADDR0xefec >> > -#define CONFIG_SYS_QE_FW_LENGTH 0x1 >> > +#define CONFIG_SYS_QE_FMAN_FW_IN_NOR >> > +#define CONFIG_SYS_QE_FMAN_FW_ADDR 0xefec000

Re: [U-Boot] [PATCH 2/2] mpc83xx: Implement interrupt support for mpc83xx

2011-11-08 Thread Tabi Timur-B04825
On Wed, Oct 5, 2011 at 6:14 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Kim Phillips > --- Where's the patch description? You need to explain how this patch works. -- Timur Tabi Linux kernel developer at Freescale _

Re: [U-Boot] [PATCH v5] MPC8360EMDS: 512MB DDR and 33.33MHz oscillator support

2011-11-01 Thread Tabi Timur-B04825
On Tue, Nov 1, 2011 at 9:08 PM, Huang Changming-R66093 wrote: > Kim, > Since 2008, the boards shipped to customer are the new boards with 33.33MHz > oscillator and 512MB DDR. > How can I deal with the new board and old board? Check the board revision at runtime. -- Timur Tabi Linux kernel deve

Re: [U-Boot] [PATCH 4/5] e1000: Export core EEPROM access functions for SPI support

2011-11-01 Thread Tabi Timur-B04825
On Tue, Oct 18, 2011 at 4:05 PM, Kyle Moffett wrote: > A followup patch will be adding a configurable feature to enable > programming of E1000 EEPROMs from the command line or via the generic > U-Boot SPI interface. > > In order for it to work it needs access to certain E1000-internal > functions,

Re: [U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit

2011-10-31 Thread Tabi Timur-B04825
On Sun, Oct 30, 2011 at 7:54 PM, Mike Frysinger wrote: > > > -static void print_num(const char *, ulong); > +__maybe_unused > +static void print_num(const char *name, ulong value) > +{ > +       printf("%-12s= 0x%08lX\n", name, value); > +} > Will the linker remove the functions from the binary i

Re: [U-Boot] [PATCH] miiphy: Note that miiphy_* API is deprecated

2011-10-31 Thread Tabi Timur-B04825
On Mon, Oct 31, 2011 at 9:46 AM, Andy Fleming wrote: > We want to move everything to phylib, and we definitely don't want > new drivers using the miiphy infrastructure. How about using gcc's deprecated function feature? Or is that too aggressive? http://gcc.gnu.org/onlinedocs/gcc/Function-Attri

Re: [U-Boot] [PATCH] Powerpc/DIU: Fixed the 800x600 and 1024x768 resolution bug

2011-10-31 Thread Tabi Timur-B04825
On Mon, Oct 31, 2011 at 1:19 AM, wrote: > From: Jerry Huang > > When the resolution is set to 800x600 and 1024x768, > but, the driver will use 1280x1024 resolution to set the DIU register > > Signed-off-by: Jerry Huang Acked-by: Timur Tabi Thanks, Jerry. I'm amazed that I didn't notice this

Re: [U-Boot] [Patch v4] powerpc/eeprom: cleanup mac command

2011-10-14 Thread Tabi Timur-B04825
On Fri, Oct 14, 2011 at 4:32 PM, Wolfgang Denk wrote: > These changes silently change the behaviour of the command.  So far, > an argument line "24" would be parsed as hex number (i. e. result in > decimal value 36); with this change it suddenly becomes devcimal 24, > which is quite unexpected.

Re: [U-Boot] [GIT PULL] Pull request u-boot-85xx.git

2011-10-14 Thread Tabi Timur-B04825
On Fri, Oct 14, 2011 at 2:34 AM, Kumar Gala wrote: > The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51: > >  Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 22:47:15 > +0200) > > are available in the git repository at: > >  git://git.denx.de/u-boot-mpc

Re: [U-Boot] [PATCH 1/3] [v2] powerpc/85xx: don't display address map size (32-bit vs. 36-bit) during boot

2011-10-14 Thread Tabi Timur-B04825
Kumar Gala wrote: > For the FSL boards, lets add 'bdinfo' to 'preboot' and enable CONFIG_PREBOOT I don't think that's a good idea. bdinfo display about a dozen lines of text, most of it is not generally useful. Plus, this would make preboot unavailable for everyone else. -- Timur Tabi Linux

Re: [U-Boot] [PATCH 3/3] [v2] powerpc/85xx: wait for alignment before resetting SERDES RX lanes (SERDES9)

2011-10-14 Thread Tabi Timur-B04825
Kumar Gala wrote: > Rather than looking at tn2020_driver.uid lets just do something like: > > if ((phydev->drv->uid& phydev->drv->mask) == TN2020_UID) > > And add a #define in phy.h: > > #define TN2020_UID0x00a19410 I guess that makes more sense. I thought my original version was cooler, th

Re: [U-Boot] [PATCH v2] powerpc/p3060qds: Add board related support for P3060QDS platform

2011-10-13 Thread Tabi Timur-B04825
On Thu, Oct 6, 2011 at 4:23 PM, Wolfgang Denk wrote: > Checkpatch says: > > WARNING: static const char * array should probably be static const > char * const > #1511: FILE: board/freescale/p3060qds/p3060qds.c:84: > +               static const char *freq[] = {"100", "125", "Reserved", > > > Pleas

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Tabi Timur-B04825
On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: > New default, weak i2c_set_bus_num() function. > > Signed-off-by: Stefano Babic > Cc: Heiko Schocher I would prefer to see a new set of I2C functions that take a bus number as a parameter, so that we can eliminate i2c_set_bus_num() (and the

Re: [U-Boot] [PATCH v2] powerpc/mpc8548cds: Update config file

2011-10-09 Thread Tabi Timur-B04825
Kumar Gala wrote: > * The only things not explained is the env address change. I can see > it matches our other boards MPC8572DS, etc. So not exactly critical to > me. There's no explanation for increasing the malloc size. > * If Wolfgang wants to remove CONFIG_PCI_SCAN_SHOW so be it, but as >

Re: [U-Boot] [PATCH v2] powerpc/mpc8548cds: Update config file

2011-10-09 Thread Tabi Timur-B04825
On Sun, Oct 9, 2011 at 5:55 PM, Kumar Gala wrote: > > - Increase the size of malloc space. > - Enable e1000 network card. > - Show pci devices on startup. > - Change the location of env address. > - Use hwconfig to turn off ECC by default. This patch is missing all of the explanations that were p

Re: [U-Boot] [PATCH 8/9 v2] powerpc/mpc8548cds: Fix config according to system address map

2011-10-08 Thread Tabi Timur-B04825
On Sat, Oct 8, 2011 at 2:33 AM, Zhao Chenhui wrote: > > - Fix config according to system address map in the manual. > - Rework tlb and law tables. > - Remove unnecessary macros. You're making a lot of changes here. The device tree needs to match the U-Boot configuration. Are you changing U-Boot

Re: [U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY

2011-10-04 Thread Tabi Timur-B04825
Kumar Gala wrote: >> > Note: I'm not sure of my change to struct fm_mdio. It works, but it >> > doesn't >> > smell right. > What exactly is the concern? Nothing specific, just a gut feeling. -- Timur Tabi Linux kernel developer at Freescale ___ U-

Re: [U-Boot] [GIT PULL] Pull request u-boot-85xx.git (master)

2011-10-03 Thread Tabi Timur-B04825
On Mon, Oct 3, 2011 at 9:44 AM, Kumar Gala wrote: > Timur Tabi (4): >      powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros >      powerpc/85xx: relocate CCSR before creating the initial RAM area >      powerpc/mp: add support for discontiguous cores >      powerpc/hydra: Add ethern

Re: [U-Boot] [PATCH] powerpc/mpc8xxx: Fix ddr build error

2011-10-03 Thread Tabi Timur-B04825
On Mon, Oct 3, 2011 at 6:59 PM, Becky Bruce wrote: > -#ifdef DEBUG >  const char *step_string_tbl[] = { >        "STEP_GET_SPD", >        "STEP_COMPUTE_DIMM_PARMS", > @@ -153,7 +152,6 @@ const char * step_to_string(unsigned int step) { > >        return step_string_tbl[s]; >  } > -#endif How big

Re: [U-Boot] [PATCH 2/9] powerpc/mpc85xxcds: Fix PCI speed

2011-09-13 Thread Tabi Timur-B04825
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui wrote: > @@ -222,8 +222,8 @@ int checkboard (void) > >        printf("PCI1: %d bit, %s MHz, %s\n", >                (pci1_32) ? 32 : 64, > -               (pci1_speed == 3300) ? "33" : > -               (pci1_speed == 6600) ? "66" : "unknown",

Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file

2011-09-13 Thread Tabi Timur-B04825
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui wrote: > From: chenhui zhao > > -Increase the size of malloc space. > -Enable e1000 network card. > -Change the location of env address. > -Use hwconfig to turn off ECC. Please repost this patch with a detailed explanation as to why these changes are

Re: [U-Boot] [PATCH 2/2] powerpc/85xx: standardize display of address map size (32-bit vs. 36-bit)

2011-09-02 Thread Tabi Timur-B04825
Kumar Gala wrote: > 1. We reduce the amount printed in the "default" case > 2. First choice should always be to have a command the print status info > 3. Allow a board port to makes its own decision if it wants to do something > like enable CONFIG_PCI_SCAN_SHOW > > Any concerns w/that proposal? A

Re: [U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to registers

2011-09-01 Thread Tabi Timur-B04825
On Thu, Sep 1, 2011 at 6:40 AM, Dave Aldridge wrote: >  #if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == > 0) >  #error "Please define NS16550 registers size." > +#elif defined(CONFIG_SYS_NS16550_MEM32) > +#define UART_REG(x) unsigned int x; Shouldn't this be #defin

Re: [U-Boot] [PATCH] powerpc/85xx: Enable CMD_REGINFO on corenet boards

2011-09-01 Thread Tabi Timur-B04825
Kumar Gala wrote: > > On Aug 31, 2011, at 12:14 PM, Tabi Timur-B04825 wrote: > >> On Wed, Aug 31, 2011 at 9:16 AM, Kumar Gala >> wrote: >>> Signed-off-by: Kumar Gala >>> --- >> >> Why are we enabling this? > > because its a useful command

Re: [U-Boot] [PATCH] powerpc/85xx: Enable CMD_REGINFO on corenet boards

2011-08-31 Thread Tabi Timur-B04825
On Wed, Aug 31, 2011 at 9:16 AM, Kumar Gala wrote: > Signed-off-by: Kumar Gala > --- Why are we enabling this? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2 v4] powerpc/p1023rds: Disable nor flash node and enable nand flash node

2011-08-29 Thread Tabi Timur-B04825
On Mon, Aug 29, 2011 at 2:15 AM, Chunhe Lan wrote: > In the p1023rds, accessing exclusively nor flash or nand flash device by > BR0/OR0. This is not an English sentence. I do not understand what you're saying. -- Timur Tabi Linux kernel developer at Freescale __

Re: [U-Boot] gcc-4.6 warnings

2011-08-25 Thread Tabi Timur-B04825
On Thu, Aug 25, 2011 at 9:51 AM, Mike Frysinger wrote: > i feel like some (many?) #ifdef's in the tree could be done without ifdefs (by > relying on gcc's DCE) thus improving overall code quality What's DCE? -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] README: clean up and document the Freescale QE/FMAN firmware macros

2011-08-24 Thread Tabi Timur-B04825
On Mon, Aug 22, 2011 at 4:45 PM, Timur Tabi wrote: > The Freescale QE and FMAN devices support uploading of firmware, and U-Boot > can locate that firmware on different types of storage media.  However, > the current macros used for this code are inconsistent and poorly documented. > > Note that s

Re: [U-Boot] [PATCH 1/2] fdt: Add a fdt_set_node_status function

2011-08-14 Thread Tabi Timur-B04825
On Thu, Aug 11, 2011 at 11:18 PM, Chunhe Lan wrote: > +/* > + * Sets the specified node's status to the value contained in "status". > + * If the first character of the specified path is "/" then we use > + * alias as a path. Otherwise, we look for an alias of that name. > + */ > +void fdt_set_no

Re: [U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command

2011-08-11 Thread Tabi Timur-B04825
I see two calls to simple_stroul, and both have 16 in them. -- Timur Tabi Linux kernel developer at Freescale From: sun york-R58495 Sent: Thursday, August 11, 2011 10:03 AM To: Tabi Timur-B04825 Cc: u-boot@lists.denx.de Subject: Re: [u-boot-release

Re: [U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command

2011-08-11 Thread Tabi Timur-B04825
York Sun wrote: > - e.mac_count = simple_strtoul(argv[2], NULL, 16); > + e.mac_count = simple_strtoul(argv[2], NULL, 10); You forgot the MAC address index. There's another use of strtoul in the code that needs to be fixed. Also, if you use "0" instead of "10", then it sh

Re: [U-Boot] [u-boot-release] [PATCH 7/7] powerpc/8xxx: Add support for interactive DDR programming interface

2011-08-10 Thread Tabi Timur-B04825
York Sun wrote: > +/* Option parameter Structures */ > +typedef struct { > + const char *option_name; > + size_t offset; > + unsigned int size; > + const char printHex; > +} options_strings_t; Does it make sense for only printHex (which should be "print_hex") and option_name to be

Re: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command

2011-08-10 Thread Tabi Timur-B04825
York Sun wrote: > Change the help message to be more helpful. Print argument format. > Fix MAX_NUM_PORTS to comply with v1 NXID format. > > Signed-off-by: York Sun Could you also fix the commands so that they take a number in decimal instead of hex? e.mac[index][i] = simple_strtoul(p,

Re: [U-Boot] [PATCH 1/2] [v3] powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros

2011-08-05 Thread Tabi Timur-B04825
Kumar Gala wrote: > ok. Sounds fine to leave as it, just wondering. Also, I want people to specifically set the physical address in the board header file if they want to relocate CCSR. Anyway, I'll post a new version that reduces the merge conflicts. -- Timur Tabi Linux kernel developer at Fre

Re: [U-Boot] [PATCH 1/2] [v3] powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros

2011-08-05 Thread Tabi Timur-B04825
Kumar Gala wrote: > Why didn't we do in include/mpc85xx.h: > > #ifndef CONFIG_SYS_CCSRBAR_PHYS_LOW > #define CONFIG_SYS_CCSRBAR_PHYS_LOW CONFIG_SYS_CCSRBAR > #endif > > Thus removing that line from every board file? That might make more sense, but that will break other boards where virtual != p

Re: [U-Boot] [PATCH 1/2] [v2] powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros

2011-08-04 Thread Tabi Timur-B04825
Kumar Gala wrote: > What changed in v2? I fixed the problem on several boards where I wasn't setting the relocated physical address properly. For instance, on the P2020DS, the original code moved CCSR from ff7 to ffe, but my v1 patch left it at ff7 because I didn't notice that the device tree

Re: [U-Boot] [PATCH 1/5] powerpc/85xx: Add support for FMan ethernet in Independent mode

2011-08-01 Thread Tabi Timur-B04825
On Mon, Aug 1, 2011 at 10:26 AM, Kumar Gala wrote: > Just wondering which checkpatch you are running. > > I get: > > total: 1 errors, 16 warnings, 3172 lines checked > > Mine's from linux kernel tree HEAD as of a day or so ago. I believe that checkpatch has become a more forgiving with the 80-ch

Re: [U-Boot] [GIT pull] Please pull u-boot-mpc85xx

2011-07-27 Thread Tabi Timur-B04825
On Fri, Jul 22, 2011 at 2:55 AM, Kumar Gala wrote: > The following changes since commit 74fac70084bb040342fafc3b0d2ef50fbe35646f: > >  Merge branch 'master' of git://git.denx.de/u-boot-mmc (2011-07-19 22:27:07 > +0200) > > are available in the git repository at: > >  git://git.denx.de/u-boot-mpc8

Re: [U-Boot] [PATCH] powerpc/85xx: Add support for new P102x/P2020 RDB style boards

2011-07-27 Thread Tabi Timur-B04825
On Tue, Jul 26, 2011 at 9:52 PM, Kumar Gala wrote: > +/* CCSRBAR PHYSICAL Address */ > +/* IN case of NAND bootloader relocate CCSRBAR in RAMboot code not in the 4k > +       SPL code*/ > +#if defined(CONFIG_NAND_U_BOOT) && defined(CONFIG_NAND_SPL) > +#define CONFIG_SYS_CCSRBAR_PHYS        CONFIG

[U-Boot] Author search of git.denx.de does not work

2011-07-03 Thread Tabi Timur-B04825
The following URL doesn't show anything: http://git.denx.de/?p=u-boot.git&a=search&h=HEAD&st=author&s=Timur+Tabi No matter what I put after the "s=", I get nothing. I think it should work, because this URL, which has the same search string, does work: http://git.kernel.org/?p=linux/kernel/git/t

Re: [U-Boot] [PATCH 2/2] powerpc/85xx: Fix the work-arounds for errata SERDES-8 & SERDES-A001 on p4080

2011-07-01 Thread Tabi Timur-B04825
Kumar Gala wrote: > Ok, Can you send a commit message for when I merge them or repost a merged > patch. powerpc/85xx: remove SERDES4 soft-reset work-around Some P4080 rev1 errata work-arounds, notably erratum SERDES4, required a bank soft-reset after the bank was configured and enabled, even tho

Re: [U-Boot] [PATCH 2/2] powerpc/85xx: Fix the work-arounds for errata SERDES-8 & SERDES-A001 on p4080

2011-07-01 Thread Tabi Timur-B04825
Kumar Gala wrote: > Erratum SERDES-8 says that the clocks for bank 3 needs to be enabled if > bank 2 is enabled, but this was not being done for SERDES protocols 0xF > and 0x10. The bank reset that was being done for erratum SERDES4 (a > left-over work-around that was removed in "powerpc/85xx: rem

[U-Boot] Please update libfdt for U-Boot

2011-06-29 Thread Tabi Timur-B04825
Jerry, Now that the merge window is open, could you please update libfdt? The version in U-Boot hasn't been updated in over a year, and there are new features that I need to have. Specifically, this commit: http://git.jdl.com/gitweb/?p=dtc.git;a=commit;h=d75b33af676d0beac8398651a7f09037555a550b

Re: [U-Boot] [u-boot-release] [PATCH 1/7] powerpc/i2c: introduce CONFIG_I2C_TWR for setting tWR value

2011-05-26 Thread Tabi Timur-B04825
York Sun wrote: > From: york You should fix this so that it includes your full name. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message

2011-05-02 Thread Tabi Timur-B04825
On Mon, May 2, 2011 at 8:51 PM, York Sun wrote: > -               printf("The DIMM max tCKmin is %d ps," > +               printf("The combined minimum tCKmin is %d ps," >                        "doesn't support the MCLK cycle %d ps\n", That still needs some work, IMHO. I think you might need t

Re: [U-Boot] [GIT PULL] Pull request u-boot-mpc85xx.git

2011-05-02 Thread Tabi Timur-B04825
On Mon, May 2, 2011 at 10:00 AM, Kumar Gala wrote: > I thought that was less of an issue because of our use of patchworks. How? Patchwork uses the same subject line as the email. There's still the problem of trying to correlate the actual commit to the entry in patchwork. On the other hand, I

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-30 Thread Tabi Timur-B04825
Mike Frysinger wrote: > so implement this in your board file in misc_init_r or board_eth_init. have > the code do something like: > uchar enetaddr[6]; > if (!eth_getenv_enetaddr("ethaddr", enetaddr)) { > /* ... read current MAC out of the driver's registers ... */ >

Re: [U-Boot] [PATCH] [v4] powerpc/85xx: fix compatible property for the L2 cache node

2011-04-29 Thread Tabi Timur-B04825
Wolfgang Denk wrote: > This gets lost in the code. That's why I added the comments: /* MPC, where == 4-digit number */ > If you keep the if / else, you have to add braces for the multiline > statements. Ok. -- Timur Tabi Linux kernel developer at Freescale ___

Re: [U-Boot] [PATCH] [v4] powerpc/85xx: fix compatible property for the L2 cache node

2011-04-29 Thread Tabi Timur-B04825
Wolfgang Denk wrote: > Why do we need this "if" at all? tolower() on a digit is a nop, so you > can omit the first branch. Because cpu->name looks like one of two ways: 8578 or P4080 In the case of "8578", we want to convert that to "mpc8578". In the case of "P4080",

Re: [U-Boot] [GIT PULL] Pull request u-boot-mpc85xx.git (updated)

2011-04-29 Thread Tabi Timur-B04825
On Fri, Apr 29, 2011 at 10:34 AM, Kumar Gala wrote: > Timur Tabi (7): >      powerpc/86xx: remove empty board_early_init_f() >      powerpc/fsl: add 'pixis_reset dump' command >      powerpc/85xx: Implement work-around for P4080 erratum SERDES-A005 >      powerpc/85xx: Display SERDES 8 erratum war

Re: [U-Boot] [PATCH] powerpc/85xx: Bump up the CONFIG_SYS_BOOTM_LEN to 64M on FSL 85xx boards

2011-04-28 Thread Tabi Timur-B04825
On Thu, Apr 28, 2011 at 9:55 PM, Kumar Gala wrote: > CONFIG_SYS_BOOTMAPSZ has been 64M on these boards for some time so we > should also allow the kernel image to be up to 64M decompressed. This > also matches what we pass to the OS based on the ePAPR specification. Is there any e500-based board

Re: [U-Boot] Pull request for u-boot-video?

2011-04-28 Thread Tabi Timur-B04825
Anatolij Gustschin wrote: > it turns out that your patches broke DIU support on mpc5121. I need > to fix it first before sending a pull request. I'm planning to work > on fixes and hope to resolve the issue this week. Anything I can do to help, please just let me know. We don't have any 5121s he

Re: [U-Boot] boot-up time optimization. Where to start?

2011-04-27 Thread Tabi Timur-B04825
On Wed, Apr 27, 2011 at 8:39 AM, Simon Schwarz wrote: > So here is my question: Where do you see the most potential to optimize > u-boot? I'm sure many of the timeouts could be optimized. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot m

[U-Boot] Pull request for u-boot-video?

2011-04-25 Thread Tabi Timur-B04825
Anatolij, Are you planning on making a pull request for u-boot-video soon? The merge window closed last week, but I have some pending video patches that I would like to see included. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mail

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-25 Thread Tabi Timur-B04825
On Sun, Apr 24, 2011 at 6:50 PM, Wolfgang Denk wrote: > And please add documentation for the new CONFIG_PRESERVE_LOCAL_MAC to > the README. We have something similar already on Freescale parts, but it does sometimes cause problems. If the environment ethaddr is already set, it is left alone. O

Re: [U-Boot] [PATCH] powerpc/85xx: Change timebase divisor to be defined per processor

2011-04-22 Thread Tabi Timur-B04825
On Fri, Apr 22, 2011 at 8:26 AM, Kumar Gala wrote: >> Shouldn't there also be a README update to document this option? > > I think its self evident what it is. I have to disagree. Without reading the patch description, it's hard to know what value to choose for this macro. Besides, Wolfgang is

Re: [U-Boot] [PATCH 4/4] powerpc/85xx: Implement work-around for P4080 erratum SERDES-A001

2011-04-22 Thread Tabi Timur-B04825
Kumar Gala wrote: > The > work-around is to enable and then disable bank two after bank three is > disabled. That should say, "after bank three is enabled". -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH] powerpc/85xx: Change timebase divisor to be defined per processor

2011-04-22 Thread Tabi Timur-B04825
On Thu, Apr 21, 2011 at 1:59 PM, Kumar Gala wrote: > Introduce new CONFIG_SYS_FSL_TBCLK_DIV on 85xx platforms because > different SoCs have different divisor amounts.  All the PQ3 parts are > /8, the P4080/P4080 is /16, and P2040/P3041/P5020 are /32. Shouldn't there also be a README update to doc

Re: [U-Boot] [PATCH] mpc83xx fdt: do not adjust clock frequency of external UARTs

2011-04-16 Thread Tabi Timur-B04825
"David Müller (ELSOFT AG)" wrote: >> > Just out of curiosity -- do you have an example of a device tree with >> > an external UART? > Yes. May I see it? -- Timur Tabi Linux kernel developer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.d

Re: [U-Boot] [PATCH 6/6] powerpc/85xx: Add SHARP LQ084S3LG01 LCD support on P1022DS

2011-04-09 Thread Tabi Timur-B04825
Kumar Gala wrote: > what about this patch? I missed this one. Unfortunately, it conflicts with my patch. I'll have to rewrite this one to make it work. Plus, there were problems with it. For instance, I'm not crazy about the setenv() calls (I NAK'd an earlier internal version of this patch t

Re: [U-Boot] [PATCH 3/6] powerpc/85xx: Added DIU configs for P1022DS and fixed LVDS config

2011-04-09 Thread Tabi Timur-B04825
Kumar Gala wrote: > I'll deal with merge issues, can you ack or provide feedback on this patch My patch, "[v3] powerpc: user 'video-mode' environment variable to configure DIU" ("user" should be "use") should be applied instead. -- Timur Tabi Linux kernel developer _

  1   2   >