I see two calls to simple_stroul, and both have 16 in them. -- Timur Tabi Linux kernel developer at Freescale
________________________________________ From: sun york-R58495 Sent: Thursday, August 11, 2011 10:03 AM To: Tabi Timur-B04825 Cc: u-boot@lists.denx.de Subject: Re: [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command On Thu, 2011-08-11 at 09:55 -0500, Tabi Timur-B04825 wrote: > York Sun wrote: > > - e.mac_count = simple_strtoul(argv[2], NULL, 16); > > + e.mac_count = simple_strtoul(argv[2], NULL, 10); > > You forgot the MAC address index. There's another use of strtoul in the > code that needs to be fixed. I didn't forget the index. It is base 10 already. > > Also, if you use "0" instead of "10", then it should be able to handle > hex as well, just in case someone wants to use it. That's not a bad idea. I will change to "0" but leave the mac address as hex. York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
