Re: [U-Boot] [PATCH v3 08/14] fit: fdt overlays doc

2017-09-06 Thread Pantelis Antoniou
Hi Lukasz, On Wed, 2017-09-06 at 21:06 +0200, Łukasz Majewski wrote: > On 09/04/2017 10:12 PM, Pantelis Antoniou wrote: > > Signed-off-by: Pantelis Antoniou > > --- > > doc/uImage.FIT/command_syntax_extensions.txt | 12 +- > > doc/uImage.FIT/overlay-

[U-Boot] [PATCH v3 12/14] config: sandbox: Add unit tests

2017-09-04 Thread Pantelis Antoniou
Add unit tests for sandbox default config. Signed-off-by: Pantelis Antoniou --- configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 4c4e480..54120c2 100644 --- a/configs/sandbox_defconfig +++ b/configs

[U-Boot] [PATCH v3 08/14] fit: fdt overlays doc

2017-09-04 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou --- doc/uImage.FIT/command_syntax_extensions.txt | 12 +- doc/uImage.FIT/overlay-fdt-boot.txt | 221 +++ doc/uImage.FIT/source_file_format.txt| 6 +- 3 files changed, 236 insertions(+), 3 deletions(-) create mode

[U-Boot] [PATCH v3 14/14] test: overlay: Add unit test for stacked overlay

2017-09-04 Thread Pantelis Antoniou
Verify that stacked overlays work. Signed-off-by: Pantelis Antoniou --- test/overlay/Makefile | 1 + test/overlay/cmd_ut_overlay.c | 34 ++- test/overlay/test-fdt-overlay-stacked.dts | 21 +++ 3 files changed, 55

[U-Boot] [PATCH v3 03/14] fdt: Switch to using the verbose overlay application method

2017-09-04 Thread Pantelis Antoniou
The verbose overlay application method prints out more helpful messages, so switch to it. Signed-off-by: Pantelis Antoniou --- cmd/fdt.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cmd/fdt.c b/cmd/fdt.c index 118613f..362a621 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c

[U-Boot] [PATCH v3 11/14] dtbo: make dtbos special

2017-09-04 Thread Pantelis Antoniou
Special rule for dtbo generation Signed-off-by: Pantelis Antoniou --- scripts/Makefile.lib | 17 + 1 file changed, 17 insertions(+) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 9ce47b4..2a7ed70 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib

[U-Boot] [PATCH v3 04/14] fdt: Allow stacked overlays phandle references

2017-09-04 Thread Pantelis Antoniou
bar = "/foonode/barnode"; foo = "/foonode"; }; }; Signed-off-by: Pantelis Antoniou Signed-off-by: David Gibson --- lib/libfdt/fdt_overlay.c | 228 ++- 1 file changed, 206 insertions(+), 22 d

[U-Boot] [PATCH v3 09/14] doc: Document how to apply fdt overlays

2017-09-04 Thread Pantelis Antoniou
We have the capability to apply overlays on the command line but we didn't have a document explaining how. Signed-off-by: Pantelis Antoniou --- doc/README.fdt-overlays | 37 + 1 file changed, 37 insertions(+) create mode 100644 doc/README.fdt-overlays

[U-Boot] [PATCH v3 13/14] ut: fix fdt_getprop_u32() change

2017-09-04 Thread Pantelis Antoniou
fdt_getprop_u32 is not exported and it's different than what the unit test uses. Rename u32 prop access methods to something that's unit test specific. Signed-off-by: Pantelis Antoniou --- test/overlay/cmd_ut_overlay.c | 16 1 file changed, 8 insertions(+), 8 deletion

[U-Boot] [PATCH v3 05/14] fit: Allow multiple images per property

2017-09-04 Thread Pantelis Antoniou
As part of the fdt overlay support which need it, allow a list of configurations per property. Signed-off-by: Pantelis Antoniou --- common/image-fit.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/common/image-fit.c b/common/image-fit.c index 109ecfa

[U-Boot] [PATCH v3 07/14] fit: Introduce methods for applying overlays on fit-load

2017-09-04 Thread Pantelis Antoniou
Introduce an overlay based method for constructing a base DT blob to pass to the kernel. It is based on a specific method now to get the FDT from a FIT image named boot_get_fdt_fit(). Signed-off-by: Pantelis Antoniou --- common/image-fdt.c | 7 +-- common/image-fit.c | 181

[U-Boot] [PATCH v3 10/14] doc: overlays: Tweak documentation regarding overlays

2017-09-04 Thread Pantelis Antoniou
From: Franklin S Cooper Jr Pull some information regarding overlays from commit messages and put them directly within the documentation. Also add some information regarding required dtc version to properly use overlays. Signed-off-by: Franklin S Cooper Jr --- doc/README.fdt-overlays

[U-Boot] [PATCH v3 01/14] Introduce fdt_setprop_placeholder() method

2017-09-04 Thread Pantelis Antoniou
In some cases you need to add a property but the contents of it are not known at creation time, merely the extend of it. This method allows you to create a property of a given size (filled with garbage) while a pointer to the property data will be provided. Signed-off-by: Pantelis Antoniou [dwg

[U-Boot] [PATCH v3 06/14] fit: Do not throw away extra configuration on fit_image_load()

2017-09-04 Thread Pantelis Antoniou
fit_image_load() threw away the extra configuration parts when loading. We need them around for applying extra overlays for building the boot fdt. Signed-off-by: Pantelis Antoniou --- common/image-fit.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/common/image

[U-Boot] [PATCH v3 00/14] uboot overlays, FIT image & unittest

2017-09-04 Thread Pantelis Antoniou
/2017. Franklin S Cooper Jr (1): doc: overlays: Tweak documentation regarding overlays Pantelis Antoniou (13): Introduce fdt_setprop_placeholder() method fdt: Introduce helper method fdt_overlay_apply_verbose() fdt: Switch to using the verbose overlay application method fdt: Allow stacked

[U-Boot] [PATCH v3 02/14] fdt: Introduce helper method fdt_overlay_apply_verbose()

2017-09-04 Thread Pantelis Antoniou
the -@ option. Signed-off-by: Pantelis Antoniou --- common/fdt_support.c | 31 +++ include/fdt_support.h | 2 ++ 2 files changed, 33 insertions(+) diff --git a/common/fdt_support.c b/common/fdt_support.c index 916a448..f4f9543 100644 --- a/common/fdt_support.c +++ b

Re: [U-Boot] [PATCH v2 08/10] config: sandbox: Add unit tests

2017-08-28 Thread Pantelis Antoniou
Hi Simon, On Sat, 2017-08-26 at 07:37 -0600, Simon Glass wrote: > On 11 August 2017 at 02:52, Pantelis Antoniou > wrote: > > Add unit tests for sandbox default config. > > > > Signed-off-by: Pantelis Antoniou > > --- > > configs/sandbox_defconfig | 2

[U-Boot] [PATCH v2 09/10] ut: fix fdt_getprop_u32() change

2017-08-11 Thread Pantelis Antoniou
fdt_getprop_u32 is not exported and it's different than what the unit test uses. Rename u32 prop access methods to something that's unit test specific. Signed-off-by: Pantelis Antoniou --- test/overlay/cmd_ut_overlay.c | 16 1 file changed, 8 insertions(+), 8 deletion

[U-Boot] [PATCH v2 04/10] fdt-overlay: Spit out a descriptive failure warning

2017-08-11 Thread Pantelis Antoniou
The most common trouble with overlays appears to be miscompiled blobs without the -@ option. In case of an error, spit out a descriptive error message. Signed-off-by: Pantelis Antoniou --- cmd/fdt.c | 8 common/image-fit.c | 12 +++- 2 files changed, 19 insertions

[U-Boot] [PATCH v2 08/10] config: sandbox: Add unit tests

2017-08-11 Thread Pantelis Antoniou
Add unit tests for sandbox default config. Signed-off-by: Pantelis Antoniou --- configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index fd0b952..df8659a 100644 --- a/configs/sandbox_defconfig +++ b/configs

[U-Boot] [PATCH v2 10/10] test: overlay: Add unit test for stacked overlay

2017-08-11 Thread Pantelis Antoniou
Verify that stacked overlays work. Signed-off-by: Pantelis Antoniou --- test/overlay/Makefile | 1 + test/overlay/cmd_ut_overlay.c | 34 ++- test/overlay/test-fdt-overlay-stacked.dts | 21 +++ 3 files changed, 55

[U-Boot] [PATCH v2 07/10] dtbo: make dtbos special

2017-08-11 Thread Pantelis Antoniou
Special rule for dtbo generation Signed-off-by: Pantelis Antoniou --- scripts/Makefile.lib | 17 + 1 file changed, 17 insertions(+) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 9ce47b4..2a7ed70 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib

[U-Boot] [PATCH v2 03/10] fit: Introduce methods for applying overlays on fit-load

2017-08-11 Thread Pantelis Antoniou
Introduce an overlay based method for constructing a base DT blob to pass to the kernel. Both canned and runtime feature selection is supported. Signed-off-by: Pantelis Antoniou --- common/image-fdt.c | 7 +- common/image-fit.c | 216

[U-Boot] [PATCH v2 05/10] doc: Document how to apply fdt overlays

2017-08-11 Thread Pantelis Antoniou
We have the capability to apply overlays on the command line but we didn't have a document explaining how. Signed-off-by: Pantelis Antoniou --- doc/README.fdt-overlays | 37 + 1 file changed, 37 insertions(+) create mode 100644 doc/README.fdt-overlays

[U-Boot] [PATCH v2 06/10] doc: overlays: Tweak documentation regarding overlays

2017-08-11 Thread Pantelis Antoniou
From: Franklin S Cooper Jr Pull some information regarding overlays from commit messages and put them directly within the documentation. Also add some information regarding required dtc version to properly use overlays. Signed-off-by: Franklin S Cooper Jr --- doc/README.fdt-overlays

[U-Boot] [PATCH v2 02/10] fdt: Allow stacked overlays phandle references

2017-08-11 Thread Pantelis Antoniou
bar = "/foonode/barnode"; foo = "/foonode"; }; }; Signed-off-by: Pantelis Antoniou Signed-off-by: David Gibson --- lib/libfdt/fdt_overlay.c | 228 ++- 1 file changed, 206 insertions(+), 22 d

[U-Boot] [PATCH v2 01/10] Introduce fdt_setprop_placeholder() method

2017-08-11 Thread Pantelis Antoniou
In some cases you need to add a property but the contents of it are not known at creation time, merely the extend of it. This method allows you to create a property of a given size (filled with garbage) while a pointer to the property data will be provided. Signed-off-by: Pantelis Antoniou [dwg

[U-Boot] [PATCH v2 00/10] uboot overlays, FIT image & unittest

2017-08-11 Thread Pantelis Antoniou
1): doc: overlays: Tweak documentation regarding overlays Pantelis Antoniou (9): Introduce fdt_setprop_placeholder() method fdt: Allow stacked overlays phandle references fit: Introduce methods for applying overlays on fit-load fdt-overlay: Spit out a descriptive failure warning doc: Docume

Re: [U-Boot] [PATCH 4/5] test: overlay: Add unit test for stacked overlay

2017-07-07 Thread Pantelis Antoniou
On Fri, 2017-07-07 at 00:48 -0700, Moritz Fischer wrote: > Hi Pantelis, > > nit inline > > On Fri, Jun 30, 2017 at 9:23 AM, Pantelis Antoniou > wrote: > > Verify that stacked overlays work. > > > > Signed-off-by: Pantelis Antoniou > > Reviewed-by:

Re: [U-Boot] [PATCH 1/5] libfdt.h: Introduce FDT_PATH_MAX

2017-07-07 Thread Pantelis Antoniou
Hi Simon, On Thu, 2017-07-06 at 21:58 -0600, Simon Glass wrote: > Hi, > > On 1 July 2017 at 08:01, Marek Vasut wrote: > > On 06/30/2017 06:22 PM, Pantelis Antoniou wrote: > >> Introduce FDT_PATH_MAX > > > > Because ... why ? The commit message is crap, ple

Re: [U-Boot] [PATCH 3/5] fdt: Allow stacked overlays phandle references

2017-07-07 Thread Pantelis Antoniou
Hi Simon, On Thu, 2017-07-06 at 21:58 -0600, Simon Glass wrote: > On 30 June 2017 at 10:23, Pantelis Antoniou > wrote: > > This patch enables an overlay to refer to a previous overlay's > > labels by performing a merge of symbol information at application > > t

Re: [U-Boot] [PATCH 5/5] fit: Introduce methods for applying overlays on fit-load

2017-07-04 Thread Pantelis Antoniou
Hi Marek, On Sat, 2017-07-01 at 16:11 +0200, Marek Vasut wrote: > On 06/30/2017 06:23 PM, Pantelis Antoniou wrote: > > Introduce an overlay based method for constructing a base DT blob > > to pass to the kernel. > > > > Both canned and runtime feature selection is sup

Re: [U-Boot] [PATCH 3/5] fdt: Allow stacked overlays phandle references

2017-07-04 Thread Pantelis Antoniou
Hi Marek, On Sat, 2017-07-01 at 16:07 +0200, Marek Vasut wrote: > On 06/30/2017 06:23 PM, Pantelis Antoniou wrote: > > [...] > > > +static int overlay_symbol_update(void *fdt, void *fdto) > > +{ > > + int root_sym, ov_sym, prop, path_len, fragment, target; >

Re: [U-Boot] [PATCH 2/5] libfdt_env.h: Add in libfdt environment

2017-07-04 Thread Pantelis Antoniou
Hi Marek, On Sat, 2017-07-01 at 16:02 +0200, Marek Vasut wrote: > On 06/30/2017 06:22 PM, Pantelis Antoniou wrote: > > Overlays require malloc so add it in the libfdt environment. > > Include this where it's actually used, not in some header. > This follows the same me

[U-Boot] [PATCH 4/5] test: overlay: Add unit test for stacked overlay

2017-06-30 Thread Pantelis Antoniou
Verify that stacked overlays work. Signed-off-by: Pantelis Antoniou --- test/overlay/Makefile | 1 + test/overlay/cmd_ut_overlay.c | 34 ++- test/overlay/test-fdt-overlay-stacked.dts | 21 +++ 3 files changed, 55

[U-Boot] [PATCH 3/5] fdt: Allow stacked overlays phandle references

2017-06-30 Thread Pantelis Antoniou
bar = "/foonode/barnode"; foo = "/foonode"; }; }; Signed-off-by: Pantelis Antoniou --- lib/libfdt/fdt_overlay.c | 148 ++- 1 file changed, 147 insertions(+), 1 deletion(-) diff --git a/

[U-Boot] [PATCH 5/5] fit: Introduce methods for applying overlays on fit-load

2017-06-30 Thread Pantelis Antoniou
Introduce an overlay based method for constructing a base DT blob to pass to the kernel. Both canned and runtime feature selection is supported. Signed-off-by: Pantelis Antoniou --- common/image-fdt.c | 7 +- common/image-fit.c | 215

[U-Boot] [PATCH 1/5] libfdt.h: Introduce FDT_PATH_MAX

2017-06-30 Thread Pantelis Antoniou
Introduce FDT_PATH_MAX Signed-off-by: Pantelis Antoniou --- lib/libfdt/libfdt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/libfdt/libfdt.h b/lib/libfdt/libfdt.h index 2f7ebf8..c369015 100644 --- a/lib/libfdt/libfdt.h +++ b/lib/libfdt/libfdt.h @@ -100,6 +100,9 @@ #define

[U-Boot] [PATCH 2/5] libfdt_env.h: Add in libfdt environment

2017-06-30 Thread Pantelis Antoniou
Overlays require malloc so add it in the libfdt environment. Signed-off-by: Pantelis Antoniou --- include/libfdt_env.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/libfdt_env.h b/include/libfdt_env.h index 6c6845f..59463c0 100644 --- a/include/libfdt_env.h +++ b/include

[U-Boot] [PATCH 0/5] uboot overlays and FIT image

2017-06-30 Thread Pantelis Antoniou
patchset is available at https://github.com/pantoniou/u-boot/tree/uboot-overlays and is against mainline u-boot as pulled today, 30/6/2017. Pantelis Antoniou (5): libfdt.h: Introduce FDT_PATH_MAX libfdt_env.h: Add in libfdt environment fdt: Allow stacked overlays phandle references

[U-Boot] [PATCH] arm: Always keep the dtb section on objcopy

2017-05-25 Thread Pantelis Antoniou
The dtb blob section must always be present in the resulting image. Either if OF_EMBEDED is used or if unit tests include dtb blobs. Signed-off-by: Pantelis Antoniou --- arch/arm/config.mk | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/config.mk b/arch/arm

[U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests

2017-05-25 Thread Pantelis Antoniou
Unit tests require mallinfo which in turn requires DEBUG on dlmalloc to be enabled. The dependancy on CONFIG_SANDBOX is wrong. Signed-off-by: Pantelis Antoniou --- common/dlmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/dlmalloc.c b/common/dlmalloc.c index

Re: [U-Boot] [PATCH] scripts/Makefile.lib: Only apply u-boot.dtsi files in the target directory

2017-05-24 Thread Pantelis Antoniou
the same directory as their target dts. > Verified that it fixes the build breakage. Tested-by: Pantelis Antoniou > Cc: Simon Glass > Reported-by: Pantelis Antoniou > Signed-off-by: Tom Rini > --- > scripts/Makefile.lib | 12 +--- > 1 file changed, 5 insertions(+

Re: [U-Boot] [PATCH] MAINTAINERS, git-mailrc: Update the mmc maintainer

2016-08-01 Thread Pantelis Antoniou
Hi Jaehoon, > On Aug 1, 2016, at 06:35 , Jaehoon Chung wrote: > > Update the mmc maintainer from Pantelis to me. > > Signed-off-by: Jaehoon Chung Acked-by: Pantelis Antoniou Good job! > --- > MAINTAINERS| 2 +- > doc/git-mailrc | 4 ++-- > 2 files changed, 3

Re: [U-Boot] [linux-sunxi] Auto-detecting touchscreen controller and dealing with hw configuration differences on q8 tablets

2016-06-20 Thread Pantelis Antoniou
Hi Rob, > On Jun 20, 2016, at 21:20 , Rob Herring wrote: > > On Mon, Jun 20, 2016 at 04:08:47PM +0300, Pantelis Antoniou wrote: >> Hi Hans, >> >>> On Jun 20, 2016, at 16:02 , Hans de Goede wrote: >>> >>> Hi, >>> >>> On 20-

Re: [U-Boot] [linux-sunxi] Auto-detecting touchscreen controller and dealing with hw configuration differences on q8 tablets

2016-06-20 Thread Pantelis Antoniou
Hi Hans, > On Jun 20, 2016, at 16:02 , Hans de Goede wrote: > > Hi, > > On 20-06-16 14:22, Pantelis Antoniou wrote: >> Hi Hans, >> >>> On Jun 20, 2016, at 14:03 , Hans de Goede wrote: >>> >>> Hi, >>> >>> On 20-06-1

Re: [U-Boot] Auto-detecting touchscreen controller and dealing with hw configuration differences on q8 tablets

2016-06-20 Thread Pantelis Antoniou
Hi Hans, > On Jun 20, 2016, at 14:03 , Hans de Goede wrote: > > Hi, > > On 20-06-16 11:27, Pantelis Antoniou wrote: >> Hi Hans, >> >> I’m going to commend only on the overlay related parts since I’m not I >> get all the nuances right. > >

Re: [U-Boot] Auto-detecting touchscreen controller and dealing with hw configuration differences on q8 tablets

2016-06-20 Thread Pantelis Antoniou
Hi Hans, I’m going to commend only on the overlay related parts since I’m not I get all the nuances right. > On Jun 19, 2016, at 14:06 , Hans de Goede wrote: > > > > Hi All, > > The sunxi support in the kernel supports (amongst many other devices) the > quite > popular low cost q8 form fact

Re: [U-Boot] [PATCH v2 7/9] libfdt: Add overlay application function

2016-06-15 Thread Pantelis Antoniou
Hi David, > On Jun 15, 2016, at 13:19 , David Gibson wrote: > > On Wed, Jun 15, 2016 at 12:34:00PM +0300, Pantelis Antoniou wrote: >> Hi David, >> >>> On Jun 15, 2016, at 06:14 , David Gibson >>> wrote: >>> >>> On Tue, Jun 14, 2016 at

Re: [U-Boot] [PATCH v2 7/9] libfdt: Add overlay application function

2016-06-15 Thread Pantelis Antoniou
Hi David, > On Jun 15, 2016, at 06:14 , David Gibson wrote: > > On Tue, Jun 14, 2016 at 12:22:23PM +0300, Pantelis Antoniou wrote: >> Hi David, >>> On Jun 14, 2016, at 03:25 , David Gibson >>> wrote: >>> On Fri, Jun 10, 2016 at 05:28:11PM +0300, Pante

Re: [U-Boot] [PATCH v2 7/9] libfdt: Add overlay application function

2016-06-14 Thread Pantelis Antoniou
Hi David, > On Jun 14, 2016, at 03:25 , David Gibson wrote: > > On Fri, Jun 10, 2016 at 05:28:11PM +0300, Pantelis Antoniou wrote: >> Hi Maxime, >> >>> On May 27, 2016, at 12:13 , Maxime Ripard >>> wrote: >>> >>> The device

Re: [U-Boot] [PATCH v2 9/9] tests: Introduce DT overlay tests

2016-06-10 Thread Pantelis Antoniou
/overlay/test-fdt-overlay.dts > b/test/overlay/test-fdt-overlay.dts > new file mode 100644 > index ..ca3abcff287c > --- /dev/null > +++ b/test/overlay/test-fdt-overlay.dts > @@ -0,0 +1,60 @@ > +/* > + * Copyright (c) 2016 NextThing Co > + * Copyright (c) 2016 F

Re: [U-Boot] [PATCH v2 6/9] libfdt: Add max phandle retrieval function

2016-06-10 Thread Pantelis Antoniou
> On May 27, 2016, at 12:13 , Maxime Ripard > wrote: > > Add a function to retrieve the highest phandle in a given device tree. > > Signed-off-by: Maxime Ripard > --- > include/libfdt.h| 13 + > lib/libfdt/fdt_ro.c | 15 +++ > 2 files changed, 28 insertions(+) > > d

Re: [U-Boot] [PATCH v2 7/9] libfdt: Add overlay application function

2016-06-10 Thread Pantelis Antoniou
Hi Maxime, > On May 27, 2016, at 12:13 , Maxime Ripard > wrote: > > The device tree overlays are a good way to deal with user-modifyable > boards or boards with some kind of an expansion mechanism where we can > easily plug new board in (like the BBB, the Raspberry Pi or the CHIP). > > Add a n

Re: [U-Boot] [PATCH v2 5/9] libfdt: Add iterator over properties

2016-06-10 Thread Pantelis Antoniou
ieve the property at a given offset > * @fdt: pointer to the device tree blob > * @offset: offset of the property to retrieve > -- > 2.8.2 > Acked-by: Pantelis Antoniou I’d like to see this merged in dtc upstream please too. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/9] libfdt: Add new headers and defines

2016-06-10 Thread Pantelis Antoniou
endif > + > /* adding a ramdisk needs 0x44 bytes in version 2008.10 */ > #define FDT_RAMDISK_OVERHEAD 0x80 > We need to figure out what the upstream libfdt/dtc maintainer’s take is on this is. For u-boot we’re fine and for now it’s OK. Acked-by: Pantelis Antoniou > -- >

Re: [U-Boot] [PATCH v2 3/9] vsprintf: Include stdarg for va_list

2016-06-10 Thread Pantelis Antoniou
printf.h > @@ -8,6 +8,8 @@ > #ifndef __VSPRINTF_H > #define __VSPRINTF_H > > +#include > + > ulong simple_strtoul(const char *cp, char **endp, unsigned int base); > > /** > -- > 2.8.2 > Acked-by: Pantelis Antoniou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/9] scripts: Makefile.lib: Sanitize DTB names

2016-06-10 Thread Pantelis Antoniou
';\ > - echo '.global __dtb_$(*F)_end'; \ > + echo '__dtb_$(subst -,_,$(*F))_end:'; \ > + echo '.global __dtb_$(subst -,_,$(*F))_end';\ > echo '.balign 16'; \ > ) > $@ > > -- > 2.8.2 > Acked-by: Pantelis Antoniou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 8/9] cmd: fdt: add fdt overlay application subcommand

2016-06-10 Thread Pantelis Antoniou
- Set the [control] fdt location to > \n" > + "fdt apply - Apply overlay to the DT\n" > #ifdef CONFIG_OF_BOARD_SETUP > "fdt boardsetup - Do board-specific set up\n" > #endif > -- > 2.8.2 > Acked-by: Pantelis Antoniou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/9] cmd: fdt: Narrow the check for fdt addr

2016-06-10 Thread Pantelis Antoniou
dely used letter, narrow down that check a bit. >> >> Signed-off-by: Maxime Ripard >> --- >> cmd/fdt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Simon Glass Acked-by: Pantelis Antoniou __

Re: [U-Boot] [PATCH RESEND 2/2] cmd: fdt: add fdt overlay application subcommand

2016-05-18 Thread Pantelis Antoniou
Hi Maxime, > On May 10, 2016, at 14:45 , Maxime Ripard > wrote: > [snip] > How do you want me to proceed? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com FYI an updated dtc patch has been sent. Hopefu

Re: [U-Boot] [PATCH RESEND 2/2] cmd: fdt: add fdt overlay application subcommand

2016-04-13 Thread Pantelis Antoniou
Hi Tom, > On Apr 13, 2016, at 22:42 , Tom Rini wrote: > > On Fri, Apr 08, 2016 at 04:29:40PM -0500, Rob Herring wrote: >> On Tue, Apr 5, 2016 at 5:03 PM, Pantelis Antoniou >> wrote: >>> Hi Maxime, >>> >>>> On Apr 4, 2016, at 11:25 , Max

Re: [U-Boot] [PATCH RESEND 2/2] cmd: fdt: add fdt overlay application subcommand

2016-04-05 Thread Pantelis Antoniou
Hi Maxime, > On Apr 4, 2016, at 11:25 , Maxime Ripard > wrote: > > The device tree overlays are a good way to deal with user-modifyable > boards or boards with some kind of an expansion mechanism where we can > easily plug new board in (like the BBB or the raspberry pi). > > However, so far, t

Re: [U-Boot] [PATCH] mmc: sdhci: Fix the SD clock stop sequence

2015-09-21 Thread Pantelis Antoniou
Hi Wenyou, > On Sep 16, 2015, at 11:22 , Wenyou Yang wrote: > > According to the SDHC specification, stopping the SD Clock is by setting > the SD Clock Enable bit in the Clock Control register at 0, instead of > setting all bits at 0. > > Before stopping the SD clock, we need to make sure all S

Re: [U-Boot] [PATCH 1/2] mmc: dw_mmc: Increase timeout to 20 seconds

2015-09-21 Thread Pantelis Antoniou
Hi Tom, > On Sep 18, 2015, at 22:27 , Tom Rini wrote: > > On Fri, Sep 18, 2015 at 09:32:47AM +0200, Lukasz Majewski wrote: >> Hi Tom, >> >>> On Thu, Sep 17, 2015 at 04:43:33PM +0200, Lukasz Majewski wrote: >>> Hi Tom, > On Monday, September 14, 2015 at 01:22:20 PM, Lukasz Majews

Re: [U-Boot] [PATCH 1/2] mmc: dw_mmc: Increase timeout to 20 seconds

2015-09-01 Thread Pantelis Antoniou
Hi Marek, > On Aug 29, 2015, at 22:19 , Marek Vasut wrote: > > On Saturday, August 29, 2015 at 06:38:48 PM, Lukasz Majewski wrote: >> Hi Marek, > > Hi Lukasz, > >>> On Saturday, August 29, 2015 at 01:55:36 PM, Lukasz Majewski wrote: On Fri, 28 Aug 2015 23:55:17 +0200 >>> >>> Hi! >>> >>>

Re: [U-Boot] [PATCH V2 4/4] mmc: dw_mmc: Probe the MMC from OF

2015-08-19 Thread Pantelis Antoniou
robing >> from the ancient qts-generated header files. >> >> Signed-off-by: Marek Vasut >> Cc: Dinh Nguyen >> Cc: Pantelis Antoniou >> Cc: Tom Rini > > Bump? > > Best regards, > Marek Vasut ___

Re: [U-Boot] [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART

2015-08-14 Thread Pantelis Antoniou
Hi Ian, > On Aug 13, 2015, at 22:04 , Ian Lepore wrote: > > On Thu, 2015-08-13 at 14:13 -0400, Tom Rini wrote: >> On Thu, Aug 13, 2015 at 10:02:58AM -0600, Stephen Warren wrote: >>> On 08/13/2015 09:59 AM, Simon Glass wrote: Hi Linus, On 11 August 2015 at 07:00, Linus Walleij wr

Re: [U-Boot] Pull request: u-boot-mmc 12082015

2015-08-13 Thread Pantelis Antoniou
Hi Tom, > On Aug 12, 2015, at 12:19 , Marek Vasut wrote: > > On Wednesday, August 12, 2015 at 09:48:28 AM, Pantelis Antoniou wrote: >> Hi Tom, >> >> The following changes since commit >> e2c1c5bae619d2e87505de99f907a26237640bc9: >> >> Merge git

[U-Boot] Pull request: u-boot-mmc 12082015

2015-08-12 Thread Pantelis Antoniou
Hi Tom, The following changes since commit e2c1c5bae619d2e87505de99f907a26237640bc9: Merge git://git.denx.de/u-boot-dm (2015-08-10 10:06:07 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to 956f662b1f79ae7455bc6aaa9defc2a

Re: [U-Boot] [PATCH v4 3/3] mmc: Calculate dwmmc FIFO threshold size if not provided

2015-08-12 Thread Pantelis Antoniou
Hi Simin, > On Aug 7, 2015, at 05:16 , Simon Glass wrote: > > We can calculate this. Add code to do this if it is not provided. > > Signed-off-by: Simon Glass > --- > > Changes in v4: None > > drivers/mmc/dw_mmc.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --

Re: [U-Boot] [PATCH v4 2/3] mmc: dw_mmc: Support bypass mode with the get_mmc_clk() method

2015-08-12 Thread Pantelis Antoniou
Hi Simon, > On Aug 7, 2015, at 05:16 , Simon Glass wrote: > > Some SoCs want to adjust the input clock to the DWMMC block as a way of > controlling the MMC bus clock. Update the get_mmc_clk() method to support > this. > > Signed-off-by: Simon Glass > --- > > Changes in v4: > - Update commit m

Re: [U-Boot] [PATCH v4 1/3] mmc: dw_mmc: Avoid using printf() for errors

2015-08-12 Thread Pantelis Antoniou
Hi Simon, > On Aug 7, 2015, at 05:16 , Simon Glass wrote: > > The dw_mmc driver uses printf() in various places. > > These bloat the code and cause problems for SPL. Use debug() where possible > and try to return a useful error code instead. > > Signed-off-by: Simon Glass > --- > > Changes i

Re: [U-Boot] [PATCH 4/4] mmc: dw_mmc: Probe the MMC from OF

2015-08-12 Thread Pantelis Antoniou
t; Cc: Dinh Nguyen > Cc: Pantelis Antoniou > Cc: Tom Rini > --- > arch/arm/mach-socfpga/include/mach/dwmmc.h | 2 +- > arch/arm/mach-socfpga/misc.c | 3 +- > drivers/mmc/socfpga_dw_mmc.c | 81 +- > include/fdtdec.h

Re: [U-Boot] [PATCH 1/4] mmc: dw_mmc: Stop bounce buffer even in case of failure

2015-08-12 Thread Pantelis Antoniou
stop the bounce buffer. > > Signed-off-by: Marek Vasut > Cc: Dinh Nguyen > Cc: Pantelis Antoniou > Cc: Tom Rini > --- > drivers/mmc/dw_mmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > index 53a8aca..3fffa71

Re: [U-Boot] [PATCH 3/4] mmc: dw_mmc: Improve handling of data transfer failure

2015-08-12 Thread Pantelis Antoniou
t; Cc: Dinh Nguyen > Cc: Pantelis Antoniou > Cc: Tom Rini > --- > drivers/mmc/dw_mmc.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > index 0f61f16..fcd5784 100644 > --- a/drivers/mm

Re: [U-Boot] [PATCH 2/4] mmc: dw_mmc: Zap endless timeout

2015-08-12 Thread Pantelis Antoniou
Hi Marek, > On Jul 27, 2015, at 23:39 , Marek Vasut wrote: > > Endless timeouts are bad, since if we get stuck in one, we have no > way out. Zap this one by implementing proper timeout. > > Signed-off-by: Marek Vasut > Cc: Dinh Nguyen > Cc: Pantelis Antoniou > Cc

Re: [U-Boot] [PATCH] mmc_spi: Big-endian support

2015-08-12 Thread Pantelis Antoniou
Hi Yoshinori, > On Jun 1, 2015, at 09:22 , Yoshinori Sato wrote: > > Currently implement always swap for big-endian value. > So doesn't work big-endian environment. > > Signed-off-by: Yoshinori Sato > --- > drivers/mmc/mmc_spi.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [U-Boot] [PATCH] ls2085a: esdhc: flush D-cache before 'mmc read'

2015-08-12 Thread Pantelis Antoniou
Hi Yangbo, > On Jun 24, 2015, at 05:13 , Yangbo Lu wrote: > > It needs to flush D-cache before 'mmc read' so that > we can see the right data in DDR. And fix parameter > for invalidate_dcache_range() after 'mmc read'. > > Signed-off-by: Yangbo Lu > Cc: York Sun > --- > drivers/mmc/fsl_esdhc.c

[U-Boot] Pull request: u-boot-mmc 05052015

2015-05-05 Thread Pantelis Antoniou
Hi Tom, The following changes since commit ace97d26176a3ebc9ec07738450de93eea35975c: Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze (2015-04-29 06:46:33 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to 3

Re: [U-Boot] [PATCH 3/4] ARM: mmc: bcm283x: Remove get_timer_us() from mmc driver

2015-05-05 Thread Pantelis Antoniou
Hi Marek, > On May 4, 2015, at 23:54 , Marek Vasut wrote: > > The get_timer_us() function is something which is no longer > existing in case we use generic timer framework, so replace > it with get_timer(). > > Signed-off-by: Marek Vasut > Cc: Stephen Warren > Cc: Tyler Baker > --- > drivers

Re: [U-Boot] [PATCH 23/24] tegra: mmc: Set the removable flag correctly

2015-05-05 Thread Pantelis Antoniou
Hi Simon, > On May 4, 2015, at 20:31 , Simon Glass wrote: > > If the mmc device is non-removable (as indicated by the device tree), set > the flag so that users of the device know. > > Signed-off-by: Simon Glass > --- > > drivers/mmc/tegra_mmc.c | 12 > 1 file changed, 8 insertion

Re: [U-Boot] [PATCH 1/1] mmc: bcm2835_sdhci: Use calloc to allocate bcm2835_sdhci_host

2015-05-05 Thread Pantelis Antoniou
Hi Alexander, > On Apr 17, 2015, at 18:33 , Alexander Stein wrote: > > We need to clear the allocated memory explicitly as the included > struct sdhci_host has function pointers. Those are compared to NULL to > test if this (optional) feature is supported. Leaving them undefined let > u-boot jum

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: update eMMC44 adapter card erase timeout

2015-05-05 Thread Pantelis Antoniou
Hi Yango, > On Apr 15, 2015, at 05:13 , Yangbo Lu wrote: > > Freescale eMMC44 adapter card uses Micron N2M400FDB311A3CF eMMC > memory. According to the silicon datasheet, secure erase timeout > is 600ms. So increase erase timeout value from 250ms to 600ms. > > Signed-off-by: Yangbo Lu > Cc: Yo

Re: [U-Boot] [PATCH] mmc: sdhci: add timeout setting for response busy command

2015-05-05 Thread Pantelis Antoniou
n Liu > Signed-off-by: Rob Herring > Cc: Pantelis Antoniou > --- > drivers/mmc/sdhci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index 78e958e..8faeca3 100644 > --- a/drivers/mmc/sdhci.c > +

Re: [U-Boot] [PATCH] mmc: remove the MMC_MODE_HC flag

2015-05-05 Thread Pantelis Antoniou
gt; implementation. > > Signed-off-by: Rob Herring > Cc: Pantelis Antoniou > --- > drivers/mmc/dw_mmc.c | 2 +- > drivers/mmc/fsl_esdhc.c | 2 +- > drivers/mmc/kona_sdhci.c | 1 - > drivers/mmc/mmc.c| 7 ++- > drivers/mmc/mvebu_mmc.c | 2 +- > drivers/mmc

Re: [U-Boot] [PATCH 6/6] mmc: Fix splitting device initialization

2015-05-05 Thread Pantelis Antoniou
Hi Andrew, > On Mar 19, 2015, at 14:44 , Andrew Gabbasov > wrote: > > Starting part of device initialization sets the init_in_progress flag > only if the MMC card did not yet come to ready state and needs to continue > polling. If the card is SD or if the MMC card became ready quickly, > the fl

Re: [U-Boot] [PATCH] mmc: fix OCR Polling

2015-05-05 Thread Pantelis Antoniou
Hi Peng, > On Mar 19, 2015, at 10:22 , Peng Fan wrote: > > If in mmc_send_op_cond, OCR_BUSY is set in CMD1's response, then > state is transfered to Ready state, and there is no need to send > CMD1 again. Otherwise following CMD1 will recieve no response, or > timeour error from driver such as f

Re: [U-Boot] [PATCH 5/6] mmc: Restructure polling loops to avoid extra delays

2015-05-05 Thread Pantelis Antoniou
Hi Andrew, > On Mar 19, 2015, at 14:44 , Andrew Gabbasov > wrote: > > The polling loops in sd_send_op_cond and mmc_complete_op_cond functions > check the ready flag state at the end of the loop, that is after executing > a delay inside the loop, which, in case of exiting with no error, > is not

Re: [U-Boot] [PATCH 4/6] mmc: Continue polling MMC card for OCR only if it is still not ready

2015-05-05 Thread Pantelis Antoniou
Hi Andrew, > On Mar 19, 2015, at 14:44 , Andrew Gabbasov > wrote: > > Some MMC cards come to ready state quite quickly, so that the respective > flag appears to be set in mmc_send_op_cond already. In this case trying > to continue polling the card with CMD1 in mmc_complete_op_cond is incorrect

Re: [U-Boot] [PATCH 4/6] mmc: Continue polling MMC card for OCR only if it is still not ready

2015-05-05 Thread Pantelis Antoniou
Hi Andrew, > On Mar 24, 2015, at 21:02 , Andrew Gabbasov > wrote: > >> From: Troy Kisky [mailto:troy.ki...@boundarydevices.com] >> Sent: Tuesday, March 24, 2015 9:03 PM >> To: Gabbasov, Andrew; peng@freescale.com; u-boot@lists.denx.de >> Cc: Eric Nelson >> Subject: Re: [U-Boot] [PATCH 4/6]

Re: [U-Boot] [PATCH 2/6] mmc: Avoid extra duplicate entry in mmc device structure

2015-05-05 Thread Pantelis Antoniou
Hi Andrw, > On Mar 19, 2015, at 14:44 , Andrew Gabbasov > wrote: > > The 'op_cond_response' field in mmc structure contains the response > from the last SEND_OP_COND MMC command while making iterational > polling of the card. Later it is copied to 'ocr' field, designed > to contain the OCR regi

Re: [U-Boot] [PATCH 3/6] mmc: Do not pass external mmc_cmd structure to mmc_send_op_cond_iter()

2015-05-05 Thread Pantelis Antoniou
Hi Andrew, > On Mar 19, 2015, at 14:44 , Andrew Gabbasov > wrote: > > The previous change to use 'ocr' structure field for storing send_op_cond > command response also stopped using command response directly > outside of mmc_send_op_cond_iter(). Now it becomes possible to use > command structur

Re: [U-Boot] [PATCH 1/6] mmc: Fix typo in MMC type checking macro

2015-05-05 Thread Pantelis Antoniou
Hi Andrew, > On Mar 19, 2015, at 14:44 , Andrew Gabbasov > wrote: > > The version flag constant name used in IS_MMC macro is incorrect/undefined. > > Signed-off-by: Andrew Gabbasov > --- > include/mmc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/mmc.h b/i

Re: [U-Boot] [PATCH] mmc: fix OCR Polling

2015-03-27 Thread Pantelis Antoniou
Hi Andrew, Peng, > On Mar 23, 2015, at 01:23 , Andrew Gabbasov > wrote: > > Hi Peng, > >> From: Peng Fan [mailto:peng@freescale.com] >> Sent: Saturday, March 21, 2015 1:34 PM >> To: Gabbasov, Andrew; u-boot@lists.denx.de >> Subject: Re: [U-Boot] [PATCH] mmc: fix OCR Polling >> >> [skipped

[U-Boot] Pull request: u-boot-mmc 18032015

2015-03-18 Thread Pantelis Antoniou
Hi Tom, Only bug fixes for now, rather uneventful. The following changes since commit 3231e364bf8426a9c8fd5158fe2d155ae7b9: mmc: fsl_esdhc fix register offset (2015-03-17 09:09:47 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch c

Re: [U-Boot] [PATCH] mv_sdhci: fix warnings on 64-bit builds

2015-03-18 Thread Pantelis Antoniou
Hi Rob, > On Mar 17, 2015, at 22:46 , Rob Herring wrote: > > Change addresses to unsigned long to be compatible with 64-bit builds. > Regardless of fixing warnings, the device is still only 32-bit capable. > > Signed-off-by: Rob Herring > Cc: Pantelis Antoniou > ---

Re: [U-Boot] [PATCH] sdhci: fix warnings on 64-bit builds

2015-03-18 Thread Pantelis Antoniou
Hi Rob, > On Mar 17, 2015, at 22:46 , Rob Herring wrote: > > Change addresses to unsigned long to be compatible with 64-bit builds. > Regardless of fixing warnings, the device is still only 32-bit capable. > > Signed-off-by: Rob Herring > Cc: Pantelis Antoniou > --- &

Re: [U-Boot] [PATCH] mmc: sdhci: don't clobber adjacent registers

2015-03-18 Thread Pantelis Antoniou
Hi Matt, > On Feb 23, 2015, at 23:56 , Matt Reimer wrote: > > SDHCI_HOST_CONTROL is a byte-sized register, so don't write to it > as if it were a long, as that would result in clobbering the three > registers following. > > Signed-off-by: Matt Reimer > --- > drivers/mmc/sdhci.c |2 +- > 1 f

Re: [U-Boot] [PATCH] mmc: s5p: properly mask SELBASECLK

2015-03-18 Thread Pantelis Antoniou
Hi Matt, > On Feb 23, 2015, at 23:52 , Matt Reimer wrote: > > Properly mask SELBASECLK by using an actual mask rather than the > number of bits to shift in order to create the mask. > > Signed-off-by: Matt Reimer > --- > drivers/mmc/s5p_sdhci.c |2 +- > 1 file changed, 1 insertion(+), 1 del

  1   2   3   4   5   >