Re: [PATCH v2 1/1] configs: SiFive Unmatched: add 'nvme scan' to preboot

2025-02-06 Thread Heinrich Schuchardt
On 11/13/24 14:39, Simon Glass wrote: Hi Heinrich, On Tue, 12 Nov 2024 at 03:26, Heinrich Schuchardt wrote: Without 'nvme scan' the ESP on the NVMe drive is not found early. EFI variables cannot be persisted. Hit any key to stop autoboot: 0 Cannot persist EFI variables without sys

Re: [PATCH] tools: mkenvimage: Add pure shell implementation of mkenvimage

2025-02-06 Thread Alexander Dahl
Hi Marek, had a short look on your script yesterday. Looks clean and well designed, nice job. Am Thu, Feb 06, 2025 at 09:38:58PM +0100 schrieb Marek Vasut: > On 2/6/25 1:38 PM, Simon Glass wrote: > > Hi Marek, > > > > On Wed, 5 Feb 2025 at 07:37, Marek Vasut wrote: > > > > > > Add implementat

[PATCH 4/4] arch: arm: dts: k3-am642-phycore-som-binman: Add custMpk and ti-degenerate keys with CONFIG entries

2025-02-06 Thread Daniel Schultz
From: Nathan Morrisson Add the SMPK and ti-degenerate keys using CONFIG entries. These keys are set by the build system and are stored outside of u-boot. Signed-off-by: Nathan Morrisson Signed-off-by: Daniel Schultz --- arch/arm/dts/k3-am642-phycore-som-binman.dtsi | 70 +++ 1

[PATCH 3/4] arch: arm: dts: k3-am625-phycore-som-binman: Add custMpk and ti-degenerate keys with CONFIG entries

2025-02-06 Thread Daniel Schultz
From: Nathan Morrisson Add the SMPK and ti-degenerate keys using CONFIG entries. These keys are set by the build system and are stored outside of u-boot. Signed-off-by: Nathan Morrisson Signed-off-by: Daniel Schultz --- arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 72 ++- 1

[PATCH 2/4] board: Phytec: phycore_am6*: Add k3 Kconfig to A53

2025-02-06 Thread Daniel Schultz
Add board/phytec/common/k3/Kconfig to the A53 builds to make the PHYTEC_K3_ configs visible for this defconfig. This patch also adds .../k3/Kconfig to the AM64x R5 build for the same reason. Signed-off-by: Daniel Schultz --- board/phytec/phycore_am62ax/Kconfig | 1 + board/phytec/phycore_am62x/

[PATCH 1/4] board: phytec: common: k3: Introduce Configs to Sign Images

2025-02-06 Thread Daniel Schultz
Private keys to sign bootloader images shouldn't be commit or part of this repository. Add config entries to use keys located outside of U-Boot to sign images. Signed-off-by: Maik Otto Signed-off-by: Nathan Morrisson Signed-off-by: Daniel Schultz --- board/phytec/common/k3/Kconfig | 34 +++

[PATCH 0/4] phyCORE-AM62x/AM64x: Sign Images with External Keys

2025-02-06 Thread Daniel Schultz
This patch series adds three new Kconfigs for PHYTEC's K3 boards to pass private keys from an external location. These keys are required to sign all bootloader images and device-trees to boot on High-Secure Secure-Enforced (HS-SE) hardware. Daniel Schultz (2): board: phytec: common: k3: Introdu

Re: [PATCH 00/10] phyCORE-AM62x/AM64x: Add RAUC and Secure Boot

2025-02-06 Thread Daniel Schultz
On 06.02.25 18:07, Tom Rini wrote: On Thu, Feb 06, 2025 at 11:41:14AM +0100, Daniel Schultz wrote: Hi, On 05.02.25 15:51, Tom Rini wrote: On Wed, Feb 05, 2025 at 12:01:36AM -0800, Daniel Schultz wrote: This patch series adds support to boot PHYTEC's reference distros for RAUC and Secure Bo

[PATCH] xilinx: Enable mkfwumdata tool for a/b update for Kria

2025-02-06 Thread Michal Simek
Build mkfwumdata tool by default for building ab mdata structure. Signed-off-by: Michal Simek --- configs/xilinx_zynqmp_kria_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_zynqmp_kria_defconfig b/configs/xilinx_zynqmp_kria_defconfig index ad46c091c4a6..1e8ec90ff53

[PATCH] xilinx: zynq: Guard code around SPL_FS_LOAD_PAYLOAD_NAME

2025-02-06 Thread Michal Simek
Guard code around CONFIG_SPL_FS_LOAD_PAYLOAD_NAME usage to avoid compilation failure. Signed-off-by: Michal Simek --- board/xilinx/zynq/board.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c index a852d5b8ed53..8dbfa5604231 100644 ---

Re: [GIT PULL] amd/xilinx patches for v2025.04-rc2

2025-02-06 Thread Michal Simek
On 2/7/25 00:33, Tom Rini wrote: On Thu, Feb 06, 2025 at 08:57:41AM +0100, Michal Simek wrote: Hi Tom, please pull these patches to your tree. Nothing really significant there. Some binman fixes which were not spot before and switching our platform to LWIP to have cover it better. Thanks,

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:49:55PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 16:24, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 02:27:30PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 21/32] efi: arm: Drop exception code when running as an EFI app

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:49:43PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 16:22, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 02:27:13PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 6 Feb 2025 at 10:08, Tom Rini wrote: > > > > > > > > On Thu, Feb 06, 2025

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:49:23PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 17:20, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 05:09:41PM -0700, Simon Glass wrote: > > > Hi Raymond, > > > > > > On Thu, 6 Feb 2025 at 15:35, Raymond Mao wrote: > > > > > > > > Hi Simon, > >

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 16:24, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 02:27:30PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > > > > > It is confusing to have a

Re: [PATCH 21/32] efi: arm: Drop exception code when running as an EFI app

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 16:22, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 02:27:13PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 6 Feb 2025 at 10:08, Tom Rini wrote: > > > > > > On Thu, Feb 06, 2025 at 05:33:06AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon,

Re: [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests

2025-02-06 Thread Simon Glass
Hi Marek, On Thu, 6 Feb 2025 at 13:52, Marek Vasut wrote: > > On 2/6/25 1:42 PM, Simon Glass wrote: > > Hi, > > >>> FAILED (errors=1) > >>> > >>> So where is the SRK_1_2_3_4_table.bin file? > >> See the tool documentation: > >> > >> https://gitlab.apertis.org/pkg/imx-code-signing-tool/-/blob/debi

Re: [PATCH] tools: mkenvimage: Add pure shell implementation of mkenvimage

2025-02-06 Thread Simon Glass
Hi Marek, On Thu, 6 Feb 2025 at 13:52, Marek Vasut wrote: > > On 2/6/25 1:38 PM, Simon Glass wrote: > > Hi Marek, > > > > On Wed, 5 Feb 2025 at 07:37, Marek Vasut wrote: > >> > >> Add implementation of mkenvimage written purely in bourne shell. > >> > >> This is not a replacement for mkenvimage

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 17:20, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 05:09:41PM -0700, Simon Glass wrote: > > Hi Raymond, > > > > On Thu, 6 Feb 2025 at 15:35, Raymond Mao wrote: > > > > > > Hi Simon, > > > > > > On Thu, 6 Feb 2025 at 10:41, Simon Glass wrote: > > > > > > > > Hi Raym

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:09:41PM -0700, Simon Glass wrote: > Hi Raymond, > > On Thu, 6 Feb 2025 at 15:35, Raymond Mao wrote: > > > > Hi Simon, > > > > On Thu, 6 Feb 2025 at 10:41, Simon Glass wrote: > > > > > > Hi Raymond, > > > > > > On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > > > >

Re: [PATCH 29/29] bloblist: Allow relocation at the end of the SPL phase

2025-02-06 Thread Simon Glass
Hi Raymond, On Thu, 6 Feb 2025 at 15:22, Raymond Mao wrote: > > Hi Simon, > > On Thu, 6 Feb 2025 at 16:28, Simon Glass wrote: > > > > Hi Raymond, > > > > On Wed, 5 Feb 2025 at 08:35, Raymond Mao wrote: > > > > > > Hi Simon, > > > > > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > >

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Simon Glass
Hi Raymond, On Thu, 6 Feb 2025 at 15:35, Raymond Mao wrote: > > Hi Simon, > > On Thu, 6 Feb 2025 at 10:41, Simon Glass wrote: > > > > Hi Raymond, > > > > On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > > > > > +CC Ilias, > > > > > > Hi Simon, > > > > > > On Tue, 4 Feb 2025 at 20:57, Simon G

Re: [GIT PULL] amd/xilinx patches for v2025.04-rc2

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 08:57:41AM +0100, Michal Simek wrote: > Hi Tom, > > please pull these patches to your tree. Nothing really significant there. > Some binman fixes which were not spot before and switching our platform to > LWIP to have cover it better. > > Thanks, > Michal > > > The foll

Re: [PATCH 31/32] efi: arm: Simplify the crt0 file and update link script

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 02:31:59PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 10:08, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 05:33:30AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 19:14, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:34:58PM -0500, Raymond Mao wrote: > Hi Simon, > > On Thu, 6 Feb 2025 at 10:41, Simon Glass wrote: > > > > Hi Raymond, > > > > On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > > > > > +CC Ilias, > > > > > > Hi Simon, > > > > > > On Tue, 4 Feb 2025 at 20:57, Simon Gla

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 02:27:30PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > > > It is confusing to have a camel-case indentifier in the link scripts. > > > Rename it to fit with

Re: [PATCH 21/32] efi: arm: Drop exception code when running as an EFI app

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 02:27:13PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 10:08, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 05:33:06AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 19:00, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH v3 2/2] CI: Use different git-directories for concurrent runners

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 03:38:56PM -0700, Simon Glass wrote: > When running multiple runners on the same machine, each git repo should > be in its own place to avoid them interfering with either other. > > Link to docs: > > https://docs.gitlab.com/ee/ci/runners/configure_runners.html#custom-buil

Re: [PATCH v3 1/2] CI: Move default image under global defaults

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 03:38:55PM -0700, Simon Glass wrote: > This is a global default, so put it under 'default' like the tags. > > Signed-off-by: Simon Glass > Suggested-by: Tom Rini Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 29/29] bloblist: Allow relocation at the end of the SPL phase

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 02:27:28PM -0700, Simon Glass wrote: > Hi Raymond, > > On Wed, 5 Feb 2025 at 08:35, Raymond Mao wrote: > > > > Hi Simon, > > > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > > > Where the bloblist is located in internal memory and TF-A's BL31 blob > > > removes

Re: [PATCH v4 6/6] configs: am6*_evm_a53_defconfig: Enable remoteproc support

2025-02-06 Thread Andrew Davis
On 2/5/25 7:54 PM, Judith Mendez wrote: From: Hari Nagalla Enable configs needed to enable remoteproc drivers for AM62 and AM64 devices. While we are here, cleanup some remoteproc configs, there is no DSP subsystem for am62px device. Signed-off-by: Hari Nagalla Signed-off-by: Judith Mendez

[PATCH v3 2/2] CI: Use different git-directories for concurrent runners

2025-02-06 Thread Simon Glass
When running multiple runners on the same machine, each git repo should be in its own place to avoid them interfering with either other. Link to docs: https://docs.gitlab.com/ee/ci/runners/configure_runners.html#custom-build-directories Signed-off-by: Simon Glass --- Changes in v3: - Use GIT_C

[PATCH v3 1/2] CI: Move default image under global defaults

2025-02-06 Thread Simon Glass
This is a global default, so put it under 'default' like the tags. Signed-off-by: Simon Glass Suggested-by: Tom Rini --- (no changes since v2) Changes in v2: - Add new patch to move default image under global defaults .gitlab-ci.yml | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Raymond Mao
Hi Simon, On Thu, 6 Feb 2025 at 10:41, Simon Glass wrote: > > Hi Raymond, > > On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > > > +CC Ilias, > > > > Hi Simon, > > > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > > > The logic of this has become too confusing. > > > > > > The prim

Re: [PATCH 29/29] bloblist: Allow relocation at the end of the SPL phase

2025-02-06 Thread Raymond Mao
Hi Simon, On Thu, 6 Feb 2025 at 16:28, Simon Glass wrote: > > Hi Raymond, > > On Wed, 5 Feb 2025 at 08:35, Raymond Mao wrote: > > > > Hi Simon, > > > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > > > Where the bloblist is located in internal memory and TF-A's BL31 blob > > > removes

[PATCH] common: fix: add NULL checks for xrealloc in make_string

2025-02-06 Thread Anton Moryakov
- Check return value of xrealloc for NULL. - Free allocated memory and return NULL if xrealloc fails. - Prevent NULL pointer dereference in strlen and strcat. Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov --- common/cli_hush.c | 8 +++- 1 file changed, 7 insertions

[PATCH] common: fix: add NULL checks for malloc_cache_aligned in

2025-02-06 Thread Anton Moryakov
- Check return value of malloc_cache_aligned for presskey and sha. - Return -ENOMEM if memory allocation fails. - Free allocated memory in error paths." Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov --- common/autoboot.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH] lib: ecdsa: fix prevent memory leak in ecdsa_add_verify_data

2025-02-06 Thread Anton Moryakov
- Ensure `free_ctx` is called in both error and success paths. - Fix memory leak in `ctx.signature` when `do_add` fails." Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov --- lib/ecdsa/ecdsa-libcrypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Simon Glass
Hi Tom, On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > It is confusing to have a camel-case indentifier in the link scripts. > > Rename it to fit with U-Boot's snake-case style. > > > > Signed-off-by: Simon Glass > > This isn't

Re: [PATCH 31/32] efi: arm: Simplify the crt0 file and update link script

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 10:08, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 05:33:30AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 3 Feb 2025 at 19:14, Tom Rini wrote: > > > > > > On Mon, Feb 03, 2025 at 05:38:16PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon,

[PATCH] arm64: zynqmp: versal: Consistently use enum tcm_mode

2025-02-06 Thread Marek Vasut
Turn anonymous enum TCM_LOCK/TCM_SPLIT into enum tcm_mode {}, set TCM_LOCK as 0 and TCM_SPLIT as 1 to match LOCK and SPLIT macros in mach-zynqmp/mp.c, and unify all the functions and their parameters on this one single enum tcm_mode {} instead of a mix of bool and u8. No functional change intended.

Re: [PATCH 29/29] bloblist: Allow relocation at the end of the SPL phase

2025-02-06 Thread Simon Glass
Hi Raymond, On Wed, 5 Feb 2025 at 08:35, Raymond Mao wrote: > > Hi Simon, > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > Where the bloblist is located in internal memory and TF-A's BL31 blob > > removes access to this memory, the best option seems to be to relocate > > the bloblist

Re: [PATCH 16/32] efi: arm: Don't do the EL2 switch when running under EFI

2025-02-06 Thread Simon Glass
Hi Tom, On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > On Mon, Feb 03, 2025 at 10:42:09AM -0700, Simon Glass wrote: > > > The previous bootloader has likely done this already, so avoid trying to > > do it again. This fixes a crash in QEMU when booting from EDK2 > > > > Signed-off-by: Simon Glas

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 09:23, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 08:41:09AM -0700, Simon Glass wrote: > > Hi Raymond, > > > > On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > > > > > +CC Ilias, > > > > > > Hi Simon, > > > > > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote:

Re: [PATCH 22/32] efi: arm: Allow use of the EFI table in the app

2025-02-06 Thread Simon Glass
Hi Heinrich, On Thu, 6 Feb 2025 at 10:13, Heinrich Schuchardt wrote: > > On 2/6/25 13:37, Simon Glass wrote: > > Hi Heinrich, > > > > On Thu, 6 Feb 2025 at 03:52, Heinrich Schuchardt wrote: > >> > >> On 2/3/25 18:42, Simon Glass wrote: > >>> It isn't worth the hassle of omitting this field for t

Re: [PATCH 21/32] efi: arm: Drop exception code when running as an EFI app

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 10:08, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 05:33:06AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 3 Feb 2025 at 19:00, Tom Rini wrote: > > > > > > On Mon, Feb 03, 2025 at 05:38:52PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon,

Re: [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests

2025-02-06 Thread Marek Vasut
On 2/6/25 1:42 PM, Simon Glass wrote: Hi, FAILED (errors=1) So where is the SRK_1_2_3_4_table.bin file? See the tool documentation: https://gitlab.apertis.org/pkg/imx-code-signing-tool/-/blob/debian/3.4.0+dfsg-2/docs/CST_UG.pdf?ref_type=tags 3.1.2 Running the hab4_pki_tree script Example 3.

Re: [PATCH] tools: mkenvimage: Add pure shell implementation of mkenvimage

2025-02-06 Thread Marek Vasut
On 2/6/25 1:38 PM, Simon Glass wrote: Hi Marek, On Wed, 5 Feb 2025 at 07:37, Marek Vasut wrote: Add implementation of mkenvimage written purely in bourne shell. This is not a replacement for mkenvimage tool, but rather a simple implementation which can be used in environments where mkenvimag

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > Hi Ilias, > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > wrote: > > > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > > > wrote: > > > > > > >

Re: [RFC PATCH v1 00/20] Introduce support for Raspberry PI 5.

2025-02-06 Thread Oleksii Moisieiev
On 06/02/2025 18:54, Tom Rini wrote: > On Thu, Feb 06, 2025 at 04:07:53PM +, Oleksii Moisieiev wrote: >> Hi Simon, >> >> Please see below. >> >> On 06/02/2025 17:58, Simon Glass wrote: >>> Hi Oleksii, >>> >>> On Thu, 6 Feb 2025 at 05:46, Oleksii Moisieiev >>> wrote: Hi Simon. P

Re: [RFC PATCH v1 00/20] Introduce support for Raspberry PI 5.

2025-02-06 Thread Oleksii Moisieiev
Hi Simon, Please see below. On 06/02/2025 17:58, Simon Glass wrote: > Hi Oleksii, > > On Thu, 6 Feb 2025 at 05:46, Oleksii Moisieiev > wrote: >> Hi Simon. >> >> Please see below. >> >> -- Oleski >> >> On 06/02/2025 14:31, Simon Glass wrote: >>> Hi Oleksii, >>> >>> On Wed, 5 Feb 2025 at 03:15, Ol

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Simon Glass
Hi Ilias, On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas wrote: > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > Hi Ilias, > > > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > > > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > Hi Ilias, > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > > > wrote: > > > >

[PATCH] common: Fix memory leak and incorrect comparison

2025-02-06 Thread Maks Mishin
Changing the order of actions: the input argument is checked before memory is allocated. The input argument `n` is of type `size_t` and cannot take negative values, so the comparison has been fixed. Signed-off-by: Maks Mishin --- common/dlmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 8/8] efi_loader: efi_net: Add support for multiple efi_net_obj

2025-02-06 Thread Adriano Cordova
Add support for multiple efi_net_obj structs in efi_net.c. This comes in preparation for an EFI network driver supporting multiple network interfaces. For now the EFI network stack still registers a single ethernet udevice as an EFI network device even if multiple are present, namely the one that w

[PATCH 7/8] efi_loader: efi_net: Add dhcp cache

2025-02-06 Thread Adriano Cordova
Add a dhcp cache to store the DHCP ACKs received by the U-Boot network stack. Signed-off-by: Adriano Cordova --- lib/efi_loader/efi_net.c | 55 +++- 1 file changed, 43 insertions(+), 12 deletions(-) diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_n

[PATCH 6/8] efi_loader: efi_net: Add device path cache

2025-02-06 Thread Adriano Cordova
In preparation to support mutiple efi net udevices. Add a device path cache to support device paths from multiple ethernet udevices. The device paths can be added to the cache before EFI gets initialized and the protocols get installed. Signed-off-by: Adriano Cordova --- include/efi_loader.h

[PATCH 3/8] efi_loader: efi_setup: Add efi_start_obj_list() to efi_setup.c

2025-02-06 Thread Adriano Cordova
The coomand bootefi calls efi_init_obj_list to do the efi set up before launching an .efi payload, but efi_init_obj_list is called only once. There are some initializations which depend on the environment and should be done each time a payload gets launched and not only once. A motivation for this

[PATCH 5/8] efi_loader: efi_device_path: Pass net udevice as argument

2025-02-06 Thread Adriano Cordova
In preparation to support multiple EFI net objects, support constructing device paths using an ethernet device different than the default. Add a udevice argument to the device path generation, and keep the callsites with eth_get_dev() to preserve existing functionality. Signed-off-by: Adriano Cord

[PATCH 4/8] efi_loader: efi_net: Add efi_net_do_start() to efi_net.c

2025-02-06 Thread Adriano Cordova
This gets called each time a payload is to get executed by bootefi. For now this only updates the PXE IP address. Signed-off-by: Adriano Cordova --- include/efi_loader.h | 1 + lib/efi_loader/efi_net.c | 31 --- lib/efi_loader/efi_setup.c | 3 +++ 3 files ch

[PATCH 2/8] efi_loader: expose symbols to be used by the EFI network stack

2025-02-06 Thread Adriano Cordova
The following symbols are exposed: - efi_reinstall_protocol_interface This is done so that the device path protocol interface of the network device can be changed internally by u-boot when a new bootfile gets downloaded. - eth_set_dev

[PATCH 1/8] legacy-net: wget: fix wget_info handling after new tcp legacy stack

2025-02-06 Thread Adriano Cordova
Check wget_info->buffer_size for overflow and do not clean the wget_info struct on failure, let the owner of the struct handle the error. The latter is necesary , e.g., for when a request fails because the provided buffer was too small. Signed-off-by: Adriano Cordova --- net/wget.c | 18

[PATCH 0/8] EFI net driver - series 1/2: Support multiple EFI net objects

2025-02-06 Thread Adriano Cordova
This series adds support for multiple efi_net_obj structs in efi_net.c. The EFI network code still only registers one efi_net_obj, corresponding to the current ethernet udevice when EFI initializes. In the next series the EFI net driver will [de]register ethernet udevices in the EFI network code at

Re: [PATCH 22/32] efi: arm: Allow use of the EFI table in the app

2025-02-06 Thread Heinrich Schuchardt
On 2/6/25 13:37, Simon Glass wrote: Hi Heinrich, On Thu, 6 Feb 2025 at 03:52, Heinrich Schuchardt wrote: On 2/3/25 18:42, Simon Glass wrote: It isn't worth the hassle of omitting this field for the app, since code is shared between the payload and the app. Adjust the condition to avoid a bui

Re: [PATCH 01/32] Convert build-efi script to Python

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 06:05:36AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 13:07, Tom Rini wrote: > > > > On Mon, Feb 03, 2025 at 10:41:54AM -0700, Simon Glass wrote: > > > > > Before this gets any longer, convert it to Python so it is easier to > > > maintain. > > > > > > S

Re: [PATCH 31/32] efi: arm: Simplify the crt0 file and update link script

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:33:30AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 19:14, Tom Rini wrote: > > > > On Mon, Feb 03, 2025 at 05:38:16PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 13:10, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 15/32] efi: lmb: Avoid access to _start

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:33:17AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 19:12, Tom Rini wrote: > > > > On Mon, Feb 03, 2025 at 05:38:44PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 21/32] efi: arm: Drop exception code when running as an EFI app

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:33:06AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 19:00, Tom Rini wrote: > > > > On Mon, Feb 03, 2025 at 05:38:52PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 00/10] phyCORE-AM62x/AM64x: Add RAUC and Secure Boot

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 11:41:14AM +0100, Daniel Schultz wrote: > Hi, > > On 05.02.25 15:51, Tom Rini wrote: > > On Wed, Feb 05, 2025 at 12:01:36AM -0800, Daniel Schultz wrote: > > > > > This patch series adds support to boot PHYTEC's reference distros for > > > RAUC and Secure Boot. > > > > > >

Re: [RFC PATCH v1 00/20] Introduce support for Raspberry PI 5.

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 04:07:53PM +, Oleksii Moisieiev wrote: > Hi Simon, > > Please see below. > > On 06/02/2025 17:58, Simon Glass wrote: > > Hi Oleksii, > > > > On Thu, 6 Feb 2025 at 05:46, Oleksii Moisieiev > > wrote: > >> Hi Simon. > >> > >> Please see below. > >> > >> -- Oleski > >> >

Re: [PATCH 3/3] rockchip: Fix binman error

2025-02-06 Thread Quentin Schulz
Hi Simon, On 2/6/25 1:46 PM, Simon Glass wrote: Hi Quentin, On Wed, 5 Feb 2025 at 06:00, Quentin Schulz wrote: Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: After adding the below configs, binman produces an error. CONFIG_SPL_DFU CONFIG_SPL_ENV_SUPPORT CONFIG_SPL_USB_DWC3_GE

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 08:41:09AM -0700, Simon Glass wrote: > Hi Raymond, > > On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > > > +CC Ilias, > > > > Hi Simon, > > > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > > > The logic of this has become too confusing. > > > > > > The prim

Re: [RFC PATCH v1 00/20] Introduce support for Raspberry PI 5.

2025-02-06 Thread Simon Glass
Hi Oleksii, On Thu, 6 Feb 2025 at 05:46, Oleksii Moisieiev wrote: > > Hi Simon. > > Please see below. > > -- Oleski > > On 06/02/2025 14:31, Simon Glass wrote: > > Hi Oleksii, > > > > On Wed, 5 Feb 2025 at 03:15, Oleksii Moisieiev > > wrote: > >> This patch series provides generic support for Ra

Re: [PATCH] Add 'bootsource' /chosen property

2025-02-06 Thread Quentin Schulz
Hi Simon, On 2/6/25 1:33 PM, Simon Glass wrote: Hi Quentin, On Wed, 5 Feb 2025 at 02:12, Quentin Schulz wrote: From: Quentin Schulz Bootloaders typically can be loaded from different storage media, such as eMMC, SD card, SPI flash, EEPROM, but also from non-persistent media such as USB (vi

Re: [PATCH 28/29] Revert "bloblist: Load the bloblist from the previous loader"

2025-02-06 Thread Simon Glass
Hi Raymond, On Wed, 5 Feb 2025 at 08:25, Raymond Mao wrote: > > +CC Ilias, > > Hi Simon, > > On Tue, 4 Feb 2025 at 20:57, Simon Glass wrote: > > > > The logic of this has become too confusing. > > > > The primary issue with the patch is that U-Boot needs to set up a > > bloblist in the first pha

[PATCH v2 0/2] EFI Capsule update explicitly sets dfu_alt_info

2025-02-06 Thread Jonathan Humphreys
For capsule update, explicitly set the dfu_alt_info environment variable before the DFU operation, and then restore it to the original value. Previously, the dfu_alt_info environment variable was set with the set_dfu_alt_info() function. The problem with setting the capsule update's dfu_alt_info s

[PATCH v2 2/2] board: remove capsule update support in set_dfu_alt_info()

2025-02-06 Thread Jonathan Humphreys
Now that capsule update sets the dfu_alt_info environment variable explicitly, there is no need to support it in the set_dfu_alt_info() function. Decouple SET_DFU_ALT_INFO from EFI_CAPSULE_FIRMWARE_FIT and EFI_CAPSULE_FIRMWARE_RAW. For many boards, this was the only use of set_dfu_alt_info() so rem

[PATCH v2 1/2] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-06 Thread Jonathan Humphreys
The current implementation of EFI capsule update uses set_dfu_alt_info() to set the dfu_alt_info environment variable with the settings it requires. However, set_dfu_alt_info() is doing this for all DFU operations, even those unrelated to capsule update. Thus other uses of DFU, such as DFU boot wh

2025.04-rc1 breaks booting 6.13 on VisionFive 2 v1.2A

2025-02-06 Thread Andreas Schwab
The last kernel messages are [ 18.318118] [ T49] platform 94000.pcie: deferred probe pending: pcie-starfive: failed to get pcie phy [ 18.327846] [ T49] platform 9c000.pcie: deferred probe pending: pcie-starfive: failed to get pcie phy and no MMC driver is loaded (dw_mmc_pltf

Re: [PATCH 5/6] rockchip: mkimage: Add support for up to 4 input files

2025-02-06 Thread Quentin Schulz
On 2/5/25 8:00 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 17:43, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format can support up to 4 embedded images that can be loaded by the BootROM using the back-to-bootrom method. Currently two input f

Re: Enabling test/py/tests/test_spi.py more?

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 06:14:09PM +0530, Love Kumar wrote: > Hi Tom, > > On 01/02/25 4:28 am, Tom Rini wrote: > > On Fri, Jan 31, 2025 at 02:00:07PM -0600, Tom Rini wrote: > > > Hey, > > > > > > Can you please confirm that this test currently functions on your > > > platforms? And then can we pl

Re: [PATCH 6/6] rockchip: mkimage: Add option for image load address and flag

2025-02-06 Thread Quentin Schulz
Hi Jonas, On 2/5/25 8:54 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 17:51, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: The v2 image format supports defining a load address and flag for each embedded image. Add initial support for writing the image load

Re: [PATCH 2/6] rockchip: mkimage: Print image information for all embedded images

2025-02-06 Thread Quentin Schulz
Hi Jonas, On 2/5/25 8:36 PM, Jonas Karlman wrote: Hi Quentin, On 2025-02-05 16:57, Quentin Schulz wrote: Hi Jonas, On 1/29/25 11:36 PM, Jonas Karlman wrote: [...] --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -331,8 +331,6 @@ static void rkcommon_set_header0_v2(void *buf, struct image_t

Re: [PATCH v3 2/5] rockchip: io-domain: Add CONFIG_SPL_ROCKCHIP_IODOMAIN

2025-02-06 Thread Quentin Schulz
Hi Justin, On 2/5/25 6:16 PM, Justin Klaassen wrote: Allows use of the Rockchip IO-domain driver in SPL to configure the GPIO to match the voltage supplied by specific regulators (e.g. "vcc_sdio"). Signed-off-by: Justin Klaassen Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v3 1/5] rockchip: io-domain: Add debug logging for regulators during probe

2025-02-06 Thread Quentin Schulz
Hi Justin, On 2/5/25 6:16 PM, Justin Klaassen wrote: Log the value of the regulators during initialization of the IO-domain driver to aid in debugging GPIO voltage configuration problems. Signed-off-by: Justin Klaassen Reviewed-by: Quentin Schulz Thanks! Quentin

[PATCH 1/1] configs: microchip_mpfs_icicle: set DEFAULT_FDT_FILE

2025-02-06 Thread Heinrich Schuchardt
Variable $fdtfile needs to be set for automatically loading a device-tree from the ESP or boot partition. * Set CONFIG_DEFAULT_FDT_FILE in the defconfig. * Add $fdtfile to the default environment. Signed-off-by: Heinrich Schuchardt --- configs/microchip_mpfs_icicle_defconfig | 1 + include/conf

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Simon Glass
Hi Ilias, On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > > wrote: > > > > > > Hi Heinrich, > > > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchar

Re: [PATCH 00/32] arm: Support building as an EFI app

2025-02-06 Thread Simon Glass
Hi Heinrich, On Thu, 6 Feb 2025 at 03:56, Heinrich Schuchardt wrote: > > On 2/3/25 18:41, Simon Glass wrote: > > The original x86 EFI-app was written back in 2015, about a year before > > the EFI-loader was introduced. At that point, ARM mostly used U-Boot and > > FIT (Flat Image Tree). > > > > T

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > Hi Ilias, > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > wrote: > > > > Hi Heinrich, > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > > > For armv8 we are a

Re: [PATCH v1 0/6] Fix page permission on arm64 architectures

2025-02-06 Thread Simon Glass
Hi Ilias, On Wed, 5 Feb 2025 at 00:17, Ilias Apalodimas wrote: > > Hi! > This is v1 of [0]. > > This is an attempt to map the U-Boot binary properly, but leave the > area we load binaries unaffected and RWX. > > There's a few changes since the RFC > - Fixed the alignment of meminfo command when p

Re: [RFC PATCH v1 00/20] Introduce support for Raspberry PI 5.

2025-02-06 Thread Oleksii Moisieiev
Hi Simon. Please see below. -- Oleski On 06/02/2025 14:31, Simon Glass wrote: > Hi Oleksii, > > On Wed, 5 Feb 2025 at 03:15, Oleksii Moisieiev > wrote: >> This patch series provides generic support for Raspberry PI 5 in >> U-Boot with additional hardware drivers. >> The following features were

Re: [PATCH v1 2/6] doc: update meminfo with arch specific information

2025-02-06 Thread Ilias Apalodimas
Hi Simon On Thu, 6 Feb 2025 at 14:31, Simon Glass wrote: > > Hi Ilias, > > On Wed, 5 Feb 2025 at 00:17, Ilias Apalodimas > wrote: > > > > Since we added support in meminfo to dump live page tables, describe > > the only working architecture for now (aarch64) and add links to public > > documenta

Re: [PATCH v1 2/6] doc: update meminfo with arch specific information

2025-02-06 Thread Simon Glass
Hi Ilias, On Wed, 5 Feb 2025 at 00:17, Ilias Apalodimas wrote: > > Since we added support in meminfo to dump live page tables, describe > the only working architecture for now (aarch64) and add links to public > documentation for further reading. > > Signed-off-by: Ilias Apalodimas > --- > doc/

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Simon Glass
Hi Ilias, On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas wrote: > > Hi Heinrich, > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > > For armv8 we are adding proper page permissions for the relocated U-Boot > > > binary. Add a weak fun

Re: [PATCH 01/32] Convert build-efi script to Python

2025-02-06 Thread Simon Glass
Hi Tom, On Mon, 3 Feb 2025 at 13:07, Tom Rini wrote: > > On Mon, Feb 03, 2025 at 10:41:54AM -0700, Simon Glass wrote: > > > Before this gets any longer, convert it to Python so it is easier to > > maintain. > > > > Signed-off-by: Simon Glass > > --- > > > > MAINTAINERS|

Re: [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests

2025-02-06 Thread Simon Glass
Hi, On Wed, 5 Feb 2025 at 03:20, Marek Vasut wrote: > > On 1/9/25 3:10 PM, Simon Glass wrote: > > Hi Marek, > > > > On Tue, 7 Jan 2025 at 04:24, Marek Vasut wrote: > >> > >> On 1/7/25 4:50 AM, Simon Glass wrote: > >>> Hi Marek, > >>> > >>> On Mon, 6 Jan 2025 at 13:51, Marek Vasut wrote: >

Re: [PATCH 15/32] efi: lmb: Avoid access to _start

2025-02-06 Thread Simon Glass
Hi Tom, On Mon, 3 Feb 2025 at 19:12, Tom Rini wrote: > > On Mon, Feb 03, 2025 at 05:38:44PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > On Mon, Feb 03, 2025 at 10:42:08AM -0700, Simon Glass wrote: > > > > > > > The app does not have this

Re: [PATCH 3/3] rockchip: Fix binman error

2025-02-06 Thread Simon Glass
Hi Quentin, On Wed, 5 Feb 2025 at 06:00, Quentin Schulz wrote: > > Hi Naoki, > > On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: > > After adding the below configs, binman produces an error. > > > > CONFIG_SPL_DFU > > CONFIG_SPL_ENV_SUPPORT > > CONFIG_SPL_USB_DWC3_GENERIC > > CONFIG_SPL_USB_GADG

Re: Enabling test/py/tests/test_spi.py more?

2025-02-06 Thread Love Kumar
Hi Tom, On 01/02/25 4:28 am, Tom Rini wrote: On Fri, Jan 31, 2025 at 02:00:07PM -0600, Tom Rini wrote: Hey, Can you please confirm that this test currently functions on your platforms? And then can we please enable it in https://source.denx.de/u-boot/u-boot-test-hooks as both a functional exam

Re: [RFC PATCH 0/4] Fix page permission on arm64 architectures

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 14:33, Simon Glass wrote: > > Hi Ilias, > > On Thu, 30 Jan 2025 at 00:21, Ilias Apalodimas > wrote: > > > > U-Boot maps all pages as RWX. Sadly it's not not 1990 anymore and we are > > better off mapping binaries with proper permissions. > > > > This is an attempt

  1   2   >