Hi Tom, On Mon, 3 Feb 2025 at 13:09, Tom Rini <tr...@konsulko.com> wrote: > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > It is confusing to have a camel-case indentifier in the link scripts. > > Rename it to fit with U-Boot's snake-case style. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > This isn't the linker script, it's the crt0 file.
Yes, it's referred to in the x86 linker scripts. Probably we should rationalise some of these names. > Given that this is intended to match up with > https://learn.microsoft.com/en-us/windows/win32/debug/pe-format (which I > got from looking at the commit message on commit 216459d2cf36 > ("efi_loader: correct SizeOfCode, SizeOfInitializedData") and > include/pe.h I don't think this is a good change. Heinrich? Well, pe.h is a file format so I don't believe we need to use the same code style. We had that discussion when the EFI code was coming in, and decided that it wasn't a good idea (as I recall). Regards, Simon
