On Thu, Feb 06, 2025 at 06:05:36AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 13:07, Tom Rini <tr...@konsulko.com> wrote: > > > > On Mon, Feb 03, 2025 at 10:41:54AM -0700, Simon Glass wrote: > > > > > Before this gets any longer, convert it to Python so it is easier to > > > maintain. > > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > > --- > > > > > > MAINTAINERS | 2 +- > > > doc/develop/uefi/u-boot_on_efi.rst | 4 +- > > > scripts/build-efi.py | 258 +++++++++++++++++++++++++++++ > > > scripts/build-efi.sh | 207 ----------------------- > > > 4 files changed, 261 insertions(+), 210 deletions(-) > > > create mode 100755 scripts/build-efi.py > > > delete mode 100755 scripts/build-efi.sh > > > > This should just go live in the u-boot-extras repository as another > > sample script. And as a bonus, there you can just push the script right > > now. > > But I can't be sure it will stay that way. In any case I see these > scripts as first-class citizens, in the docs, tested in CI, used by > people to report bugs, updated as new features appear, etc.
Yup, I still think that's the wrong way of looking at it. It's a sample script on how to use this for QEMU which means it's useful as a debug and development aid. It's bad for CI since if we want to deal with "CI is slow" we need to pre-create test disk images, not do that on the fly. And you've got sudo and various external blobs being used. No, it does not belong in the main repository and I'm sorry I missed it the first time. And converting this to python is even worse as we have yet another tool that should have a proper requirements.txt file and keeping that up to date. And then oh, the inevitable "here's a security issue in U-Boot!" (by which they mean an issue in a support script and not what's deployed and used). So please, lets just move this to the extras repository, and point to *that* in our docs enough that it's clear that we have tooling that can be useful in some cases there. -- Tom
signature.asc
Description: PGP signature
