Re: [PATCH 0/2] Fix device removal order for Apple dart iommu

2024-10-31 Thread Sughosh Ganu
mit: 1d147b74f437fb0e85821e8271fe52bc5fd30194 > change-id: 20241031-iommu_apple_dart_ordering-558e62671512 > > Best regards, > -- > Janne Grunau >

Re: [PATCH v2 6/8] armv8: Add generic smbios information into the device tree

2024-10-31 Thread Heinrich Schuchardt
Am 29. Oktober 2024 16:45:44 MEZ schrieb Simon Glass : >On Mon, 28 Oct 2024 at 21:00, Raymond Mao wrote: >> >> Hi Simon, >> >> On Mon, 28 Oct 2024 at 13:05, Simon Glass wrote: >>> >>> Hi Raymond, >>> >>> On Tue, 22 Oct 2024 at 22:07, Raymond Mao wrote: >>> > >>> > Add common smbios informatio

Re: [PATCH v2 6/8] armv8: Add generic smbios information into the device tree

2024-10-31 Thread Heinrich Schuchardt
Am 29. Oktober 2024 16:45:44 MEZ schrieb Simon Glass : >On Mon, 28 Oct 2024 at 21:00, Raymond Mao wrote: >> >> Hi Simon, >> >> On Mon, 28 Oct 2024 at 13:05, Simon Glass wrote: >>> >>> Hi Raymond, >>> >>> On Tue, 22 Oct 2024 at 22:07, Raymond Mao wrote: >>> > >>> > Add common smbios informatio

Re: [PATCH] dm: sysinfo: Shorten the SYSINFO_ID prefix

2024-10-31 Thread Raymond Mao
Hi Simon, On Thu, 31 Oct 2024 at 13:50, Simon Glass wrote: > We are about to add a large number of new entries. Update the prefix to > be a little shorter. > > For SMBIOS items, use SYSID_SM_ (for System Management) which is enough > to distinguish it. For now at least, it seems that most items

Re: [PATCH v4 2/2] board: rockchip: Add support for rk3588 GenBook

2024-10-31 Thread Kever Yang
Hi Andy, On 2024/10/30 20:09, Andy Yan wrote: Add support for Cool Pi GenBook, it works as a carrier board connect with CM5 SOM. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3.0 Host x 1 - USB-C 3.0 with DisplayPort AltMode - PCIE M.2 E Key for RTL

Suggestions for Custom U-Boot Project

2024-10-31 Thread Suraj Sonawane
Hi everyone! I'm planning to work on a U-Boot project for learning and would love some input. My idea is to create a customized U-Boot bootloader with features like dual boot, A/B System Updates, secure boot, and OTA updates. If anyone has suggestions to enhance this project or ideas for other int

bios_emulator: how LOG_inpb() is supposed to work on non-x86 systems?

2024-10-31 Thread Yuri Zaporozhets
Hi all, When trying to compile drivers/bios_emulator for RISC-V, I get a bunch of the following warnings: In file included from drivers/bios_emulator/besys.c:51: drivers/bios_emulator/besys.c: In function ‘BE_inb’: ./arch/riscv/include/asm/io.h:18:43: warning: cast to pointer fr

Re: [PATCH 00/15] efi_loader: Add support for logging to a buffer

2024-10-31 Thread Simon Glass
Hi Ilias, On Tue, 29 Oct 2024 at 19:32, Ilias Apalodimas wrote: > > On Tue, 29 Oct 2024 at 17:45, Simon Glass wrote: > > > > Hi Ilias, > > > > On Tue, 29 Oct 2024 at 10:58, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > > > > >

[PATCH 1/2] iommu: apple: Mark device with DM_FLAG_VITAL

2024-10-31 Thread Janne Grunau
Avoids NULL pointer dereferences in apple_dart_unmap when the iommu device is removed before its user. U-boot's device model does not track dependencies between devices. Observed on a M1 Ultra Mac Studio with v2024.10. Signed-off-by: Janne Grunau --- drivers/iommu/apple_dart.c | 2 +- 1 file cha

[PATCH 2/2] efi_loader: remove non vital devices first

2024-10-31 Thread Janne Grunau
DM_FLAG_VITAL marks devices which are essential for the operation of other devices. Removing these devices before their users can result in hangs or crashes. This potentially fixes EFI boot of Renesas rcar3 devices. Their clock devices (and with this series the dart iommu) are the only devices mark

[PATCH 0/2] Fix device removal order for Apple dart iommu

2024-10-31 Thread Janne Grunau
insertions(+), 1 deletion(-) --- base-commit: 1d147b74f437fb0e85821e8271fe52bc5fd30194 change-id: 20241031-iommu_apple_dart_ordering-558e62671512 Best regards, -- Janne Grunau

Re: [PATCH 10/15] efi_loader: Add support for logging EFI calls

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 11:30:58PM +0100, Heinrich Schuchardt wrote: > > > Am 31. Oktober 2024 19:01:47 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Tue, 29 Oct 2024 at 23:32, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 28. Oktober 2024 13:48:01 MEZ schrieb Simon Glass : > >> >The c

Re: [PATCH 10/15] efi_loader: Add support for logging EFI calls

2024-10-31 Thread Heinrich Schuchardt
Am 31. Oktober 2024 19:01:47 MEZ schrieb Simon Glass : >Hi Heinrich, > >On Tue, 29 Oct 2024 at 23:32, Heinrich Schuchardt wrote: >> >> >> >> Am 28. Oktober 2024 13:48:01 MEZ schrieb Simon Glass : >> >The current logging system suffers from some disadvantages, mainly that >> >it writes its outpu

Re: [PATCH v7 04/11] test: Introduce the concept of a role

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 07:01:56PM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > > > On Wed, Oct 09, 2024 at 07:51:38PM -0600, Simon Glass wrote: > > > > > In Labgrid there is the concept of a 'role', which is similar to the > > > U-Boot board ID in U-B

Re: [PATCH v7 10/11] test: Support testing with two board-builds

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 06:59:37PM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Oct 2024 at 00:52, Tom Rini wrote: > > > > On Wed, Oct 09, 2024 at 07:51:44PM -0600, Simon Glass wrote: > > > > > The Beagleplay board uses two entirely separate builds to produce an > > > image, rather than usi

Re: [PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Jonas Karlman
On 2024-10-31 22:52, Jonas Karlman wrote: > Hi Sebastian, > > On 2024-10-31 22:16, Sebastian Reichel wrote: >> Hi, >> >> On Thu, Oct 31, 2024 at 08:17:32PM +0100, Jonas Karlman wrote: >>> On 2024-10-31 19:15, Eugen Hristev wrote: On 10/31/24 20:01, Sebastian Reichel wrote: > PCI enumerati

[PATCH] armv8: cpu: Implement allow_unaligned()

2024-10-31 Thread Sam Protsenko
Usually ARMv8 platforms allow unaligned access for Normal memory. But some chips might not allow it by default, having SCTLR.A bit set to 1 before U-Boot execution. One such example is Exynos850 SoC. As allow_unaligned() is not implemented for ARMv8 at the moment, its __weak implementation is used,

Re: [PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Jonas Karlman
Hi Sebastian, On 2024-10-31 22:16, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 31, 2024 at 08:17:32PM +0100, Jonas Karlman wrote: >> On 2024-10-31 19:15, Eugen Hristev wrote: >>> On 10/31/24 20:01, Sebastian Reichel wrote: PCI enumeration is required to detect the onboard Ethernet device.

Re: [PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Sebastian Reichel
Hi, On Thu, Oct 31, 2024 at 08:17:32PM +0100, Jonas Karlman wrote: > On 2024-10-31 19:15, Eugen Hristev wrote: > > On 10/31/24 20:01, Sebastian Reichel wrote: > >> PCI enumeration is required to detect the onboard Ethernet device. > >> > >> Signed-off-by: Sebastian Reichel > >> --- > >> configs

Re: [PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Jonas Karlman
Hi Sebastian, On 2024-10-31 19:15, Eugen Hristev wrote: > Hello Sebastian, > > On 10/31/24 20:01, Sebastian Reichel wrote: >> PCI enumeration is required to detect the onboard Ethernet device. >> >> Signed-off-by: Sebastian Reichel >> --- >> configs/rock5b-rk3588_defconfig | 1 + >> 1 file ch

Re: [PATCH v2 1/3] menu: fix the logic checking whether ESC key is pressed

2024-10-31 Thread Daniel Golle
On Tue, Oct 29, 2024 at 05:47:10PM +0800, Weijie Gao wrote: > It's observed that the bootmenu on a serial console sometimes > incorrectly quitted with superfluous characters filled to command > line input: > > > *** U-Boot Boot Menu *** > > > > 1. Startup system (Default) > > 2. Upgrade

Re: [PATCH] mtd: spi-nor: Guard SPI_STACKED_PARALLEL with DM_SPI check

2024-10-31 Thread Marek Vasut
On 10/31/24 7:51 PM, Tom Rini wrote: On Thu, Oct 31, 2024 at 12:37:32PM -0600, Tom Rini wrote: While we want to compile the SPI_STACKED_PARALLEL code everywhere we can, it must first be guarded with an #if for DM_SPI as not all cases where we have this code built, such as in SPL, will have the r

Re: [PATCH] mtd: spi-nor: Guard SPI_STACKED_PARALLEL with DM_SPI check

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 08:13:00PM +0100, Marek Vasut wrote: > On 10/31/24 7:51 PM, Tom Rini wrote: > > On Thu, Oct 31, 2024 at 12:37:32PM -0600, Tom Rini wrote: > > > While we want to compile the SPI_STACKED_PARALLEL code everywhere we > > > can, it must first be guarded with an #if for DM_SPI as

Re: [PATCH v2 2/3] menu: add support to check if menu needs to be reprinted

2024-10-31 Thread Daniel Golle
On Tue, Oct 29, 2024 at 05:47:16PM +0800, Weijie Gao wrote: > This patch adds a new callback named need_reprint for menu. > The need_reprint will be called before printing the menu. If the > callback exists and returns FALSE, menu printing will be canceled. > > This is very useful if the menu was

Re: [PATCH v2 3/3] bootmenu: add reprint check

2024-10-31 Thread Daniel Golle
On Tue, Oct 29, 2024 at 05:47:22PM +0800, Weijie Gao wrote: > Record the last active menu item and check if it equals to the > current selected item before reprint. > > Signed-off-by: Weijie Gao Reviewed-by: Daniel Golle Tested-by: Daniel Golle > --- > cmd/bootmenu.c | 16 +++- >

Re: [PATCH] mtd: spi-nor: Guard SPI_STACKED_PARALLEL with DM_SPI check

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 12:37:32PM -0600, Tom Rini wrote: > While we want to compile the SPI_STACKED_PARALLEL code everywhere we > can, it must first be guarded with an #if for DM_SPI as not all cases > where we have this code built, such as in SPL, will have the relevant > DM_SPI option enabled. >

Re: [PATCH v7 03/11] test: Allow connecting to a running board

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 07:00:24PM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > > > On Wed, Oct 09, 2024 at 07:51:37PM -0600, Simon Glass wrote: > > > > > Sometimes we know that the board is already running the right software, > > > so provide an optio

Re: [PATCH 03/21] bloblist: test: doc: Move into the common suite

2024-10-31 Thread Simon Glass
Hi Tom, On Tue, 29 Oct 2024 at 17:36, Tom Rini wrote: > > On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 28 Oct 2024 at 20:33, Tom Rini wrote: > > > > > > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote: > > > > > > > There is no particular n

[PATCH] mtd: spi-nor: Guard SPI_STACKED_PARALLEL with DM_SPI check

2024-10-31 Thread Tom Rini
While we want to compile the SPI_STACKED_PARALLEL code everywhere we can, it must first be guarded with an #if for DM_SPI as not all cases where we have this code built, such as in SPL, will have the relevant DM_SPI option enabled. Fixes: 43423cdc5dc1 ("mtd: spi-nor: Always build SPI_STACKED_PARAL

Re: [PATCH v7 02/11] test: Release board after tests complete

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 07:00:14PM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > > > On Wed, Oct 09, 2024 at 07:51:36PM -0600, Simon Glass wrote: > > > > > When a board is finished with, the lab may want to power it off, or > > > perform some other func

[PATCH v1 2/4] usb: tcpm: avoid resets for missing source capability messages

2024-10-31 Thread Sebastian Reichel
The current TCPM code implements source capability message handling according to the USB-PD specification. Unfortunately some USB PD sources do not properly follow the specification and do not send source capability messages after a soft reset when they already negotiated a specific contract before

Re: [PATCH v2 12/13] sysinfo: Add driver for IOT2050 boards

2024-10-31 Thread Simon Glass
Hi Jan, On Wed, 23 Oct 2024 at 06:14, Jan Kiszka wrote: > > On 23.10.24 05:39, Simon Glass wrote: > > Hi Jan, > > > > On Tue, 22 Oct 2024 at 21:59, Jan Kiszka wrote: > >> > >> On 22.10.24 19:00, Simon Glass wrote: > >>> On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote: > > From: Li Hua

Re: [PATCH v7 01/11] test: Allow signaling that U-Boot is ready

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 07:00:10PM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > > > On Wed, Oct 09, 2024 at 07:51:35PM -0600, Simon Glass wrote: > > > > > When Labgrid is used, it can get U-Boot ready for running tests. It > > > prints a message when i

Re: [PATCH v6 01/19] test: Allow signaling that U-Boot is ready

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 07:03:19PM +0100, Simon Glass wrote: > Hi Tom, > > On Fri, 27 Sept 2024 at 04:52, Tom Rini wrote: > > > > On Thu, Sep 26, 2024 at 11:36:00PM +0200, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 25 Sept 2024 at 19:26, Tom Rini wrote: > > > > > > > > On Wed, Sep 25,

Re: [PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Eugen Hristev
Hello Sebastian, On 10/31/24 20:01, Sebastian Reichel wrote: PCI enumeration is required to detect the onboard Ethernet device. Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/

Re: [PATCH v7 10/11] test: Support testing with two board-builds

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:52, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:44PM -0600, Simon Glass wrote: > > > The Beagleplay board uses two entirely separate builds to produce an > > image, rather than using an SPL build for this purpose. > > JFTR, this is an incorrect explanation

Re: [PATCH v9 03/11] sandbox: Add a -N flag to control on-host behaviour

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 06:52:33PM +0100, Simon Glass wrote: > Hi Tom, > > On Tue, 29 Oct 2024 at 21:14, Tom Rini wrote: > > > > On Tue, Oct 29, 2024 at 08:22:11PM +0100, Simon Glass wrote: > > > > > Sandbox is its own architecture, but sometimes we want to mimic the host > > > architecture, e.g.

Re: [PATCH] test/cmd/mem_copy.c: Use CONFIG_SYS_LOAD_ADDR for base

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 06:51:52PM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Oct 2024 at 01:36, Tom Rini wrote: > > > > When reading/writing to memory we cannot assume that a base address of > > 0x0 is correct and functional. So use CONFIG_SYS_LOAD_ADDR as the base > > from which we add

Re: [PATCH 03/21] bloblist: test: doc: Move into the common suite

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 07:00:41PM +0100, Simon Glass wrote: > Hi Tom, > > On Tue, 29 Oct 2024 at 17:36, Tom Rini wrote: > > > > On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 28 Oct 2024 at 20:33, Tom Rini wrote: > > > > > > > > On Mon, Oct 28, 20

Re: [PATCH v7 01/11] test: Allow signaling that U-Boot is ready

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:35PM -0600, Simon Glass wrote: > > > When Labgrid is used, it can get U-Boot ready for running tests. It > > prints a message when it has done so. > > > > Add logic to detect this message and accept it. > > >

Re: [PATCH v2 1/3] menu: fix the logic checking whether ESC key is pressed

2024-10-31 Thread Simon Glass
On Tue, 29 Oct 2024 at 10:47, Weijie Gao wrote: > > It's observed that the bootmenu on a serial console sometimes > incorrectly quitted with superfluous characters filled to command > line input: > > > *** U-Boot Boot Menu *** > > > > 1. Startup system (Default) > > 2. Upgrade firmware

Re: [PATCH 23/34] bootstd: Maintain a list of images

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 23 Oct 2024 at 20:41, Tom Rini wrote: > > On Tue, Oct 22, 2024 at 07:00:44PM +0200, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 22 Oct 2024 at 17:01, Tom Rini wrote: > > > > > > On Tue, Oct 22, 2024 at 02:16:52PM +0200, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Sat

Re: [RFC PATCH] zynqmp: Add binman description for SOM

2024-10-31 Thread Simon Glass
Hi Michal, On Wed, 9 Oct 2024 at 10:33, Michal Simek wrote: > > There is necessary to do some steps to compose boot images. These steps > were in scripts in layers for a while. That's why introduce description via > binman to simplify wiring and remove all scripting around. > This should make sur

Re: [PATCH v6 01/19] test: Allow signaling that U-Boot is ready

2024-10-31 Thread Simon Glass
Hi Tom, On Fri, 27 Sept 2024 at 04:52, Tom Rini wrote: > > On Thu, Sep 26, 2024 at 11:36:00PM +0200, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 25 Sept 2024 at 19:26, Tom Rini wrote: > > > > > > On Wed, Sep 25, 2024 at 02:49:56PM +0200, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On M

Re: [PATCH v7 06/11] test: Improve handling of sending commands

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:40PM -0600, Simon Glass wrote: > > > We expect commands to be echoed and this should happen quite quickly, > > since U-Boot is sitting at the prompt waiting for a command. > > > > Reduce the timeout for this s

Re: [PATCH v9 02/11] efi_loader: Add a test app

2024-10-31 Thread Simon Glass
Hi, On Wed, 30 Oct 2024 at 18:55, Ilias Apalodimas wrote: > > Hi Heinrich > > > > On Wed, 30 Oct 2024 at 18:55, Heinrich Schuchardt wrote: > > > > On 10/29/24 20:22, Simon Glass wrote: > > > Add a simple app to use for testing. This is intended to do whatever it > > > needs to for testing purpos

Re: [PATCH v7 08/11] test: Try to shut down the lab console gracefully

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:42PM -0600, Simon Glass wrote: > > > Send the Labgrid quit characters to ask it to exit gracefully. This > > typically allows it to power off the board being used. Only do this when > > labgrid is being used (

Re: [PATCH v7 05/11] test: Introduce lab mode

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:39PM -0600, Simon Glass wrote: > > > There is quite a bit of code in pytest to try to start up U-Boot on a > > board, with timeouts, expects, etc. > > > > This is tedious to maintain and is peripheral to the t

Re: [PATCH v7 04/11] test: Introduce the concept of a role

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:38PM -0600, Simon Glass wrote: > > > In Labgrid there is the concept of a 'role', which is similar to the > > U-Boot board ID in U-Boot's pytest subsystem. > > > > The role indicates both the target and inform

[PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Sebastian Reichel
PCI enumeration is required to detect the onboard Ethernet device. Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index c54e13e8732c..e5b9f7d326b4 100644 --

Re: [PATCH 10/15] efi_loader: Add support for logging EFI calls

2024-10-31 Thread Simon Glass
Hi Heinrich, On Tue, 29 Oct 2024 at 23:32, Heinrich Schuchardt wrote: > > > > Am 28. Oktober 2024 13:48:01 MEZ schrieb Simon Glass : > >The current logging system suffers from some disadvantages, mainly that > >it writes its output to the console and cannot be easily reviewed. > > > >Add a dedica

Re: [PATCH] test/cmd/mem_copy.c: Use CONFIG_SYS_LOAD_ADDR for base

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 01:36, Tom Rini wrote: > > When reading/writing to memory we cannot assume that a base address of > 0x0 is correct and functional. So use CONFIG_SYS_LOAD_ADDR as the base > from which we add a bit more padding and being our tests. > > Signed-off-by: Tom Rini > ---

Re: [PATCH v7 02/11] test: Release board after tests complete

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:36PM -0600, Simon Glass wrote: > > > When a board is finished with, the lab may want to power it off, or > > perform some other function. Add a new script which is called when tests > > are complete. > > > > S

Re: [PATCH v7 03/11] test: Allow connecting to a running board

2024-10-31 Thread Simon Glass
Hi Tom, On Wed, 30 Oct 2024 at 00:53, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 07:51:37PM -0600, Simon Glass wrote: > > > Sometimes we know that the board is already running the right software, > > so provide an option to allow running of tests directly, without first > > resetting the board.

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Tudor Ambarus
Hi, Michal, On 10/30/24 3:20 PM, Michal Simek wrote: > Jagan is aware that we are using this configuration for quite a long > time and we are still here and not leaving. Okay, great. Would be good if you/your team can allocate time and review/test patches that are improving/fixing the stacked/par

[PATCH v1 1/4] usb: tcpm: improve handling of some power-supplies

2024-10-31 Thread Sebastian Reichel
When the Rock 5B is booted with the current TCPM with its power supplied by a "Cambrionix PDSync-C4" port it reaches the power-supply ready state. Once that has happened the hub starts sending GetSinkCap messages, but U-Boot already stopped processing PD messages. After retrying a bunch of times th

[PATCH v1 3/4] usb: tcpm: print error on hard reset

2024-10-31 Thread Sebastian Reichel
A USB-PD hard reset involves removing the voltage from VBUS for some time. So basically it has the same effect as removing the USB-C plug for a short moment. If the machine is powered from the USB-C port and does not have a fallback supply (e.g. a battery), this will result in a full machine reset

[PATCH v1 4/4] usb: tcpm: improve data role mismatch error recovery

2024-10-31 Thread Sebastian Reichel
On Radxa ROCK 5B I managed to get U-Boot into an endless loop of printing fusb302 usb-typec@22: TCPM: data role mismatch, initiating error recovery messages by changing the data role in Linux and then rebooting the system. This is happening because the external device (A cheap USB-C hub powered t

[PATCH v1 0/4] USB-PD TCPM improvements

2024-10-31 Thread Sebastian Reichel
Hi, I have a couple of fixes/improvements for the TCPM code. Three are fixing actual problems I noticed on the Rock 5B, which prevented booting up the system. One of them simply adds an error print before potentially committing hara-kiri by triggering a hard reset, which helps people understanding

Re: [PATCH v9 03/11] sandbox: Add a -N flag to control on-host behaviour

2024-10-31 Thread Simon Glass
Hi Tom, On Tue, 29 Oct 2024 at 21:14, Tom Rini wrote: > > On Tue, Oct 29, 2024 at 08:22:11PM +0100, Simon Glass wrote: > > > Sandbox is its own architecture, but sometimes we want to mimic the host > > architecture, e.g. when running an EFI app not built by U-Boot. > > > > Add a -N/--native flag

Re: [PATCH 09/15] efi_loader: Fix free in ..._media_device_boot_option()

2024-10-31 Thread Simon Glass
Hi Heinrich, On Tue, 29 Oct 2024 at 23:13, Heinrich Schuchardt wrote: > > > > Am 29. Oktober 2024 16:45:29 MEZ schrieb Simon Glass : > >Hi Ilias, > > > >On Tue, 29 Oct 2024 at 11:02, Ilias Apalodimas > > wrote: > >> > >> Hi Simon, > >> > >> On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > >> >

[PATCH] dm: sysinfo: Shorten the SYSINFO_ID prefix

2024-10-31 Thread Simon Glass
We are about to add a large number of new entries. Update the prefix to be a little shorter. For SMBIOS items, use SYSID_SM_ (for System Management) which is enough to distinguish it. For now at least, it seems that most items will be for SMBIOS. Signed-off-by: Simon Glass --- board/coreboot/c

Re: 回复: [EXT] Re: [PATCH 08/17] scmi_protocols: update struct scmi_base_discover_list_protocols_out

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 09:57:27AM +, Alice Guo (OSS) wrote: > Hi Tom, > > > -邮件原件- > > 发件人: Tom Rini > > 发送时间: 2024年10月17日 2:07 > > 收件人: Alice Guo (OSS) > > 抄送: Lukasz Majewski ; Sean Anderson > > ; Stefano Babic ; Fabio Estevam > > ; Marek Vasut ; dl-uboot-imx > > ; u-boot@lists.de

[PATCH v2] arm: mach-k3: am62a7: Provide a way to obtain boot device for non SPLs

2024-10-31 Thread Garrett Giordano
Introduce get_boot_device() to obtain the booting device. Make it also available for non SPL builds so u-boot can also know the device it is booting from. Signed-off-by: Garrett Giordano Reviewed-by: Bryan Brattlof --- v2: - Drop duplicate CONFIG_SOC_K3_AM62A7 entry from arch/arm/mach-k3/Mak

Re: [PATCH] arm: mach-k3: am62a7: Provide a way to obtain boot device for non SPLs

2024-10-31 Thread Garrett Giordano
Hey Bryan! On 10/30/24 14:54, Bryan Brattlof wrote: Hi Garrett! On October 30, 2024 thus sayeth Garrett Giordano: Introduce get_boot_device() to obtain the booting device. Make it also available for non SPL builds so u-boot can also know the device it is booting from. All looks good but I'm

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Tom Rini
On Sat, 26 Oct 2024 22:16:18 +0200, Marek Vasut wrote: > Remove undocumented nor->addr_width == 3 test. This was added in commit > 5d40b3d384dc ("mtd: spi-nor: Add parallel and stacked memories support") > without any explanation in the commit message. Remove it. > > This also has a bad side-effe

Re: Pull request efi-2025-01-rc2

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 08:01:45AM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 5cca0e3f6e0ff17db92476235ea1bb9cd8cbc9eb: > > Merge tag 'u-boot-imx-master-20241029' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2024-10-29 18:46:08 > -0600) >

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Tom Rini
On Thu, Oct 31, 2024 at 02:39:14PM +0100, Marek Vasut wrote: > On 10/31/24 8:10 AM, Tudor Ambarus wrote: > > > > > > On 10/30/24 4:56 PM, Tom Rini wrote: > > > On Wed, Oct 30, 2024 at 04:20:32PM +0100, Michal Simek wrote: > > > > > > > > > > > > On 10/30/24 15:49, Tudor Ambarus wrote: > > > > >

Re: [PATCH v2] arm: mach-k3: am62a7: Provide a way to obtain boot device for non SPLs

2024-10-31 Thread Andrew Davis
On 10/31/24 11:21 AM, Garrett Giordano wrote: Introduce get_boot_device() to obtain the booting device. Make it also available for non SPL builds so u-boot can also know the device it is booting from. Signed-off-by: Garrett Giordano Reviewed-by: Bryan Brattlof --- Seems similar enough to wha

Re: [PATCH v4 2/2] board: rockchip: Add support for rk3588 GenBook

2024-10-31 Thread Kever Yang
On 2024/10/30 20:09, Andy Yan wrote: Add support for Cool Pi GenBook, it works as a carrier board connect with CM5 SOM. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3.0 Host x 1 - USB-C 3.0 with DisplayPort AltMode - PCIE M.2 E Key for RTL8852BE W

Re: [PATCH] usb: Fix test dependency on ext4write command

2024-10-31 Thread Marek Vasut
On 10/31/24 12:20 PM, Andrew Goodbody wrote: On 16/10/2024 07:33, Kumar, Love wrote: Reviewed-by: Love Kumar On 15/10/24, 10:25 PM, Marek Vasut wrote: On 10/15/24 4:17 PM, Andrew Goodbody wrote: The tests test_usb_ext4load_ext4write, test_usb_ext2load and test_usb_load depend on the command

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Marek Vasut
On 10/31/24 7:56 AM, Tudor Ambarus wrote: Hi, Michal, Hi, On 10/30/24 3:20 PM, Michal Simek wrote: Jagan is aware that we are using this configuration for quite a long time and we are still here and not leaving. Okay, great. Would be good if you/your team can allocate time and review/test

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Marek Vasut
On 10/31/24 8:10 AM, Tudor Ambarus wrote: On 10/30/24 4:56 PM, Tom Rini wrote: On Wed, Oct 30, 2024 at 04:20:32PM +0100, Michal Simek wrote: On 10/30/24 15:49, Tudor Ambarus wrote: On 10/30/24 2:17 PM, Jagan Teki wrote: On Wed, Oct 30, 2024 at 4:15 PM Tudor Ambarus wrote: On 10/30/

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Tudor Ambarus
On 10/30/24 4:56 PM, Tom Rini wrote: > On Wed, Oct 30, 2024 at 04:20:32PM +0100, Michal Simek wrote: >> >> >> On 10/30/24 15:49, Tudor Ambarus wrote: >>> >>> >>> On 10/30/24 2:17 PM, Jagan Teki wrote: On Wed, Oct 30, 2024 at 4:15 PM Tudor Ambarus wrote: > > > > On 10/

Re: [PATCH] libfdt: Fix build with swig 4.3.0

2024-10-31 Thread Rob Herring
On Tue, Oct 29, 2024 at 8:10 PM David Gibson wrote: > > On Tue, Oct 29, 2024 at 08:52:52PM +0800, Xi Ruoyao wrote: > > On Sat, 2024-10-26 at 12:34 +, Rudi Heitbaum wrote: > > > Call SWIG_AppendOutput instead of SWIG_Python_AppendOutput so that > > > is_void is handled within swig. > > > > > >

Re: [PATCH] usb: Fix test failure with multiple partitions

2024-10-31 Thread Andrew Goodbody
On 16/10/2024 11:14, Kumar, Love wrote: On 15/10/24, 10:25 PM, Marek Vasut wrote: On 10/15/24 2:19 PM, Andrew Goodbody wrote: When test_usb_load finds multiple partitions of the same type then it will cause a test failure. The call to write the test file will write a different test file to eac

Re: [PATCH] usb: Fix test dependency on ext4write command

2024-10-31 Thread Andrew Goodbody
On 16/10/2024 07:33, Kumar, Love wrote: Reviewed-by: Love Kumar On 15/10/24, 10:25 PM, Marek Vasut wrote: On 10/15/24 4:17 PM, Andrew Goodbody wrote: The tests test_usb_ext4load_ext4write, test_usb_ext2load and test_usb_load depend on the command ext4write being present not just the feature

Re: [PATCH 1/3] configs: rockchip: enable RK806 SPI PMIC for Radxa ROCK 5A

2024-10-31 Thread Quentin Schulz
Hi Naoki, On 10/31/24 4:22 AM, FUKAUMI Naoki wrote: enable RK806 SPI PMIC driver and related cmd/configs for Radxa ROCK 5A. Signed-off-by: FUKAUMI Naoki --- configs/rock5a-rk3588s_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configs/rock5a-rk3588s_defconfig b/configs/

Re: [PATCH v2 2/2] rockchip: add support for Radxa ROCK 5A with SPI NOR flash module

2024-10-31 Thread Quentin Schulz
Hi Naoki, On 10/30/24 11:22 PM, FUKAUMI Naoki wrote: Hi, On 10/30/24 19:39, Quentin Schulz wrote: Hi Naoki, On 10/30/24 4:09 AM, FUKAUMI Naoki wrote: Hi, could you review this patch, anyone? Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 8/25/24 07:33, FUKAUMI Naok

回复: [EXT] Re: [PATCH 08/17] scmi_protocols: update struct scmi_base_discover_list_protocols_out

2024-10-31 Thread Alice Guo (OSS)
Hi Tom, > -邮件原件- > 发件人: Tom Rini > 发送时间: 2024年10月17日 2:07 > 收件人: Alice Guo (OSS) > 抄送: Lukasz Majewski ; Sean Anderson > ; Stefano Babic ; Fabio Estevam > ; Marek Vasut ; dl-uboot-imx > ; u-boot@lists.denx.de; Ye Li ; Alice > Guo > 主题: [EXT] Re: [PATCH 08/17] scmi_protocols: update stru

[RFC PATCH] mkimage: Allow -o to set hash algorithm in auto mode

2024-10-31 Thread Joel Stanley
Users would like to be able to create a FIT with hashed images using using a given algorithm in auto mode. Allow them to use the existing -o option for this. In commit b93a65209c4a ("mkimage: fit: Support signed configurations in 'auto' FITs"), the examples lead me to believe this was already the

[PATCH] lib: rsa: Set conventional salt length RSA-PSS parameter

2024-10-31 Thread Loic Poulain
RFC 3447 says that Typical salt length are either 0 or the length of the output of the digest algorithm, RFC 4055 also recommends hash value length as the salt length. Moreover, By convention, most of the signing infrastructures/libraries use the length of the digest algorithm (such as google cloud

Re: [PATCH v1 1/1] drivers: bootcount: Add ZynqMP specific bootcount support

2024-10-31 Thread Michal Simek
On 10/30/24 17:04, Vasileios Amoiridis wrote: On Wed, Oct 30, 2024 at 04:49:10PM +0100, Michal Simek wrote: On 10/30/24 15:38, Vasileios Amoiridis wrote: On Wed, Oct 30, 2024 at 02:13:43PM +0100, Michal Simek wrote: On 10/29/24 19:58, Vasileios Amoiridis wrote: From: Vasileios Amoiridi

Re: [PATCH v3 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2024-10-31 Thread Kever Yang
Hi Lukasz, Quentin, On 2024/10/25 22:56, Quentin Schulz wrote: Hi Lukasz, On 10/25/24 4:27 PM, Łukasz Czechowski wrote: Hi, On 2024/10/25 14:30, Kever Yang wrote: Hi Tom,   This is regression of "#ifdef CONFIG", is it possible for us to go back to use "#ifdef CONFIG" in this case? O

Re: [PATCH v4 1/2] arm64: dts: rockchip: Add support for rk3588 based Cool Pi CM5 GenBook

2024-10-31 Thread Kever Yang
On 2024/10/30 20:09, Andy Yan wrote: Cool Pi CM5 GenBook works as a carrier board connect with CM5 [0]. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3.0 Host x 1 - USB-C 3.0 with DisplayPort AltMode - PCIE M.2 E Key for RTL8852BE Wireless connecti

Re: [PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

2024-10-31 Thread Michal Simek
On 10/30/24 17:56, Tom Rini wrote: On Wed, Oct 30, 2024 at 04:20:32PM +0100, Michal Simek wrote: On 10/30/24 15:49, Tudor Ambarus wrote: On 10/30/24 2:17 PM, Jagan Teki wrote: On Wed, Oct 30, 2024 at 4:15 PM Tudor Ambarus wrote: On 10/30/24 10:33 AM, Jagan Teki wrote: Hi Marek, O

Pull request efi-2025-01-rc2

2024-10-31 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit 5cca0e3f6e0ff17db92476235ea1bb9cd8cbc9eb: Merge tag 'u-boot-imx-master-20241029' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2024-10-29 18:46:08 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/