Hi Sebastian, On 2024-10-31 19:15, Eugen Hristev wrote: > Hello Sebastian, > > On 10/31/24 20:01, Sebastian Reichel wrote: >> PCI enumeration is required to detect the onboard Ethernet device. >> >> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.com> >> --- >> configs/rock5b-rk3588_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configs/rock5b-rk3588_defconfig >> b/configs/rock5b-rk3588_defconfig >> index c54e13e8732c..e5b9f7d326b4 100644 >> --- a/configs/rock5b-rk3588_defconfig >> +++ b/configs/rock5b-rk3588_defconfig >> @@ -17,6 +17,7 @@ CONFIG_DEBUG_UART_CLOCK=24000000 >> CONFIG_SPL_SPI_FLASH_SUPPORT=y >> CONFIG_SPL_SPI=y >> CONFIG_PCI=y >> +CONFIG_PCI_INIT_R=y >> CONFIG_DEBUG_UART=y >> CONFIG_AHCI=y >> CONFIG_FIT=y > > This has been added and removed before, please see > > https://lore.kernel.org/all/20231104130451.111020-1-martin.rouk...@mupuf.org/T/ > > this commit adds it > 5b269ed404dc ("configs: rockchip: rock5b-rk3588: Enable CONFIG_PCI_INIT_R") > > this commit removes it again > 191ece249a96 ("rockchip: rk3588-rock-5b: Enable support for PCIe SATA > cards")
What use-case are you trying to solve with a forced pci enumeration? With standard boot Ethernet should be enabled when it is needed. However for EFI boot Ethernet maybe is not detected? Please see [1] for a possible alternative patch that I created when someone reported an issue with iPXE boot some time ago. I did not get confirmation it fully solved the issue, from what I could test it should help get Ethernet detected during EFI boot on a ROCK 5B. [1] https://github.com/Kwiboo/u-boot-rockchip/commit/90b6d787de0b3e6ed863440be576b01d83ba5789 Regards, Jonas > > Eugen > >
