Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-09 Thread AKASHI Takahiro
On Thu, Feb 10, 2022 at 12:48:13PM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Thu, 10 Feb 2022 at 08:18, AKASHI Takahiro > wrote: > > > > Hi Sughosh, > > > > On Mon, Feb 07, 2022 at 11:49:55PM +0530, Sughosh Ganu wrote: > > > The FWU Multi Banks Update feature allows updating different type

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread Ilias Apalodimas
On Thu, Feb 10, 2022 at 04:41:15PM +0900, AKASHI Takahiro wrote: > On Thu, Feb 10, 2022 at 09:33:46AM +0200, Ilias Apalodimas wrote: > > > > > > msg = pkcs7_parse_message(auth, auth_size); > > > > [...] > > > > > > > > @@ -717,32 +665,32 @@ static bool efi_image_authenticate(void *efi

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread AKASHI Takahiro
On Thu, Feb 10, 2022 at 09:33:46AM +0200, Ilias Apalodimas wrote: > > > > > msg = pkcs7_parse_message(auth, auth_size); > > [...] > > > > > > @@ -717,32 +665,32 @@ static bool efi_image_authenticate(void *efi, > > > > > size_t efi_size) > > > > >*/ > > > > >

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread AKASHI Takahiro
On Thu, Feb 10, 2022 at 09:13:34AM +0200, Ilias Apalodimas wrote: > On Thu, Feb 10, 2022 at 02:13:48PM +0900, AKASHI Takahiro wrote: > > Hi Ilias, > > > > Thank you for reviewing the logic. > > > > On Fri, Feb 04, 2022 at 09:32:01AM +0200, Ilias Apalodimas wrote: > > > The EFI spec allows for ima

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread Ilias Apalodimas
> > > > msg = pkcs7_parse_message(auth, auth_size); [...] > > > > @@ -717,32 +665,32 @@ static bool efi_image_authenticate(void *efi, > > > > size_t efi_size) > > > > */ > > > > /* try black-list first */ > > > > if (efi_signature_

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread Heinrich Schuchardt
On 2/10/22 08:13, Ilias Apalodimas wrote: On Thu, Feb 10, 2022 at 02:13:48PM +0900, AKASHI Takahiro wrote: Hi Ilias, Thank you for reviewing the logic. On Fri, Feb 04, 2022 at 09:32:01AM +0200, Ilias Apalodimas wrote: The EFI spec allows for images to carry multiple signatures. Currently we d

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-09 Thread AKASHI Takahiro
On Thu, Feb 10, 2022 at 09:14:25AM +0200, Ilias Apalodimas wrote: > Akashi-san > > On Thu, 10 Feb 2022 at 07:22, AKASHI Takahiro > wrote: > > > > On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > > > The previous patch is changing U-Boot's behavior wrt certificate based > > > bi

Re: converting IMX6 board to DM_ETH and DM_USB - usb_ether gadget support

2022-02-09 Thread Heiko Schocher
Hello Tim, On 10.02.22 01:45, Tim Harvey wrote: > On Mon, Feb 7, 2022 at 12:47 AM Heiko Schocher wrote: >> >> Hello Tim, >> >> On 28.01.22 07:06, Heiko Schocher wrote: >>> Hello Tim, >>> >>> On 28.01.22 01:20, Tim Harvey wrote: On Fri, Jan 14, 2022 at 6:55 AM Heiko Schocher wrote: > >>>

Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-09 Thread Sughosh Ganu
hi Takahiro, On Thu, 10 Feb 2022 at 08:18, AKASHI Takahiro wrote: > > Hi Sughosh, > > On Mon, Feb 07, 2022 at 11:49:55PM +0530, Sughosh Ganu wrote: > > The FWU Multi Banks Update feature allows updating different types of > > updatable firmware images on the platform. These image types are > > id

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-09 Thread Ilias Apalodimas
Akashi-san On Thu, 10 Feb 2022 at 07:22, AKASHI Takahiro wrote: > > On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > > The previous patch is changing U-Boot's behavior wrt certificate based > > binary authentication. Specifically an image who's digest of a > > certificate is f

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread Ilias Apalodimas
On Thu, Feb 10, 2022 at 02:13:48PM +0900, AKASHI Takahiro wrote: > Hi Ilias, > > Thank you for reviewing the logic. > > On Fri, Feb 04, 2022 at 09:32:01AM +0200, Ilias Apalodimas wrote: > > The EFI spec allows for images to carry multiple signatures. Currently > > we don't adhere to the verificat

[PATCH 3/3] efi_loader: add menu-driven UEFI Boot Variable maintenance

2022-02-09 Thread Masahisa Kojima
This commit adds the menu-driven UEFI Boot Variable maintenance. User can add and delete the Boot variable, and update the BootOrder variable through menu operation. Signed-off-by: Masahisa Kojima --- lib/efi_loader/efi_bootmgr.c | 720 +++ 1 file changed, 720

[PATCH 2/3] lib/charset: add u16_strcat() function

2022-02-09 Thread Masahisa Kojima
Provide u16 string version of strcat(). Signed-off-by: Masahisa Kojima --- include/charset.h | 13 + lib/charset.c | 12 2 files changed, 25 insertions(+) diff --git a/include/charset.h b/include/charset.h index b93d023092..baba9d7c14 100644 --- a/include/charset.h

[PATCH 1/3] efi_loader: add menu-driven boot device selection

2022-02-09 Thread Masahisa Kojima
This patch enables the menu-driven boot device selection. User can select the Boot included in BootOrder variable. If user quits thie menu, or the selected Boot fails to boot, efi bootmgr continues to boot in accordance with BootOrder variable. Signed-off-by: Masahisa Kojima --- include

[PATCH 0/3] enable menu-driven boot device selection

2022-02-09 Thread Masahisa Kojima
This patch series adds the menu-driven boot device selection. This menu also provides the functionality to add and delete Boot variable, and edit the BootOrder variable. This menu appears with the command "bootefi bootmgr", the menu structure is as follows. * Menu structure [Boot Manager]

Re: [PATCH] arm: kirkwood: Pogoplug E02 : Convert Ethernet to Driver Model

2022-02-09 Thread Stefan Roese
On 2/9/22 03:56, Tony Dinh wrote: The Pogoplug E02 board has the network chip Marvell 88E1116R. Convert to Driver Model and use uclass mvgbe and the compatible driver M88E1118R to bring up Ethernet. - Add board_eth_init(), CONFIG_DM_ETH, and CONFIG_PHY_MARVELL to bring up Ethernet. - Currently,

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-09 Thread AKASHI Takahiro
On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > The previous patch is changing U-Boot's behavior wrt certificate based > binary authentication. Specifically an image who's digest of a > certificate is found in dbx is now rejected. Fix the test accordingly Please not only fix

Re: [RFC PATCH 1/2] efi_loader: fix dual signed image certification

2022-02-09 Thread AKASHI Takahiro
Hi Ilias, Thank you for reviewing the logic. On Fri, Feb 04, 2022 at 09:32:01AM +0200, Ilias Apalodimas wrote: > The EFI spec allows for images to carry multiple signatures. Currently > we don't adhere to the verification process for such images. In this patch, you're trying to do three things:

[PATCH v1 3/3] mach-sunxi: Enable spi boot for SUNIV

2022-02-09 Thread Jesse Taube
Enable spi boot in spl on suniv architecture. Signed-off-by: Jesse Taube --- arch/arm/mach-sunxi/Kconfig | 2 +- configs/licheepi_nano_defconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index 205fe3c9d3..d1

[PATCH v1 2/3] mach-sunxi: Add spi boot for SUNIV

2022-02-09 Thread Jesse Taube
Add support for the spi boot in spl on suniv architecture. Signed-off-by: Jesse Taube --- arch/arm/include/asm/arch-sunxi/gpio.h | 1 + arch/arm/mach-sunxi/spl_spi_sunxi.c| 26 +++--- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/arch/arm/include/asm/ar

[PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-09 Thread Jesse Taube
Use Samuel's suggestion of looking at the BootRom's stack to determine the boot device. Signed-off-by: Jesse Taube Suggested-by: Samuel Holland --- arch/arm/include/asm/arch-sunxi/spl.h | 15 arch/arm/mach-sunxi/board.c | 50 --- 2 files changed, 38 in

[PATCH v1 0/3] Add spi boot to SPL on SUNIV

2022-02-09 Thread Jesse Taube
This patch adds the ability to detect the BROM's boot source as well as the ability to boot from spi. Jesse Taube (3): mach-sunxi: Add boot device detection for SUNIV mach-sunxi: Add spi boot for SUNIV mach-sunxi: Enable spi boot for SUNIV arch/arm/include/asm/arch-sunxi/gpio.h | 1 + arc

[PATCH] arm: dts: k3-j721e-r5-common-proc-board: tps659413: Correct the min/max voltages of VDD_CPU

2022-02-09 Thread Keerthy
Correct the min/max voltages of VDD_CPU. As per data sheet the VDD_CPU minimum voltage is .6V & maximum voltage is .9V. Correct the same. While at it fix the comment to reflect VDD_CPU instead of VDD_MPU. Data Sheet Link: https://www.ti.com/lit/gpn/dra829v Signed-off-by: Keerthy --- arch/arm/d

Re: [PATCH 03/19] mmc: call device_probe() after scanning

2022-02-09 Thread AKASHI Takahiro
On Wed, Feb 09, 2022 at 08:46:18AM +0900, Jaehoon Chung wrote: > On 2/2/22 10:08, AKASHI Takahiro wrote: > > Every time a mmc bus/port is scanned and a new device is detected, > > we want to call device_probe() as it will give us a chance to run > > additional post-processings for some purposes. >

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-09 Thread Masami Hiramatsu
2022年2月10日(木) 10:43 Masami Hiramatsu : > > > > > > Of course as I said in the other thread, I would like to put the > > > > > dfu_alt_info like information in the devicetree too. > > > > > (But it maybe different from this discussion) > > > > > > > > Just curious, why do you need to define a variab

Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-09 Thread AKASHI Takahiro
Hi Sughosh, On Mon, Feb 07, 2022 at 11:49:55PM +0530, Sughosh Ganu wrote: > The FWU Multi Banks Update feature allows updating different types of > updatable firmware images on the platform. These image types are > identified using the ImageTypeId GUID value. Add support in the > GetImageInfo func

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-09 Thread Masami Hiramatsu
Hi Sughosh, 2022年2月10日(木) 3:40 Sughosh Ganu : > > hi Masami, > > On Wed, 9 Feb 2022 at 17:18, Masami Hiramatsu > wrote: > > > > Hi Sughosh, > > > > 2022年2月9日(水) 18:03 Sughosh Ganu : > > > > > > hi Masami, > > > > > > On Wed, 9 Feb 2022 at 10:26, Masami Hiramatsu > > > wrote: > > > > > > > > Hi S

Re: [PATCH v4 10/11] mkeficapsule: Add support for generating empty capsules

2022-02-09 Thread AKASHI Takahiro
On Wed, Feb 09, 2022 at 12:05:06PM +0900, AKASHI Takahiro wrote: > Hi Sughosh, > > On Mon, Feb 07, 2022 at 11:50:00PM +0530, Sughosh Ganu wrote: > > The Dependable Boot specification describes the structure of the > > What is this specification? Please specify the link to the doc. > > > firmware

Re: converting IMX6 board to DM_ETH and DM_USB - usb_ether gadget support

2022-02-09 Thread Tim Harvey
On Mon, Feb 7, 2022 at 12:47 AM Heiko Schocher wrote: > > Hello Tim, > > On 28.01.22 07:06, Heiko Schocher wrote: > > Hello Tim, > > > > On 28.01.22 01:20, Tim Harvey wrote: > >> On Fri, Jan 14, 2022 at 6:55 AM Heiko Schocher wrote: > >>> > >>> Hello Tim, > >>> > >>> On 25.02.21 02:21, Tim Harvey

[PATCH v12] driver: spi: add bcm iproc qspi support

2022-02-09 Thread Roman Bacik
From: Rayagonda Kokatanur IPROC qspi driver supports both BSPI and MSPI modes. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Bharat Gooty Acked-by: Rayagonda Kokatanur Signed-off-by: Roman Bacik --- Changes in v12: - fix typo FLASH_BIT to FLUSH_BIT - return -EBUSY instead of -1 from bs

Re: Running qemu tests on RISC-V

2022-02-09 Thread Tom Rini
On Wed, Feb 09, 2022 at 11:20:51PM +0300, Alper Nebi Yasak wrote: > On 07/02/2022 19:49, Tom Rini wrote: > > And as an aside, if anyone has tips on changes that would need to be > > made to our Dockerfile so that some of those tools that let you run app > > from a container "normally" would work wi

[PATCH 1/1] video: bmp: Support x2r10g10b10 pixel format

2022-02-09 Thread Janne Grunau
Fixes the display of the u-boot logo on Apple silicon devices. Signed-off-by: Janne Grunau --- drivers/video/video_bmp.c | 70 +++ 1 file changed, 56 insertions(+), 14 deletions(-) diff --git a/drivers/video/video_bmp.c b/drivers/video/video_bmp.c index c8c3f

Re: Running qemu tests on RISC-V

2022-02-09 Thread Alper Nebi Yasak
On 09/02/2022 00:55, Simon Glass wrote: > Hi Alper, > > On Tue, 8 Feb 2022 at 14:36, Alper Nebi Yasak > wrote: >> If I run `touch fw_dynamic.bin` it no longer does, maybe check if such a >> file exists in your include paths. > > OK that is it, thanks. > > I think binman should remove the fake

Re: Running qemu tests on RISC-V

2022-02-09 Thread Alper Nebi Yasak
On 07/02/2022 19:49, Tom Rini wrote: > And as an aside, if anyone has tips on changes that would need to be > made to our Dockerfile so that some of those tools that let you run app > from a container "normally" would work with our container, that'd be > handy and appreciated. I also don't know wh

Please pull u-boot-dm (take 3)

2022-02-09 Thread Simon Glass
Hi Tom, This just drops off the final patch of 'take 2' since that is being reworked. running here: https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936 The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c: Merge branch '2022-02-08-Kconfig-updates' (2

Re: Please pull u-boot-dm (take 2)

2022-02-09 Thread Simon Glass
Hi Tom, Sorry, that's not right, let me try take 3. Regards, Simon On Wed, 9 Feb 2022 at 12:44, Simon Glass wrote: > > Hi Tom, > > I am sending this now, but the pipeline is still running: > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10933 > > > The following changes since

Please pull u-boot-dm (take 2)

2022-02-09 Thread Simon Glass
Hi Tom, I am sending this now, but the pipeline is still running: https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10933 The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c: Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500) are avail

[PATCH v2] binman: Skip processing "hash" subnodes of FIT subsections

2022-02-09 Thread Alper Nebi Yasak
Binman's FIT entry type can have image subentries with "hash" subnodes intended to be processed by mkimage, but not binman. However, the Entry class and any subclass that reuses its implementation tries to process these unconditionally. This can lead to an error when boards specify hash algorithms

lib.a in tools/env

2022-02-09 Thread rich_ogrady
Hello, It seems that lib.a doesn't get built correctly (at least for us) since u-boot-2020.10. In later versions the file is there in the folder but is rather small and unidentifiable as a valid archive. We build with options tools-only_defconfig, envtools, and NO_SDL=1 Any ideas? Regards, Ri

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-09 Thread Sughosh Ganu
hi Masami, On Wed, 9 Feb 2022 at 17:18, Masami Hiramatsu wrote: > > Hi Sughosh, > > 2022年2月9日(水) 18:03 Sughosh Ganu : > > > > hi Masami, > > > > On Wed, 9 Feb 2022 at 10:26, Masami Hiramatsu > > wrote: > > > > > > Hi Sughosh, > > > > > > While porting mdata-sf driver, I'm confusing on the device

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Joakim Tjernlund
On Wed, 2022-02-09 at 13:13 +, Andre Przywara wrote: > On Wed, 9 Feb 2022 14:05:57 +0100 > Michael Walle wrote: > > Hi, > > > > > The problem I have is that I boot a custom SOC into u-boot and when > > > > u-boot tries > > > > to boot linux I get an error exception when u-boot calls > > >

[PATCH v5 14/16] test: py: vboot: add test for global image signature

2022-02-09 Thread Philippe Reynes
Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 123 +++--- test/py/tests/vboot/sandbox-binman-pss.dts| 25 test/py/tests/vboot/sandbox-binman.dts| 24 .../tests/vboot/sandbo

[PATCH v5 16/16] configs: sandbox_defconfig: enable config CMD_VERIFY

2022-02-09 Thread Philippe Reynes
Enable the command verify on sandbox. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 2732b05ca7..483f01ef79 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_d

[PATCH v5 08/16] cmd: bootm: add a stage pre-load

2022-02-09 Thread Philippe Reynes
Add a stage pre-load to the command bootm. Right now, this stage may be used to read a header and check the signature of the full image. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- boot/bootm.c| 33 + cmd/Kconfig | 10 ++ cmd/bootm

[PATCH v5 11/16] Makefile: provide sah-key to binman

2022-02-09 Thread Philippe Reynes
Set the variable key-path with the shell variable KEY_PATH that contain the keys path (used for signature). This variable key-path is provided to binman. Signed-off-by: Philippe Reynes --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 1ee7089c52..dcc582d9

[PATCH v5 00/16] image: add a stage pre-load

2022-02-09 Thread Philippe Reynes
This serie adds a stage pre-load before launching an image. This stage is used to read a header before the image and this header contains the signature of the full image. So u-boot may check the full image before using any data of the image. The support of this header is added to binman, and a com

[PATCH v5 15/16] cmd: verify: initial import

2022-02-09 Thread Philippe Reynes
Add the command verify that check the signature of an image with the pre-load header. If the check succeed, the u-boot env variable 'loadaddr_verified' is set to the address of the image (without the header). It allows to run such commands: tftp script.img && verify $loadaddr && source $loadaddr_v

[PATCH v5 12/16] tools: binman: add support for pre-load header

2022-02-09 Thread Philippe Reynes
Adds the support of the pre-load header with the image signature to binman. Signed-off-by: Philippe Reynes --- tools/binman/etype/pre_load.py | 156 + 1 file changed, 156 insertions(+) create mode 100644 tools/binman/etype/pre_load.py diff --git a/tools/binman/e

[PATCH v5 07/16] boot: image: add a stage pre-load

2022-02-09 Thread Philippe Reynes
Add a stage pre-load that could check or modify an image. For the moment, only a header with a signature is supported. This header has the following format: - magic : 4 bytes - version : 4 bytes - header size : 4 bytes - image size : 4 bytes - offset image signature : 4 bytes - flags : 4 bytes - r

[PATCH v5 09/16] common: spl: fit_ram: allow to use image pre load

2022-02-09 Thread Philippe Reynes
Add the support of image pre load in spl or tpl when loading an image from ram. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- common/spl/spl_ram.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c

[PATCH v5 02/16] lib: Kconfig: enhance help for ASN1

2022-02-09 Thread Philippe Reynes
Enhance the help for configs ASN1_COMPILER and ASN1_decoder. Signed-off-by: Philippe Reynes --- lib/Kconfig | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 3c6fa99b1a..b0e5d60b3d 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -791

[PATCH v5 04/16] lib: allow to build asn1 decoder and oid registry in SPL

2022-02-09 Thread Philippe Reynes
This commit adds the options: - SPL_ASN1_DECODER - SPL_OID_REGISTRY Signed-off-by: Philippe Reynes --- lib/Kconfig | 19 +++ lib/Makefile | 7 +-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index e749826f22..effe735365 100644 -

[PATCH v5 03/16] lib: Kconfig: enhance the help of OID_REGISTRY

2022-02-09 Thread Philippe Reynes
Enhance the help for the config OID_REGISTRY. Signed-off-by: Philippe Reynes --- lib/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index b0e5d60b3d..e749826f22 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -812,6 +812,10 @@ config ASN1_DECODER config

[PATCH v5 06/16] lib: rsa: allow rsa verify with pkey in SPL

2022-02-09 Thread Philippe Reynes
This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. Signed-off-by: Philippe Reynes --- lib/rsa/Kconfig | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index be9775bcce..b773f17c26 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -

[PATCH v5 10/16] mkimage: add public key for image pre-load stage

2022-02-09 Thread Philippe Reynes
This commit enhances mkimage to update the node /image/pre-load/sig with the public key. Signed-off-by: Philippe Reynes --- include/image.h| 15 ++ tools/fit_image.c | 3 ++ tools/image-host.c | 114 + 3 files changed, 132 insertions(+) di

[PATCH v5 13/16] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-02-09 Thread Philippe Reynes
Enable the support of stage pre-load in bootm. For the moment, this stage allow to verify the signature of the full image with a header. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox

[PATCH v5 05/16] lib: crypto: allow to build crypyo in SPL

2022-02-09 Thread Philippe Reynes
This commit adds the options: - SPL_ASYMMETRIC_KEY_TYPE - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE - SPL_RSA_PUBLIC_KEY_PARSER Signed-off-by: Philippe Reynes --- lib/Makefile| 3 ++- lib/crypto/Kconfig | 29 + lib/crypto/Makefile | 19 +-- 3 files c

[PATCH v5 01/16] arch: Kconfig: imply BINMAN for SANDBOX

2022-02-09 Thread Philippe Reynes
To be able to use BINMAN on sandbox, the config SANDBOX imply BINMAN. Signed-off-by: Philippe Reynes --- arch/Kconfig | 1 + arch/sandbox/dts/sandbox.dtsi | 3 +++ arch/sandbox/dts/test.dts | 3 +++ test/py/tests/test_fit.py | 3 +++ t

Re: [PATCH] Replace echo -n's used in environment processing with touch

2022-02-09 Thread Simon Glass
Hi Qthedev, On Wed, 9 Feb 2022 at 08:25, qthedev wrote: > > On Monday, February 7th, 2022 at 11:22 PM, Simon Glass > wrote: > > > Hi, > > > > On Sat, 5 Feb 2022 at 06:49, qthedev qthe...@protonmail.com wrote: > > > > > echo -n does not give the intended effect when invoked in macOS through > >

Re: [PATCH v3 07/18] pxe: Move pxe_utils files

2022-02-09 Thread Simon Glass
Hi, On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > > > > > Move the header file into the main include/ directory so we can use it > > > from the bootmethod code. Move the C fil

[PATCH] scripts: dtc: libfdt: fdt_ro.c: always define fdt_check_full

2022-02-09 Thread Philippe Reynes
On some configs (like stm32mp15_dhcom_basic_defconfig), if configs SPL_LOAD_FIT_FULL and SPL_FIT_FULL_CHECK are enabled. Then the compilatio fails with the following error: arm-linux-gnueabi-ld.bfd: boot/image-fit.o: in function `fit_check_format': /uboot/u-boot-stm/boot/image-fit.c:1641: undefine

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-02-09 Thread Mark Kettenis
> Date: Wed, 9 Feb 2022 17:09:50 +0100 > From: Pali Rohár > > On Monday 07 February 2022 11:48:29 Alistair Delva wrote: > > On Mon, Feb 7, 2022 at 11:39 AM Pali Rohár wrote: > > > > > > PING! Could you look at this email? > > > > > > On Thursday 20 January 2022 14:48:34 Pali Rohár wrote: > > > >

Re: [PATCH 7/8] Convert CONFIG_SCSI_AHCI_PLAT et al to Kconfig

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:37AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SCSI_AHCI_PLAT >CONFIG_SYS_SCSI_MAX_SCSI_ID >CONFIG_SYS_SCSI_MAX_LUN >CONFIG_SYS_SATA_MAX_DEVICE > > Drop CONFIG_SCSI for everything except the sandbox build. We only nee

Re: [PATCH 8/8] dm: scsi: Add a migration deadline for scsi

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:38AM -0700, Simon Glass wrote: > Very few boards remain to be migrated: > >am57xx_hs_evm_usb >controlcenterdc >highbank >ls1021atsn_qspi >ls1021atsn_sdcard >ls1021atwr_sdcard_ifc_SECURE_BOOT >ls1046ardb_sdcard_SECURE_BOOT >ls1088ardb_s

Re: [PATCH 6/8] scsi: Drop CONFIG_SYS_SCSI_MAX_DEVICE

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:36AM -0700, Simon Glass wrote: > This is defined based on two other CONFIGs for all boards except sandbox > and durian. > > For sandbox the value does not matter. For durian the value seems > excessive. > > Drop the option completely, to simplify configuration and r

Re: [PATCH 5/8] ahci: Make ahci drivers depend on AHCI

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:35AM -0700, Simon Glass wrote: > At present all ahci drivers depend on AHCI except for DWC_AHCI. But no > boards enable that without also enabling AHCI: > >/tools/moveconfig.py -f ~AHCI DWC_AHCI >0 matches > > Group them together and sort them in order by Kc

Re: [PATCH 4/8] sata: sata_sil: Only support BLK

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:34AM -0700, Simon Glass wrote: > No boards use this driver without CONFIG_BLK, so clean up the dead code. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/8] sata: Rearrange Kconfig for SATA

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:33AM -0700, Simon Glass wrote: > Move the SATA options inside an 'if SATA' part, so they are grouped. > > Fix the 'Complient' typo while we are here. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature

Re: [PATCH 2/8] sata: Only support BLK

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:32AM -0700, Simon Glass wrote: > No boards currently use SATA without BLK: > >./tools/moveconfig.py -f SATA ~BLK >0 matches > > Make SATA depend on BLK to avoid any future confusion. Drop the dead code. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan

Re: [PATCH 1/8] sata: Drop Silicon Image SIL3114 SATA driver

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:31AM -0700, Simon Glass wrote: > This is not used in U-Boot and has not been converted to driver model. > Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] Convert CONFIG_REMAKE_ELF to Kconfig

2022-02-09 Thread Tom Rini
On Sat, Jan 29, 2022 at 06:25:30PM +0300, Alper Nebi Yasak wrote: > This converts the following to Kconfig: >CONFIG_REMAKE_ELF > > Signed-off-by: Alper Nebi Yasak Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/3] Drop CONFIG_SYS_PIO_MODE

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:53:25AM -0700, Simon Glass wrote: > This option is not used in U-Boot. Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/3] Convert CONFIG_SYS_IDE_MAXBUS et al to Kconfig

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:53:24AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SYS_IDE_MAXBUS >CONFIG_SYS_IDE_MAXDEVICE >CONFIG_SYS_ATA_BASE_ADDR >CONFIG_SYS_ATA_STRIDE >CONFIG_SYS_ATA_DATA_OFFSET >CONFIG_SYS_ATA_REG_OFFSET >CONFIG_SYS_AT

Re: [PATCH 1/3] ide: Drop CONFIG_IDE_AHB

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:53:23AM -0700, Simon Glass wrote: > This is not used in U-Boot anymore. Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 12/13] buildman: Allow adjusting board config on the fly

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:33AM -0700, Simon Glass wrote: > Add a -a option to specify changes to the config before the build > commences. For example > >buildman -a ~CONFIG_CMDLINE > > disables CONFIG_CMDLINE before doing the build. > > This makes it easier to try things out as well as

Re: [PATCH v5 11/13] buildman: Provide a hint on how to debug thread crashes

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:32AM -0700, Simon Glass wrote: > If a thread crashes it is helpful to try the operation again with > threading disabled. Add a hint about that. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 10/13] buildman: Add helper functions for updating .config files

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:31AM -0700, Simon Glass wrote: > At present the only straightforward way to write tests that need a > slightly different configuration is to create a new board with its own > configuration. This is cumbersome. > > It would be useful if buildman could adjust the confi

Re: [PATCH v5 09/13] buildman: Make use of test_util

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:30AM -0700, Simon Glass wrote: > Use test_util to run the tests, with the ability to select a single test > to run, if desired. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 08/13] buildman: Add a flag to control the traceback

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:29AM -0700, Simon Glass wrote: > At present the full horror of the Python traceback is shown by default. It > is normally only useful for debugging. Turn it off by default and add a > --debug flag to enable it. > > Signed-off-by: Simon Glass Applied to u-boot/maste

Re: [PATCH v5 07/13] patman: Update test_util to run doc tests

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:28AM -0700, Simon Glass wrote: > At present this function does not run the doctests. Allow the caller to > pass these modules in as strings. > > Update patman to use this. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc De

Re: [PATCH v5 06/13] bloblist: Update to use conditional value

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:27AM -0700, Simon Glass wrote: > Use the new IF_ENABLED_INT() feature to avoid needing our own inline > function to handle this case. Tidy up the logic to ensure that the value > is only used when present. Update the 'expected' comment also. > > Signed-off-by: Simon

Re: [PATCH v5 05/13] kconfig: Add support for conditional values

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:26AM -0700, Simon Glass wrote: > At present if an optional Kconfig value needs to be used it must be > bracketed by #ifdef. For example, with this Kconfig setup: > > config WIBBLE > bool "Support wibbles, the world needs more wibbles" > > config WIBBLE_ADDR >

Re: [PATCH v5 04/13] kconfig: Update IS_ENABLED() internals

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:25AM -0700, Simon Glass wrote: > The config_enabled() macro currently uses 0 as the default value. Update > it to allow any value, so we can pass it something else, such as a > non-existent function, to produce a build error if it is not defined. > > Also tidy up the

Re: [PATCH v5 03/13] mmc: fsl: Use brackets around if()

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:24AM -0700, Simon Glass wrote: > At present the IS_ENABLED() macro has extra brackets, making it possible > to write: > >if IS_ENABLED(CONFIG_XXX) > > but it is a bit confusing. Add the missing brackets. > > Signed-off-by: Simon Glass > Reviewed-by: Jaehoon Ch

Re: [PATCH v5 02/13] mips: Avoid using config_enabled() directly

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:23AM -0700, Simon Glass wrote: > Use IS_ENABLED() instead, which is the correct macro for checking a CONFIG > option. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 01/13] imx: Don't define __ASSEMBLY__ in source files

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:22AM -0700, Simon Glass wrote: > This is supposed to be a build-system flag. Move it there so we can > define it before linux/kconfig.h is included. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-02-09 Thread Pali Rohár
On Wednesday 09 February 2022 08:24:27 Alistair Delva wrote: > On Wed, Feb 9, 2022 at 8:09 AM Pali Rohár wrote: > > > > On Monday 07 February 2022 11:48:29 Alistair Delva wrote: > > > On Mon, Feb 7, 2022 at 11:39 AM Pali Rohár wrote: > > > > > > > > PING! Could you look at this email? > > > > > >

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-02-09 Thread Pali Rohár
On Monday 07 February 2022 11:48:29 Alistair Delva wrote: > On Mon, Feb 7, 2022 at 11:39 AM Pali Rohár wrote: > > > > PING! Could you look at this email? > > > > On Thursday 20 January 2022 14:48:34 Pali Rohár wrote: > > > Hello Alistair! > > > > > > On Wednesday 19 January 2022 14:48:21 Alistair

Re: [PATCH v4 06/11] remoteproc: uclass: Add remoteproc resource handling helpers

2022-02-09 Thread Amjad Ouled-Ameur
Hi Simon, Thank you for your feedback. Since the patchset has already been applied, I will address your comments in follow-up patches. Kindly, Amjad On 27/01/2022 16:43, Simon Glass wrote: Hi Amjad, On Thu, 27 Jan 2022 at 05:17, Amjad Ouled-Ameur wrote: From: Keerthy Add remoteproc re

[PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

2022-02-09 Thread Daniel Klauer
The miiphy_read/miiphy_write functions return 1 on error, not -errno. Fix up the checks accordingly and insert -EIO as fallback error code. Signed-off-by: Daniel Klauer --- drivers/net/phy/mv88e6352.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git

[PATCH 1/2] miiphyutil: Fix inconsistent miiphy_write() error return value

2022-02-09 Thread Daniel Klauer
miiphy_write() should not directly return the error return value from bus->write(), because that is typically a -errno value, while generally miiphy_write() and other miiphy_*() functions return 1 on error. Some miiphy_write() callers only check for > 0 to detect errors. Fix it to match miiphy_rea

[PATCH] lx2160a: Fix distroboot device list for configs without USB/SCSI/etc

2022-02-09 Thread Daniel Klauer
The BOOT_TARGET_DEVICES list for distro_bootcmd was hard-coded to assume that all boot devices are available/enabled in the configuration, thus ignoring the actual config settings. The config_distro_bootcmd.h header file specifically has compile-time checks to detect such problems. To allow disabl

Re: [PATCH v5 13/13] test: Add some tests for kconfig.h

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:34AM -0700, Simon Glass wrote: > The macros in this file are a little confusing and we currently have no > tests to check that they work as expected. > > Add some tests which check the macros in C code. Add a few tests which > check that the build errors are generate

Re: commit leads to failure while writing env to sdcard (MMC1) on my imx8mq board

2022-02-09 Thread Heiko Thiery
Hi Fabio, Am Mi., 9. Feb. 2022 um 15:20 Uhr schrieb Fabio Estevam : > > Hi Heiko, > > On Wed, Feb 9, 2022 at 11:11 AM Heiko Thiery wrote: > > > > Hi Sean, > > > > I tried the latest U-boot master and faced an issue with your commit. > > I was able to do a bisect and see that it comes from > > 41

Re: commit leads to failure while writing env to sdcard (MMC1) on my imx8mq board

2022-02-09 Thread Fabio Estevam
Hi Heiko, On Wed, Feb 9, 2022 at 11:11 AM Heiko Thiery wrote: > > Hi Sean, > > I tried the latest U-boot master and faced an issue with your commit. > I was able to do a bisect and see that it comes from > 41c6a22fc2963bfc76fc2aa21f572ceb0c5a4e22 (mmc: fsl_esdhc_imx: simplify > esdhc_setup_data()

Re: [PATCH V8] arm: add initial support for the Phytium Pomelo Board

2022-02-09 Thread Rob Herring
is only On Mon, Jan 10, 2022 at 7:49 PM wrote: > > From: weichangzheng > > This adds platform code and the device tree for the Phytium Pomelo Board. > The initial support comprises the UART and the PCIE. > > Signed-off-by: weichangzheng > Changes since v1: > updated to DT > Changes sinc

commit leads to failure while writing env to sdcard (MMC1) on my imx8mq board

2022-02-09 Thread Heiko Thiery
Hi Sean, I tried the latest U-boot master and faced an issue with your commit. I was able to do a bisect and see that it comes from 41c6a22fc2963bfc76fc2aa21f572ceb0c5a4e22 (mmc: fsl_esdhc_imx: simplify esdhc_setup_data() ). Is someone able to confirm that? 8< Hit any key to stop au

Re: [PATCH 3/3] net: xilinx: Force a probe failure if it cannot setup phy

2022-02-09 Thread Andy Chiu
Dear Maintainers, I am sending this email to check if this patch was missed. I would be really appreciated if I get any suggestion from you, thanks! Best regards Andy On Thu, Jan 20, 2022 at 3:35 PM Andy Chiu wrote: > > Or we may get load access faults afterward. > > The `phydev` field on axi-e

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Andre Przywara
On Wed, 9 Feb 2022 14:05:57 +0100 Michael Walle wrote: Hi, > >> The problem I have is that I boot a custom SOC into u-boot and when u-boot > >> tries > >> to boot linux I get an error exception when u-boot calls > >> armv8_switch_to_el2 to enter linux. > > > > So that means that U-Boot runs

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Michael Walle
>> The problem I have is that I boot a custom SOC into u-boot and when u-boot >> tries >> to boot linux I get an error exception when u-boot calls armv8_switch_to_el2 >> to enter linux. > > So that means that U-Boot runs in EL3, is that the first and only firmware > that you run? I think the EL3

  1   2   >