Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Rasmus Villemoes
On 12/01/2022 22.56, Tom Rini wrote: > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: >> Hi Ilias, >> >> On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas >> wrote: >>> >>> On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: At present if an optional Kconfig value needs to be used

[PATCH] net: fastboot: make UDP port net: configurable

2022-01-12 Thread Christian Gmeiner
The fastboot protocol uses per default the UDP port 5554. In some cases it might be needed to change the used port. The fastboot utility provides a way to specifiy an other port number to use already. fastboot -s udp:192.168.1.76:1234 boot fastboot.img Signed-off-by: Christian Gmeiner --- dri

Re: [PATCH V3] sf: Querying write-protect status before operating the flash

2022-01-12 Thread Jan Kiszka
On 17.11.21 12:59, Tom Rini wrote: On Wed, Nov 17, 2021 at 01:43:28PM +0530, Jagan Teki wrote: On Wed, Nov 17, 2021 at 1:33 PM Michael Walle wrote: Hi, Am 2021-11-17 03:48, schrieb chaochao2021...@163.com: From: chao zeng When operating the write-protection flash,spi_flash_std_write() and

Re: [PATCH u-boot-marvell v2] arm: mvebu: turris_omnia: Fixup SATA or PCIe nodes at runtime in DT blob

2022-01-12 Thread Stefan Roese
On 1/10/22 11:47, Marek Behún wrote: From: Pali Rohár On of the MiniPCIe ports on Turris Omnia is also a mSATA port. Whether it works in SATA or PCIe mode is determined by a strapping pin, which value is read from the MCU. We already determine which type of card is connected when configuring S

Re: [PATCH u-boot-marvell] ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision

2022-01-12 Thread Chris Packham
On Thu, 13 Jan 2022, 7:29 PM Stefan Roese, wrote: > +Cc Chris > > On 1/12/22 17:06, Marek Behún wrote: > > From: Marek Behún > > > > This is a cleaned up and fixed version of a patch > >mv_ddr: a380: fix SPLIT_OUT_MIX state decision > > > >in each pattern cycle the bus state can be chang

Re: [PATCH] arm: mvebu: Replace hardcoded values 0x0030/0x4030 by proper calculation

2022-01-12 Thread Stefan Roese
On 1/12/22 18:32, Pali Rohár wrote: These hardcoded values were calculated from CONFIG_SPL_TEXT_BASE macro. Now this macro is configurable via Kconfig, so calculate values 0x0030/0x4030 at compile time via CONFIG_SPL_TEXT_BASE option. Values 0x0030/0x4030 represents offset of CONFIG_SPL_TEXT_BASE

Re: [PATCH] arm: mvebu: db-88f6720: Fix CONFIG_SPL_TEXT_BASE and remove wrong memory layout

2022-01-12 Thread Stefan Roese
On 1/12/22 18:30, Pali Rohár wrote: Memory layout in the comment is from Armada XP platform which uses load address 0x40004030. DB-88f6720 is Armada 375 platform which uses same load address as Armada 38x which is 0x4030. Currently SPL support for Armada 375 is unfinished and does not work.

Re: [PATCH u-boot-marvell v2 20/20] tools: kwbimage: Fix mkimage/dumpimage -l argument

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Do not check for kwbimage configuration file when just showing information about existing kwbimage file. The check for kwbimage configuration file is required only when creating kwbimage, not when showing information about image or when extracting data from im

Re: [PATCH u-boot-marvell v2 19/20] tools: kwbimage: Extract main data image without -p arg for dumpimage

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: When there is no -p argument for dumpimage tool specified, extract the main data image from kwbimage file. This makes dumpimage consistent with other image formats. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stef

Re: [PATCH u-boot-marvell v2 18/20] tools: kwbimage/kwboot: Check ext field for non-zero value

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Despite the official specification, BootROM does not look at the lowest bit of ext field but rather checks if ext field is non-zero. Moreover original Marvell doimage tool puts into the mhdr->ext field the number of extended headers, so basically it sets ext f

Re: [PATCH u-boot-marvell v2 17/20] tools: kwbimage: Do not cast const pointers to non-const pointers

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Avoid casting const to non-const. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/kwbimage.h b/tools/kwbim

Re: [PATCH 4/6] arm: Clean up asm/io.h

2022-01-12 Thread Leo Liang
On Sun, Jan 09, 2022 at 09:39:03PM +, Andre Przywara wrote: > On Sun, 9 Jan 2022 17:30:07 + > Andre Przywara wrote: > > Hi Rick, Leo: > > > asm/io.h is the header file containing the central MMIO accessor macros. > > Judging by the header and the comments, it was apparently once copied

Re: [PATCH u-boot-marvell v2 16/20] tools: kwbimage: Dump kwbimage config file on '-p -1' option

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: To regenerate kwbimage from existing image, it is needed to have kwbimage config file. Add a new option to generate kwbimage config file from existing kwbimage when '-p 1' option is given. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Ste

Re: [PATCH u-boot-marvell v2 15/20] tools: kwbimage: Show binary image offset in mkimage -l, in addition to size

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: For debugging purposes it is good to know where the binary image would be loaded and also it is needed to know if printed size is image size or the size of header together with image. Make it unambiguous by showing that printed size is not the size of the whol

Re: [PATCH u-boot-marvell v2 14/20] tools: kwbimage: Add missing check for maximal value for DATA_DELAY

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Data delay is stored as 8-bit number in kwbimage structure. Ensure the given value is at most 255. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 4 1 file changed, 4 insertion

Re: [PATCH u-boot-marvell v2 13/20] arm: mvebu: Enable BootROM output on A38x

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: BootROMs on pre-A38x SoCs enabled its output on UART by default, but A38x' BootROM has its output on UART disabled by default. To enable BootROM output on A38x SoC, it is required to set DEBUG flag (which only enables BootROM output and nothing more) in kwbima

Re: [PATCH 1/1] riscv: revert Complete efi header for RV32/64

2022-01-12 Thread Leo Liang
On Sun, Jan 09, 2022 at 06:38:55PM +0100, Heinrich Schuchardt wrote: > EDK II refuses to load the EFI binaries created by U-Boot. > The reason is an incorrect PE-COFF header. The number of > data directories does not match NumberOfRvaAndSizes. > This leads to a failed consistency check in > PeCoffL

Re: [PATCH u-boot-marvell v2 12/20] tools: kwbimage: Enforce 128-bit boundary alignment only for Sheeva CPU

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: This alignment is required only for platforms based on Sheeva CPU core which are A370 and AXP. Now when U-Boot build system correctly propagates LOAD_ADDRESS there is no need to have enabled 128-bit boundary alignment on platforms which do not need it. Previous

Re: [PATCH u-boot-marvell v2 11/20] arm: mvebu: Correctly set LOAD_ADDRESS for U-Boot SPL binary in kwbimage

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: U-Boot SPL for mvebu platform is not compiled as position independent. Therefore it is required to instruct BootROM to load U-Boot SPL at the correct address. Loading of kwbimage binary code at specific address can be now achieved by the new LOAD_ADDRESS token

Re: [PATCH u-boot-marvell v2 10/20] arm: mvebu: Set CPU for U-Boot SPL binary in kwbimage

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: kwbimage needs to know CPU type, so set it in kwbimage config file. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Makefile| 8 arch/arm/mach-mvebu/kwbimage.cfg.in | 3 +++ 2 files changed

Re: [PATCH u-boot-marvell v2 09/20] tools: kwbimage: Check for maximal kwbimage header size

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: BootROM loads kwbimage header to L2-SRAM and BootROM reserve only 192 kB for it. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index a5b518f60bc8..ce053a4a5a78 10

Re: [PATCH u-boot-marvell v2 08/20] tools: kwbimage: Check the return value of image_headersz_v1()

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Function image_headersz_v1() may return zero on fatal errors. In this case the function already printed an error message. Check the return value of image_headersz_v1() in kwbimage_generate(), and exit on zero value with EXIT_FAILURE. Signed-off-by: Pali Rohár

Re: [PATCH u-boot-marvell v2 07/20] tools: kwbimage: Add support for specifying LOAD_ADDRESS for BINARY command

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: ARM executable code included in kwbimage binary header, which is not position independent, needs to be loaded and executed by BootROM at the correct fixed address. Armada BootROMs load kwbimage header (in which the executable code is also stored) at fixed addr

Re: [PATCH u-boot-marvell v2 06/20] tools: kwbimage: Add support for specifying CPU core

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: For other changes it is required to know if CPU core is Sheeva or not. Therefore add a new command CPU for specifying CPU. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 26 ++ 1 file

Re: [PATCH u-boot-marvell v2 05/20] arm: mvebu: Generate kwbimage.cfg with $(call cmd, ...)

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Usage of $(call cmd,...) is standard way to call other commands which generate things. It also has the advantage of printing build information in the form KWBCFG arch/arm/mach-mvebu/kwbimage.cfg if verbosity is disabled, and printing the build command othe

Re: [PATCH u-boot-marvell v2 04/20] tools: kwbimage: Preserve order of BINARY, DATA and DATA_DELAY commands

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Preserve the order of BINARY, DATA and DATA_DELAY commands as they appear in the input file. They may depend on each other. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 58

Re: [PATCH u-boot-marvell v2 03/20] tools: kwbimage: Fix generating image with multiple DATA_DELAY commands

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Register set header consists of sequence of DATA commands followed by exactly one DATA_DELAY command. Thus if we are generating image with multiple DATA_DELAY commands, we need to create more register set headers. Fix calculation of image size with multiple DA

Re: [PATCH u-boot-marvell v2 02/20] tools: kwbimage: Deduplicate v1 regtype header finishing

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Deduplicate code that finishes OPT_HDR_V1_REGISTER_TYPE header by extracing it into separate function. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 41 ++---

Re: [PATCH u-boot-marvell v2 01/20] tools: kwbimage: Mark all local functions as static

2022-01-12 Thread Stefan Roese
On 1/12/22 18:20, Pali Rohár wrote: Mark all local functions as static. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff

Re: [PATCH u-boot-marvell] ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision

2022-01-12 Thread Stefan Roese
+Cc Chris On 1/12/22 17:06, Marek Behún wrote: From: Marek Behún This is a cleaned up and fixed version of a patch mv_ddr: a380: fix SPLIT_OUT_MIX state decision in each pattern cycle the bus state can be changed in order to avoide it, need to back to the same bus state on each pa

Re: [PATCH v2 2/2] doc: board: avoid ambiguous names for axy17lte

2022-01-12 Thread Minkyu Kang
Dear Henrik Grmler, On Wed, 12 Jan 2022 at 08:07, Jaehoon Chung wrote: > On 1/12/22 3:06 AM, Henrik Grimler wrote: > > Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to > > SM-J{3,5,7}20 or SM-T{3,5,7}20. > > > > Also fix a5y17lte->a7y17lte for SM-A720. > > > > Fixes: 3e2095e9

Re: [PATCH v2 1/2] board: samsung: fix menu entries for a{3,7}y17lte

2022-01-12 Thread Minkyu Kang
Dear Henrik Grimler On Wed, 12 Jan 2022 at 08:06, Jaehoon Chung wrote: > On 1/12/22 3:06 AM, Henrik Grimler wrote: > > a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also > > should select PINCTRL_EXYNOS78x0, not the (non-existent) > > PINCTRL_EXYNOS7880, and it has an Exynos 7870

[PATCH v2 11/12] bloblist: doc: Bring in the API documentation

2022-01-12 Thread Simon Glass
FIx up various minor errors and add the API documentation to the bloblist docs, since it is quite useful to see it in the same place. Signed-off-by: Simon Glass --- (no changes since v1) doc/develop/bloblist.rst | 8 +++- include/bloblist.h | 79 +++-

[PATCH v2 12/12] bloblist: Relicense to allow BSD-3-Clause

2022-01-12 Thread Simon Glass
This implementation is intended to be copied to other projects and modified, to as to foster a standard means of communcating runtime information between firmware projects. The GPL-2 license is too restrictive for some projects, e.g. those intended as reference implementations rather than designed

[PATCH v2 10/12] bloblist: Add functions to obtain base address and size

2022-01-12 Thread Simon Glass
Add a few convenience functions to obtain useful information about the bloblist. Signed-off-by: Simon Glass --- (no changes since v1) common/bloblist.c | 12 include/bloblist.h | 14 ++ test/bloblist.c| 2 ++ 3 files changed, 28 insertions(+) diff --git a/common

[PATCH v2 09/12] bloblist: Refactor Kconfig to support alloc or fixed

2022-01-12 Thread Simon Glass
At present we do support allocating the bloblist but the Kconfig is a bit strange, since we still have to specify an address in that case. Partly this is because it is a pain to have CONFIG options that disappears when its dependency is enabled. It means that we must have #ifdefs in the code, eithe

[PATCH v2 08/12] bloblist: Use 'phase' consistently for bloblists

2022-01-12 Thread Simon Glass
We typically refer to the different U-Boot builds that a board runs through as phases. This avoids confusion with the word 'stage' which is used with bootstage, for example. Fix up some bloblist Kconfig help which uses the wrong term. Signed-off-by: Simon Glass --- (no changes since v1) common

[PATCH v2 07/12] bloblist: Use LOG_CATEGORY to simply logging

2022-01-12 Thread Simon Glass
Use the convenience functions to improve readability. Signed-off-by: Simon Glass --- (no changes since v1) common/bloblist.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/common/bloblist.c b/common/bloblist.c index baf1d371b71..b5fea12b697 100644 -

[PATCH v2 06/12] bloblist: Use explicit numbering for the tags

2022-01-12 Thread Simon Glass
At present if someone adds a tag in the middle of the list it works well enough within a U-Boot build. But if these tags are used in another project, or with an older version of SPL, the numbers make become inconsistent. Use explicit tag numbers that never change, to resolve this problem. Allocate

[PATCH v2 05/12] bloblist: Drop unused tags

2022-01-12 Thread Simon Glass
The EC event log tag is no-longer used. The vboot handoff is now handled by the vboot context instead. Drop these unused tags. Signed-off-by: Simon Glass --- (no changes since v1) common/bloblist.c | 4 +--- include/bloblist.h | 2 -- test/bloblist.c| 4 ++-- 3 files changed, 3 insertion

[PATCH v2 04/12] bloblist: Rename the SPL tag

2022-01-12 Thread Simon Glass
Add a U_BOOT prefix to this tag since it is specific to the U-Boot project. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/broadwell/cpu_from_spl.c | 4 ++-- common/bloblist.c | 2 +- common/board_f.c | 2 +- common/spl/spl.c

[PATCH v2 03/12] bloblist: Put the magic number first

2022-01-12 Thread Simon Glass
It seems best to put the magic number right at the start of the bloblist header, so it is easier to check. This is how devicetree works. Make this change now, before other projects make use of bloblist. Other changes may be needed / discussed, but that is TBD. Add a checker function as well. Sig

[PATCH v2 02/12] fdt: Drop SPL_BUILD macro

2022-01-12 Thread Simon Glass
This old macro is not needed anymore since we can use IS_ENABLED() now. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/serial-uclass.c | 3 ++- include/fdtdec.h | 6 -- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/serial

[PATCH v2 01/12] stddef: Avoid warning with clang with offsetof()

2022-01-12 Thread Simon Glass
Some bright sparks have decided that a cast on a constant cannot be a constant, so offsetof() produces this warning on clang-10: include/intel_gnvs.h:113:1: error: static_assert expression is not an integral constant expression check_member(acpi_global_nvs, unused2, GNVS_CHROMEOS_ACPI_OFFS

[PATCH v2 00/12] bloblist: Enhancements for standard passage

2022-01-12 Thread Simon Glass
This series collects together the prerequisites for standard passage. The only change is to drop the CONFIG_IF_ENABLED_INT() macro. Changes in v2: - Create an accessor for CONFIG_BLOBLIST_ADDR instead of the Kconfig macro Simon Glass (12): stddef: Avoid warning with clang with offsetof() fdt:

Re: [PATCH u-boot-next 12/12] pci: sh7751: Fix access to config space via PCI_CONF1_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:52AM +0100, Pali Rohár wrote: > sh7751 platform uses standard format of Config Address for PCI > Configuration Mechanism #1. > > Commit 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing") which did > conversion of PCI sh7751 driver to DM, broke access to confi

Re: [PATCH u-boot-next 11/12] m68k: mcf5445x: pci: Use PCI_CONF1_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:51AM +0100, Pali Rohár wrote: > mcf5445x platform uses standard format of Config Address for PCI > Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_ADDRESS(). > > Signed-off-by: Pali Rohár > Reviewed-by: Simon Glass Applied to u-boot/master, thanks!

Re: [PATCH u-boot-next 10/12] x86: pci: Use PCI_CONF1_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:50AM +0100, Pali Rohár wrote: > x86 platform uses standard format of Config Address for PCI Configuration > Mechanism #1. So use new U-Boot macro PCI_CONF1_ADDRESS(). > > Signed-off-by: Pali Rohár > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- T

Re: [PATCH u-boot-next 09/12] pci: sh7780: Use PCI_CONF1_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:49AM +0100, Pali Rohár wrote: > PCI sh7780 driver uses standard format of Config Address for PCI > Configuration Mechanism #1. > > So use new U-Boot macro PCI_CONF1_ADDRESS(). > > Signed-off-by: Pali Rohár > Reviewed-by: Simon Glass Applied to u-boot/master, than

Re: [PATCH u-boot-next 08/12] pci: mediatek: Use PCI_CONF1_EXT_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:48AM +0100, Pali Rohár wrote: > PCI mediatek driver uses extended format of Config Address for PCI > Configuration Mechanism #1 but with cleared Enable bit. > > So use new U-Boot macro PCI_CONF1_EXT_ADDRESS() with clearing > PCI_CONF1_ENABLE bit and remove old custom

Re: [PATCH u-boot-next 07/12] pci: fsl: Use PCI_CONF1_EXT_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:47AM +0100, Pali Rohár wrote: > PCI fsl driver uses extended format of Config Address for PCI > Configuration Mechanism #1. > > So use new U-Boot macro PCI_CONF1_EXT_ADDRESS(). > > Signed-off-by: Pali Rohár > Reviewed-by: Simon Glass Applied to u-boot/master, tha

Re: [PATCH u-boot-next 06/12] pci: tegra: Use PCI_CONF1_EXT_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:46AM +0100, Pali Rohár wrote: > PCI tegra driver uses extended format of Config Address for PCI > Configuration Mechanism #1 but with cleared Enable bit. > > So use new U-Boot macro PCI_CONF1_EXT_ADDRESS() with clearing > PCI_CONF1_ENABLE bit and remove old custom dr

Re: [PATCH u-boot-next 05/12] pci: mvebu: Use PCI_CONF1_EXT_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:45AM +0100, Pali Rohár wrote: > PCI mvebu driver uses extended format of Config Address for PCI > Configuration Mechanism #1. > > So use new U-Boot macro PCI_CONF1_EXT_ADDRESS() and remove old custom > driver address macros. > > Signed-off-by: Pali Rohár > Reviewed

Re: [PATCH u-boot-next 04/12] pci: msc01: Use PCI_CONF1_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:44AM +0100, Pali Rohár wrote: > PCI msc01 driver uses standard format of Config Address for PCI > Configuration Mechanism #1 but with cleared Enable bit. > > So use new U-Boot macro PCI_CONF1_ADDRESS() with clearing PCI_CONF1_ENABLE > bit and remove old custom driver

Re: [PATCH u-boot-next 03/12] pci: mpc85xx: Use PCI_CONF1_EXT_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:43AM +0100, Pali Rohár wrote: > PCI mpc85xx driver uses extended format of Config Address for PCI > Configuration Mechanism #1. > > So use new U-Boot macro PCI_CONF1_EXT_ADDRESS(). > > Signed-off-by: Pali Rohár > Reviewed-by: Simon Glass Applied to u-boot/master,

Re: [PATCH u-boot-next 02/12] pci: gt64120: Use PCI_CONF1_ADDRESS() macro

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:42AM +0100, Pali Rohár wrote: > PCI gt64120 driver uses standard format of Config Address for PCI > Configuration Mechanism #1. > > So use new U-Boot macro PCI_CONF1_ADDRESS() and remove old custom driver > address macros. > > Signed-off-by: Pali Rohár > Reviewed-b

Re: [PATCH u-boot-next 01/12] pci: Add standard PCI Config Address macros

2022-01-12 Thread Tom Rini
On Fri, Nov 26, 2021 at 11:42:41AM +0100, Pali Rohár wrote: > Lot of PCI and PCIe controllers are using standard Config Address for PCI > Configuration Mechanism #1 or its extended version. > > So add PCI_CONF1_ADDRESS() and PCI_CONF1_EXT_ADDRESS() macros into U-Boot's > pci.h header file which c

Re: [PATCH] pci: When disabling pref MEM set all base bits

2022-01-12 Thread Tom Rini
On Thu, Nov 25, 2021 at 11:34:37AM +0100, Pali Rohár wrote: > It is common to set all base address bits to one and all limit address bits > to zero for disabling address forwarding. Forwarding is disabled when base > address is higher than limit address, so this change should not have any > effect

Re: [PATCH] pci: Disable I/O forwarding during autoconfiguration if unsupported

2022-01-12 Thread Tom Rini
On Thu, Nov 25, 2021 at 11:32:43AM +0100, Pali Rohár wrote: > If U-Boot does not have any I/O resource for assignment then disable I/O > forwarding in PCI bridge autoconfiguration code. Default initial state of > PCI bridge IO registers is unspecified, therefore they can be in enabled if > U-Boot

Re: [PATCH] pci: Fix register for determining type of IO base address

2022-01-12 Thread Tom Rini
On Thu, Nov 25, 2021 at 11:30:58AM +0100, Pali Rohár wrote: > Function dm_pciauto_prescan_setup_bridge() configures base address > registers, therefore it should read type of IO from base address registers > (and not from limit address registers). > > Note that base and limit address registers sh

Re: [PATCH u-boot-next 4/4] pci: pci_octeontx: Use PCIE_ECAM_OFFSET() macro

2022-01-12 Thread Tom Rini
On Wed, Nov 24, 2021 at 06:00:33PM +0100, Pali Rohár wrote: > Replace custom driver macros by PCIE_ECAM_OFFSET() macro from pci.h > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH u-boot-next 3/4] pci: pcie_iproc: Use PCIE_ECAM_OFFSET() macro

2022-01-12 Thread Tom Rini
On Wed, Nov 24, 2021 at 06:00:32PM +0100, Pali Rohár wrote: > Replace custom driver macros by PCIE_ECAM_OFFSET() macro from pci.h > > Signed-off-by: Pali Rohár Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH u-boot-next 2/4] pci: pcie-brcmstb: Use PCIE_ECAM_OFFSET() macro

2022-01-12 Thread Tom Rini
On Wed, Nov 24, 2021 at 06:00:31PM +0100, Pali Rohár wrote: > Replace custom driver macros by PCIE_ECAM_OFFSET() macro from pci.h > > Signed-off-by: Pali Rohár > Reviewed-by: Nicolas Saenz Julienne Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH u-boot-next 1/4] vexpress64: Remove unused macro XR3PCI_ECAM_OFFSET

2022-01-12 Thread Tom Rini
On Wed, Nov 24, 2021 at 06:00:30PM +0100, Pali Rohár wrote: > Macro XR3PCI_ECAM_OFFSET is unused and in case it would be needed in future > it can be replaced by standard PCIE_ECAM_OFFSET macro from pci.h file. > > Signed-off-by: Pali Rohár Applied to u-boot/master, thanks! -- Tom signature

Re: [PATCH] mmc: dwmmc: return a proper error code when busy

2022-01-12 Thread Jaehoon Chung
On 1/12/22 8:11 PM, John Keeping wrote: > On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote: >> On 1/12/22 7:12 AM, Jaehoon Chung wrote: >>> On 1/12/22 1:15 AM, John Keeping wrote: When failing to send a command because the hardware is busy, return EBUSY to indicate the cause

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Tom Rini
On Wed, Jan 12, 2022 at 03:22:51PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 12 Jan 2022 at 14:56, Tom Rini wrote: > > > > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > > > wrote: > > > > > > > > On

Re: [PATCH v3] pci: Work around PCIe link training failures

2022-01-12 Thread Maciej W. Rozycki
On Wed, 12 Jan 2022, Tom Rini wrote: > > I believe this version has addressed all concerns raised in the review > > thus far. With the nature of a problem better understood now I'm sending > > a corresponding update for Linux as well. > > What as the feedback to your Linux change? Is this es

Re: [PATCH] arm: mvebu: Replace hardcoded values 0x0030/0x4030 by proper calculation

2022-01-12 Thread Pali Rohár
On Wednesday 12 January 2022 23:27:06 Marek Behún wrote: > On Wed, 12 Jan 2022 18:32:08 +0100 > Pali Rohár wrote: > > > These hardcoded values were calculated from CONFIG_SPL_TEXT_BASE macro. Now > > this macro is configurable via Kconfig, so calculate values 0x0030/0x4030 > > at compile time via

Re: [PATCH] arm: mvebu: Replace hardcoded values 0x0030/0x4030 by proper calculation

2022-01-12 Thread Marek Behún
On Wed, 12 Jan 2022 18:32:08 +0100 Pali Rohár wrote: > These hardcoded values were calculated from CONFIG_SPL_TEXT_BASE macro. Now > this macro is configurable via Kconfig, so calculate values 0x0030/0x4030 > at compile time via CONFIG_SPL_TEXT_BASE option. Values 0x0030/0x4030 > represents offse

Re: [PATCH u-boot-dm v2] fdt_support: Add fdt_for_each_node_by_compatible() helper macro

2022-01-12 Thread Marek Behún
On Wed, 12 Jan 2022 13:04:08 -0700 Simon Glass wrote: > Hi Marek, > > On Mon, 10 Jan 2022 at 03:46, Marek Behún wrote: > > > > From: Marek Behún > > > > Add macro fdt_for_each_node_by_compatible() to allow iterating over > > fdt nodes by compatible string. > > > > Convert various usages of > >

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Simon Glass
Hi Tom, On Wed, 12 Jan 2022 at 14:56, Tom Rini wrote: > > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > > Hi Ilias, > > > > On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > > wrote: > > > > > > On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > > > > > > > At present if an opti

Re: [PATCH 1/4] ci: azure: Update to use stages

2022-01-12 Thread Tom Rini
On Tue, Jan 11, 2022 at 07:14:28PM -0500, Tom Rini wrote: > Follow what we do in GitLab CI where we break the jobs up in to stages > such that if earlier and often quicker sanity tests fail we don't run > everything else. > > Signed-off-by: Tom Rini > --- > .azure-pipelines.yml | 8 +++- >

Re: [PATCH v4 0/2] Add MNT Reform 2 board support

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:03:28PM -0500, Tom Rini wrote: > On Wed, Jan 12, 2022 at 10:29:50PM +0100, Patrick Wildt wrote: > > > Hi, > > > > is there anything I can do to help get attention on this patchset? > > Not a whole lot, sorry. The big hold up right now is that Stefano is > out currentl

Re: [PATCH v4 0/2] Add MNT Reform 2 board support

2022-01-12 Thread Tom Rini
On Wed, Jan 12, 2022 at 10:29:50PM +0100, Patrick Wildt wrote: > Hi, > > is there anything I can do to help get attention on this patchset? Not a whole lot, sorry. The big hold up right now is that Stefano is out currently and that means a number of imx patches are still outstanding. > I'm now

Re: [PATCH v4 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2022-01-12 Thread Tom Rini
On Wed, Jan 12, 2022 at 06:47:38PM -0300, Fabio Estevam wrote: > Hi Patrick, > > On Sat, Jan 8, 2022 at 12:05 PM Patrick Wildt wrote: > > > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > > lifted from

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Tom Rini
On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > Hi Ilias, > > On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > wrote: > > > > On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > > > > > At present if an optional Kconfig value needs to be used it must be > > > bracketed by #ifdef. F

Re: [PATCH v4 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2022-01-12 Thread Fabio Estevam
Hi Patrick, On Sat, Jan 8, 2022 at 12:05 PM Patrick Wildt wrote: > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > lifted from BoundaryDevices official U-Boot downstream project. > > Signed-off-by: Patri

Re: [PATCH v4 1/2] arm: dts: imx8mq: add MNT Reform 2

2022-01-12 Thread Fabio Estevam
On Sat, Jan 8, 2022 at 12:04 PM Patrick Wildt wrote: > > Device tree taken from Linux v5.16-rc5. > > Signed-off-by: Patrick Wildt Reviewed-by: Fabio Estevam

Re: [PATCH v4 0/2] Add MNT Reform 2 board support

2022-01-12 Thread Patrick Wildt
Hi, is there anything I can do to help get attention on this patchset? I'm now regularly rebasing the patchset and adjusting it to all the changes that happen in-tree to the other boards to keep the patchset compiling and working. Right now I'd have to send a v5 to remove a single define that's n

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Simon Glass
Hi Ilias, On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas wrote: > > On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > > > At present if an optional Kconfig value needs to be used it must be > > bracketed by #ifdef. For example, with this Kconfig setup: > > > > config WIBBLE > > bool "Su

[PATCH 4/4] arm64: dts: imx8mq-u-boot.dtsi: improve odd blob-ext naming

2022-01-12 Thread Patrick Wildt
Rather than using odd implicit blob-ext naming, explicitly specify the type to be of blob-ext and therefore also simplify the node naming. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 32 1 file changed, 20 insertions(+), 12 deletions(-) di

Re: [PATCH] patman: Support absolute and ~user-relative alias files

2022-01-12 Thread Simon Glass
On Fri, 7 Jan 2022 at 16:16, Brian Norris wrote: > > Python doesn't naturally support tilde (~) as a user-home marker in > paths, but git-config does. So we need to resolve it before continuing. > > We also shouldn't blindly join the top-level tree with the aliasesfile > path, because it might be

[PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-12 Thread Patrick Wildt
One of the blobs was named using a hyphen instead of an underscore, so make it consistent. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mm-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u-boot.dtsi index

[PATCH 2/4] arm64: dts: imx8mq-u-boot.dtsi: explicitly add spl filename

2022-01-12 Thread Patrick Wildt
Explicitly add SPL aka u-boot-spl.bin filename. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index d8208ae7b0..566b8b8035 100644 --- a/arch/arm/dts/imx8mq-u-b

Re: [PATCH] patman: expand user home when looking for the alias file

2022-01-12 Thread Simon Glass
Hi Otavio, +Brian Norris On Tue, 4 Jan 2022 at 09:47, Otavio Salvador wrote: > > This allows the use of git aliases files relative to the user home, > without using the full path to the file. > > Signed-off-by: Otavio Salvador > --- > > tools/patman/gitutil.py | 7 ++- > 1 file changed, 6

[PATCH 1/4] arm64: dts: imx8mq-u-boot.dtsi: alphabetically re-order properties

2022-01-12 Thread Patrick Wildt
Alphabetically re-order properties. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index 8a6075c77b..d8208ae7b0 10064

[PATCH 0/4] arm64: imx8mq/imx8mm: cleanup binman configuration

2022-01-12 Thread Patrick Wildt
The i.MX8MM boards have been converted for some longer time compared to i.MX8MQ. During that time the i.MX8MM binman configuration has already gotten some cleanup. This brings the i.MX8MQ binman config in line with the i.MX8MM one, and fixes a typo in the i.MX8MM config. Patrick Wildt (4): arm

Re: [PATCH 3/3] doc: verdin-imx8mm: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:49:46PM -0300, Fabio Estevam wrote: > imx8mm-u-boot.dtsi passes the ATF load address via the > 'entry' and 'load' properties. > > Remove the step that performs the ATF_LOAD_ADDR export, which is > now unneeded. > > Signed-off-by: Fabio Estevam Reviewed-by: Patrick Wil

Re: [PATCH 2/3] doc: sl-mx8mm: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:49:45PM -0300, Fabio Estevam wrote: > imx8mm-u-boot.dtsi passes the ATF load address via the > 'entry' and 'load' properties. > > Remove the step that performs the ATF_LOAD_ADDR export, which is > now unneeded. > > Signed-off-by: Fabio Estevam Reviewed-by: Patrick Wil

Re: [PATCH 1/3] doc: imx8mm_evk: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:49:44PM -0300, Fabio Estevam wrote: > imx8mm-u-boot.dtsi passes the ATF load address via the > 'entry' and 'load' properties. > > Remove the step that performs the ATF_LOAD_ADDR export, which is > now unneeded. > > Signed-off-by: Fabio Estevam Reviewed-by: Patrick Wil

[PATCH 3/3] doc: verdin-imx8mm: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Fabio Estevam
imx8mm-u-boot.dtsi passes the ATF load address via the 'entry' and 'load' properties. Remove the step that performs the ATF_LOAD_ADDR export, which is now unneeded. Signed-off-by: Fabio Estevam --- doc/board/toradex/verdin-imx8mm.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/board/

[PATCH 2/3] doc: sl-mx8mm: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Fabio Estevam
imx8mm-u-boot.dtsi passes the ATF load address via the 'entry' and 'load' properties. Remove the step that performs the ATF_LOAD_ADDR export, which is now unneeded. Signed-off-by: Fabio Estevam --- doc/board/kontron/sl-mx8mm.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/board/kontr

[PATCH 1/3] doc: imx8mm_evk: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Fabio Estevam
imx8mm-u-boot.dtsi passes the ATF load address via the 'entry' and 'load' properties. Remove the step that performs the ATF_LOAD_ADDR export, which is now unneeded. Signed-off-by: Fabio Estevam --- doc/board/nxp/imx8mm_evk.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/board/nxp/imx

Re: [PATCH 3/4] binman: Have faked binaries live in the output directory.

2022-01-12 Thread Simon Glass
Hi Tom, On Wed, 12 Jan 2022 at 13:03, Tom Rini wrote: > > On Wed, Jan 12, 2022 at 01:01:17PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 11 Jan 2022 at 17:14, Tom Rini wrote: > > > > > > In general, and for Azure specifically, we need to have files created in > > > the output directory

[PATCH v2 2/2] binman: Write fake blobs to the output directory

2022-01-12 Thread Simon Glass
At present binman writes fake blobs to the current directory. This is not very helpful, since the files serve no useful purpose once binman has finished. They clutter up the source directory and affect future runs, since the files in the current directory are often used in preference to those in th

[PATCH v2 1/2] binman: Renumber the fake blob dts

2022-01-12 Thread Simon Glass
Use a unique number instead of the current 203, which is used by 203_fip as well. Reformat the code to avoid a long line. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to renumber the fake blob dts tools/binman/ftest.py | 22 ++- .../{203

Re: [RFC PATCH v1 12/21] cli: hush_2021: Enable variables expansion for hush 2021.

2022-01-12 Thread Simon Glass
On Fri, 31 Dec 2021 at 09:14, Francis Laniel wrote: > > The following commit enables variables expansion for hush 2021, both for local > and environment variables. > So the following commands: > foo=bar > echo $foo > setenv bar foo > echo $bar > leads to "bar" and "foo" being printed on console ou

Re: [RFC PATCH v1 14/21] cli: Modify run_command() to add hush 2021 as parser.

2022-01-12 Thread Simon Glass
On Fri, 31 Dec 2021 at 09:14, Francis Laniel wrote: > > This commit then enables using, in code, run_command() while using hush 2021 > as > parser. > It also enables the command run to be used by CLI user of hush 2021. > > Signed-off-by: Francis Laniel > --- > common/cli.c | 17 +++-

Re: [PATCH v3 5/6] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition

2022-01-12 Thread Simon Glass
On Thu, 30 Dec 2021 at 09:48, Johan Jonker wrote: > > Not all Rockchip SoC models use the ARM arch timer. > Call the function timer_init() only when > CONFIG_SYS_ARCH_TIMER is available. > Replace the ifdef call condition by IS_ENABLED > to increase build coverage and make the code easier to read.

Re: [PATCH 4/8] video: Add sun12x22 framebuffer front

2022-01-12 Thread Simon Glass
Reviewed-by: Simon Glass

  1   2   3   >