On Sun, Jan 09, 2022 at 09:39:03PM +0000, Andre Przywara wrote: > On Sun, 9 Jan 2022 17:30:07 +0000 > Andre Przywara <andre.przyw...@arm.com> wrote: > > Hi Rick, Leo: > > > asm/io.h is the header file containing the central MMIO accessor macros. > > Judging by the header and the comments, it was apparently once copied > > from the Linux kernel, but has deviated since then *heavily*. There is > > absolutely no point in staying close to the original Linux code anymore, > > so just remove the old cruft, by: > > - removing pointless Linux history > > - removing commented code > > - removing outdated comments > > - removing unused definitions (for mem_isa) > > > > This massively improves the readability of the file. > > it looks like arch/risc-v/include/asm/io.h is a copy of the ARM > version, and includes the same pointless legacy. You might want to > remove those parts there as well. > > Cheers, > Andre > > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com> > > --- > > arch/arm/include/asm/io.h | 98 +-------------------------------------- > > 1 file changed, 2 insertions(+), 96 deletions(-)
Hi Andre, Thanks for the reminder! Will do ASAP! Best regards, Leo
