Re: [U-Boot] [PATCH] fdt: Change OF_BAD_ADDR to FDT_ADDR_T_NONE

2015-12-08 Thread Stefan Roese
Hi Bin, On 07.12.2015 10:39, Bin Meng wrote: Currently OF_BAD_ADDR is always -1ULL. When using OF_BAD_ADDR as the return value of dev_get_addr(), it creates potential size mismatch as dev_get_addr() uses FDT_ADDR_T_NONE as the return value which can be either -1U or -1ULL depending on CONFIG_PHY

[U-Boot] [PATCH v2 4/5] board: atmel: clean up peripheral clock code

2015-12-08 Thread Wenyou Yang
Due to introducing the new peripheral clock handle functions, use these functions to reduce duplicated code. Signed-off-by: Wenyou Yang --- Changes in v2: - fix checkpatch warning. board/atmel/at91rm9200ek/at91rm9200ek.c |1 - board/atmel/at91rm9200ek/led.c |5

[U-Boot] [PATCH v2 5/5] drivers: at91: clean up peripheral clock code

2015-12-08 Thread Wenyou Yang
Due to introducing the new peripheral clock handle functions, use these functions to reduce the duplicated code. Signed-off-by: Wenyou Yang --- Changes in v2: None drivers/net/at91_emac.c |9 - drivers/usb/host/ehci-atmel.c |8 drivers/usb/host/ohci-at91.c | 2

[U-Boot] [PATCH v2 3/5] ARM: cpu: at91: clean up peripheral clock code

2015-12-08 Thread Wenyou Yang
Due to introducing the new peripheral clock handle functions, use these functions to clean up the duplicated code. Meanwhile, remove unneeded header file include, at91_pmc.h. Signed-off-by: Wenyou Yang --- Changes in v2: None arch/arm/mach-at91/arm920t/at91rm9200_devices.c| 13 ++-

[U-Boot] [PATCH v2 2/5] ARM: at91: clock: add a new file to handle clock

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, add a new file to accommodate the peripheral's and system's clock handle code, shared with the SoCs with different ARM core. Signed-off-by: Wenyou Yang --- Changes in v2: None arch/arm/mach-at91/Makefile |1 + arch/arm/mach-at91/arm926ejs/clock.c |

[U-Boot] [PATCH v2 1/5] ARM: at91: asm/at91_pmc.h: fix trival register offset

2015-12-08 Thread Wenyou Yang
Remove unnecessary #ifdef CPU_HAS_PCR. Signed-off-by: Wenyou Yang --- Changes in v2: None arch/arm/mach-at91/include/mach/at91_pmc.h |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-at91/include/mach/at91_pmc.h b/arch/arm/mach-at91/include/mach/at91

[U-Boot] [PATCH v2 0/5] ARM: at91: improve peripheral and system clock handle functions

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, rework the peripheral's and system's clock handle functions, use these functions to replace the clock handle code. Changes in v2: - fix checkpatch warning. Wenyou Yang (5): ARM: at91: asm/at91_pmc.h: fix trival register offset ARM: at91: clock: add a new file t

Re: [U-Boot] [PATCH 4/5] board: atmel: clean up peripheral clock code

2015-12-08 Thread Yang, Wenyou
Hello Heiko, Thank you for your review. > -Original Message- > From: Heiko Schocher [mailto:h...@denx.de] > Sent: 2015年12月9日 14:56 > To: Yang, Wenyou > Cc: U-Boot Mailing List > Subject: Re: [U-Boot] [PATCH 4/5] board: atmel: clean up peripheral clock code > > Hello Wenyou, > > Am 09.

Re: [U-Boot] [PATCH] tools: zynqimage: Clean up check_params

2015-12-08 Thread Michal Simek
On 8.12.2015 16:03, Tom Rini wrote: > On Wed, Dec 09, 2015 at 12:44:43AM +1000, Nathan Rossi wrote: > >> Clean up the param checking, removing some code paths that will never >> happen. >> >> Signed-off-by: Nathan Rossi >> Cc: Michal Simek >> Cc: Tom Rini > > Reported-by: Coverity (CID 133251)

[U-Boot] [PATCH v2 1/3] ARM: at91: clock: add PMC_PLLICPR init function

2015-12-08 Thread Wenyou Yang
To avoid the duplicated code, add the PMC_PLLICPR init function. Signed-off-by: Wenyou Yang --- Changes in v2: - move at91_pllicpr_init() definition to the common file, clock.c. - fix checkpatch errors. arch/arm/mach-at91/clock.c |7 +++ arch/arm/mach-at91/include/mac

[U-Boot] [PATCH v2 2/3] ARM: at91: clean up the PMC_PLLICPR init code

2015-12-08 Thread Wenyou Yang
Due to introducing the PMC_PLLICPR init function, use this function to clean up the code. Signed-off-by: Wenyou Yang --- Changes in v2: None arch/arm/mach-at91/spl_at91.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm/mach-at91/spl_at91.c b/arch/arm/mach-at

[U-Boot] [PATCH v2 3/3] board: atmel: clean up the PMC_PLLICPR init code

2015-12-08 Thread Wenyou Yang
Due to introducing the PMC_PLLICPR init function, use this function to clean up the code. Signed-off-by: Wenyou Yang --- Changes in v2: None board/atmel/sama5d3_xplained/sama5d3_xplained.c |4 +--- board/atmel/sama5d3xek/sama5d3xek.c |4 +--- board/atmel/sama5d4_xplained/sa

[U-Boot] [PATCH v2 0/3] ARM: at91: add PMC_PLLICPR init function

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, add PLLICPR init function, use the function to clean up the PMC_PLLICPR directly writing code. It is based on the following patch set. [PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions [PATCH 0/4] ARM: at91: add UTMI PLL han

Re: [U-Boot] [PATCH] defconfig: taurus_defconfig: disable SPL

2015-12-08 Thread Yang, Wenyou
Hello Heiko, > -Original Message- > From: Heiko Schocher [mailto:h...@denx.de] > Sent: 2015年12月9日 15:39 > To: Yang, Wenyou > Cc: U-Boot Mailing List ; andreas.de...@googlemail.com; > Meier, Roger > Subject: Re: [PATCH] defconfig: taurus_defconfig: disable SPL > > Hello Wenyou, > > Am 0

Re: [U-Boot] [PATCH 0/3] ARM: at91: add PMC_PLLICPR init function

2015-12-08 Thread Yang, Wenyou
Hi Heiko, Thank you very much for your review. > -Original Message- > From: Heiko Schocher [mailto:h...@denx.de] > Sent: 2015年12月9日 13:32 > To: Yang, Wenyou > Cc: U-Boot Mailing List > Subject: Re: [U-Boot] [PATCH 0/3] ARM: at91: add PMC_PLLICPR init function > > Hello Wenyou, > > Am

Re: [U-Boot] [PATCH] defconfig: taurus_defconfig: disable SPL

2015-12-08 Thread Heiko Schocher
Hello Wenyou, Am 09.12.2015 um 08:15 schrieb Wenyou Yang: Build SPL with taurus_defconfig defconfig file. It build fails with following log message: ---8< $ make mrproper $ make taurus_defconfig $ make SPL [...] LD spl/lib/built-in.o LDS spl/u-boot-spl.lds LD spl/u-boot-spl a

[U-Boot] [PATCH v6] arm: Add sata support on Layerscape ARMv8 board

2015-12-08 Thread Yuantian.Tang
From: Tang Yuantian Freescale ARM-based Layerscape contains a SATA controller which comply with the serial ATA 3.0 specification and the AHCI 1.3 specification. This patch adds SATA feature on ls2080aqds, ls2080ardb and ls1043aqds boards. Signed-off-by: Tang Yuantian --- v6: - update rx

[U-Boot] [PATCH] defconfig: taurus_defconfig: disable SPL

2015-12-08 Thread Wenyou Yang
Build SPL with taurus_defconfig defconfig file. It build fails with following log message: ---8< $ make mrproper $ make taurus_defconfig $ make SPL [...] LD spl/lib/built-in.o LDS spl/u-boot-spl.lds LD spl/u-boot-spl arm-none-linux-gnueabi-ld: SPL image too big make[1]: *** [spl

[U-Boot] (no subject)

2015-12-08 Thread Peter Robinson
In Fedora with gcc 5.2 and 5.3 the fw_env is FTB due to a missing include. The following small patch fixes building it on Fedora with gcc 5.3.1 Regards, Peter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] tools: env: include compiler.h

2015-12-08 Thread Peter Robinson
With gcc 5.2 and later we get a bunch of "error: unknown type name" for 'uint8_t', 'uint32_t' and friends. Signed-off-by: Peter Robinson --- tools/env/fw_env.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index ba11f77..39f7333 100644 --- a/tools/en

Re: [U-Boot] [PATCH 1/3] ARM: at91: clock: add PMC_PLLICPR init function

2015-12-08 Thread Heiko Schocher
Hello Wenyou, Am 09.12.2015 um 05:36 schrieb Wenyou Yang: To avoid the duplicated code, add the PMC_PLLICPR init function. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/armv7/clock.c |7 +++ arch/arm/mach-at91/include/mach/at91_pmc.h |7 +++ arch/arm/mach-at9

Re: [U-Boot] [PATCH 4/5] board: atmel: clean up peripheral clock code

2015-12-08 Thread Heiko Schocher
Hello Wenyou, Am 09.12.2015 um 04:45 schrieb Wenyou Yang: Due to introducing the new peripheral clock handle functions, use these functions to reduce duplicated code. Signed-off-by: Wenyou Yang --- board/atmel/at91rm9200ek/at91rm9200ek.c |1 - board/atmel/at91rm9200ek/led.c

Re: [U-Boot] [PATCH 0/3] ARM: at91: add PMC_PLLICPR init function

2015-12-08 Thread Heiko Schocher
Hello Wenyou, Am 09.12.2015 um 05:36 schrieb Wenyou Yang: To reduce the duplicated code, add PLLICPR init function, use the function to clean up the PMC_PLLICPR directly writing code. It is based on the following patch set. [PATCH 0/5] ARM: at91: improve peripheral and system clock hand

Re: [U-Boot] [PATCH v8 13/14] sf: Use static for file-scope functions

2015-12-08 Thread Simon Glass
On 6 December 2015 at 11:34, Jagan Teki wrote: > Used static for file-scope functions in sf_probe.c > > Cc: Simon Glass > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_probe.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH v8 14/14] sf: Rename sf_ops.c to spi-flash.c

2015-12-08 Thread Simon Glass
On 6 December 2015 at 11:34, Jagan Teki wrote: > Since all spi-flash core operations are moved into > sf_ops.c then it's better to renamed as spi-flash.c > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/Makefile | 2 +- > drivers/mtd/spi/{sf_ops.c => spi-flash.c} | 7 --

Re: [U-Boot] [PATCH v8 12/14] sf: sf_probe: Remove spi_slave pointer argument

2015-12-08 Thread Simon Glass
On 6 December 2015 at 11:34, Jagan Teki wrote: > Since spi_slave is a spi pointer in spi_flash{} then assign > spi_slave{} pointer to flash->spi and remove spi_slave > pointer argument to > - spi_flash_probe_slave > - spi_flash_scan > > Cc: Simon Glass > Signed-off-by: Jagan Teki > --- > driver

Re: [U-Boot] [PATCH v8 11/14] sf: ops: Fix missing break on spansion read_bar

2015-12-08 Thread Simon Glass
On 6 December 2015 at 11:34, Jagan Teki wrote: > For assigning read_bar commands in spansion case, break > is missing this patch add that break. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_ops.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass _

[U-Boot] [PATCH 3/3] board: atmel: clean up the PMC_PLLICPR init code

2015-12-08 Thread Wenyou Yang
Due to introducing the PMC_PLLICPR init function, use this function to clean up the code. Signed-off-by: Wenyou Yang --- board/atmel/sama5d3_xplained/sama5d3_xplained.c |4 +--- board/atmel/sama5d3xek/sama5d3xek.c |4 +--- board/atmel/sama5d4_xplained/sama5d4_xplained.c |

[U-Boot] [PATCH 2/3] ARM: at91: clean up the PMC_PLLICPR init code

2015-12-08 Thread Wenyou Yang
Due to introducing the PMC_PLLICPR init function, use this function to clean up the code. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/spl_at91.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm/mach-at91/spl_at91.c b/arch/arm/mach-at91/spl_at91.c index b

[U-Boot] [PATCH 1/3] ARM: at91: clock: add PMC_PLLICPR init function

2015-12-08 Thread Wenyou Yang
To avoid the duplicated code, add the PMC_PLLICPR init function. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/armv7/clock.c |7 +++ arch/arm/mach-at91/include/mach/at91_pmc.h |7 +++ arch/arm/mach-at91/include/mach/clk.h |1 + 3 files changed, 15 insertio

[U-Boot] [PATCH 0/3] ARM: at91: add PMC_PLLICPR init function

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, add PLLICPR init function, use the function to clean up the PMC_PLLICPR directly writing code. It is based on the following patch set. [PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions [PATCH 0/4] ARM: at91: add UTMI PLL han

[U-Boot] [PATCH 2/3] drivers: usb: ohci-at91: clean up the PLLB code

2015-12-08 Thread Wenyou Yang
Due to introducing the new PLLB clock handle functions, use these functions to clean up the PLLB enable/disable code. Signed-off-by: Wenyou Yang --- drivers/usb/host/ohci-at91.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ohci-at9

[U-Boot] [PATCH 3/3] board: atmel: siemens: clean up PLLB code

2015-12-08 Thread Wenyou Yang
Due to introducing the new PLLB clock handle functions, use these functions to clean up the PLLB enable code. Signed-off-by: Wenyou Yang --- board/siemens/smartweb/smartweb.c |6 +- board/siemens/taurus/taurus.c |6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff

[U-Boot] [PATCH 1/3] ARM: at91: clock: add PLLB enable/disable functions

2015-12-08 Thread Wenyou Yang
To avoid the duplicated code, add the PLLB handle functions. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/arm926ejs/clock.c | 38 + arch/arm/mach-at91/include/mach/clk.h |2 ++ 2 files changed, 40 insertions(+) diff --git a/arch/arm/mach-at91/arm926e

[U-Boot] [PATCH 0/3] ARM: at91: add PLLB handle functions

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, add PLLB enable/disable functions, replace the UTMI PLL handle code with these functions. It is based on the following patch set. [PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions [PATCH 0/4] ARM: at91: add UTMI PLL handle f

[U-Boot] [PATCH 3/4] drivers: usb: atmel: clean up the UTMI PLL code

2015-12-08 Thread Wenyou Yang
Due to introducing the new UTMI PLL clock handle functions, use these function to reduce the duplicated code. Signed-off-by: Wenyou Yang --- drivers/usb/host/ehci-atmel.c | 39 --- drivers/usb/host/ohci-at91.c | 20 +++- 2 files changed,

[U-Boot] [PATCH 2/4] ARM: at91: armv7: clean up UTMI PLL handle code

2015-12-08 Thread Wenyou Yang
Due to introducing the UTMI PLL enable function, use this function to reduce the duplicated code. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/armv7/sama5d2_devices.c |5 + arch/arm/mach-at91/armv7/sama5d3_devices.c |5 + arch/arm/mach-at91/armv7/sama5d4_devices.c |5 +-

[U-Boot] [PATCH 1/4] ARM: at91: clock: add UTMI PLL enable/disable function

2015-12-08 Thread Wenyou Yang
To avoid the duplicated code, add the UTMI PLL handle functions, and add PMC_USB init function too. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/clock.c| 48 + arch/arm/mach-at91/include/mach/clk.h |3 +++ 2 files changed, 51 insertions(+)

[U-Boot] [PATCH 4/4] board: atmel: siemens: clean up UTMI PLL code

2015-12-08 Thread Wenyou Yang
Due to introducing the new UTMI PLL clock handle functions, use the functions to reduce the duplicated code. Signed-off-by: Wenyou Yang [PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions --- board/siemens/corvus/board.c |4 +--- 1 file changed, 1 insertion(+), 3 del

[U-Boot] [PATCH 0/4] ARM: at91: add UTMI PLL handle functions

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, add UTMI PLL enable/disable functions, replace the UTMI PLL handle code with these functions. Wenyou Yang (4): ARM: at91: clock: add UTMI PLL enable/disable function ARM: at91: armv7: clean up UTMI PLL handle code drivers: usb: atmel: clean up the UTMI PLL cod

Re: [U-Boot] [PATCH v3 2/2] arasan: nfc: Add initial nand driver support for arasan

2015-12-08 Thread Siva Durga Prasad Paladugu
Hi Scott, > -Original Message- > From: Siva Durga Prasad Paladugu [mailto:siva.durga.palad...@xilinx.com] > Sent: Tuesday, November 17, 2015 2:30 PM > To: u-boot@lists.denx.de > Cc: scottw...@freescale.com; Michal Simek; Siva Durga Prasad Paladugu > Subject: [PATCH v3 2/2] arasan: nfc: Ad

Re: [U-Boot] [PATCH v2 4/4] x86: Remove HAVE_ACPI_RESUME

2015-12-08 Thread Simon Glass
On 25 November 2015 at 17:46, Bin Meng wrote: > These are currently dead codes. Until we have complete ACPI support, > we don't know if it works or not. Remove to avoid confusion. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > > --- > > Changes in v2: None > > arch/x86/cpu/ivybridge/cpu.

Re: [U-Boot] [PATCH v2 3/4] x86: Remove CPU_INTEL_SOCKET_RPGA989

2015-12-08 Thread Simon Glass
On 25 November 2015 at 17:46, Bin Meng wrote: > This Kconfig option name indicates it has something to do with cpu > socket, however it is actually not the case. Remove it and move > options inside it to NORTHBRIDGE_INTEL_IVYBRIDGE. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > --- > > C

Re: [U-Boot] [PATCH v2 1/4] x86: ivybridge: Remove NORTHBRIDGE_INTEL_SANDYBRIDGE

2015-12-08 Thread Simon Glass
On 8 December 2015 at 01:10, Bin Meng wrote: > > Hi Simon, > > On Fri, Nov 27, 2015 at 12:50 AM, Simon Glass wrote: > > Hi Bin, > > > > On 25 November 2015 at 17:46, Bin Meng wrote: > >> NORTHBRIDGE_INTEL_SANDYBRIDGE is for sandybridge, not ivybridge. > >> > >> Signed-off-by: Bin Meng > >> > >>

Re: [U-Boot] [PATCH v2 2/4] x86: Clean up ivybridge/chrome Kconfig options

2015-12-08 Thread Simon Glass
On 25 November 2015 at 17:46, Bin Meng wrote: > There are some options which are never used, and also some options > which are selected by others but have never been a Kconfg option. > Clean these up. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > --- > > Changes in v2: None > > arch/x86

[U-Boot] [PATCH 4/5] board: atmel: clean up peripheral clock code

2015-12-08 Thread Wenyou Yang
Due to introducing the new peripheral clock handle functions, use these functions to reduce duplicated code. Signed-off-by: Wenyou Yang --- board/atmel/at91rm9200ek/at91rm9200ek.c |1 - board/atmel/at91rm9200ek/led.c |5 + board/atmel/at91sam9260ek/at91sam92

[U-Boot] [PATCH 3/5] ARM: cpu: at91: clean up peripheral clock code

2015-12-08 Thread Wenyou Yang
Due to introducing the new peripheral clock handle functions, use these functions to clean up the duplicated code. Meanwhile, remove unneeded header file include, at91_pmc.h. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/arm920t/at91rm9200_devices.c| 13 ++- arch/arm/mach-at91/ar

[U-Boot] [PATCH 5/5] drivers: at91: clean up peripheral clock code

2015-12-08 Thread Wenyou Yang
Due to introducing the new peripheral clock handle functions, use these functions to reduce the duplicated code. Signed-off-by: Wenyou Yang --- drivers/net/at91_emac.c |9 - drivers/usb/host/ehci-atmel.c |8 drivers/usb/host/ohci-at91.c | 20 ---

[U-Boot] [PATCH 2/5] ARM: at91: clock: add a new file to handle clock

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, add a new file to accommodate the peripheral's and system's clock handle code, shared with the SoCs with different ARM core. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/Makefile |1 + arch/arm/mach-at91/arm926ejs/clock.c |7 arch/arm/

[U-Boot] [PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions

2015-12-08 Thread Wenyou Yang
To reduce the duplicated code, rework the peripheral's and system's clock handle functions, use these functions to replace the clock handle code. Wenyou Yang (5): ARM: at91: asm/at91_pmc.h: fix trival register offset ARM: at91: clock: add a new file to handle clock ARM: cpu: at91: clean up

[U-Boot] [PATCH 1/5] ARM: at91: asm/at91_pmc.h: fix trival register offset

2015-12-08 Thread Wenyou Yang
Remove unnecessary #ifdef CPU_HAS_PCR. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/include/mach/at91_pmc.h |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-at91/include/mach/at91_pmc.h b/arch/arm/mach-at91/include/mach/at91_pmc.h index 3f50f77.

Re: [U-Boot] [PATCH] VxWorks: fixup MAC address for VxWorks

2015-12-08 Thread Tom Rini
On Wed, Dec 09, 2015 at 09:31:26AM +0800, Miao Yan wrote: > 2015-12-02 20:44 GMT+08:00 Bin Meng : > > On Wed, Dec 2, 2015 at 3:39 PM, Miao Yan wrote: > >> VxWorks 7 kernels retrieve 'local-mac-addr' from dtb and use > >> that for NIC MAC address. As a result, when booting the same > >> kernel imag

Re: [U-Boot] [PATCH] VxWorks: fixup MAC address for VxWorks

2015-12-08 Thread Miao Yan
2015-12-02 20:44 GMT+08:00 Bin Meng : > On Wed, Dec 2, 2015 at 3:39 PM, Miao Yan wrote: >> VxWorks 7 kernels retrieve 'local-mac-addr' from dtb and use >> that for NIC MAC address. As a result, when booting the same >> kernel image on multiple boards, there will be address >> conflicts. >> >> So f

[U-Boot] Please pull u-boot-x86

2015-12-08 Thread Bin Meng
Hi Tom, This includes fixes to PCI UART on CrownBay and Galileo, and minor changes to x86 timer. The following changes since commit 8555dd88cd1a7b5dd1e76c111fe635a92223b98b: axs10x: add support of generic EHCI USB 2.0 controller (2015-12-08 17:29:56 +0300) are available in the git repository

Re: [U-Boot] [PATCH] fdt: Change OF_BAD_ADDR to FDT_ADDR_T_NONE

2015-12-08 Thread Bin Meng
On Wed, Dec 9, 2015 at 3:34 AM, Simon Glass wrote: > On 7 December 2015 at 02:39, Bin Meng wrote: >> Currently OF_BAD_ADDR is always -1ULL. When using OF_BAD_ADDR as the >> return value of dev_get_addr(), it creates potential size mismatch >> as dev_get_addr() uses FDT_ADDR_T_NONE as the return v

Re: [U-Boot] [PATCH v2 1/2] x86: Move i8254_init() to x86_cpu_init_f()

2015-12-08 Thread Bin Meng
On Wed, Dec 9, 2015 at 9:31 AM, Bin Meng wrote: > Right now i8254_init() is called from timer_init() in the tsc timer > driver. But actually i8254 and tsc are completely different things. > Since tsc timer has been converted to driver model, we should find > a new place that is appropriate for U-B

Re: [U-Boot] [PATCH v2 2/2] common: Remove timer_init() call for x86

2015-12-08 Thread Bin Meng
On Wed, Dec 9, 2015 at 9:31 AM, Bin Meng wrote: > With driver model timer support, there should not be an explict > call to timer_init(). Remove this call for x86. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > applied to u-boot-x86/master, thanks! ___

Re: [U-Boot] [PATCH] x86: Fix PCI UART compatible string for crownbay and galileo

2015-12-08 Thread Bin Meng
On Wed, Dec 9, 2015 at 3:34 AM, Simon Glass wrote: > On 7 December 2015 at 06:28, Bin Meng wrote: >> With recent ns16550 driver changes, we only changed the legacy UART >> (at I/O port 0x3f8) compatible string, but forgot to change the PCI >> UART compatible string. Now fix it. >> >> Signed-off-b

[U-Boot] [PATCH v2 2/2] common: Remove timer_init() call for x86

2015-12-08 Thread Bin Meng
With driver model timer support, there should not be an explict call to timer_init(). Remove this call for x86. Signed-off-by: Bin Meng Acked-by: Simon Glass --- Changes in v2: None common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/board_f.c b/common

[U-Boot] [PATCH v2 1/2] x86: Move i8254_init() to x86_cpu_init_f()

2015-12-08 Thread Bin Meng
Right now i8254_init() is called from timer_init() in the tsc timer driver. But actually i8254 and tsc are completely different things. Since tsc timer has been converted to driver model, we should find a new place that is appropriate for U-Boot to call i8254_init(), which is now x86_cpu_init_f().

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

2015-12-08 Thread Tom Rini
On Tue, Dec 08, 2015 at 04:42:17PM -0700, Simon Glass wrote: > Hi Tom, > > On Dec 8, 2015 4:28 PM, "Tom Rini" wrote: > > > > On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On 7 December 2015 at 20:26, Tom Rini wrote: > > > > Coverity notes that we do not e

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

2015-12-08 Thread Simon Glass
Hi Tom, On Dec 8, 2015 4:28 PM, "Tom Rini" wrote: > > On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On 7 December 2015 at 20:26, Tom Rini wrote: > > > Coverity notes that we do not ensure when we copy in the product/vendor > > > strings that they have NULL term

Re: [U-Boot] [PATCH 1/3] serial-uclass.c: Copy at most sdev.name - 1 characters into the buffer

2015-12-08 Thread Tom Rini
On Tue, Dec 08, 2015 at 12:35:18PM -0700, Simon Glass wrote: > On 7 December 2015 at 20:26, Tom Rini wrote: > > Coverity notes that we do not ensure a NULL terminated string here as we > > could fill the entire buffer with our strncpy call. Fix this by > > subtracting one. > > > > Reported-by: Co

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

2015-12-08 Thread Tom Rini
On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: > Hi Tom, > > On 7 December 2015 at 20:26, Tom Rini wrote: > > Coverity notes that we do not ensure when we copy in the product/vendor > > strings that they have NULL termination. In this case the answer is to > > increase the buffer w

Re: [U-Boot] [PATCH v3 1/2] fdt: Deprecate "usbethaddr" usage in fdt_fixup_ethernet()

2015-12-08 Thread Joe Hershberger
Hi Bin, On Sun, Dec 6, 2015 at 7:53 PM, Bin Meng wrote: > Hi Joe, > > On Tue, Nov 3, 2015 at 8:24 PM, Bin Meng wrote: >> In fdt_fixup_ethernet() only "usbethaddr" is handled to fix up the >> first usb ethernet port MAC address. Other additional usb ethernet >> ports are ignored as there is no lo

Re: [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c

2015-12-08 Thread Simon Glass
Hi Scott, On 8 December 2015 at 12:36, Scott Wood wrote: > On Tue, 2015-12-08 at 12:34 -0700, Simon Glass wrote: >> Hi Sjoerd, >> >> On 8 December 2015 at 00:27, Sjoerd Simons >> wrote: >> > >> > On Mon, 2015-12-07 at 17:39 -0700, Simon Glass wrote: >> > > > diff --git a/lib/Makefile b/lib/Makef

Re: [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c

2015-12-08 Thread Scott Wood
On Tue, 2015-12-08 at 12:34 -0700, Simon Glass wrote: > Hi Sjoerd, > > On 8 December 2015 at 00:27, Sjoerd Simons > wrote: > > > > On Mon, 2015-12-07 at 17:39 -0700, Simon Glass wrote: > > > > diff --git a/lib/Makefile b/lib/Makefile > > > > index 1f1ff6f..ae84833 100644 > > > > --- a/lib/Makefi

Re: [U-Boot] [PATCH v5 1/2] common: Rewrite hiding the end of memory

2015-12-08 Thread Simon Glass
On 7 December 2015 at 14:37, York Sun wrote: > As the name may be confusing, the CONFIG_SYS_MEM_TOP_HIDE reserves > some memory from the end of ram, tracked by gd->ram_size. It is not > always the top of u-boot visible memory. Rewrite the macro with a > weak function to provide flexibility for com

Re: [U-Boot] [PATCH 1/3] serial-uclass.c: Copy at most sdev.name - 1 characters into the buffer

2015-12-08 Thread Simon Glass
On 7 December 2015 at 20:26, Tom Rini wrote: > Coverity notes that we do not ensure a NULL terminated string here as we > could fill the entire buffer with our strncpy call. Fix this by > subtracting one. > > Reported-by: Coverity (CID 131093) > Cc: Simon Glass > Signed-off-by: Tom Rini > --- >

Re: [U-Boot] [PATCH 1/2] Kconfig: i2c: Fix typo Suport -> Support

2015-12-08 Thread Simon Glass
On 8 December 2015 at 03:18, Michal Simek wrote: > Fix typo in command description. > > Signed-off-by: Michal Simek > --- > > drivers/i2c/muxes/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailin

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

2015-12-08 Thread Simon Glass
Hi Tom, On 7 December 2015 at 20:26, Tom Rini wrote: > Coverity notes that we do not ensure when we copy in the product/vendor > strings that they have NULL termination. In this case the answer is to > increase the buffer we have and then set the last entry to NULL. > > Reported-by: Coverity (CI

Re: [U-Boot] [PATCH 2/3] sandbox: eth-raw-os.c: Ensure that our interface name is not too long

2015-12-08 Thread Simon Glass
On 7 December 2015 at 20:26, Tom Rini wrote: > Coverity notes that we do not ensure when we copy ifname we still have > space left to ensure NULL termination. As cannot control the size of > ifr_name we must make sure that our argument will not overflow the > buffer. > > Reported-by: Coverity (CI

Re: [U-Boot] [PATCH] spl: dm: Enable DM_SEQ_ALIAS

2015-12-08 Thread Simon Glass
Hi Nathan, On 8 December 2015 at 07:44, Nathan Rossi wrote: > The Device Model sequence alias feature is required by some Uclasses. > > Specifically SPI which picks the bus to use based on the sequence. > Without this the SPI Uclass will not probe any bus and will fail which > prevents SPL from u

Re: [U-Boot] [PATCH] ARM: zynq: Enable u-boot, dm-pre-reloc for sdhci

2015-12-08 Thread Simon Glass
On 8 December 2015 at 04:03, Michal Simek wrote: > Enable u-boot,dm-pre-reloc for sdhci for zc706, zed and zybo. > And create alises for it. > > Signed-off-by: Michal Simek > --- > > arch/arm/dts/zynq-zc706.dts | 2 ++ > arch/arm/dts/zynq-zed.dts | 2 ++ > arch/arm/dts/zynq-zybo.dts | 2 ++ >

Re: [U-Boot] [PATCH 2/2] Kconfig: i2c: Fix indentation

2015-12-08 Thread Simon Glass
On 8 December 2015 at 03:18, Michal Simek wrote: > Use tabs instead of space for indentation. > > Signed-off-by: Michal Simek > --- > > drivers/i2c/muxes/Kconfig | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c

2015-12-08 Thread Simon Glass
Hi Sjoerd, On 8 December 2015 at 00:27, Sjoerd Simons wrote: > > On Mon, 2015-12-07 at 17:39 -0700, Simon Glass wrote: > > > diff --git a/lib/Makefile b/lib/Makefile > > > index 1f1ff6f..ae84833 100644 > > > --- a/lib/Makefile > > > +++ b/lib/Makefile > > > @@ -85,13 +85,13 @@ obj-$(CONFIG_LIB_RA

Re: [U-Boot] [PATCH] fdt: Change OF_BAD_ADDR to FDT_ADDR_T_NONE

2015-12-08 Thread Simon Glass
On 7 December 2015 at 02:39, Bin Meng wrote: > Currently OF_BAD_ADDR is always -1ULL. When using OF_BAD_ADDR as the > return value of dev_get_addr(), it creates potential size mismatch > as dev_get_addr() uses FDT_ADDR_T_NONE as the return value which can > be either -1U or -1ULL depending on CONF

Re: [U-Boot] [PATCH] x86: Fix PCI UART compatible string for crownbay and galileo

2015-12-08 Thread Simon Glass
On 7 December 2015 at 06:28, Bin Meng wrote: > With recent ns16550 driver changes, we only changed the legacy UART > (at I/O port 0x3f8) compatible string, but forgot to change the PCI > UART compatible string. Now fix it. > > Signed-off-by: Bin Meng > --- > > arch/x86/dts/crownbay.dts | 8 -

Re: [U-Boot] [PATCH 3/5][v5] include/linux: move typdef for uintptr_t

2015-12-08 Thread York Sun
On 12/08/2015 12:24 AM, Aneesh Bansal wrote: > uintptr_t which is a typdef for unsigned long is needed for creating > pointers (32 or 64 bit depending on Core) from 32 bit variables > storing the address. > If a 32 bit variable (u32) is typecasted to a pointer (void *), > compiler gives a warning

Re: [U-Boot] [PATCH 2/2] net: fec_mxc: unregister mdio bus on probe error

2015-12-08 Thread Måns Rullgård
Eric Nelson writes: > Hi Mans, > > On 12/08/2015 08:38 AM, Mans Rullgard wrote: >> If fecmxc_initialize_multi() fails, it frees but does not unregister >> the mdio bus, causing subsequent uses of the "mii" command to crash. >> Fix this by adding mdio_unregister() calls where needed. >> >> Signed

Re: [U-Boot] [PATCH] arm: Add and select CONFIG_ARMV7

2015-12-08 Thread Wolfgang Denk
Dear Marek, In message <201512081439.50797.ma...@denx.de> you wrote: > > Please ignore, after discussing this on IRC, we decided on doing > s/CONFIG_ARMV7/CONFIG_CPU_V7/g instead. As IRC si (to the best or my knowledge?) not logged anywhere, I would like to hear the rationale for this decision.

Re: [U-Boot] [PATCH 2/2] net: fec_mxc: unregister mdio bus on probe error

2015-12-08 Thread Eric Nelson
Hi Mans, On 12/08/2015 08:38 AM, Mans Rullgard wrote: > If fecmxc_initialize_multi() fails, it frees but does not unregister > the mdio bus, causing subsequent uses of the "mii" command to crash. > Fix this by adding mdio_unregister() calls where needed. > > Signed-off-by: Mans Rullgard > --- >

Re: [U-Boot] [PATCH 1/2] net: fec_mxc: configure MDIO hold time

2015-12-08 Thread Eric Nelson
Hi Mans, On 12/08/2015 08:38 AM, Mans Rullgard wrote: > If the host clock frequency is higher than 100 MHz, the MDIO hold > time needs to be increased from its current setting of one cycle in > order to meet the specified minium of 10 ns. Writing an appropriate > value to the HOLDTIME field of th

Re: [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check

2015-12-08 Thread Kushwaha Prabhakar
Hi York, > -Original Message- > From: York Sun [mailto:york...@freescale.com] > Sent: Saturday, December 05, 2015 1:35 AM > To: Yoder Stuart-B08248 ; Kushwaha > Prabhakar-B32579 > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH] driver: net: fsl-mc: remove MC firmware version check > > Pr

Re: [U-Boot] [PATCH v3 05/16] spi: Add support for dual and quad mode

2015-12-08 Thread Jagan Teki
On 8 December 2015 at 20:35, Mugunthan V N wrote: > On Sunday 06 December 2015 08:13 PM, Jagan Teki wrote: >> On 6 December 2015 at 11:33, Mugunthan V N wrote: >>> On Thursday 03 December 2015 09:37 PM, Jagan Teki wrote: On 19 November 2015 at 12:35, Mugunthan V N wrote: > spi bus can s

Re: [U-Boot] [PATCH] x86: Clean up SPI flash drivers in defconfig

2015-12-08 Thread Jagan Teki
On 8 December 2015 at 17:27, Bin Meng wrote: > Hi Jagan, > > On Fri, Dec 4, 2015 at 2:57 AM, Simon Glass wrote: >> Hi, >> >> On 3 December 2015 at 06:27, Bin Meng wrote: >>> Hi Jagan, >>> >>> On Thu, Dec 3, 2015 at 6:24 PM, Jagan Teki wrote: Hi Bin, On 3 December 2015 at 10:14, B

[U-Boot] [PATCH 1/2] net: fec_mxc: configure MDIO hold time

2015-12-08 Thread Mans Rullgard
If the host clock frequency is higher than 100 MHz, the MDIO hold time needs to be increased from its current setting of one cycle in order to meet the specified minium of 10 ns. Writing an appropriate value to the HOLDTIME field of the MII_SPEED register achieves this. Comment copied from Linux

[U-Boot] [PATCH 2/2] net: fec_mxc: unregister mdio bus on probe error

2015-12-08 Thread Mans Rullgard
If fecmxc_initialize_multi() fails, it frees but does not unregister the mdio bus, causing subsequent uses of the "mii" command to crash. Fix this by adding mdio_unregister() calls where needed. Signed-off-by: Mans Rullgard --- drivers/net/fec_mxc.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [U-Boot] dm: Introduce SPI-NOR framework

2015-12-08 Thread Jagan Teki
Hi Simon, On 8 December 2015 at 08:22, Simon Glass wrote: > Hi Jagan, > > On 3 December 2015 at 03:10, Jagan Teki wrote: >> Hi Simon, >> >> I re-phrase all the question from previous thread and continue in this for >> more discussion on spi-nor development. >> >>> Is it intended that SPI flash s

Re: [U-Boot] [PATCH v3 05/16] spi: Add support for dual and quad mode

2015-12-08 Thread Mugunthan V N
On Sunday 06 December 2015 08:13 PM, Jagan Teki wrote: > On 6 December 2015 at 11:33, Mugunthan V N wrote: >> On Thursday 03 December 2015 09:37 PM, Jagan Teki wrote: >>> On 19 November 2015 at 12:35, Mugunthan V N wrote: spi bus can support dual and quad wire data transfers for tx and

Re: [U-Boot] [PATCH] tools: zynqimage: Clean up check_params

2015-12-08 Thread Tom Rini
On Wed, Dec 09, 2015 at 12:44:43AM +1000, Nathan Rossi wrote: > Clean up the param checking, removing some code paths that will never > happen. > > Signed-off-by: Nathan Rossi > Cc: Michal Simek > Cc: Tom Rini Reported-by: Coverity (CID 133251) Reviewed-by: Tom Rini -- Tom signature.asc

Re: [U-Boot] Please pull ARC changes

2015-12-08 Thread Tom Rini
On Tue, Dec 08, 2015 at 02:33:25PM +, Alexey Brodkin wrote: > Hi Tom, > > The following changes since commit 8356431bf8df6d47255d6a74ca9dce53d75265c7: > > Prepare v2016.01-rc2 (2015-12-07 14:23:45 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-arc.git

[U-Boot] [PATCH] tools: zynqimage: Clean up check_params

2015-12-08 Thread Nathan Rossi
Clean up the param checking, removing some code paths that will never happen. Signed-off-by: Nathan Rossi Cc: Michal Simek Cc: Tom Rini --- tools/zynqimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/zynqimage.c b/tools/zynqimage.c index 25f558d..c43bd5d 10064

[U-Boot] [PATCH] spl: dm: Enable DM_SEQ_ALIAS

2015-12-08 Thread Nathan Rossi
The Device Model sequence alias feature is required by some Uclasses. Specifically SPI which picks the bus to use based on the sequence. Without this the SPI Uclass will not probe any bus and will fail which prevents SPL from using SPI flash as a boot location. Signed-off-by: Nathan Rossi Cc: Si

[U-Boot] [PATCH] arm: zynq: Update ZYBO config options

2015-12-08 Thread Nathan Rossi
Update the ZYBO device tree and enable config options that relate to the added devices in the device tree. Signed-off-by: Nathan Rossi Cc: Albert Aribaud Cc: Michal Simek Cc: Simon Glass --- arch/arm/dts/zynq-zybo.dts | 18 ++ configs/zynq_zybo_defconfig | 3 +++ include/con

[U-Boot] [PATCH] spi: zynq_qspi: Add configuration to disable LQSPI feature

2015-12-08 Thread Nathan Rossi
When the Zynq Boot ROM code loads the payload from QSPI it uses the LQSPI feature of the QSPI device, however it does not clean up its configuration before handing over to the payload which leaves the device confgured to by-pass the standard non-linear operating mode. This ensures the Linear QSPI

Re: [U-Boot] [PATCH v2] axs10x: add support of generic ECHI USB 2.0 controller

2015-12-08 Thread Alexey Brodkin
Hi Alexey, On Tue, 2015-12-01 at 20:23 +0100, Marek Vasut wrote: > On Tuesday, December 01, 2015 at 08:08:10 PM, Alexey Brodkin wrote: > > Hi Marek, > > Hi! > > > On Mon, 2015-11-30 at 19:06 +0100, Marek Vasut wrote: > > > On Monday, November 30, 2015 at 06:53:25 PM, Alexey Brodkin wrote: > > >

[U-Boot] Please pull ARC changes

2015-12-08 Thread Alexey Brodkin
Hi Tom, The following changes since commit 8356431bf8df6d47255d6a74ca9dce53d75265c7: Prepare v2016.01-rc2 (2015-12-07 14:23:45 -0500) are available in the git repository at: git://git.denx.de/u-boot-arc.git for you to fetch changes up to 8555dd88cd1a7b5dd1e76c111fe635a92223b98b: axs10x

Re: [U-Boot] [PATCH 4/7] dm: Expand the uclass for Peripheral Controller Hubs (PCH)

2015-12-08 Thread Bin Meng
Hi Simon, On Tue, Dec 8, 2015 at 9:23 PM, Bin Meng wrote: > Hi Simon, > > On Tue, Dec 1, 2015 at 12:11 PM, Simon Glass wrote: >> A Peripheral Controller Hub is an Intel concept - it is like the peripherals > > I believe the name is Platform Controller Hub. > >> on an SoC and is often in a separa

[U-Boot] [PATCH] arm: Replace test for CONFIG_ARMV7 with CONFIG_CPU_V7

2015-12-08 Thread Marek Vasut
The arch/arm/lib/cache-cp15.c checks for CONFIG_ARMV7 and if this macro is set, it configures TTBR0 register. This register must be configured for the cache on ARMv7 to operate correctly. The problem is that noone actually sets the CONFIG_ARMV7 macro and thus the TTBR0 is not configured at all. On

  1   2   >