Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-09-12 Thread Pali Rohár
On Wednesday 11 September 2013 18:34:52 Jan Kundrát wrote: > On Wednesday, 11 September 2013 17:45:02 CEST, Pali Rohár wrote: > > First version of code is in my pali-gsoc branch. > > Looks like you based your code on something from cmake's git. > Could you please make a separate commit that adds

Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-09-12 Thread Jan Kundrát
On Thursday, 12 September 2013 09:37:43 CEST, Pali Rohár wrote: I copied file CMakeDependentOption.cmake from system and I rewritten it. If you want I can include it in git, but you will see only that file was replaced. If it's a complete rewrite, there should be no copyright header pointing t

Re: [trojita] GSoC: plugins & loader

2013-09-12 Thread Pali Rohár
On Wednesday 11 September 2013 23:43:40 Jan Kundrát wrote: > Or just don't bother with this nonsesne and just use the > following: > > a) if the BINDIR as defined at build time matches the current > app's dir -> load from the compile-time-specified PLUGINDIR > (typically app being located at /usr/

Re: [trojita] GSoC: plugins & loader

2013-09-12 Thread Jan Kundrát
On Thursday, 12 September 2013 13:15:16 CEST, Pali Rohár wrote: What about only changing order of applicationDirPath and PLUGIN_DIR in QCoreApplication::libraryPaths()? So we will have also env QT_PLUGIN_PATH in list? Why would you need QT_PLUGIN_PATH in there? That's for Qt's own plugins, no

Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-09-12 Thread Pali Rohár
On Thursday 12 September 2013 10:43:05 Jan Kundrát wrote: > On Thursday, 12 September 2013 09:37:43 CEST, Pali Rohár wrote: > > I copied file CMakeDependentOption.cmake from system and I > > rewritten it. If you want I can include it in git, but you > > will see only that file was replaced. > > If

Re: [trojita] Merge threading & sorting options

2013-09-12 Thread Pali Rohár
On Tuesday 10 September 2013 10:41:41 Jan Kundrát wrote: > On Tuesday, 10 September 2013 10:20:24 CEST, Pali Rohár wrote: > > Yes, for this I prepared setting "gui/msgList.sortOrder". > > But IMAP function > > ThreadingMsgListModel::setUserWantsThreading(bool) is buggy > > when when is called, it c

Re: [trojita] Merge threading & sorting options

2013-09-12 Thread Jan Kundrát
On Thursday, 12 September 2013 15:57:37 CEST, Pali Rohár wrote: -allIds.append(node.internalId); +allIds.append(offset+1); You're mixing ThreadNodeInfo::internalId which is an opaque internal identifier with some consecutive counter -- that won't work. @@ -498,6 +498

[trojita] Tagging a new (pre)release soon

2013-09-12 Thread Jan Kundrát
Hi, it's been more than four months already since the last release, so it's high time to make the work of packagers easier and make a release. I'd like to tag a new version, possibly something like 0.3.96 to indicate that there's a lot of stuff going on since 0.3.93, pretty soon, perhaps tomor

Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-09-12 Thread Jan Kundrát
On Thursday, 12 September 2013 15:52:38 CEST, Pali Rohár wrote: First I changed all find_package with trojita_find_package which handle also feature summary cmake module and second there is for example qt dbus and qt test libraries which are not required always (only if dbus and test options ar