On Thursday 12 September 2013 10:43:05 Jan Kundrát wrote:
> On Thursday, 12 September 2013 09:37:43 CEST, Pali Rohár wrote:
> > I copied file CMakeDependentOption.cmake from system and I
> > rewritten it. If you want I can include it in git, but you
> > will see only that file was replaced.
> 
> If it's a complete rewrite, there should be no copyright
> header pointing to cmake's authors. So I assume it's a
> derived work, so I'd like you to do the following:
> 
> 1) cp whereever/foo.cmake cmake/something.cmake
> 2) git commit -m "adding foo from cmake, upstream version bar"
> 3) $EDITOR cmake/something.cmake
> 4) git commit -m "pali's changes to do $something"
> 

Ok, no problem.

> > I do not understand, where is problem? If qt packages are
> > missing cmake will report error.
> 
> There is no reason to use custom wrappers around the standard
> tools for Qt detection.
> 

First I changed all find_package with trojita_find_package which 
handle also feature summary cmake module and second there is for 
example qt dbus and qt test libraries which are not required 
always (only if dbus and test options are set to AUTO or ON).


-- 
Pali Rohár
pali.ro...@gmail.com

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to